An error occurred fetching the project authors.
  1. 17 Sep, 2021 9 commits
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · ae8c8d88
      Marko Mäkelä authored
      ae8c8d88
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 699de65d
      Marko Mäkelä authored
      699de65d
    • Monty's avatar
      Fixed alias.test to also works with ps · 03a10706
      Monty authored
      The issue is that max_length for prepared statements are different from
      normal queries, which can optimize the max_length based on the result
      length.
      03a10706
    • Marko Mäkelä's avatar
      MDEV-26623 Possible race condition between statistics and bulk insert · 1e9c922f
      Marko Mäkelä authored
      When computing statistics, let us play it safe and check whether
      an insert into an empty table is in progress, once we have acquired
      the root page latch. If yes, let us pretend that the table is empty,
      just like MVCC reads would do.
      
      It is unlikely that this race condition could lead into any crashes
      before MDEV-24621, because the index tree structure should be protected
      by the page latches. But, at least we can avoid some busy work and
      return earlier.
      
      As part of this, some code that is only used for statistics calculation
      is being moved into static functions in that compilation unit.
      1e9c922f
    • Marko Mäkelä's avatar
      Cleanup: Make btr_root_block_get() more robust · 1a4a7ddd
      Marko Mäkelä authored
      btr_root_block_get(): Check for index->page == FIL_NULL.
      
      btr_root_get(): Declare static. Other callers can invoke
      btr_root_block_get() directly.
      
      btr_get_size(): Remove conditions that are checked in
      btr_root_block_get().
      1a4a7ddd
    • Krunal Bauskar's avatar
      MDEV-26609 : Avoid deriving ELEMENT_PER_LATCH from cacheline · 48bbc447
      Krunal Bauskar authored
      * buffer pool has latches that protect access to pages.
      
      * there is a latch per N pages.
        (check page_hash_table for more details)
      
      * N is calculated based on the cacheline size.
      
      * for example: if cacheline size is
        : 64 then 7 pages pointers + 1 latch can be hosted on the same cacheline
        : 128 then 15 pages pointers + 1 latch can be hosted on the same cacheline
      
      * arm generally have wider cacheline so with arm 1 latch is used
        to access 15 pages vs with x86 1 latch is used to access 7 pages.
        Naturally, the contention is more with arm case.
      
      * said patch help relax this contention by limiting the elements
        per cacheline to 7 (+ 1 latch slot).
        for wider-cacheline (say 128), the remaining 8 slots are kept empty.
        this ensures there are no 2 latches on the same cacheline to avoid
        latch level contention.
      
      Based on suggestion from Marko, the same logic is now extended to
      lock_sys_t::hash_table.
      48bbc447
    • Julius Goryavsky's avatar
      MDEV-19950 addendum: galera_ssl_upgrade removed from the list of disabled... · a2e55131
      Julius Goryavsky authored
      MDEV-19950 addendum: galera_ssl_upgrade removed from the list of disabled tests and adapted for 10.4+
      a2e55131
    • Jan Lindström's avatar
      MDEV-26053 : TRUNCATE on table with Foreign Key Constraint no longer replicated to other nodes · d3b35598
      Jan Lindström authored
      Problem was that there was extra condition !thd->lex->no_write_to_binlog
      before call to begin TOI. It seems that this variable is not initialized.
      TRUNCATE does not support [NO_WRITE_TO_BINLOG | LOCAL] keywords, thus
      we should not check this condition. All this was hidden in a macro,
      so I decided to remove those macros that were used only a few places
      with actual function calls.
      d3b35598
    • Marko Mäkelä's avatar
      106b16a5
  2. 16 Sep, 2021 5 commits
    • Marko Mäkelä's avatar
      MDEV-26356 fixup: Adjust innodb_max_purge_lag_wait · 9d8e83b6
      Marko Mäkelä authored
      innodb_max_purge_lag_wait_update(): To align with
      purge_coordinator_state::refresh(), we must trigger a page flush batch
      if the last log checkpoint is too old.
      
      This was caught in a hang of the test innodb_gis.rtree_compress.
      9d8e83b6
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 03c09837
      Marko Mäkelä authored
      03c09837
    • Marko Mäkelä's avatar
      MDEV-26626 InnoDB fails to advance the log checkpoint · c430aa72
      Marko Mäkelä authored
      buf_flush_page_cleaner(): Always try to advance the log checkpoint,
      even when no pages were flushed during the latest batch.
      Maybe, since the previous batch, there was an LRU flush that
      removed the last dirty pages.
      
      Failure to advance the log checkpoint will cause unnecessary work
      in Mariabackup and on crash recovery.
      c430aa72
    • Monty's avatar
      Updated rocksdb test result · 65cce297
      Monty authored
      This was required as I added a new error code to my_base.h and rocksdb
      is adding it's own errors after the last official one
      
      Updated result file also for index_merge_rocksdb2. This is a big test
      and we have probably not before noticed that some optimizer changes
      caused a difference.
      65cce297
    • Eugene Kosov's avatar
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in... · 5b0a7607
      Eugene Kosov authored
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in /storage/innobase/btr/btr0btr.cc during IMPORT
      
      dict_index_t::clear_instant_alter(): when searhing for an AUTO_INCREMENT column
      don't skip the beginning of the list because the field can be at the beginning of the list
      5b0a7607
  3. 15 Sep, 2021 4 commits
    • Monty's avatar
      Fixed bug in aria_chk that overwrote sort_buffer_length · 0d47945b
      Monty authored
      This bug happens when one runs aria_chk on multiple tables. It does not
      affect REPAIR TABLE.
      aria_chk tries to optimize the sort buffer size to minimize memory usage
      when used with small tables. The bug was that the adjusted value was
      used as a base for the next table, which could cause problems.
      0d47945b
    • Monty's avatar
      Merge branch '10.4' into 10.5 · b4f24c74
      Monty authored
      Fixed also an error in suite/perfschema/t/transaction_nested_events-master.opt
      b4f24c74
    • Monty's avatar
      Improve error messages from Aria · f03fee06
      Monty authored
      - Error on commit now returns HA_ERR_COMMIT_ERROR instead of
        HA_ERR_INTERNAL_ERROR
      - If checkpoint fails, it will now print out where it failed.
      f03fee06
    • Monty's avatar
      Fixed compiler warnings in CONNECT · 6be0ddae
      Monty authored
      6be0ddae
  4. 14 Sep, 2021 7 commits
    • Monty's avatar
      MDEV-23519 Protocol packet - "Original Name" info is showing alias name, · 689b8d06
      Monty authored
      instead of original name of the column
      
      When doing refactoring of temporary table field creation a mistake was
      done when copying the column name when creating internal temporary tables.
      For internal temporary tables we should use the original field name, not
      the item name (= alias).
      689b8d06
    • Marko Mäkelä's avatar
      MDEV-26356 Adaptive purge scheduling based on redo log fill factor · ea52a3eb
      Marko Mäkelä authored
      This should be equivalent to pull request #1889 by Krunal Bauskar.
      
      The existing logic in purge_coordinator_state::do_purge()
      activates a number of the configured innodb_purge_threads
      based on the history list length. Activating more purge worker
      tasks should shrink the history list faster. But, more purge
      workers will also generate more redo log, which may slow down
      writes by user connections.
      
      row_purge_parse_undo_rec(): Revert the work-around that was added in
      commit 46904424.
      
      purge_coordinator_state: Keep track of the redo log fill factor
      (how big percentage of innodb_log_file_size is being occupied by
      log records that were generated since the latest checkpoint).
      If the redo log is getting full, log checkpoints will be triggered
      more frequently, and user threads may end up waiting in
      log_free_check(). We try to reduce purge-induced jitter in overall
      throughput by throttling down the active number of purge tasks as
      the log checkpoint age is approaching the log size (in other words,
      the redo log fill factor is approaching 100%).
      ea52a3eb
    • Marko Mäkelä's avatar
      MDEV-26356 preparation: Refactor purge_state · 717a3215
      Marko Mäkelä authored
      purge_coordinator_timer_callback(): Remove. We will have
      purge_coordinator_timer invoke purge_coordinator_callback()
      directly.
      
      srv_master_callback(): Invoke srv_wake_purge_thread_if_not_active()
      instead of purge_coordinator_timer_callback(). That is, we will
      trigger purge_coordinator_callback() once per second if there is
      any work to be done.
      
      purge_state::do_purge(): Replaces srv_do_purge(),
      purge_coordinator_callback_low(), and
      purge_coordinator_timer_callback(). The static variables
      inside srv_do_purge() were moved to purge_state data members.
      717a3215
    • Marko Mäkelä's avatar
      MDEV-24512 fixup: Remove after_task_callback · 03e4cb24
      Marko Mäkelä authored
      In commit ff5d306e we removed
      dbug_after_task_callback but forgot to revert the rest of
      commit bada05a8.
      03e4cb24
    • Daniel Black's avatar
      MDEV-26601: mysys - O_TMPFILE ^ O_CREAT · adaf0dde
      Daniel Black authored
      Thanks to Fabian Vogt for noticing the mutual exclusions
      of these open flags on tmpfs caused by mariadb opening it
      incorrectly.
      
      As such we clear the O_CREAT flag while opening it as O_TMPFILE.
      adaf0dde
    • Daniele Sciascia's avatar
      MDEV-21613 Failed to open table mysql.wsrep_streaming_log for writing · 5527fc58
      Daniele Sciascia authored
      Fix sporadic failure for MTR test galera_sr.GCF-1018B. The test
      sometimes fails due to an error that is logged to the error log
      unnecessarily.
      A deterministic test case (included in this patch) shows that the
      error is loggen when a transaction is BF aborted right before  it
      opens the streaming log table to perform fragment removal. When that
      happens, the attempt to open the table fails and consequently an error
      is logged. There is no need to log this error, as an ER_LOCK_DEADLOCK
      error is returned to the client.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      5527fc58
    • Otto Kekäläinen's avatar
      Deb: Fix Gitlab-CI/Salsa-CI builds failures · 07abcb50
      Otto Kekäläinen authored
      The debian/salsa-ci.yml used to work also on upstream MariaDB.org branches,
      but has recently regressed and several jobs stopped working. These fixes
      are necessary to get it working again.
      
      * Partially revert 8642f592 that never worked, as MariaDB 10.2 does not
        have a mysql.global table nor a mariadb.sys user. Those features weren't
        introduced until MariaDB 10.4.
      
      * Partially revert 0268b871 as we don't want ColumnStore as part of the
        native Debian build. It should build only when the build is triggered
        via autobake-deb.sh (MariaDB.org builds).
      
      * Adjust salsa-ci.yml to cope with various Stretch to Sid upgrade issues
        and remove the legacy mariadb-connector-c job completely as that package
        hasn't been around for years anymore.
      
      * Extend Lintian overrides to be otherwise Lintian clean
      07abcb50
  5. 13 Sep, 2021 1 commit
  6. 12 Sep, 2021 1 commit
    • Sergei Golubchik's avatar
      perfschema: use correct type for left shifts · 1a6c130c
      Sergei Golubchik authored
      set_item() uses 1UL << bit, so is_set_item() must do the same.
      
      This fixes sporadic perfschema.show_aggregate failures
      (sporadic, because `bit` is the thread id, so depending on how many
      tests were run before perfschema.show_aggregate it can be above or
      below 32).
      1a6c130c
  7. 11 Sep, 2021 13 commits