1. 02 Aug, 2007 4 commits
  2. 01 Aug, 2007 3 commits
    • jperkin@production.mysql.com's avatar
      Merge jperkin@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · 612fb66d
      jperkin@production.mysql.com authored
      into  production.mysql.com:/usersnfs/jperkin/bk/mysql-4.1-maint
      612fb66d
    • jperkin@production.mysql.com's avatar
      Option 6 tries to grant global privileges at the database level · f5c8c9a8
      jperkin@production.mysql.com authored
      which does not work.  Removing these attempted privileges makes
      this identical to option 5 so remove it completely.  The spirit
      of the program appears to be aimed at database privileges, so do
      not add another option for granting global privileges as it may
      be unexpected.  Fixes bug#14618 (same as previous patch, this
      time applied to -maint tree).
      f5c8c9a8
    • istruewing@chilla.local's avatar
      Bug#29838 - myisam corruption using concurrent select ... and update · e117a36c
      istruewing@chilla.local authored
      When using concurrent insert with parallel index reads, it could
      happen that reading sessions found keys that pointed to records
      yet to be written to the data file. The result was a report of
      a corrupted table. But it was false alert.
      
      When inserting a record in a table with indexes, the keys are
      inserted into the indexes before the record is written to the data
      file. When the insert happens concurrently to selects, an
      index read can find a key that references the record that is not
      yet written to the data file. To avoid any access to such record,
      the select saves the current end of file position when it starts.
      Since concurrent inserts are always appended at end of the data
      file, the select can easily ignore any concurrently inserted record.
      
      The problem was that the ignore was only done for non-exact key
      searches (partial key or using >, >=, < or <=).
      
      The fix is to ignore concurrently inserted records also for
      exact key searches.
      
      No test case. Concurrent inserts cannot be tested with the test
      suite. Test cases are attached to the bug report.
      e117a36c
  3. 31 Jul, 2007 2 commits
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Merge mysql.com:/home/hf/work/029717/my41-29717 · 288ab1aa
      holyfoot/hf@mysql.com/hfmain.(none) authored
      into  mysql.com:/home/hf/work/29717/my41-29717
      288ab1aa
    • holyfoot/hf@mysql.com/hfmain.(none)'s avatar
      Bug #29717 INSERT INTO SELECT inserts values even if · f1ee2d06
      holyfoot/hf@mysql.com/hfmain.(none) authored
       SELECT statement itself returns empty.
      
      As a result of this bug 'SELECT AGGREGATE_FUNCTION(fld) ... GROUP BY'
      can return one row instead of an empty result set.
      
      When GROUP BY only has fields of constant tables
      (with a single row), the optimizer deletes the group_list.
      After that we lose the information about whether we had an
      GROUP BY statement. Though it's important
      as SELECT min(x) from empty_table; and
         SELECT min(x) from empty_table GROUP BY y; have to return
      different results - the first query should return one row,
      second - an empty result set.
      So here we add the 'group_optimized_away' flag to remember this case
      when GROUP BY exists in the query and is removed
      by the optimizer, and check this flag in end_send_group()
      f1ee2d06
  4. 30 Jul, 2007 1 commit
    • kent@mysql.com/kent-amd64.(none)'s avatar
      my_pthread.c: · e99df6fd
      kent@mysql.com/kent-amd64.(none) authored
        Backport of correction for Mac OS X build problem, global variable not
        initiated is "common" and can't be used in shared libraries, unless
        special flags are used (bug#26218)
      e99df6fd
  5. 26 Jul, 2007 2 commits
  6. 22 Jul, 2007 1 commit
  7. 21 Jul, 2007 1 commit
    • igor@olga.mysql.com's avatar
      Fixed bug #29911. · 07e0cd2f
      igor@olga.mysql.com authored
      This bug manifested itself for join queries with GROUP BY and HAVING clauses
      whose SELECT lists contained DISTINCT. It occurred when the optimizer could
      deduce that the result set would have not more than one row.
      The bug could lead to wrong result sets for queries of this type because
      HAVING conditions were erroneously ignored in some cases in the function
      remove_duplicates.   
      07e0cd2f
  8. 20 Jul, 2007 1 commit
  9. 17 Jul, 2007 1 commit
  10. 16 Jul, 2007 1 commit
  11. 14 Jul, 2007 1 commit
  12. 13 Jul, 2007 1 commit
    • tnurnberg@sin.intern.azundris.com's avatar
      Bug#27198: Error returns from time() are ignored · 5cbe511f
      tnurnberg@sin.intern.azundris.com authored
      gettimeofday() can fail and presumably, so can time().
      Keep an eye on it.
      
      Since we have no data on this at all so far, we just
      retry on failure (and log the event), assuming that
      this is just an intermittant failure. This might of
      course hang the threat until we succeed. Once we know
      more about these failures, an appropriate more clever
      scheme may be picked (only try so many times per thread,
      etc., if that fails, return last "good" time() we got or
      some such).  Using sql_print_information() to log as this
      probably only occurs in high load scenarios where the debug-
      trace likely is disabled (or might interfere with testing
      the effect).  No test-case as this is a non-deterministic
      issue.
      5cbe511f
  13. 09 Jul, 2007 1 commit
  14. 08 Jul, 2007 2 commits
  15. 07 Jul, 2007 1 commit
  16. 06 Jul, 2007 2 commits
  17. 05 Jul, 2007 2 commits
  18. 04 Jul, 2007 1 commit
  19. 03 Jul, 2007 4 commits
    • gshchepa/uchum@gleb.loc's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · 0e8292c9
      gshchepa/uchum@gleb.loc authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      0e8292c9
    • gshchepa/uchum@gleb.loc's avatar
      loaddata.result, loaddata.test: · 1f85dac2
      gshchepa/uchum@gleb.loc authored
        Test case update for bug #29294.
      1f85dac2
    • gshchepa/uchum@gleb.loc's avatar
      sql_class.cc: · 5f592984
      gshchepa/uchum@gleb.loc authored
        Windows compilation error fix.
      5f592984
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #29294. · dbe4fb94
      gshchepa/uchum@gleb.loc authored
      The `SELECT 'r' INTO OUTFILE ... FIELDS ENCLOSED BY 'r' ' statement
      encoded the 'r' string to a 4 byte string of value x'725c7272'
      (sequence of 4 characters: r\rr).
      The LOAD DATA statement decoded this string to a 1 byte string of
      value x'0d' (ASCII Carriage Return character) instead of the original
      'r' character.
      The same error also happened with the FIELDS ENCLOSED BY clause
      followed by special characters: 'n', 't', 'r', 'b', '0', 'Z' and 'N'.
      
      NOTE 1: This is a result of the undocumented feature: the LOAD DATA INFILE
      recognises 2-byte input sequences like \n, \t, \r and \Z in addition
      to documented 2-byte sequences: \0 and \N. This feature should be
      documented (here backspace character is a default ESCAPED BY character,
      in the real-life example it may be any ESCAPED BY character).
      
      NOTE 2, changed behaviour:
      Now the `SELECT INTO OUTFILE' statement with the `FIELDS ENCLOSED BY'
      clause followed by one of: 'n', 't', 'r', 'b', '0', 'Z' or 'N' characters
      encodes this special character itself by doubling it ('r' --> 'rr'),
      not by prepending it with an escape character.
      dbe4fb94
  20. 26 Jun, 2007 2 commits
    • gshchepa/uchum@gleb.loc's avatar
      Fixed bug #29251. · f8bf427b
      gshchepa/uchum@gleb.loc authored
      Sometimes special 0 ENUM values was ALTERed to normal
      empty string ENUM values.
      
      Special 0 ENUM value has the same string representation
      as normal ENUM value defined as '' (empty string).
      The do_field_string function was used to convert
      ENUM data at an ALTER TABLE request, but this
      function doesn't care about numerical "indices" of
      ENUM values, i.e. do_field_string doesn't distinguish
      a special 0 value from an empty string value.
      
      A new copy function called do_field_enum has been added to
      copy special 0 ENUM values without conversion to an empty
      string.
      f8bf427b
    • tsmith@maint1.mysql.com's avatar
      Merge maint1.mysql.com:/data/localhome/tsmith/bk/41 · 2bfa624a
      tsmith@maint1.mysql.com authored
      into  maint1.mysql.com:/data/localhome/tsmith/bk/maint/41
      2bfa624a
  21. 25 Jun, 2007 1 commit
  22. 23 Jun, 2007 1 commit
  23. 22 Jun, 2007 1 commit
  24. 20 Jun, 2007 1 commit
  25. 19 Jun, 2007 2 commits