1. 28 May, 2004 2 commits
    • unknown's avatar
      Fixed BUG#2460: Crash wih Stored Procedure and UNION. · b0921b1f
      unknown authored
      
      mysql-test/r/sp.result:
        Added test case for BUG#2460.
      mysql-test/t/sp.test:
        Added test case for BUG#2460.
      sql/sql_union.cc:
        When called from stored procedures, tabs might be reset already.
      b0921b1f
    • unknown's avatar
      Added test cases for the following bugs that have been fixed by recent changes: · 72139b18
      unknown authored
       BUG#1863: CREATE TABLE in Stored Procedure sometimes crashes on repeated calls.
       BUG#2656: select with join in stored procedure: erroneous result on 2nd call.
       BUG#3426: IF x IS NULL in stored procedure fails on second call within connection.
       BUG#3448: Stored Procedures with inner joins possible bug.
       BUG#3734: Stored procedure returns wrong rows with fulltext parameter.
       BUG#3863: Stored procedure crash when incrementing variable in a loop.
      
      (And corrected the row count output to the client after CALL)
      
      
      mysql-test/r/sp.result:
        New test case results for fixed bugs.
      mysql-test/t/sp.test:
        New test cases for fixed bugs.
      sql/sql_parse.cc:
        Corrected the row_count output to the client.
      72139b18
  2. 26 May, 2004 3 commits
  3. 25 May, 2004 5 commits
  4. 20 May, 2004 1 commit
  5. 19 May, 2004 1 commit
    • unknown's avatar
      PS and SP made compatible in mechanism used for preparing query for rexecutions (Bug #2266) · 16227c28
      unknown authored
      
      mysql-test/r/sp.result:
        test suite for Bug #2266
      mysql-test/t/sp.test:
        test suite for Bug #2266
      sql/item_subselect.cc:
        made ancestor for Statement (Item_arena)
      sql/item_subselect.h:
        made ancestor for Statement (Item_arena)
      sql/item_sum.cc:
        made ancestor for Statement (Item_arena)
      sql/item_sum.h:
        made ancestor for Statement (Item_arena)
      sql/mysql_priv.h:
        reset_stmt_for_execute use PS and SP
      sql/sp_head.cc:
        sp_head use Item_arena as ancestor to be PS cleunup compatible
        SP use PS storing/restoring/cleanup mechanisms
        cleanup() of SP Items added
        Items created in temporary memory pool during SP execution saved for normal freeing after SP execution
      sql/sp_head.h:
        sp_head use Item_arena
      sql/sql_base.cc:
        made ancestor for Statement (Item_arena)
        results of wild_setup made permanent
        setup_conds make natural joins expanding only once and store results in PS/SP memory
      sql/sql_class.cc:
        made ancestor for Statement (Item_arena)
      sql/sql_class.h:
        made ancestor for Statement (Item_arena)
        method to detect PS preparation added
      sql/sql_delete.cc:
        storing where for DELETE and mark first execution
      sql/sql_derived.cc:
        use method
      sql/sql_insert.cc:
        mark first execution for INSERT
      sql/sql_lex.cc:
        flags to correctly make transformations of query and storing them in memory of PS/SP
        made ancestor for Statement (Item_arena)
      sql/sql_lex.h:
        reved variable od SP ol saving data
        flags to correctly make transformations of query and storing them in memory of PS/SP
      sql/sql_parse.cc:
        cleunup unit for any query
      sql/sql_prepare.cc:
        made ancestor for Statement (Item_arena)
        storing where moved to preparation
        changed interface of reset_stmt_for_execute to use it is SP
        do not restore where/order by/group by before first execution (but tables and unit can be chenged without execution and should be prepared (subqueries executes on demand))
      sql/sql_select.cc:
        storing where for SELECT/multi-DELETE/... and mark first execution
      sql/sql_union.cc:
        made ancestor for Statement (Item_arena)
      sql/sql_update.cc:
        storing where for UPDATE and mark first execution
      16227c28
  6. 18 May, 2004 1 commit
  7. 17 May, 2004 2 commits
  8. 14 May, 2004 4 commits
    • unknown's avatar
      a code fix (don't specify default value of argument twice), updating a line of SHOW SLAVE STATUS · 8d18ae39
      unknown authored
      in tests after the last 4.1->5.0 merge, and:
      *** The same as ChangeSet@1.1822.1.1, 2004-05-14 23:08:03+02:00, guilhem@mysql.com of MySQL 4.0 ***
        Replication testsuite: making the master-slave synchronization less likely to fail,
        by adding sleep-and-retries (max 4 times) if MASTER_POS_WAIT() returns NULL
        in sync_with_master and sync_slave_with_master.
        The problem showed up only today, in MySQL 5.0 in rpl_server_id2.test,
        but may affect 4.x as well, so I fixed 4.x too. Note that I am also fixing
        5.0, with the same exact patch, because I don't want to leave 5.0 broken
        until the next 4.0->4.1->5.0 merge.
      
      
      client/mysqltest.c:
        in sync_with_master (and sync_slave_with_master), if MASTER_POS_WAIT() returns NULL,
        it may be that the slave SQL thread did not have time to start yes, so we sleep
        1 sec and retry, 4 times at most.
      mysql-test/r/rpl_server_id2.result:
        result update
      mysql-test/t/rpl_server_id2.test:
         master_slave.inc already drops the table
      sql/slave.cc:
        gcc compiler complained that the default value of skip_lock was specified in slave.h AND slave.cc
      8d18ae39
    • unknown's avatar
      Post-merge post-merge post fix. ;-) · 17792237
      unknown authored
      
      mysql-test/r/greedy_optimizer.result:
        Post-merge post-merge post fix. ;-)
        (Syntax errror in create table.)
      mysql-test/t/greedy_optimizer.test:
        Post-merge post-merge post fix. ;-)
        (Syntax errror in create table.)
      17792237
    • unknown's avatar
      Post-merge post-merge fix (new error codes for fparser). · 7edc2cf0
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      libmysqld/Makefile.am:
        Auto merged
      mysql-test/r/func_group.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      sql/Makefile.am:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/share/czech/errmsg.txt:
        Auto merged
      sql/share/danish/errmsg.txt:
        Auto merged
      sql/share/dutch/errmsg.txt:
        Auto merged
      sql/share/english/errmsg.txt:
        Auto merged
      sql/share/estonian/errmsg.txt:
        Auto merged
      sql/share/french/errmsg.txt:
        Auto merged
      sql/share/german/errmsg.txt:
        Auto merged
      sql/share/greek/errmsg.txt:
        Auto merged
      sql/share/hungarian/errmsg.txt:
        Auto merged
      sql/share/italian/errmsg.txt:
        Auto merged
      sql/share/japanese/errmsg.txt:
        Auto merged
      sql/share/korean/errmsg.txt:
        Auto merged
      sql/share/norwegian-ny/errmsg.txt:
        Auto merged
      sql/share/norwegian/errmsg.txt:
        Auto merged
      sql/share/polish/errmsg.txt:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_test.cc:
        Auto merged
      sql/structs.h:
        Auto merged
      sql/share/portuguese/errmsg.txt:
        Auto merged
      sql/share/romanian/errmsg.txt:
        Auto merged
      sql/share/russian/errmsg.txt:
        Auto merged
      sql/share/serbian/errmsg.txt:
        Auto merged
      sql/share/slovak/errmsg.txt:
        Auto merged
      sql/share/spanish/errmsg.txt:
        Auto merged
      sql/share/swedish/errmsg.txt:
        Auto merged
      sql/share/ukrainian/errmsg.txt:
        Auto merged
      7edc2cf0
    • unknown's avatar
      Post-merge fixes. · 3a272c1f
      unknown authored
      Note: One sp.test still fails (prime), and rpl_server_id2.test fails (will be fixed by guilhem ASAP).
      
      
      mysql-test/r/index_merge.result:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/r/index_merge_bdb.result:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/r/index_merge_innodb.result:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/r/index_merge_innodb2.result:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/r/rpl_server_id1.result:
        Update result after merge.
      mysql-test/r/sp-error.result:
        Update result after merge.
      mysql-test/r/variables.result:
        Update result after merge.
      mysql-test/t/index_merge.test:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/t/index_merge_bdb.test:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/t/index_merge_innodb.test:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/t/index_merge_innodb2.test:
        Fixed syntax error (no ',' after last index in create table any more).
      mysql-test/t/sp-error.test:
        Post-merge fix of error codes.
      sql/opt_range.cc:
        Manually merged by Monty.
      sql/opt_range.h:
        Manually merged by Monty.
      sql/slave.cc:
        Post-merge fixes with some help from Guilhem.
      sql/slave.h:
        Post-merge fixes with some help from Guilhem.
      sql/sp_head.cc:
        Got rid of warning (reordering initialization).
      sql/sql_parse.cc:
        Post-merge fix: Need to set/reset select_limit at SP CALL time as well.
      tests/client_test.c:
        Post-merge fix: key_len length in explain has changed.
      3a272c1f
  9. 13 May, 2004 2 commits
  10. 12 May, 2004 2 commits
  11. 11 May, 2004 3 commits
    • unknown's avatar
      file parser for new .frm · e66b7405
      unknown authored
      
      include/my_sys.h:
        names for get_date format flags
      include/mysqld_error.h:
        error of parser
      libmysqld/Makefile.am:
        parser file added
      mysys/mf_getdate.c:
        function comment for get_date()
        2 new flags added
        names for get_date format flags
      sql/Makefile.am:
        parser file added
      sql/mysql_priv.h:
        parser file added
      sql/share/czech/errmsg.txt:
        file parser errors
      sql/share/danish/errmsg.txt:
        file parser errors
      sql/share/dutch/errmsg.txt:
        file parser errors
      sql/share/english/errmsg.txt:
        file parser errors
      sql/share/estonian/errmsg.txt:
        file parser errors
      sql/share/french/errmsg.txt:
        file parser errors
      sql/share/german/errmsg.txt:
        file parser errors
      sql/share/greek/errmsg.txt:
        file parser errors
      sql/share/hungarian/errmsg.txt:
        file parser errors
      sql/share/italian/errmsg.txt:
        file parser errors
      sql/share/japanese/errmsg.txt:
        file parser errors
      sql/share/korean/errmsg.txt:
        file parser errors
      sql/share/norwegian-ny/errmsg.txt:
        file parser errors
      sql/share/norwegian/errmsg.txt:
        file parser errors
      sql/share/polish/errmsg.txt:
        file parser errors
      sql/share/portuguese/errmsg.txt:
        file parser errors
      sql/share/romanian/errmsg.txt:
        file parser errors
      sql/share/russian/errmsg.txt:
        file parser errors
      sql/share/serbian/errmsg.txt:
        file parser errors
      sql/share/slovak/errmsg.txt:
        file parser errors
      sql/share/spanish/errmsg.txt:
        file parser errors
      sql/share/swedish/errmsg.txt:
        file parser errors
      sql/share/ukrainian/errmsg.txt:
        file parser errors
      BitKeeper/etc/ignore:
        Added libmysqld/parse_file.cc to the ignore list
      e66b7405
    • unknown's avatar
      Merge of WL#1469 with latest bk sources. · d7938b9f
      unknown authored
      d7938b9f
    • unknown's avatar
      Merge of WL#1469 with latest bk version. · 224b9a06
      unknown authored
      
      BitKeeper/etc/logging_ok:
        auto-union
      224b9a06
  12. 10 May, 2004 1 commit
    • unknown's avatar
      Complete implementation of WL#1469 "Greedy algorithm to search for an optimal execution plan", · a51ba613
      unknown authored
      consisting of pos-review fixes and improvements.
      
      
      mysql-test/r/distinct.result:
        Adjusted to account for pre-sorting of tables before optimiziation.
      mysql-test/r/func_group.result:
        Adjusted to account for pre-sorting of tables before optimiziation.
      mysql-test/r/greedy_optimizer.result:
        - Adjusted to account for pre-sorting of tables before optimiziation.
        - Removed unnecessary test.
        - More comments.
      mysql-test/r/select.result:
        - Adjusted to account for pre-sorting of tables before optimiziation.
      mysql-test/t/greedy_optimizer.test:
        - Adjusted to account for pre-sorting of tables before optimiziation.
        - Removed unnecessary test.
        - More comments.
      sql/mysql_priv.h:
        Moved function print_plan() to sql_test.cc
      sql/sql_select.cc:
        - Simplified the recursion in best_extension_by_limited_search()
          and aligned it with its pseudo-code.
        - Renamed functions to better reflect their semantics.
        - Post-review changes of function specifications.
        - Moved function print_plan() to sql_test.cc.
      sql/sql_test.cc:
        Moved function print_plan() to sql_test.cc
      a51ba613
  13. 07 May, 2004 3 commits
    • unknown's avatar
      Merge 4.1 -> 5.0 · e9c1e75b
      unknown authored
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/etc/logging_ok:
        auto-union
      VC++Files/sql/mysqld.dsp:
        Auto merged
      configure.in:
        Auto merged
      include/my_global.h:
        Auto merged
      include/mysql_com.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysqld/Makefile.am:
        Auto merged
      myisam/myisamchk.c:
        Auto merged
      myisam/myisamdef.h:
        Auto merged
      mysql-test/install_test_db.sh:
        Auto merged
      mysql-test/r/func_time.result:
        Auto merged
      mysql-test/r/mysqldump.result:
        Auto merged
      mysql-test/r/show_check.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/func_time.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      scripts/make_binary_distribution.sh:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      sql/ha_berkeley.cc:
        Auto merged
      mysql-test/t/rpl_error_ignored_table.test:
        Auto merged
      sql/ha_berkeley.h:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/ha_innodb.h:
        Auto merged
      sql/ha_myisam.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_subselect.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/lex.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/protocol.cc:
        Auto merged
      sql/records.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_acl.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_cache.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_db.cc:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_string.cc:
        Auto merged
      sql/sql_test.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      sql/table.h:
        Auto merged
      tests/client_test.c:
        Auto merged
      e9c1e75b
    • unknown's avatar
      ctype-win1250ch.c, ctype-czech.c: · e3211fbd
      unknown authored
        Czech collations were renamed to _cs
      Index.xml:
        Czech collation were renamed to _cs
      
      
      sql/share/charsets/Index.xml:
        Czech collation were renamed to _cs
      strings/ctype-czech.c:
        Czech collations were renamed to _cs
      strings/ctype-win1250ch.c:
        Czech collations were renamed to _cs
      e3211fbd
    • unknown's avatar
      Portablity fix for system with case insenstive table names. (Without this... · dedea9b6
      unknown authored
      Portablity fix for system with case insenstive table names. (Without this ALTER TABLE can fail for InnoDB)
      
      
      
      dedea9b6
  14. 06 May, 2004 10 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 33e6b2af
      unknown authored
      into mysql.com:/home/my/mysql-4.1
      
      
      libmysql/libmysql.c:
        Auto merged
      33e6b2af
    • unknown's avatar
      Portability fixes · f3544f3c
      unknown authored
      Change strtoll -> my_strtoll10()
      Fixed bug in my_strntoul() and my_strntol() where we got different values on 32 and 64 bit systems (Bug #3472)
      
      
      configure.in:
        Fixed problem on IRIX64 (One can't have AC_MSG_RESULT on same row as AC_DEFINE
      extra/my_print_defaults.c:
        Fixed wrong definition for 'verbose'
      include/my_global.h:
        Portability fix (IRIX64)
      libmysql/client_settings.h:
        Remove compiler warnings
      libmysql/libmysql.c:
        Remove compiler warnings
      mysql-test/r/func_str.result:
        Updated results
      mysql-test/r/key_cache.result:
        Updated results to not depend on key_blocks_unused
      mysql-test/t/func_str.test:
        More test of long overflow
      mysql-test/t/key_cache.test:
        Updated results to not depend on key_blocks_unused
      sql/item.cc:
        Portability fix (don't use strtoll())
      sql/item.h:
        Portability fix (don't use strtoll())
      sql/item_sum.h:
        Portability fix (don't use strtoll())
      sql/item_timefunc.cc:
        Fixed compiler warning
      strings/ctype-simple.c:
        Fixed bug in my_strntoul() and my_strntol() where we got different values on 32 and 64 bit systems
      strings/ctype-ucs2.c:
        Fixed bug in my_strntoul() and my_strntol() where we got different values on 32 and 64 bit systems
      f3544f3c
    • unknown's avatar
      Merge miguel@bk-internal.mysql.com:/home/bk/mysql-4.1 · a6bd0b3c
      unknown authored
      into hegel.local:/home/miguel/bk/mysql-4.1
      
      
      a6bd0b3c
    • unknown's avatar
      Windows VC++ compiler compatibility · 71d02f6d
      unknown authored
      
      sql/set_var.cc:
        VC++ error compiler compatibility
      71d02f6d
    • unknown's avatar
      Merge sanja.is.com.ua:/home/bell/mysql/bk/mysql-4.1 · b1657c8d
      unknown authored
      into sanja.is.com.ua:/home/bell/mysql/bk/work-all_any-4.1
      
      
      b1657c8d
    • unknown's avatar
      postreview fixes · cd328cc2
      unknown authored
      
      sql/sql_lex.h:
        description of field
      sql/sql_union.cc:
        layout fixed
      cd328cc2
    • unknown's avatar
      fake_select_lex should be prepared during PS preparation to work correctly · 56568288
      unknown authored
      item_list for fake_select will be created only once
      (problem reported by valgrind in test_union2 fixed)
      
      
      sql/sql_lex.h:
        new function to keep code in one place
      sql/sql_union.cc:
        fake_select_lex should be prepared during PS preparation to work correctly
        item_list for fake_select will be created only once
      56568288
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1 · 2ad8fc47
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      
      2ad8fc47
    • unknown's avatar
      - removed duplicate file ..\strings\strxnmov.c from the mysqlclient.dsp · 1972bca3
      unknown authored
         that was accidently added by the last BK auto merge
      
      
      VC++Files/client/mysqlclient.dsp:
         - removed duplicate file ..\strings\strxnmov.c that was added by the
           last auto merge
      1972bca3
    • unknown's avatar
      mysql_stmt_reset now expects ok/error packet from server. · 151495ba
      unknown authored
      
      libmysql/libmysql.c:
        Make advanced_command check client reply
      sql/sql_prepare.cc:
        mysql_stmt_reset now sends ok/error reply to the client.
      tests/client_test.c:
        Memory leak fixed.
      151495ba