1. 29 Mar, 2007 4 commits
  2. 28 Mar, 2007 4 commits
    • unknown's avatar
      Merge mysql.com:/home/psergey/mysql-4.1-bug26625 · 3362a93e
      unknown authored
      into  mysql.com:/home/psergey/mysql-4.1-bug26624-r2
      
      3362a93e
    • unknown's avatar
      BUG#26624: high mem usage (crash) in range optimizer · 968f7b47
      unknown authored
      - Added PARAM::alloced_sel_args where we count the # of SEL_ARGs
        created by SEL_ARG tree cloning operations.
      - Made the range analyzer to shortcut and not do any more cloning 
        if we've already created MAX_SEL_ARGS SEL_ARG objects in cloning.
      - Added comments about space complexity of SEL_ARG-graph 
        representation.
      
      
      mysql-test/r/range.result:
        BUG#26624: Testcase
      mysql-test/t/range.test:
        BUG#26624: Testcase
      968f7b47
    • unknown's avatar
      Delete: sql/mysqld.cc.rej · 5cc44c1c
      unknown authored
      5cc44c1c
    • unknown's avatar
      BUG#26625: crash in range optimizer (out of mem) · 01b23745
      unknown authored
      - Define Sql_alloc::operator new() as thow() so that C++ compiler
        handles NULL return values
      (there is no testcase as there is no portable way to set limit on the 
      amount of memory that a process can allocate)
      
      
      sql/sql_list.h:
        BUG#26625: crash in range optimizer (out of mem) 
        - Define Sql_alloc::operator new() as thow() so that C++ compiler
          handles NULL return values
      01b23745
  3. 27 Mar, 2007 1 commit
    • unknown's avatar
      Fixed bug #27348. · 9f49f034
      unknown authored
      If a set function with a outer reference s(outer_ref) cannot be aggregated 
      the outer query against which the reference has been resolved then MySQL
      interpretes s(outer_ref) in the same way as it would interpret s(const).
      Hovever the standard requires throwing an error in this situation.
      Added some code to support this requirement in ansi mode.
      Corrected another minor bug in Item_sum::check_sum_func.
       
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #27348.
      mysql-test/t/subselect.test:
        Added a test case for bug #27348.
      sql/item_sum.cc:
        Fixed bug #27348.
        If a set function with a outer reference s(outer_ref) cannot be aggregated 
        the outer query against which the reference has been resolved then MySQL
        interprets s(outer_ref) in the same way as it would interpret s(const).
        Hovever the standard requires throwing an error in this situation.
        Added some code to support this requirement in ansi mode.
        Corrected another minor bug in Item_sum::check_sum_func.
      9f49f034
  4. 26 Mar, 2007 10 commits
    • unknown's avatar
      WL3527: 5.1 · e980838f
      unknown authored
       renamed "--old-mode" to "--old" to prevent
       ambiguity.
       "old" now appears in SHOW VARIABLES as a
       read-only option.
      
      
      mysql-test/r/group_by.result:
        WL3527: 5.1 test case
      mysql-test/t/group_by.test:
        WL3527: 5.1 test case
      sql/mysqld.cc:
        WL3527: 5.1
         renamed the "old-mode" to "old" to fit
         the options naming scheme
      sql/set_var.cc:
        WL3527: 5.1
         added "-old" as read-only system variable
      sql/set_var.h:
        WL3527: 5.1
         added class for boolean pointer read-only 
         option to support the "--old" option.
      sql/sql_base.cc:
        fixed 5.0->5.1 merge problems.
      e980838f
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/WL3527-5.0-opt · 74474a01
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/WL3527-after-merge-5.1-opt
      
      
      mysql-test/r/select.result:
        null-merge
      mysql-test/t/select.test:
        null-merge
      sql/sql_yacc.yy:
        null-merge
      74474a01
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/WL3527-5.0-opt · 4c1e11a3
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/WL3527-5.1-opt
      
      
      mysql-test/r/gis.result:
        Auto merged
      mysql-test/t/gis.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/item_sum.h:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_delete.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/subselect.result:
        merge 5.0-opt -> 5.1-opt
      mysql-test/t/subselect.test:
        merge 5.0-opt -> 5.1-opt
      sql/sql_base.cc:
        merge 5.0-opt -> 5.1-opt
      4c1e11a3
    • unknown's avatar
      WL3527: 5.0 part: · fbf7748f
      unknown authored
      enabled the optional FOR JOIN to all the three
      clauses : USE, FORCE and IGNORE
      
      
      mysql-test/r/select.result:
        WL3527: 5.0 part: test cases
      mysql-test/t/select.test:
        WL3527: 5.0 part: test cases
      fbf7748f
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B27164-4.1-opt · 79b19994
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B27164-5.0-opt
      
      
      mysql-test/t/gis.test:
        Auto merged
      mysql-test/r/gis.result:
        merge 4.1-opt -> 5.0-opt
      sql/field.h:
        merge 4.1-opt -> 5.0-opt
      79b19994
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · 4ed83d4a
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B26303-5.1-opt
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      4ed83d4a
    • unknown's avatar
      Bug #27164: not reseting the data pointer · c9b64463
      unknown authored
       to 0 causes wrong (large) length to be read
       from the row in _mi_calc_blob_length() when 
       storing NULL values in (e.g) POINT columns.
       This large length is then used to allocate
       a block of memory that (on some OSes) causes
       trouble.
       Fixed by calling the base class's 
       Field_blob::reset() from Field_geom::reset()
       that is called when storing a NULL value into
       the column.
      
      
      mysql-test/r/gis.result:
        Bug #27164: test case
      mysql-test/t/gis.test:
        Bug #27164: test case
      sql/field.h:
        Bug #27164: not reseting the data pointer
         to 0 causes wrong (large) length to be read
         from the row in _mi_calc_blob_length() when 
         storing NULL values in (e.g) POINT columns.
         This large length is then used to allocate
         a block of memory that (on some OSes) causes
         trouble.
      c9b64463
    • unknown's avatar
      Bug #26303: Reserve is not called before qs_append(). · 05d00f17
      unknown authored
      This may lead to buffer overflow.
      The String::qs_append() function will append a string
      without checking if there's enough space.
      So qs_append() must be called beforehand to ensure 
      there's enough space in the buffer for the subsequent 
      qs_append() calls.
      Fixed Item_case_expr::print() to make sure there's
      enough space before appending data by adding a call to 
      String::reserve() to make sure qs_append() will have 
      enough space.
      
      
      mysql-test/r/sp-code.result:
        Bug #26303: test case
      mysql-test/t/sp-code.test:
        Bug #26303: test case
      sql/item.cc:
        Bug #26303: added a call to String::reserve() to
         make sure qs_append will have enough space
      sql/item.h:
        Bug #26303: m_case_expr_id made unsigned 
        because it's offset in an array.
      05d00f17
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 2b04d1b4
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug27229
      
      2b04d1b4
    • unknown's avatar
      This is a fix for the memory corruption occurred in one of test cases · 371b1a59
      unknown authored
      from func_group.test after the patch for bug #27229 had been applied.
      The memory corruption happened because in some rare cases the function
      count_field_types underestimated the number of elements in
      in the array param->items_to_copy.
      
      
      sql/item_sum.cc:
        The return value of the Item_sum::update_used_tables method
        should not depend on the place of aggregation of the set 
        function for which the Item_sum object has been created.
      sql/sql_select.cc:
        This is a fix for the memory corruption occurred in one of test cases
        from func_group.test after the patch for bug #27229 had been applied.
        The memory corruption happened because in some rare cases the function
        count_field_types underestimated the number of elements in
        in the array param->items_to_copy.
        
        Currently it's not guaranteed that after JOIN::prepare() the 
        used_tables attribute is calculated for all items. For example
        for the expression SUM(outer_ref)+1 used_tables() must return
        OUTER_REF_TABLE_BIT. Yet by the moment when the used_tables
        attribute is calculated in JOIN::prepare SUM(outer_ref) has
        not been substituted for Item_aggregate_ref yet.
        By this reason additional calls of the method update_used_tables
        are needed for some items passed as parameters to the function
        create_tmp_table.
      371b1a59
  5. 23 Mar, 2007 4 commits
  6. 22 Mar, 2007 17 commits
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · a27ddd70
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug27229
      
      
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      a27ddd70
    • unknown's avatar
      Fixed bug #27229: crash when a set function aggregated in outer · 31f97af2
      unknown authored
      context was used as an argument of GROUP_CONCAT.
      Ensured correct setting of the depended_from field in references
      generated for set functions aggregated in outer selects.
      A wrong value of this field resulted in wrong maps returned by 
      used_tables() for these references.
      Made sure that a temporary table field is added for any set function
      aggregated in outer context when creation of a temporary table is 
      needed to execute the inner subquery. 
      
      
      mysql-test/r/subselect.result:
        Added a test case for bug #27229.
      mysql-test/t/subselect.test:
        Added a test case for bug #27229.
      sql/item.cc:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        Ensured correct setting of the depended_from field in references
        generated for set functions aggregated in outer selects.
      sql/item_sum.cc:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        Added the field aggr_sel to the objects of the class Item_sum.
        In any Item_sum object created for a set function this field 
        has to contain a pointer to the select where the set function
        is aggregated.
      sql/item_sum.h:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        Added the field aggr_sel to the objects of the class Item_sum.
        In any Item_sum object created for a set function this field 
        has to contain a pointer to the select where the set function
        is aggregated.
        Added a method that says whether a set function is aggregated
        in outer context and, if so, returns the aggregating select.
        Removed the field nest_level_tables_count introduced by the
        patch for bug 24484 as aggr_sel->join->tables contains the
        sane number.
      sql/sql_base.cc:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        Added the field aggr_sel to the objects of the class Item_sum.
        Removed changes introduced by the patch for bug 24484 as 
        the field leaf_count of the THD class is not used anymore.
      sql/sql_class.h:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        Added the field aggr_sel to the objects of the class Item_sum.
        Removed changes introduce by the patch for bug 24484 as 
        the field leaf_count of the THD class is not used anymore.
      sql/sql_insert.cc:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        Added the field aggr_sel to the objects of the class Item_sum.
        Removed changes introduce by the patch for bug 24484 as 
        the field leaf_count of the THD class is not used anymore.
      sql/sql_select.cc:
        Fixed bug #27229: crash when a set function aggregated in outer
        context was used as an argument of GROUP_CONCAT.
        When creating a temporary table a field is added in it for any 
        set function aggregated in outer context.
      31f97af2
    • unknown's avatar
      merging · 9cabdbcd
      unknown authored
      9cabdbcd
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 071db6c5
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/sql_view.cc:
        Auto merged
      071db6c5
    • unknown's avatar
      merging · e84ee68e
      unknown authored
      e84ee68e
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e17b6fdd
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/26813-bug-5.0-opt-mysql
      
      e17b6fdd
    • unknown's avatar
      sql_view.cc: · 3548ccc9
      unknown authored
        Post-fix for bug#26813.
      
      
      sql/sql_view.cc:
        Post-fix for bug#26813.
      3548ccc9
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · b6d14c4e
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/view_grant.result:
        Auto merged
      mysql-test/t/view_grant.test:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      b6d14c4e
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 25b34c7b
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      25b34c7b
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · e876a021
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/insert_select.result:
        Auto merged
      mysql-test/t/insert_select.test:
        Auto merged
      sql/field.h:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_sum.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      mysql-test/r/create.result:
        merging
      mysql-test/r/temp_table.result:
        SCCS merged
      mysql-test/r/type_float.result:
        merging
      mysql-test/r/union.result:
        merging
      mysql-test/t/temp_table.test:
        merging
      e876a021
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · 40609c75
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      40609c75
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 4b291020
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      4b291020
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-4.1-opt · f8b24de4
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      f8b24de4
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1 · aab8d197
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      aab8d197
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 61ff2625
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/item_cmpfunc.cc:
        Auto merged
      61ff2625
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · fad244c5
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      fad244c5
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c7831e89
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/26813-bug-5.0-opt-mysql
      
      c7831e89