An error occurred fetching the project authors.
  1. 03 Jan, 2006 1 commit
    • unknown's avatar
      Fix for bug#15533 crash, information_schema, function, view · 22c97333
      unknown authored
        enable view prepared mode during getting metedata for I_S table
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#15533 crash, information_schema, function, view
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#15533 crash, information_schema, function, view
          test case
      22c97333
  2. 19 Dec, 2005 2 commits
    • unknown's avatar
      Fix for bug#14271 I_S: columns has no size for (var)binary columns · bc66ca62
      unknown authored
        set character_octet_length, character_maximum_length for
        binary and varbinary field types
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#14271 I_S: columns has no size for (var)binary columns
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#14271 I_S: columns has no size for (var)binary columns
          test case
      bc66ca62
    • unknown's avatar
      Bug#12770 DESC cannot display the info. about temporary table · 959ce241
      unknown authored
      Bug#14387 SHOW COLUMNS doesn't work on temporary tables.
      Bug#15224 SHOW INDEX from temporary table doesn't work.
        Restore thd->temporary_tables to be able to process
        temporary tables(only for 'show index' & 'show columns').
        This should be changed when processing of temporary tables for
        I_S tables will be done.
      
      
      mysql-test/r/information_schema.result:
        Bug#12770 DESC cannot display the info. about temporary table
        Bug#14387 SHOW COLUMNS doesn't work on temporary tables.
        Bug#15224 SHOW INDEX from temporary table doesn't work.
          test case
      mysql-test/t/information_schema.test:
        Bug#12770 DESC cannot display the info. about temporary table
        Bug#14387 SHOW COLUMNS doesn't work on temporary tables.
        Bug#15224 SHOW INDEX from temporary table doesn't work.
          test case
      959ce241
  3. 01 Dec, 2005 1 commit
    • unknown's avatar
      Fix for bug#14476 `information_schema`.`TABLES`.`TABLE_TYPE` with empty value · 65f8e2ab
      unknown authored
        store TABLES.TABLE_TYPE in case of error during table opening
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#14476 `information_schema`.`TABLES`.`TABLE_TYPE` with empty value
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#14476 `information_schema`.`TABLES`.`TABLE_TYPE` with empty value
          test case
      65f8e2ab
  4. 11 Nov, 2005 1 commit
    • unknown's avatar
      Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail · d2205238
      unknown authored
                        for invalid view
       Permit SHOW CREATE VIEW, SHOW CREATE TABLE, and retrieval of metadata from
       information_schema for invalid views
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail 
                          for invalid view
         test case
      mysql-test/t/information_schema.test:
        Fix for bug#13818 SHOW CREATE VIEW / TABLE and information_schema.views fail 
                          for invalid view
         test case
      d2205238
  5. 25 Oct, 2005 1 commit
  6. 21 Oct, 2005 1 commit
    • unknown's avatar
      fix for bug#14089 FROM list subquery always fails when · cb76c37b
      unknown authored
                        information_schema is current database
        skip the check of I_S tables if table is derived table
      
      
      mysql-test/r/information_schema.result:
        fix for bug#14089 FROM list subquery always fails when 
                          information_schema is current database
          test case
      mysql-test/t/information_schema.test:
        fix for bug#14089 FROM list subquery always fails when 
                          information_schema is current database
          test case
      cb76c37b
  7. 12 Oct, 2005 1 commit
    • unknown's avatar
      Always test ssl and compress · 32f2ad06
      unknown authored
       - Updated after review
      
      
      client/mysqltest.c:
        Updated after review.
        Fix "connect" command to take SSL and/or COMPRESS as options instead of enable/disable_ssl and enable/disable_compress
        Commented do_connect, added test cases etc.
        Fix safe_get_param to make it possible to call it once for every argument without having any checks inbetween.
        Make a copy for query->first_argument  since safe_get_param will modify query string. Now connect works inside a while loop as well.
      mysql-test/mysql-test-run.pl:
        Updated after review
      mysql-test/r/connect.result:
        Enable test that was previolsy disabled because of "no error handling" in connect
      mysql-test/r/mysqltest.result:
        Added tests for "connect"
      mysql-test/t/compress.test:
        Updated after review, use the option argument to connect
      mysql-test/t/connect.test:
        Enable test that was previolsy disabled because of "no error handling" in connect
        Now it's possible to use "--error" before connect, so let's use it.
      mysql-test/t/information_schema.test:
        Connection user4 was already used
      mysql-test/t/myisam.test:
        Disconnect con1 so the name can be reused
      mysql-test/t/mysqltest.test:
        Added tests for "connect"
      mysql-test/t/openssl_1.test:
        Updated after review, use the option argument to connect
      mysql-test/t/sp-security.test:
        Disconnect user1 connection so the name can be reused
      mysql-test/t/ssl.test:
        Updated after review, use the option argument to connect
      mysql-test/t/ssl_compress.test:
        Updated after review, use the option argument to connect
      sql/mysqld.cc:
        Updated after review, Compression variable is always available
      sql/sql_show.cc:
        Updated after review, Compression variable is always available
      sql/structs.h:
        Updated after review, Compression variable is always available
      32f2ad06
  8. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · 872a537c
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      872a537c
  9. 22 Sep, 2005 1 commit
    • unknown's avatar
      Fixed problems found by valgrind · b762e55c
      unknown authored
      Fixed problems in test suite where some test failed
      Fixed access to not initialized memory in federated
      Fixed access to not initialized memory when using BIT fields in internal temporary tables
      
      
      BitKeeper/etc/ignore:
        added libmysqld/sql_cursor.h
      mysql-test/r/information_schema.result:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middlecd
      mysql-test/r/information_schema_inno.result:
        Remove used tables at start
      mysql-test/r/multi_statement.result:
        Remove used tables at start
      mysql-test/r/temp_table.result:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/r/type_bit.result:
        More tests
      mysql-test/t/information_schema.test:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/t/information_schema_inno.test:
        Remove used tables at start
      mysql-test/t/multi_statement.test:
        Remove used tables at start
      mysql-test/t/temp_table.test:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/t/type_bit.test:
        More tests
      mysql-test/valgrind.supp:
        Removed some valgrind warnings that isn't errors
      sql/ha_federated.cc:
        Fixed errors discovered by valgrind:
        - Socket was not initialized
        - share->scheme was deleted while there was still pointer into it from the hash
      sql/item_func.h:
        Remove access to table object from cleanup() as the table object may have been dropped earlier (In case of temporary tables or of close_thread_tables() is run before cleanup())
        This fixed a bug with access to already freed memory
      sql/sql_base.cc:
        Reset variables used by fulltext
      sql/sql_select.cc:
        Fixed various problems with bit fields when used in internal temporary tables.
        Calculate space needed for bit fields correctly (previously we allocated more space than needed for rows in heap/myisam tables)
      b762e55c
  10. 13 Sep, 2005 1 commit
    • unknown's avatar
      Bug#9683 INFORMATION_SCH: Creation of temporary table allowed in · 553d6985
      unknown authored
               Information_schema DB 
      Bug#9846 Inappropriate error displayed while
               dropping table from 'INFORMATION_SCHEMA'
      Bug#10734 Grant of privileges other than 'select' and 
               'create view' should fail on schema 
      Bug#10708 SP's can use INFORMATION_SCHEMA as ROUTINE_SCHEMA
      
       cumulative fix for bugs above(after review, 2nd version)
       added privilege check for information schema db & tables
      
      553d6985
  11. 07 Sep, 2005 1 commit
  12. 01 Sep, 2005 1 commit
    • unknown's avatar
      Fix for spelling miss and eol junk · 840e3735
      unknown authored
      client/mysqltest.c:
        Fix spelling error
      mysql-test/t/information_schema.test:
        Eol junk detected, added #
      mysql-test/t/rpl_slave_status.test:
        Missing ;
      mysql-test/t/sp.test:
        Eol junk detected, added #
      mysql-test/t/view.test:
        Eol junk detected, added #
      840e3735
  13. 25 Aug, 2005 1 commit
    • unknown's avatar
      Make test predictable · 2f4a043c
      unknown authored
      mysql-test/r/information_schema.result:
        Ensure that rows are in given order
      mysql-test/t/information_schema.test:
        Ensure that rows are in given order
      2f4a043c
  14. 23 Aug, 2005 1 commit
    • unknown's avatar
      sql_show.cc: · ce9b8cea
      unknown authored
        Database name was set incorrectly for any show command
        that used sunqueries in its where condition.
      information_schema.test, information_schema.result:
        Added a test case for bug #12636.
      
      
      mysql-test/r/information_schema.result:
        Added a test case for bug #12636.
      mysql-test/t/information_schema.test:
        Added a test case for bug #12636.
      sql/sql_show.cc:
        Database name was set incorrectly for any show command
        that used sunqueries in its where condition.
      ce9b8cea
  15. 20 Aug, 2005 1 commit
    • unknown's avatar
      Fixes during review of new pushed code · 8cc25933
      unknown authored
      Fixed new bug when running a SP without a default database
      
      
      mysql-test/r/information_schema.result:
        Added test to cover changes made in default handling
      mysql-test/r/sp-security.result:
        Added test when executing SP without a default database
      mysql-test/t/information_schema.test:
        Added test to cover changes made in default handling
      mysql-test/t/sp-security.test:
        Added test when executing SP without a default database
      sql/item_strfunc.cc:
        Removed wrong push
      sql/mysqld.cc:
        Indentation fix
      sql/sql_base.cc:
        Use share->db instead of share->table_cache_key
        Remove assert that can never fail (because of test in previous row)
      sql/sql_db.cc:
        Allow empty database name when called from SP
        (To allow on run without a default database)
      sql/sql_parse.cc:
        Added comment
      sql/sql_show.cc:
        Indentation fixes
        Simplified code by checking for 'wrong' condition first and doing continue instead of going down one level
        Simplified precision and decimal handling
      8cc25933
  16. 16 Aug, 2005 1 commit
    • unknown's avatar
      information_schema.test: · 9a8ea2f9
      unknown authored
        Added a comment line for a test case used for bug #12301.
      information_schema.result:
        Fixed some test cases results (bug #12301).
      sql_show.cc:
        Fixed bug #12301.
        The bug was due to a missing value setting for the NUMERIC_SCALE column
         in the get_schema_column_record() function (sql_show.cc).
      
      
      sql/sql_show.cc:
        Fixed bug #12301.
        The bug was due to a missing value setting for the NUMERIC_SCALE column
         in the get_schema_column_record() function (sql_show.cc).
      mysql-test/r/information_schema.result:
        Fixed some test cases results (bug #12301).
      mysql-test/t/information_schema.test:
        Added a comment line for a test case used for bug #12301.
      9a8ea2f9
  17. 15 Aug, 2005 1 commit
    • unknown's avatar
      Bug#12518 · 4813facf
      unknown authored
        "COLUMN_DEFAULT has wrong value if NOT NULL is set"
        Show NULL instead of empty string when no default value is set
      
      
      mysql-test/r/information_schema.result:
        test for bug 12518
      mysql-test/t/information_schema.test:
        test for bug 12518
      sql/sql_show.cc:
        report NULL for information schema result when there is no default value
      4813facf
  18. 08 Aug, 2005 1 commit
    • unknown's avatar
      Fix for bug #10055 "Using stored function with information_schema causes empty · 4eac93cd
      unknown authored
      result set".
      
      To enable full access to contents of I_S tables from stored functions
      or statements that use them, we manipulate with thread's open tables
      state and ensure that we won't cause deadlock when we open tables by
      ignoring flushes and name-locks.
      Building of contents of I_S.TABLES no longer requires locking of tables
      since we use use handler::info() method with HA_STATUS_AUTO flag instead
      of handler::update_auto_increment() for obtaining information about
      auto-increment values. But this also means that handlers have to implement
      support for HA_STATUS_AUTO flag (particularly InnoDB needs it).
      
      
      mysql-test/r/alter_table.result:
        Updated test results. This change was caused by the fact that now when
        we build contents of I_S tables (and thus output of SHOW INDEX) we
        don't use instances of tables which may be already opened and locked
        by thread (we always use new instance).
      mysql-test/r/information_schema.result:
        Added test which checks how information about current auto-increment value for
        table is reported in INFORMATION_SCHEMA.TABLES view.
      mysql-test/r/sp.result:
        Added test for bug #10055 "Using stored function with information_schema causes
        empty result set".
      mysql-test/t/information_schema.test:
        Added test which checks how information about current auto-increment value for
        table is reported in INFORMATION_SCHEMA.TABLES view.
      mysql-test/t/sp.test:
        Added test for bug #10055 "Using stored function with information_schema causes
        empty result set".
      sql/mysql_priv.h:
        close_thread_tables():
          Get rid of 'stopper' argument which is no longer used. Now when we need
          to open and then close some table without touching tables which are already
          opened we use THD::reset_n/restore_backup_open_tables_state() methods.
        open_tables()/open_normal_and_derived_tables():
          Added 'flags' argument to be able open tables even if some has done
          a flush or hold namelock on them.
      sql/sp.cc:
        close_proc_table/open_proc_table_for_read/db_find_routine():
          Replaced push_open_tables_state/pop_open_tables_state() methods which
          were saving/restoring current open tables state in/from THD::open_state_list
          with reset_n_backup_open_tables_state/restore_backup_open_tables_state()
          methods which assume that backup storage for this state is allocated on
          stack (or elsewhere) by their caller.
        open_proc_table_for_read():
          Since now we can have several open tables states stacked up we can't rely
          rely on checking whether we have some tables open in previous state.
          Instead we always assume that some tables are open and we need to ignore
          flush while locking mysql.proc. We don't really need 
          MYSQL_LOCK_IGNORE_GLOBAL_READ_LOCK in this case since we open mysql.proc table
          only for reading.
      sql/sp.h:
        Added declarations of open_proc_table_for_read()/close_proc_table() to be
        able to use them in sql_show.cc.
      sql/sql_base.cc:
        close_thread_tables():
          Get rid of 'stopper' argument which is no longer used. Now when we need
          to open and then close some table without touching tables which are already
          opened we use THD::reset_n/restore_backup_open_tables_state() methods.
        open_tables()/open_normal_and_derived_tables():
          Added 'flags' argument to be able open tables even if some has done
          a flush or hold namelock on them.
      sql/sql_class.cc:
        Open_tables_state, THD:
          Replaced push_open_tables_state/pop_open_tables_state() methods which
          were saving/restoring current open tables state in/from THD::open_state_list
          with reset_n_backup_open_tables_state/restore_backup_open_tables_state()
          methods which assume that backup storage for this state is allocated on
          stack (or elsewhere) by their caller.
      sql/sql_class.h:
        Open_tables_state, THD:
          Replaced push_open_tables_state/pop_open_tables_state() methods which
          were saving/restoring current open tables state in/from THD::open_state_list
          with reset_n_backup_open_tables_state/restore_backup_open_tables_state()
          methods which assume that backup storage for this state is allocated on
          stack (or elsewhere) by their caller.
      sql/sql_handler.cc:
        open_tables()/open_normal_and_derived_tables():
          Added 'flags' argument to be able open tables even if some has done
          a flush or hold namelock on them.
      sql/sql_prepare.cc:
        open_tables()/open_normal_and_derived_tables():
          Added 'flags' argument to be able open tables even if some has done
          a flush or hold namelock on them.
      sql/sql_show.cc:
        get_all_tables():
          Now we use THD::reset_n_/restore_backup_open_tables_state() for 
          saving/restoring open tables state instead of working with it directly
          (This also allows us to have proper content of I_S system tables in
          statements with stored functions and in stored functions). We also
          ignore possible flushes when opening tables (we may create deadlock
          otherwise). Also we do all needed manipulations with LEX in this function
          and not in get_schema_tables_result() now.
        get_schema_tables_record():
          Let us use handler::info() method with HA_STATUS_AUTO flag for obtaining
          information about table's auto-increment value. This allows to avoid locking
          of tables which is needed when we use handler::update_auto_increment() method.
        fill_schema_proc():
          Now we use open_proc_table_for_read/close_proc_table() for access to
          mysql.proc table (so we won't cause deadlock if we already have some
          tables open and locked, this also allows us to have proper content in
          ROUTINES system table in statements using stored functions/in stored
          functions).
        get_schema_tables_result():
          Moved all manipulations with Open_tables_state and LEX needed for
          safe opening of tables to ST_SCHEMA_TABLE::fill_table functions
          (i.e. get_all_tables() and fill_schema_proc()).
      sql/sql_update.cc:
        open_tables()/open_normal_and_derived_tables():
          Added 'flags' argument to be able open tables even if some has done
          a flush or hold namelock on them.
      4eac93cd
  19. 02 Aug, 2005 1 commit
  20. 31 Jul, 2005 1 commit
    • unknown's avatar
      Fixes during review of new pushed code · f5589f21
      unknown authored
      Change bool in C code to my_bool
      Added to mysqltest --enable_parsning and --disable_parsing to avoid to have to comment parts of tests
      Added comparison of LEX_STRING's and use this to compare file types for view and trigger files.
      
      
      client/client_priv.h:
        Added OPT_TRIGGERS (to get rid of compiler warning)
      client/mysql.cc:
        Added cast to get rid of compiler warning
      client/mysqldump.c:
        Added OPT_TRIGGERS (to get rid of compiler warning)
        Abort if we can't write to outfile (even if --ignore-errors is given)
      client/mysqltest.c:
        Added --enable_parsning and --disable_parsing to avoid to have to comment parts of tests
      include/my_sys.h:
        Make my_progname const
      include/my_time.h:
        Avoid using 'bool' in C programs
      mysql-test/lib/init_db.sql:
        Align with mysql_create_system_tables
        (Ideally this file should be auto-generated from the above script)
      mysql-test/r/mysqltest.result:
        Test for --enable_parsing
      mysql-test/r/variables.result:
        Update results after fix for overflow checking of max_heap_table_size
      mysql-test/t/information_schema.test:
        USe --enable/disable parsing instead of comments
      mysql-test/t/mysqltest.test:
        Test for --enable_parsing
      mysql-test/t/sp.test:
        USe --enable/disable parsing instead of comments
      mysql-test/t/variables.test:
        Portability fix for 64 bit systems
      mysql-test/t/view.test:
        USe --enable/disable parsing instead of comments
      mysys/my_init.c:
        May my_progname const
      mysys/my_static.c:
        May my_progname const
      mysys/thr_lock.c:
        Remove not needed casts
      sql-common/my_time.c:
        Change bool -> my_bool as bool is not portable in C programs
      sql/field.cc:
        Test number_to_datetime() for -1 instead of < 0 (Safety fix)
        New prototype for TIME_to_timestamp()
      sql/item.h:
        Don't have prototypes for both uint32 and ulong as these 'may' be the same thing
      sql/item_timefunc.cc:
        New prototype for TIME_to_timestamp()
      sql/log.cc:
        Remove compiler warnings
      sql/mysql_priv.h:
        New prototype for TIME_to_timestamp()
        Added function for comparing LEX_STRING
      sql/set_var.cc:
        Added overflow checking when setting ulong variable
      sql/sql_base.cc:
        Added function is_equal()
        Changed strncmp -> is_equal() as strncmp() to not match "V" (instead of "VIEW")
      sql/sql_class.cc:
        Added comment
      sql/sql_select.cc:
        Portability fixes
        After review fixes
      sql/sql_trigger.cc:
        Use 'tables_alias_charset' for comparing database name
        Use 'is_equal()' to compare file type. (Old code didn't do the comparison correctly)
      sql/sql_view.cc:
        Use 'is_equal()' to compare file type. (Old code didn't do the comparison correctly)
      sql/time.cc:
        New prototype for TIME_to_timestamp() to allow easyer mapping to C function
      sql/tztime.cc:
        bool -> my_bool (to allow calling C code from C++ code)
      sql/tztime.h:
        bool -> my_bool (to allow calling C code from C++ code)
      f5589f21
  21. 27 Jul, 2005 1 commit
  22. 19 Jul, 2005 3 commits
    • unknown's avatar
      Fix for bugs #5892/6182/8751/8758/10994 (based on Antony's patch) · e4bbce4f
      unknown authored
        "Triggers have the wrong namespace"
        "Triggers: duplicate names allowed"
        "Triggers: CREATE TRIGGER does not accept fully qualified names"
        "SHOW TRIGGERS"
      
      
      mysql-test/r/information_schema.result:
        Added tests for new INFORMATION_SCHEMA.TRIGGERS view and SHOW TRIGGERS command.
      mysql-test/r/information_schema_db.result:
        INFORMATION_SCHEMA.TRIGGERS view was added.
      mysql-test/r/rpl_sp.result:
        Now DROP TRIGGER interprets first part of trigger identifier as database
        name and not as table name. Adjusted tests properly.
      mysql-test/r/trigger.result:
        Now DROP TRIGGER interprets first part of trigger identifier as database
        name and not as table name. Adjusted tests properly.
        Added test checking that triggers have database wide namespace.
        Added test for bug #8791 "Triggers: Allowed to create triggers on a subject
        table in a different DB".
      mysql-test/r/view.result:
        Now DROP TRIGGER interprets first part of trigger identifier as database
        name and not as table name. Adjusted tests properly.
      mysql-test/t/information_schema.test:
        Added tests for new INFORMATION_SCHEMA.TRIGGERS view and SHOW TRIGGERS command.
      mysql-test/t/rpl_sp.test:
        Now DROP TRIGGER interprets first part of trigger identifier as database
        name and not as table name. Adjusted tests properly.
      mysql-test/t/trigger.test:
        Now DROP TRIGGER interprets first part of trigger identifier as database
        name and not as table name. Adjusted tests properly.
        Added test checking that triggers have database wide namespace.
        Added test for bug #8791 "Triggers: Allowed to create triggers on a subject
        table in a different DB".
      mysql-test/t/view.test:
        Now DROP TRIGGER interprets first part of trigger identifier as database
        name and not as table name. Adjusted tests properly.
      sql/handler.cc:
        Added .TRN tho the list of known file extensions assoicated with tables.
      sql/item.h:
        trg_action_time_type/trg_event_type enums:
          Added TRG_ACTION_MAX/TRG_EVENT_MAX elements which should be used instead of
          magical values in various loops where we iterate through all types of trigger
          action times or/and trigger event types.
      sql/lex.h:
        Added new symbol "TRIGGERS".
      sql/mysql_priv.h:
        Added declaration of constant holding extension for trigger name (.TRN) files.
      sql/mysqld.cc:
        Added statistical variable for SHOW TRIGGERS command.
      sql/share/errmsg.txt:
        Added error message saying that one attempts to create trigger in wrong schema.
      sql/sp.cc:
        Replaced magical values with TRG_EVENT_MAX/TRG_ACTION_MAX constants.
      sql/sql_base.cc:
        open_unireg_entry():
          Now Table_triggers_list::check_n_load() has one more argument which
          controls whether we should prepare Table_triggers_list with fully functional
          triggers or load only their names.
      sql/sql_lex.h:
        Added element for new SHOW TRIGGERS command to enum_sql_command enum.
      sql/sql_parse.cc:
        prepare_schema_table():
          Added support for SHOW TRIGGERS statement.
      sql/sql_show.cc:
        Added new INFORMATION_SCHEMA.TRIGGERS view and SHOW TRIGGERS command.
      sql/sql_table.cc:
        mysql_rm_table_part2():
          Replaced simple deletion of .TRG file with call to
          Table_triggers_list::drop_all_triggers which will also delete .TRN files
          for all triggers associated with table.
      sql/sql_trigger.cc:
        Now triggers have database wide namespace. To support it we create special .TRN
        file with same name as trigger for each trigger. This file contains name of
        trigger's table so one does not need to specify it explicitly in DROP TRIGGER.
        Moreover DROP TRIGGER treats first part of trigger identifier as database name
        now. Updated mysql_create_or_drop_trigger() routine and
        Table_triggers_list::create_trigger()/drop_trigger()/check_n_load() methods
        accordingly. Added add_table_for_trigger() routine and
        Table_triggers_list::drop_all_triggers() method.
        
        Added Table_triggers_list::get_trigger_info() for obtaining trigger metadata.
      sql/sql_trigger.h:
        Table_triggers_list:
          Use TRG_EVENT_MAX, TRG_ACTION_MAX instead of magic values.
          Added get_trigger_info() method for obtaining trigger's meta-data.
          Added drop_all_triggers() method which drops all triggers for table.
          Added declarations of trg_action_time_type_names/trg_event_type_names
          arrays which hold names of triggers action time types  and event types.
      sql/sql_yacc.yy:
        Changed grammar for CREATE/DROP TRIGGER to support database wide trigger
        namespace. Added new SHOW TRIGGERS statement.
      sql/table.h:
        enum enum_schema_tables:
          Added constant for new INFORMATION_SCHEMA.TRIGGERS view.
      e4bbce4f
    • unknown's avatar
      Fix for bug#11057 information_schema: columns table has some questionable contents · 4aac980f
      unknown authored
        fixed BLOB, TEXT(wrong maximum length), BIT and integer types(wrong numeric_precision value)
      
      4aac980f
    • unknown's avatar
      Bug#11577 'show procedure/function status' doesn't work for user with limited access · 855aafe0
      unknown authored
         changed 'SHOW PROCEDURE' behavoiur to be like INFORMATION_SCHEMA.routines
      
      855aafe0
  23. 04 Jul, 2005 1 commit
    • unknown's avatar
      Fixes during review of new code · 8c5e2ab4
      unknown authored
      - Mostly indentation fixes
      - Added missing test
      - Ensure that Item_func_case() checks for stack overruns
      - Use real_item() instead of (Item_ref*) item
      - Fixed wrong error handling
      
      
      myisam/mi_unique.c:
        Improved comments
      myisam/myisampack.c:
        Updated version number
      mysql-test/r/group_by.result:
        Added test that was lost during earlier merge
      mysql-test/r/information_schema.result:
        Safety fix: Drop procedures before used
      mysql-test/t/group_by.test:
        Added test that was lost during earlier merge
      mysql-test/t/information_schema.test:
        Safety fix: Drop procedures before used
      mysys/hash.c:
        Updated comment
      sql/field.cc:
        false -> FALSE
      sql/ha_ndbcluster.cc:
        Fix some style issues
        - No () around argument to 'case'
        - Space before ( in switch and if
        - Removed 'goto'
        - Added {}
        - Added () to make expressions easier to read
        - my_snprintf -> strmov
      sql/handler.cc:
        if( -> if (
      sql/item.cc:
        Indentation changes
      sql/item.h:
        false -> FALSE
      sql/item_cmpfunc.cc:
        Ensure that Item_func_case() check for stack overrun properly
      sql/item_cmpfunc.h:
        Ensure that Item_func_case() check for stack overrun properly
      sql/item_func.cc:
        Indentation fixes
        Fixed wrong goto label
      sql/mysqld.cc:
        Remove test for opt_disable_networking as this flag can never be set here
      sql/opt_range.cc:
        Simplify code
      sql/sql_class.h:
        Move define out from middle of class definition
      sql/sql_parse.cc:
        Remove extra empty lines
      sql/sql_select.cc:
        use real_item() instead of (Item_ref*) item
        Modifed function comment to be align with others
        Simple optimization
      sql/sql_union.cc:
        Portability fix:
        Don't use 'bool_variable|=...'
      sql/sql_view.cc:
        Move List_iterator_fast out from loops (rewind is faster than creating a new itearator)
      strings/ctype-utf8.c:
        if( -> if (
      strings/ctype.c:
        Remove disabled code
      strings/decimal.c:
        Indentation fixes
      strings/xml.c:
        Indentation fixes
      8c5e2ab4
  24. 18 Jun, 2005 1 commit
    • unknown's avatar
      Fix information_schema test on Windows. (Bug #10844) · 591e6e51
      unknown authored
      mysql-test/mysql_test_run_new.c:
        Add --log-bin-trust-routine-creators
      mysql-test/mysql-test-run.pl:
        Add --log-bin-trust-routine-creators
      mysql-test/t/information_schema.test:
        Fix use of users to cope with lack of grant to %@localhost to test.*
      mysql-test/r/information_schema.result:
        Update results
      591e6e51
  25. 16 Jun, 2005 2 commits
  26. 02 Jun, 2005 1 commit
  27. 01 Jun, 2005 1 commit
    • unknown's avatar
      Code cleanups during code reviews · 16b7c83c
      unknown authored
      Ensure we get error if INSERT IGNORE ... SELECT fails
      Fixed wrong key_part->key_length usage in index_merge
      
      
      client/mysql.cc:
        Code cleanups & simply optimizations
      mysql-test/r/information_schema.result:
        Safety
      mysql-test/t/information_schema.test:
        Safety
      sql/ha_ndbcluster.cc:
        Code cleanups
      sql/item.cc:
        Code cleanups
      sql/item_subselect.cc:
        Code cleanups
      sql/item_sum.cc:
        Code cleanups
      sql/opt_range.cc:
        Made get_index_only_read_time() static (instad of inline) to increase portability (function was not declared before use)
        Simple optimization
        Fixed wrong key_part->key_length usage in index_merge
        Removed not used variable n_used_covered
        Indentation fixes & comment cleanups
      sql/parse_file.cc:
        Code cleanups
      sql/sql_base.cc:
        Code cleanups
      sql/sql_bitmap.h:
        Added missing return
      sql/sql_insert.cc:
        Ensure we get error if INSERT IGNORE ... SELECT fails
      sql/sql_select.cc:
        Code cleanups
      sql/sql_show.cc:
        Safety fix if a LOT of errors are ignored
      sql/sql_update.cc:
        Code cleanups
      sql/table.cc:
        Code cleanups
      sql/table.h:
        Code cleanups
      sql/uniques.cc:
        Code cleanups
      strings/decimal.c:
        Simple optimization
        Code cleanups
      16b7c83c
  28. 09 May, 2005 1 commit
  29. 07 May, 2005 2 commits
    • unknown's avatar
      Fix for bug#10261: INFORMATION_SCHEMA.COLUMNS, incomplete result for non root user · 7ae997f4
      unknown authored
         I_S table columns information is available for any user 
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#10261: INFORMATION_SCHEMA.COLUMNS, incomplete result for non root user
      mysql-test/t/information_schema.test:
        Fix for bug#10261: INFORMATION_SCHEMA.COLUMNS, incomplete result for non root user
      sql/sql_show.cc:
        Fix for bug#10261: INFORMATION_SCHEMA.COLUMNS, incomplete result for non root user
      7ae997f4
    • unknown's avatar
      Fix for bug #9838: INFORMATION_SCHEMA.COLUMNS columns of granted views missing · 59589b31
      unknown authored
      sql/sql_acl.cc:
        Fix for bug #9838: INFORMATION_SCHEMA.COLUMNS columns of granted views missing
          -increase grant_version in acl_init, mysql_table_grant
          -table privileges should be taken into account when we calculate column
           grants
      sql/sql_show.cc:
        Fix for bug #9838: INFORMATION_SCHEMA.COLUMNS columns of granted views missing
             use 'base_name', 'file_name' because 'tables->db', 'tables->tables' could be invalid in
             case of view(derived tables).
      59589b31
  30. 14 Apr, 2005 1 commit
    • unknown's avatar
      information_schema.result, information_schema.test: · 99584b9d
      unknown authored
        Added a test in connection with the fix for
        bug #6106.
      view.result, view.test:
        Added test cases for bugs #6106/6107.
      sql_show.cc:
        The addition of the case for items of the type REF_ITEM in the
        function uses_only_table_name_fields became necessary after
        the fix for bug #6106.
      sql_base.cc:
        The problem was due to the fact that two different column
        references were glued together though one of them belonged to
        a subquery while another to an outer query. This caused
        eventually a wrong calculation of values for the used_tables
        attribute.
      
      
      sql/sql_base.cc:
        The problem was due to the fact that two different column
        references were glued together though one of them belonged to
        a subquery while another to an outer query. This caused
        eventually a wrong calculation of values for the used_tables
        attribute.
      sql/sql_show.cc:
        The addition of the case for items of the type REF_ITEM in the
        function uses_only_table_name_fields became necessary after
        the fix for bug #6106.
      mysql-test/t/view.test:
        Added test cases for bugs #6106/6107.
      mysql-test/r/view.result:
        Added test cases for bugs #6106/6107.
      mysql-test/t/information_schema.test:
        Added a test in connection with the fix for
        bug #6106.
      mysql-test/r/information_schema.result:
        Added a test in connection with the fix for
        bug #6106.
      99584b9d
  31. 05 Apr, 2005 1 commit
    • unknown's avatar
      Fix for bug#7214: information_schema: unauthorized user can see metadata · f746a7ae
      unknown authored
          the fix for 'columns' table only
          Rights check for 'routines' table is already done
          (see WL2131 Access control for SHOW ... PROCEDURE|FUNCTION ...)
          rename 'testtets' database to 'mysqltest' to keep number of
            DBs which created by mysql-test as small as possible
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#7214: information_schema: unauthorized user can see metadata
      mysql-test/t/information_schema.test:
        Fix for bug#7214: information_schema: unauthorized user can see metadata
      sql/sql_show.cc:
        Fix for bug#7214: information_schema: unauthorized user can see metadata
      f746a7ae
  32. 04 Apr, 2005 1 commit
    • unknown's avatar
      Cleanup tests and results after merge from 4.1 of embedded · 926e6656
      unknown authored
      server testing cleanups.
      
      
      mysql-test/r/innodb.result:
        Update results
      mysql-test/r/insert_select-binlog.result:
        Update results
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Update results
      mysql-test/r/ps_1general.result:
        Update results
      mysql-test/r/ps_grant.result:
        Update results
      mysql-test/r/view.result:
        Update results
      mysql-test/t/client_xml.test:
        Skip test with embedded server
      mysql-test/t/flush_read_lock_kill.test:
        Skip test with embedded server
      mysql-test/t/grant3.test:
        Skip test with embedded server
      mysql-test/t/information_schema.test:
        Skip test with embedded server
      mysql-test/t/innodb.test:
        Fix up filenames
      mysql-test/t/multi_update.test:
        Skip test with embedded server
      mysql-test/t/mysqlshow.test:
        Skip test with embedded server
      mysql-test/t/ps_1general.test:
        Move grant-related tests to ps_grant, and fix cleanup of filename
      mysql-test/t/ps_grant.test:
        Add additional tests
      mysql-test/t/sp-security.test:
        Skip test with embedded server
      mysql-test/t/user_limits.test:
        Skip test with embedded server
      mysql-test/t/view.test:
        Split grant-related tests to new test file view_grant
      926e6656
  33. 31 Mar, 2005 1 commit
    • unknown's avatar
      Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns · c7cb1cb2
      unknown authored
        The columns CHARACTER_MAXIMUM_LENGTH and CHARACTER_OCTET_LENGTH 
        of INFORMATION_SCHEMA.COLUMNS must be NULL for numeric columns
      
      
      mysql-test/r/information_schema.result:
        Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns
      mysql-test/t/information_schema.test:
        Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns
      sql/sql_show.cc:
        Fix for bug #9344 INFORMATION_SCHEMA, wrong content, numeric columns
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      c7cb1cb2
  34. 24 Mar, 2005 1 commit
    • unknown's avatar
      Bug #9317: Wrong count for tables in INFORMATION_SCHEMA · 23f377fc
      unknown authored
        there was no check of result of 
        table->file->write_row() function. When count of rows was
        more than table max_rows(HEAP table) the following recodrs
        were not inserted to the table
        -'schema_table_store_record' function is added. 
          The function checks result of write_row function
          and convert HEAP table to MyISAM if necessary
        - Result check after write_row is added into all 
          I_S function which store the records to I_S tables  
      
      
      mysql-test/r/information_schema.result:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      mysql-test/t/information_schema.test:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      sql/sql_select.cc:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      sql/sql_show.cc:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      sql/table.h:
        Bug #9317: Wrong count for tables in INFORMATION_SCHEMA
      23f377fc
  35. 15 Mar, 2005 1 commit