- 18 May, 2022 3 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Andrei authored
that is not in binlog. Post-crash recovery of --rpl-semi-sync-slave-enabled server failed to recognize a transaction in-doubt that needed rolled back. A prepared-but-not-in-binlog transaction gets committed instead to possibly create inconsistency with a master (e.g the way it was observed in the bug report). The semisync recovery is corrected now with initializing binlog coordinates of any transaction in-doubt to the maximum offset which is unreachable. In effect when a prepared transaction that is not found in binlog it will be decided to rollback because it's guaranteed to reside in a truncated tail area of binlog. Mtr tests are reinforced to cover the described scenario.
-
- 17 May, 2022 10 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
commit 84984b79 is null-merged
-
Julius Goryavsky authored
This commit sends a flag indicating the presence of the "--bypass" option from the donor node to the joiner nodes during rsync IST, because without such a flag it is impossible to distinguish IST from the SST on the joiner nodes (in IST/SST scripts, because the "--bypass" option is still not passed to scripts from server code). Specifically, this fixes an issue with binary logs disappearing after IST (via rsync). There are also changes to diagnostic messages here that will make it easier to diagnose script-related problems in the future when debugging and when checking the logs. This commit also adds more robust signal handlers - to handle exceptions during script execution. These handlers won't mask some crashes and it also unifies exit codes between different scripts. These changes have already been helpful to debugging "bypass" flag handling.
-
Julius Goryavsky authored
This commit fixes an issue with IST handling in version 10.9 which is a regression after MDEV-26971 and related to trying to get a non-existent "total" tag on the IST branch (this tag is only defined in SST mode).
-
Aleksey Midenkov authored
We cannot permanently change bits in read_partitions in the middle of processing because ha_rnd_init()/ha_rnd_end() depends on that.
-
Sergei Golubchik authored
prefer if/skip over require (works better with debugging, not affected by query log)
-
Sergei Golubchik authored
followup for c9b5a053
-
Sergei Golubchik authored
This reverts commit 17e0f522.
-
Alexander Barkov authored
-
Jan Lindström authored
Function wsrep_read_only_option was already removed in commit d54bc3c0 because it could cause race condition on variable opt_readonly so that value OFF can become permanent. Removed function again and added test case. Note that writes to TEMPORARY tables are still allowed when read_only=ON.
-
- 16 May, 2022 8 commits
-
-
Sergei Golubchik authored
same as MDEV-26412, but in CREATE...SELECT. fix: apply 39feab3c to create rule too.
-
Sergei Golubchik authored
-
Marko Mäkelä authored
The counter srv_stats.key_rotation_list_length is never updated, and therefore Innodb_encryption_key_rotation_list_length will always be 0. The view INFORMATION_SCHEMA.INNODB_TABLESPACES_ENCRYPTION comes close to reporting this information.
-
Marko Mäkelä authored
The counters were added in commit 5e55d1ce and any code to update them was inadvertently removed in commit 2e814d47 when applying InnoDB changes from MySQL 5.7. Let us remove these counters that never reported anything useful. If such statistics are really needed in a special case, they can be obtained by instrumenting the code by some means, such as eBPF or a source code patch.
-
Daniele Sciascia authored
This patch fixes a problem that arises when a Galera node acts as a replica for native replication. When parallel applying is enabled, it is possible to end up with attempts to write binlog events with gtids out of order. This happens because when multiple events are delivered from the native replication stream and applied in concurrently, it is for them to be replicated to the Galera cluster in an order which is different from the original order in which they were committed in the aync replication master. To correct this behavior we now wait_for_prior_commit() before replicating changes though galera. As a consequence, parallel appliers may apply events in parallel until the galera replication step, which is now serialized.
-
Jan Lindström authored
-
Jan Lindström authored
Add disconnect.
-
Jan Lindström authored
Decrease the number of tables and operations.
-
- 15 May, 2022 5 commits
-
-
Alexey Botchkov authored
Arythmetic can overrun the uint type when possible group_concat_max_len is multiplied to collation.mbmaxlen (can easily be like 4). So use ulonglong there for calculations.
-
Sergei Golubchik authored
followup for d16c3aca
-
Sergei Golubchik authored
to make the all headers -std=c++20 clean for those, who need c++20 (some plugins)
-
Michael Widenius authored
The warning comes from copying POSITION objects where 'type' is not initialized. This does not affect any production code as when 'type' was compared/used, it was always initialized. Removed by initializing the type variable in the constructor
-
Sergei Petrunia authored
- In best_extension_by_limited_search(), do not check for "(remaining_tables & real_table_bit)", it is guaranteed to be true. Make it an assert. - In (!idx || check_interleaving_with_nj())", remove the !idx part. This check made sense only in the original version of this function. - "micro optimization" in check_interleaving_with_nj().
-
- 13 May, 2022 4 commits
-
-
Nayuta Yanagisawa authored
The condition of the if statements are always true.
-
Vladislav Vaintroub authored
The error message "InnoDB: innodb_page_size=65536 requires innodb_buffer_pool_size >= 20MiB current 10MiB" is the relevant one. The root cause: mysql_install_db bootstraps with --innodb-buffer-pool-size=10M. Small bufferpool is here by design - bootstrap should succeed, even if there is not much RAM available, bootstrap does not need that much memory. For pagesize 64K specifically, Innodb thinks it needs a larger bufferpool, and thus it lets the bootstrap process die (although the expected behavior in this case would be to adjust value, give warning and continue) The workaround: - pass --innodb-buffer-pool-size=20M, which is suitable for all page sizes. - check the same limit in MSI custom action. Also, the patch adds mtr test for 64K page size.
-
Brandon Nesterenko authored
If a slave received a fake GLLE event after a GTID event it would terminate the group. This adds a test for the previous commit which fixed this issue (939672a). Review by Andrei Elkin <andrei.elkin@mariadb.com>
-
Andrei authored
GTID_LIST_EVENT or INCIDENT_EVENT. It's legal to have either of the two inside a group. E.g Gtid_event, Gtid_log_list_event, Query_1, ... Xid_log_event is permitted. However, the slave IO thread treated both as the terminal even when the group represents a DDL query. That causes a premature Gtid state update so the slave IO would think the whole group has been collected while in fact Query_1 etc are yet to process. Fixed with correcting a condition to compute the terminal event of the group. Tested with rpl_mysqlbinlog_slave_consistency (of 10.9) and rpl_gtid_errorlog.test.
-
- 12 May, 2022 5 commits
-
-
anel authored
- This commit rely on MDEV-28391 - When temporary table shadows the base table, error is raised (it can be changed if needed), since the procedure is relying on creating the views and view cannot be created from the temporary table. - Reviewed by: <wlad@mariadb.com>
-
Monty authored
The issue was that best_extension_by_limited_search() had to go through too many plans with the same cost as there where many EQ_REF tables. Fixed by shortcutting EQ_REF (AND REF) when the result only contains one row. This got the optimization time down from hours to sub seconds. The only known downside with this patch is that in some cases a table with ref and 1 record may be used before on EQ_REF table. The faster optimzation phase should compensate for this.
-
Monty authored
Before this change the test could abort with ER_OPTION_PREVENTS_STATEMENT
-
Marko Mäkelä authored
-
Hartmut Holzgraefe authored
Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>
-
- 11 May, 2022 4 commits
-
-
Vlad Lesin authored
The solution is to initialize field_ref_zero in main_low() before xtrabackup_backup_func() and xtrabackup_prepare_func() calls.
-
Alexander Barkov authored
MDEV-28446 mariabackup prepare fails for incrementals if a new schema is created after full backup is taken Adding a 10.6 specific test
-
Sergei Golubchik authored
-
Daniel Black authored
Errors where: /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:6478:12: error: 'val_datetime_packed' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] longlong val_datetime_packed(THD *thd) ^ /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:3501:12: note: overridden virtual function is here longlong val_datetime_packed(THD *thd) override; ^ /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:6480:12: error: 'val_time_packed' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] longlong val_time_packed(THD *thd) ^ /buildbot/amd64-ubuntu-2004-msan/build/sql/item.h:3502:12: note: overridden virtual function is here longlong val_time_packed(THD *thd) override; ^
-
- 10 May, 2022 1 commit
-
-
Sergei Golubchik authored
-