- 16 Aug, 2017 1 commit
-
-
Sergei Petrunia authored
Apply this patch from upstream: commit 2c8deddfb67f1cd41ea3d1ac95aa1aa9327e3406 Author: Yoshinori Matsunobu <yoshinorim@users.noreply.github.com> Date: Tue Aug 15 16:21:58 2017 -0700 Set exclusive_manual_compaction = false on manual compactions Summary: Combining exclusive manual compaction and non-exclusive manual compaction may hit rocksdb assertion errors. This diff makes all MyRocks internal manual compactions non exclusive. Closes https://github.com/facebook/mysql-5.6/pull/682 Differential Revision: D5633619 Pulled By: yoshinorim fbshipit-source-id: a90786d
-
- 15 Aug, 2017 7 commits
-
-
Igor Babaev authored
The bug was caused by a defect of the patch for the bug 11081. The patch was actually a port of the fix this bug from the mysql code line. Later a correction of this fix was added to the mysql code. Here's the comment this correction was provided with: Bug#16499751: Opening cursor on SELECT in stored procedure causes segfault This is a regression from the fix of bug#14740889. The fix started using another set of expressions as the source for the temporary table used for the materialized cursor. However, JOIN::make_tmp_tables_info() calls setup_copy_fields() which creates an Item_copy wrapper object on top of the function being selected. The Item_copy objects were not properly handled by create_tmp_table - they were simply ignored. This patch creates temporary table fields based on the underlying item of the Item_copy objects. The test case for the bug 13346 was taken from mdev-13380.
-
Sergei Petrunia authored
The test mis-used MTR's "restart the server if it crashed or exited" feature to try starting MyRocks plugin with invalid arguments. Changed the test to use the --default-storage-engine=myisam which allows the server to start when MyRocks fails to start. This removes the need to "start the server with the arguments which will caused it to fail to start", and so removes the race conditions with MTR server restart code and mysqld.*.expect file.
-
Marko Mäkelä authored
row_ins_check_foreign_constraint(): On timeout, return DB_LOCK_WAIT_TIMEOUT instead of DB_LOCK_WAIT, so that the lock wait will be properly terminated. Also, replace some redundant assignments. It looks like this bug was introduced in MySQL 5.7.8 by: commit a97f6b91227c7e0fc3151cfe5421891e79c12d19 Author: Annamalai Gurusami <annamalai.gurusami@oracle.com> Date: Tue Jun 9 16:02:31 2015 +0530 Bug #20953265 INNODB: FAILING ASSERTION: RESULT != FTS_INVALID
-
Marko Mäkelä authored
MDEV-13498 is a performance regression that was introduced in MariaDB 10.2.2 by commit fec844ac which introduced some Galera-specific conditions that were being evaluated even if the write-set replication was not enabled. MDEV-13246 Stale rows despite ON DELETE CASCADE constraint is a correctness regression that was introduced by the same commit. Especially the subcondition !(parent && que_node_get_type(parent) == QUE_NODE_UPDATE) which is equivalent to !parent || que_node_get_type(parent) != QUE_NODE_UPDATE makes little sense. If parent==NULL, the evaluation would proceed to the std::find() expression, which would dereference parent. Because no SIGSEGV was observed related to this, we can conclude that parent!=NULL always holds. But then, the condition would be equivalent to que_node_get_type(parent) != QUE_NODE_UPDATE which would not make sense either, because the std::find() expression is actually assuming the opposite when casting parent to upd_node_t*. It looks like this condition never worked properly, or that it was never properly tested, or both. wsrep_must_process_fk(): Helper function to check if FOREIGN KEY constraints need to be processed. Only evaluate the costly std::find() expression when write-set replication is enabled. Also, rely on operator<<(std::ostream&, const id_name_t&) and operator<<(std::ostream&, const table_name_t&) for pretty-printing index and table names. row_upd_sec_index_entry(): Add !wsrep_thd_is_BF() to the condition. This is applying part of "Galera MW-369 FK fixes" https://github.com/codership/mysql-wsrep/commit/f37b79c6dab101310a45a9e8cb23c0f98716da52 that is described by the following part of the commit comment: additionally: skipping wsrep_row_upd_check_foreign_constraint if thd has BF, essentially is applier or replaying This FK check would be needed only for populating parent row FK keys in write set, so no use for appliers
-
Marko Mäkelä authored
trx_set_rw_mode(): Check the flag high_level_read_only instead of testing srv_force_recovery (innodb_force_recovery) directly. There is no need to prevent the creation of read-write transactions if innodb_force_recovery=3 is used. Yes, in that mode any recovered incomplete transactions will not be rolled back, but these transactions will continue to hold locks on the records that they have modified. If the new read-write transactions hit conflicts with already existing (possibly recovered) transactions, the lock wait timeout mechanism will work just fine.
-
Marko Mäkelä authored
-
Sergei Golubchik authored
Install mtr and mysql-test-run symlinks in case of the out-of-source build. This was broken in c872b100
-
- 14 Aug, 2017 22 commits
-
-
Elena Stepanova authored
-
Sergei Petrunia authored
Make test result stable
-
Sergei Golubchik authored
-
Sergei Golubchik authored
collateral changes: * remove a test from innodb_virtual_basic that is already present in gcol_keys_innodb * set thd->abort_on_warning for inplace alter, just like it's set for copy_data_between_tables - to have warnings converted into errors identically in all alter algorithms * don't ignore errors in TABLE::update_virtual_field
-
Sergei Golubchik authored
don't allocate memory on thd->mem_root in every fix_fields(), do it once and reuse.
-
Sergei Golubchik authored
doing SYSVAR_AUTOSIZE() because of back_log > max_connections enabled "autosized" flag, and that made IS_SYSVAR_AUTOSIZE() true, which triggered the second SYSVAR_AUTOSIZE. Remove back_log <= max_connections limit, back_log doesn't *always* have to be smaller than max_connections.
-
Sergei Golubchik authored
make JSON an alias for LONGTEXT CHARACTER SET utf8mb4 COLLATE utf8mb4_bin (same collation that item_jsonfunc.cc is using internally)
-
Sergei Golubchik authored
SQL Standard behavior for DROP COLUMN xxx RESTRICT: * If a constraint (UNIQUE or CHECK) uses only the dropped column, it's automatically dropped too. If it uses many columns - an error.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
don't allow arbitrary combinations of SIGNED/UNSIGNED/ZEROFILL
-
Sergei Golubchik authored
let include/restart_mysqld.inc use include/start_mysqld.inc and include/shutdown_mysqld.inc. Instead of copying their content.
-
Sergei Golubchik authored
InnoDB: in slow shutodwn mode do not stop purge threads as long as some connection threads are running
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
execute queries after purge thread has exited, but the connection thread hasn't before c720e68f it used to crash
-
Sergei Golubchik authored
-
Sergei Golubchik authored
install all server includes under /usr/include/mysql/server/ and C/C includes under /usr/include/mysql/
-
Sergei Golubchik authored
CMakeLists.txt - merge mistake, apparently include/CMakeLists.txt - install from CMAKE_CURRENT_BINARY_DIR. Only install from CMAKE_CURRENT_SOURCE_DIR, if it's different from CMAKE_CURRENT_BINARY_DIR mysql-test/CMakeLists.txt - INSTALL_MYSQL_TEST() macro installs everything, no need to install mtr separately once again mysql-test/lib/My/SafeProcess/CMakeLists.txt MYSQL_ADD_EXECUTABLE includes INSTALL sql-bench/CMakeLists.txt list files explicitly. don't install garbage, don't process 'foo' and 'foo.sh' separately, it's only one file to install, not two.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Vladislav Vaintroub authored
-
Sergei Petrunia authored
-
- 11 Aug, 2017 2 commits
-
-
Vladislav Vaintroub authored
-
Marko Mäkelä authored
xtrabackup_copy_log(): Use a 64-bit bitmask (lsn_t), not 32-bit (int).
-
- 10 Aug, 2017 4 commits
-
-
Alexey Botchkov authored
JSON_EXTRACT behaves specifically in the comparison, so we have to implement specific method for that in Arg_comparator.
-
Marko Mäkelä authored
buf_page_io_complete(): Do not test bpage for NULL, because it is declared (and always passed) as nonnull. buf_flush_batch(): Remove the constant local variable count=0. fil_ibd_load(): Use magic comment to suppress -Wimplicit-fallthrough. ut_stage_alter_t::inc(ulint): Disable references to an unused parameter. lock_queue_validate(), sync_array_find_thread(), rbt_check_ordering(): Define only in debug builds.
-
Oleksandr Byelkin authored
The bug is result adding ability to have derived tables inside views. Fixed checks should be a switch between view/derived or select derived and information schema.
-
Marko Mäkelä authored
Only a relevant subset of the InnoDB changes was merged. In particular, two follow-up bug fixes for the bugs that were introduced in 5.7.18 but not MariaDB 10.2.7 were omitted. Because MariaDB 10.2.7 omitted the risky change Bug#23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX APPLIED BY UNCOMMITTED ROWS we do not need the follow-up fixes that were introduced in MySQL 5.6.37 and MySQL 5.7.19: Bug#25175249 ASSERTION: (TEMPL->IS_VIRTUAL && !FIELD) || ... Bug#25793677 INNODB: FAILING ASSERTION: CLUST_TEMPL_FOR_SEC || LEN
-
- 09 Aug, 2017 4 commits
-
-
Thirunarayanan Balathandayuthapani authored
Analysis: ========= During alter table rebuild, InnoDB fails to apply concurrent insert log. If the insert log record is present across the blocks then apply phase trying to access the next block without fetching it. Fix: ==== During virtual column parsing, check whether the record is present across the blocks before accessing the virtual column information. Reviewed-by: Jimmy Yang <jimmy.yang@oracle.com> RB: 16243
-
Thirunarayanan Balathandayuthapani authored
Analysis: ======== During alter table rebuild, InnoDB fails to apply concurrent delete log. Parsing and validation of merge record happens while applying the log operation on a table. Validation goes wrong for the virtual column. Validation assumes that virtual column information can't be the end of the merge record end. Fix: ==== Virtual column information in the merge record can be end of the merge record. Virtual column information is written at the end for row_log_table_delete(). Reviewed-by: Satya Bodapati<satya.bodapati@oracle.com> RB: 16155
-
Marko Mäkelä authored
The test is for a bug that was introduced in MySQL 5.7.18 but not MariaDB 10.2, because MariaDB did not merge the change that was considered incomplete and too risky for a GA release: Bug#23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX APPLIED BY UNCOMMITTED ROWS So, we are only merging the test changes from the bug fix in MySQL 5.7.19, not any code changes: commit 4f86aca37d551cc756d9187ec901f8c4a68a0543 Author: Thirunarayanan Balathandayuthapani <thirunarayanan.balathandayuth@oracle.com> Date: Wed Apr 26 11:10:41 2017 +0530 Bug #25793677 INNODB: FAILING ASSERTION: CLUST_TEMPL_FOR_SEC || LEN
-
Marko Mäkelä authored
MariaDB 10.2 never contained the Oracle change Bug#23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX APPLIED BY UNCOMMITTED ROWS because it was considered risky for a GA release and incomplete. Remove the references that were added when merging MySQL 5.6.36 to MariaDB 10.0.31, 10.1.24, and 10.2.7.
-