1. 18 Dec, 2017 1 commit
    • Aleksey Midenkov's avatar
      Timestamp-based versioning for InnoDB [closes #209] · b55a1491
      Aleksey Midenkov authored
      * Removed integer_fields check
      * Reworked Vers_parse_info::check_sys_fields()
      * Misc renames
      * versioned as vers_sys_type_t
      
      * Removed versioned_by_sql(), versioned_by_engine()
      
      versioned() works as before;
      versioned(VERS_TIMESTAMP) is versioned_by_sql();
      versioned(VERS_TRX_ID) is versioned_by_engine().
      
      * create_tmp_table() fix
      * Foreign constraints for timestamp-based
      * Range auto-specifier fix
      * SQL: 1-row partition rotation fix [fixes #260]
      * Fix 'drop system versioning, algorithm=inplace'
      b55a1491
  2. 17 Dec, 2017 2 commits
  3. 15 Dec, 2017 7 commits
  4. 14 Dec, 2017 21 commits
    • Sachin Setiya's avatar
      mysqldump fix for invisible column · 0bc3c0fb
      Sachin Setiya authored
      Actually there are 2 issues in the case of invisible columns
      
        1st `select fields from t1` will have more fields then `select * from t1`.
      So instead of `select * from t1` we are using `select a,b,invisible from t1`
      these fields are supplied from `select fields from t1`.
      
        2nd We are using --complete-insert when we detect that this table is using
      invisible columns.
      0bc3c0fb
    • Sachin Setiya's avatar
      BuildBot bug fix for invisible columns · c90db2c8
      Sachin Setiya authored
      c90db2c8
    • Sergei Golubchik's avatar
      Add tests for system and completely invisible columns · 022b163a
      Sergei Golubchik authored
      debug only
      022b163a
    • Sachin Setiya's avatar
      MDEV-10177 Invisible Columns and Invisible Index · 84726906
      Sachin Setiya authored
      Feature Definition:-
      
      This feature adds invisible column functionality to server.
      There is 4 level of "invisibility":
      
      1. Not invisible (NOT_INVISIBLE) — Normal columns created by the user
      
      2. A little bit invisible (USER_DEFINED_INVISIBLE) — columns that the
          user has marked invisible. They aren't shown in SELECT * and they
          don't require values in INSERT table VALUE (...). Otherwise
          they behave as normal columns.
      
      3. More invisible (SYSTEM_INVISIBLE) — Can be queried explicitly,
          otherwise invisible from everything. Think ROWID sytem column.
          Because they're invisible from ALTER TABLE and from CREATE TABLE
          they cannot be created or dropped, they're created by the system.
          User cant not create a column name which is same as of
          SYSTEM_INVISIBLE.
      
      4. Very invisible (COMPLETELY_INVISIBLE) — as above, but cannot be
          queried either. They can only show up in EXPLAIN EXTENDED (might
          be possible for a very invisible indexed virtual column) but
          otherwise they don't exist for the user.If user creates a columns
          which has same name as of COMPLETELY_INVISIBLE then
          COMPLETELY_INVISIBLE column is renamed again. So it is completely
          invisible from user.
      
      Invisible Index(HA_INVISIBLE_KEY):-
         Creation of invisible columns require a new type of index which
         will be only visible to system. User cant see/alter/create/delete
         this index. If user creates a index which is same name as of
         invisible index then it will be renamed.
      
      Syntax Details:-
      
        Only USER_DEFINED_INVISIBLE column can be created by user. This
        can be created by adding INVISIBLE suffix after column definition.
      
        Create table t1( a int invisible, b int);
      
      Rules:-
        There are some rules/restrictions related to use of invisible columns
        1. All the columns in table cant be invisible.
           Create table t1(a int invisible); \\error
           Create table t1(a int invisible, b int invisble); \\error
        2. If you want invisible column to be NOT NULL then you have to supply
           Default value for the column.
           Create table t1(a int, b int not null); \\error
        3. If you create a view/create table with select * then this wont copy
           invisible fields. So newly created view/table wont have any invisible
           columns.
           Create table t2 as select * from t1;//t2 wont have t1 invisible column
           Create view v1 as select * from t1;//v1 wont have t1 invisible column
        4. Invisibility wont be forwarded to next table in any case of create
           table/view as select */(a,b,c) from table.
           Create table t2 as select a,b,c from t1; // t2 will have t1 invisible
                                 // column(b), but this wont be invisible in t2
           Create view v1 as select a,b,c from t1; // v1 will have t1 invisible
                                 // column(b), but this wont be invisible in v1
      
      Implementation Details:-
        Parsing:- INVISIBLE_SYM is added into vcol_attribute(so its like unique
            suffix), It is also added into keyword_sp_not_data_type so that table
            can have column with name invisible.
        Implementation detail is given by each modified function/created function.
         (Some function are left as they were self explanatory)
         (m= Modified, n= Newly Created)
      
        mysql_prepare_create_table(m):- Extra checks for invisible columns are
        added. Also some DEBUG_EXECUTE_IF are also added for test cases.
      
        mysql_prepare_alter_table(m):- Now this will drop all the
        COMPLETELY_INVISIBLE column and HA_INVISIBLE_KEY index. Further
        Modifications are made to stop drop/change/delete of SYSTEM_INVISIBLE
        column.
      
        build_frm_image(m):- Now this allows incorporating field_visibility
        status into frm image. To remain compatible with old frms
        field_visibility info will be only written when any of the field is
        not NOT_INVISIBLE.
      
        extra2_write_additional_field_properties(n):- This will write field
        visibility info into buffer. We first write EXTRA2_FIELD_FLAGS into
        buffer/frm , then each next char will have field_visibility for each
        field.
      
        init_from_binary_frm_image(m):- Now if we get EXTRA2_FIELD_FLAGS,
        then we will read the next n(n= number of fields) chars and set the
        field_visibility. We also increment
        thd->status_var.feature_invisible_columns. One important thing to
        note if we find out that key contains a field whose visibility is
        > USER_DEFINED_INVISIBLE then , we declare this key as invisible
        key.
      
        sql_show.cc is changed accordingly to make show table, show keys
        correct.
      
        mysql_insert(m):- If we get to know that we are doing insert in
        this way insert into t1 values(1,1); without explicitly specifying
        columns, then we check for if we have invisible fields if yes then
        we reset the whole record, Why ? Because first we want hidden columns
        to get default/null value. Second thing auto_increment has property
        no default and no null which voilates invisible key rule 2, And
        because of this it was giving error. Reseting table->record[0]
        eliminates this issue. More info put breakpoint on handler::write_row
        and see auto_increment value.
      
        fill_record(m):- we continue loop if we find invisible column because
        this is already reseted/will get its value if it is default.
      
      Test cases:- Since we can not directly add > USER_DEFINED_INVISIBLE
        column then I have debug_dbug to create it in mysql_prepare_create_table.
      
        Patch Credit:- Serg Golubchik
      84726906
    • Sergei Golubchik's avatar
      84e14bff
    • Sergei Golubchik's avatar
      Partitioning syntax for versioning · 18405e5f
      Sergei Golubchik authored
       partition by system_time (
          partition p0 history,
          partition pn current
       )
      18405e5f
    • Aleksey Midenkov's avatar
      MDEV-14652 NATURAL JOIN crash in mark_common_columns() [fixes #405] · 2ae2876a
      Aleksey Midenkov authored
      SQL: reverted NATURAL JOIN fix #161 (deprecated by #383)
      2ae2876a
    • Eugene Kosov's avatar
      SQL: uninitialized read [#387] · 4be2173e
      Eugene Kosov authored
      versioning.truncate is affected in embedded mode
      4be2173e
    • Aleksey Midenkov's avatar
      MDEV-14650 Assertion 0 failed in TABLE::vers_update_fields [fixes #402] · 27187443
      Aleksey Midenkov authored
      SQL: fixed selecion of handlerton by respecting partitioning
      27187443
    • Aleksey Midenkov's avatar
    • Aleksey Midenkov's avatar
    • Aleksey Midenkov's avatar
    • Eugene Kosov's avatar
      System Versioning 1.0 pre4 · 76556960
      Eugene Kosov authored
      Merge branch '10.3' into trunk
      76556960
    • Eugene Kosov's avatar
      5d5ae2f4
    • Eugene Kosov's avatar
      f14f0483
    • Aleksey Midenkov's avatar
      2e3b580b
    • Sergei Golubchik's avatar
      rename versioning_* variables · f1490133
      Sergei Golubchik authored
      f1490133
    • Marko Mäkelä's avatar
      Merge bb-10.2-ext into 10.3 · 866ccc88
      Marko Mäkelä authored
      866ccc88
    • Marko Mäkelä's avatar
      Merge 10.2 into bb-10.2-ext · 1b5f0cbd
      Marko Mäkelä authored
      1b5f0cbd
    • Marko Mäkelä's avatar
      80638049
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · ece9c54e
      Marko Mäkelä authored
      ece9c54e
  5. 13 Dec, 2017 9 commits