1. 14 Oct, 2009 1 commit
  2. 12 Oct, 2009 3 commits
  3. 07 Oct, 2009 1 commit
  4. 01 Oct, 2009 1 commit
    • vasil's avatar
      branches/5.1: · ece195f7
      vasil authored
      Fix Bug#38996 Race condition in ANALYZE TABLE
      
      by serializing ANALYZE TABLE inside InnoDB.
      
      Approved by:	Heikki (rb://175)
      ece195f7
  5. 22 Sep, 2009 1 commit
  6. 14 Sep, 2009 1 commit
  7. 10 Sep, 2009 2 commits
    • jyang's avatar
      branches/5.1: Block creating table with column name conflicting · 5224d8a7
      jyang authored
      with Innodb reserved key words. (Bug #44369) rb://151 approved
      by Sunny Bains.
      5224d8a7
    • vasil's avatar
      branches/5.1: · 2fb3a5a7
      vasil authored
      Fix a compilation warning caused by c5799:
      
      handler/ha_innodb.cc: In function 'void innobase_get_cset_width(ulint, ulint*, ulint*)':
      handler/ha_innodb.cc:830: warning: format '%d' expects type 'int', but argument 2 has type 'ulint'
      2fb3a5a7
  8. 09 Sep, 2009 2 commits
    • calvin's avatar
      branches/5.1: fix bug#46256 · d6784c3d
      calvin authored
      Allow tables to be dropped even if the collation is not found,
      but issue a warning.
      
      Could not find an easy way to add mysql-test since it requires
      changes to charsets and restarting the server. Tests were
      executed manually.
      
      Approved by: Heikki (on IM)
      d6784c3d
    • calvin's avatar
      branches/5.1: merge change from 5.1.38 · 180ed3e4
      calvin authored
      HA_ERR_TOO_MANY_CONCURRENT_TRXS is added in 5.1.38.
      180ed3e4
  9. 04 Sep, 2009 2 commits
  10. 03 Sep, 2009 2 commits
  11. 26 Aug, 2009 1 commit
    • calvin's avatar
      branches/5.1: · 06db0143
      calvin authored
      Merge PART OF r2911.5.5 from MySQL:
      
      adjust CMakeLists.txt to work with MySQL 5.1.38
      and beyond.
      
      MySQL changed how the build works on Windows starting from 5.1.38.
      All shared properties are defined in mysql_storage_engine.cmake.
      And the top level CMakeLists.txt determines what engines to build
      and how (static vs. dynamic).
      
      log message from BZR:
      
        ------------------------------------------------------------
        revno: 2911.5.5
        committer: Vladislav Vaintroub <vvaintroub@mysql.com>
        branch nick: 5.1-innodb_plugin
        timestamp: Wed 2009-06-10 10:59:49 +0200
        message:
          Backport WL#3653 to 5.1 to enable bundled innodb plugin.
          Remove custom DLL loader code from innodb plugin code, use 
          symbols exported from mysqld.
        removed:
          storage/innodb_plugin/handler/handler0vars.h
          storage/innodb_plugin/handler/win_delay_loader.cc
        added:
          storage/mysql_storage_engine.cmake
          win/create_def_file.js
        modified:
          CMakeLists.txt
          include/m_ctype.h
          include/my_global.h
          include/my_sys.h
          include/mysql/plugin.h
          libmysqld/CMakeLists.txt
          mysql-test/mysql-test-run.pl
          mysql-test/t/plugin.test
          mysql-test/t/plugin_load-master.opt
          mysys/charset.c
          sql/CMakeLists.txt
          sql/handler.h
          sql/mysql_priv.h
          sql/mysqld.cc
          sql/sql_class.cc
          sql/sql_class.h
          sql/sql_list.h
          sql/sql_profile.h
          storage/Makefile.am
          storage/archive/CMakeLists.txt
          storage/blackhole/CMakeLists.txt
          storage/csv/CMakeLists.txt
          storage/example/CMakeLists.txt
          storage/federated/CMakeLists.txt
          storage/heap/CMakeLists.txt
          storage/innobase/CMakeLists.txt
          storage/innobase/handler/ha_innodb.cc
          storage/innodb_plugin/CMakeLists.txt
          storage/innodb_plugin/handler/ha_innodb.cc
          storage/innodb_plugin/handler/handler0alter.cc
          storage/innodb_plugin/handler/i_s.cc
          storage/innodb_plugin/plug.in
          storage/myisam/CMakeLists.txt
          storage/myisammrg/CMakeLists.txt
          win/Makefile.am
          win/configure.js
      06db0143
  12. 03 Aug, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 69362950
      vasil authored
      Merge a change from MySQL:
      
        ------------------------------------------------------------
        revno: 2988
        committer: Satya B <satya.bn@sun.com>
        branch nick: mysql-5.1-bugteam
        timestamp: Wed 2009-07-01 11:06:05 +0530
        message:
          Fix build failure after applying Innodb snapshot 5.1-ss5282
          
          After applying Innodb snapshot 5.1-ss5282, build was broken
          because of missing header file. 
          
          Adding the header file to Makefile.am after informing the 
          innodb developers.
        modified:
          storage/innobase/Makefile.am
      69362950
  13. 20 Jul, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 03906dfb
      vasil authored
      Merge a change from MySQL:
      
        ------------------------------------------------------------
        revno: 2874.2.1
        committer: Anurag Shekhar <anurag.shekhar@sun.com>
        branch nick: mysql-5.1-bugteam-windows-warning
        timestamp: Wed 2009-05-13 15:41:24 +0530
        message:
          Bug #39802 On Windows, 32-bit time_t should be enforced
          
          This patch fixes compilation warning, "conversion from 'time_t' to 'ulong', 
          possible loss of data". 
          The fix is to typecast time_t to ulong before assigning it to ulong. 
          Backported this from 6.0-bugteam tree.
        modified:
          storage/archive/ha_archive.cc
          storage/federated/ha_federated.cc
          storage/innobase/handler/ha_innodb.cc
          storage/myisam/ha_myisam.cc
      03906dfb
  14. 09 Jul, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 6fab83e1
      vasil authored
      Fix Bug#21704 Renaming column does not update FK definition
      
      by checking whether a column that participates in a FK definition is being
      renamed and denying the ALTER in this case.
      
      The patch was originally developed by Davi Arnaut <Davi.Arnaut@Sun.COM>:
      http://lists.mysql.com/commits/77714
      and was later adjusted to conform to InnoDB coding style by me (Vasil),
      I also added some more comments and moved the bug specific mysql-test to
      a separate file to make it more manageable and flexible.
      6fab83e1
  15. 02 Jul, 2009 1 commit
    • vasil's avatar
      branches/5.1: · fec0e9f7
      vasil authored
      Adjust the failing innodb-autoinc test to conform to the latest behavior
      of the MySQL code. The idea and the comment in innodb-autoinc.test come
      from Sunny.
      fec0e9f7
  16. 30 Jun, 2009 1 commit
  17. 25 Jun, 2009 1 commit
    • marko's avatar
      branches/5.1: Merge r5418 from branches/zip: · 274dd549
      marko authored
        ------------------------------------------------------------------------
        r5418 | marko | 2009-06-25 15:55:52 +0300 (Thu, 25 Jun 2009) | 5 lines
        Changed paths:
           M /branches/zip/ChangeLog
           M /branches/zip/handler/ha_innodb.cc
           M /branches/zip/mysql-test/innodb_bug42101-nonzero.result
           M /branches/zip/mysql-test/innodb_bug42101-nonzero.test
           M /branches/zip/mysql-test/innodb_bug42101.result
           M /branches/zip/mysql-test/innodb_bug42101.test
        
        branches/zip: Fix a race condition caused by
        SET GLOBAL innodb_commit_concurrency=DEFAULT. (Bug #45749)
        When innodb_commit_concurrency is initially set nonzero,
        DEFAULT would change it back to 0, triggering Bug #42101.
        rb://139 approved by Heikki Tuuri.
        ------------------------------------------------------------------------
      274dd549
  18. 24 Jun, 2009 1 commit
  19. 17 Jun, 2009 2 commits
  20. 05 Jun, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 13738529
      vasil authored
      Remove the word "Error" from the printout because the mysqltest suite
      interprets it as an error and thus the innodb-autoinc test fails.
      
      Approved by:	Sunny (via IM)
      13738529
  21. 04 Jun, 2009 1 commit
  22. 03 Jun, 2009 2 commits
    • sunny's avatar
      branches/5.1: When the InnoDB and MySQL data dictionaries go out of sync, before · 992a74f4
      sunny authored
      the bug fix we would assert on missing autoinc columns. With this fix we allow
      MySQL to open the table but set the next autoinc value for the column to the
      MAX value. This effectively disables the next value generation. INSERTs will
      fail with a generic AUTOINC failure. However, the user should be able to
      read/dump the table, set the column values explicitly, use ALTER TABLE to
      set the next autoinc value and/or sync the two data dictionaries to resume
      normal operations.
      
      Fix Bug#44030 Error: (1500) Couldn't read the MAX(ID) autoinc value from the
      index (PRIMARY)
      
      rb://118
      992a74f4
    • marko's avatar
      branches/5.1: Merge the test case from r5232 from branches/5.0: · 1a9e35d4
      marko authored
        ------------------------------------------------------------------------
        r5232 | marko | 2009-06-03 14:31:04 +0300 (Wed, 03 Jun 2009) | 21 lines
      
        branches/5.0: Merge r3590 from branches/5.1 in order to fix Bug #40565
        (Update Query Results in "1 Row Affected" But Should Be "Zero Rows").
      
        Also, add a test case for Bug #40565.
      
        rb://128 approved by Heikki Tuuri
        ------------------------------------------------------------------------
      1a9e35d4
  23. 30 May, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 534ab8a6
      vasil authored
      Merge a change from MySQL (this fixes the failing innodb_mysql test):
      
        ------------------------------------------------------------
        revno: 1810.3894.10
        committer: Sergey Glukhov <Sergey.Glukhov@sun.com>
        branch nick: mysql-5.0-bugteam
        timestamp: Tue 2009-05-19 11:32:21 +0500
        message:
          Bug#39793 Foreign keys not constructed when column has a '#' in a comment or default value
          Internal InnoDN FK parser does not recognize '\'' as quotation symbol.
          Suggested fix is to add '\'' symbol check for quotation condition
          (dict_strip_comments() function).
        modified:
          innobase/dict/dict0dict.c
          mysql-test/r/innodb_mysql.result
          mysql-test/t/innodb_mysql.test
      534ab8a6
  24. 27 May, 2009 1 commit
  25. 26 May, 2009 3 commits
    • vasil's avatar
      branches/5.1: · b1c6e114
      vasil authored
      Fix Bug#45097 Hang during recovery, redo logs for doublewrite buffer pages
      
      Do not write redo log for the pages in the doublewrite buffer. Also, do not
      make a dummy change to the page because this is not needed.
      b1c6e114
    • vasil's avatar
      branches/5.1: · a1532f0d
      vasil authored
      Preparation for the fix of
      Bug#45097 Hang during recovery, redo logs for doublewrite buffer pages
      
      Do not include unnecessary headers mtr0log.h and fut0lst.h in trx0sys.h
      and include fsp0fsp.h just before it is needed. This is needed in order
      to be able to use TRX_SYS_SPACE in mtr0log.ic.
      a1532f0d
    • vasil's avatar
      branches/5.1: · cf1b7085
      vasil authored
      Preparation for the fix of
      Bug#45097 Hang during recovery, redo logs for doublewrite buffer pages 
      
      Non-functional change: move FSP_* macros from fsp0fsp.h to a new file
      fsp0types.h. This is needed in order to be able to use FSP_EXTENT_SIZE 
      in mtr0log.ic.
      cf1b7085
  26. 14 May, 2009 1 commit
    • marko's avatar
      branches/5.1: Prevent a race condition in innobase_commit() by ensuring · f1439b00
      marko authored
      that innodb_commit_concurrency>0 remains constant at run time. (Bug #42101)
      
      srv_commit_concurrency: Make this a static variable in ha_innodb.cc.
      
      innobase_commit_concurrency_validate(): Check that innodb_commit_concurrency
      is not changed from or to 0 at run time.  This is needed, because
      innobase_commit() assumes that innodb_commit_concurrency>0 remains constant.
      Without this limitation, the checks for innodb_commit_concurrency>0
      in innobase_commit() should be removed and that function would have to
      acquire and release commit_cond_m at least twice per invocation.
      Normally, innodb_commit_concurrency=0, and introducing the mutex operations
      would mean significant overhead.
      
      innodb_bug42101.test, innodb_bug42101-nonzero.test: Test cases.
      
      rb://123 approved by Heikki Tuuri
      f1439b00
  27. 13 May, 2009 1 commit
  28. 17 Apr, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 1bf3bcbc
      vasil authored
      Merge a change from MySQL:
      
        ------------------------------------------------------------
        revno: 2728.10.2
        committer: Ignacio Galarza <iggy@mysql.com>
        branch nick: mysql-5.1-bugteam-bug29125
        timestamp: Fri 2009-02-13 11:41:47 -0500
        message:
          Bug#29125 Windows Server X64: so many compiler warnings
          - Remove bothersome warning messages.  This change focuses on the warnings 
          that are covered by the ignore file: support-files/compiler_warnings.supp.
          - Strings are guaranteed to be max uint in length
        modified:
          client/mysql_upgrade.c
          client/mysqladmin.cc
          client/mysqlbinlog.cc
          client/mysqlcheck.c
          client/mysqldump.c
          client/mysqlslap.c
          client/mysqltest.cc
          client/sql_string.cc
          extra/comp_err.c
          extra/yassl/src/buffer.cpp
          extra/yassl/taocrypt/include/block.hpp
          extra/yassl/taocrypt/src/algebra.cpp
          extra/yassl/taocrypt/src/asn.cpp
          include/config-win.h
          libmysql/libmysql.c
          mysys/array.c
          mysys/base64.c
          mysys/charset.c
          mysys/checksum.c
          mysys/default.c
          mysys/default_modify.c
          mysys/hash.c
          mysys/mf_keycache.c
          mysys/mf_tempdir.c
          mysys/my_append.c
          mysys/my_compress.c
          mysys/my_conio.c
          mysys/my_copy.c
          mysys/my_getwd.c
          mysys/my_pread.c
          mysys/my_quick.c
          mysys/my_read.c
          mysys/safemalloc.c
          mysys/string.c
          server-tools/instance-manager/buffer.cc
          server-tools/instance-manager/instance.cc
          server-tools/instance-manager/options.cc
          server-tools/instance-manager/parse.h
          sql-common/client.c
          sql-common/my_user.c
          sql/event_data_objects.cc
          sql/event_parse_data.cc
          sql/events.cc
          sql/gen_lex_hash.cc
          sql/item.h
          sql/item_func.cc
          sql/item_strfunc.cc
          sql/item_timefunc.cc
          sql/lock.cc
          sql/log_event.cc
          sql/log_event.h
          sql/log_event_old.cc
          sql/net_serv.cc
          sql/sp_head.h
          sql/spatial.h
          sql/sql_class.h
          sql/sql_connect.cc
          sql/sql_crypt.cc
          sql/sql_error.cc
          sql/sql_insert.cc
          sql/sql_lex.cc
          sql/sql_lex.h
          sql/sql_load.cc
          sql/sql_prepare.cc
          sql/sql_profile.cc
          sql/sql_repl.cc
          sql/sql_servers.cc
          sql/sql_string.cc
          sql/sql_table.cc
          sql/sql_trigger.cc
          sql/sql_udf.cc
          sql/sql_view.cc
          sql/udf_example.c
          sql/uniques.cc
          storage/archive/azio.c
          storage/archive/azlib.h
          storage/csv/ha_tina.cc
          storage/csv/ha_tina.h
          storage/csv/transparent_file.h
          storage/federated/ha_federated.cc
          storage/federated/ha_federated.h
          storage/heap/hp_write.c
          storage/innobase/handler/ha_innodb.cc
          storage/innobase/include/pars0pars.h
          storage/myisam/ha_myisam.cc
          storage/myisam/mi_check.c
          storage/myisam/mi_packrec.c
          storage/myisam/mi_search.c
          storage/myisam/rt_index.c
          storage/myisammrg/ha_myisammrg.cc
          strings/ctype.c
          strings/my_vsnprintf.c
          tests/bug25714.c
          tests/mysql_client_test.c
      1bf3bcbc
  29. 15 Apr, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 996238b4
      vasil authored
      Merge a change from MySQL (looks like this is against 5.0 but they later
      merged it to 5.1):
      
        ------------------------------------------------------------
        revno: 1810.3846.1
        committer: Alexey Botchkov <holyfoot@mysql.com>
        branch nick: 31435
        timestamp: Tue 2008-11-11 14:42:32 +0400
        message:
          Bug#31435 ha_innodb.cc:3983: ulint convert_search_mode_to_innobase(ha_rkey_function): Asse 
              I think we don't need to issue an error statement in the convert_search_mode_to_innobase().
              Returning the PAGE_CUR_UNSUPP value is enough as allows to handle this
              case depending on the requirements.
          
          per-file comments:
            sql/ha_innodb.cc 
          Bug#31435 ha_innodb.cc:3983: ulint convert_search_mode_to_innobase(ha_rkey_function): Asse 
               no error issued in convert_search_mode_to_innobase.
               ha_innobase::records_in_range() returns HA_POS_ERROR if search mode isn't supported.
        modified:
          sql/ha_innodb.cc
      996238b4
  30. 14 Apr, 2009 1 commit
    • vasil's avatar
      branches/5.1: · 07f52813
      vasil authored
      When using the random function, first take the modulus by the number of pages
      and then typecast to ulint.
      
      This is a followup to r4699 - the fix of Bug#43660.
      07f52813