1. 06 Mar, 2019 2 commits
    • Marko Mäkelä's avatar
      MDEV-18659: Fix string truncation/overflow in InnoDB and XtraDB · b7612116
      Marko Mäkelä authored
      Fix the warnings issued by GCC 8 -Wstringop-truncation
      and -Wstringop-overflow in InnoDB and XtraDB.
      
      This work is motivated by Jan Lindström. The patch mainly differs
      from his original one as follows:
      
      (1) We remove explicit initialization of stack-allocated string buffers.
      The minimum amount of initialization that is needed is a terminating
      NUL character.
      (2) GCC issues a warning for invoking strncpy(dest, src, sizeof dest)
      because if strlen(src) >= sizeof dest, there would be no terminating
      NUL byte in dest. We avoid this problem by invoking strncpy() with
      a limit that is 1 less than the buffer size, and by always writing
      NUL to the last byte of the buffer.
      (3) We replace strncpy() with memcpy() or strcpy() in those cases
      when the result is functionally equivalent.
      
      Note: fts_fetch_index_words() never deals with len==UNIV_SQL_NULL.
      This was enforced by an assertion that limits the maximum length
      to FTS_MAX_WORD_LEN. Also, the encoding that InnoDB uses for
      the compressed fulltext index is not byte-order agnostic, that is,
      InnoDB data files that use FULLTEXT INDEX are not portable between
      big-endian and little-endian systems.
      b7612116
    • Marko Mäkelä's avatar
      MDEV-18749: Uninitialized value upon ADD FULLTEXT INDEX · b21930fb
      Marko Mäkelä authored
      row_merge_create_fts_sort_index(): Initialize dict_col_t.
      
      This fixes an access to uninitialized dict_col_t::ind when a debug
      assertion in MariaDB 10.4 invokes is_dropped() in
      rec_get_converted_size_comp_prefix_low(). Older MariaDB versions
      seem to be unaffected by the uninitialized values, but it should
      not hurt to initialize everything.
      b21930fb
  2. 04 Mar, 2019 2 commits
  3. 01 Mar, 2019 1 commit
  4. 28 Feb, 2019 7 commits
  5. 25 Feb, 2019 1 commit
    • Julius Goryavsky's avatar
      MDEV-9519: Data corruption will happen on the Galera cluster size change · 243f829c
      Julius Goryavsky authored
      If we have a 2+ node cluster which is replicating from an async master
      and the binlog_format is set to STATEMENT and multi-row inserts are executed
      on a table with an auto_increment column such that values are automatically
      generated by MySQL, then the server node generates wrong auto_increment
      values, which are different from what was generated on the async master.
      
      In the title of the MDEV-9519 it was proposed to ban start slave on a Galera
      if master binlog_format = statement and wsrep_auto_increment_control = 1,
      but the problem can be solved without such a restriction.
      
      The causes and fixes:
      
      1. We need to improve processing of changing the auto-increment values
      after changing the cluster size.
      
      2. If wsrep auto_increment_control switched on during operation of
      the node, then we should immediately update the auto_increment_increment
      and auto_increment_offset global variables, without waiting of the next
      invocation of the wsrep_view_handler_cb() callback. In the current version
      these variables retain its initial values if wsrep_auto_increment_control
      is switched on during operation of the node, which leads to inconsistent
      results on the different nodes in some scenarios.
      
      3. If wsrep auto_increment_control switched off during operation of the node,
      then we must return the original values of the auto_increment_increment and
      auto_increment_offset global variables, as the user has set. To make this
      possible, we need to add a "shadow copies" of these variables (which stores
      the latest values set by the user).
      
      https://jira.mariadb.org/browse/MDEV-9519
      243f829c
  6. 21 Feb, 2019 2 commits
  7. 20 Feb, 2019 4 commits
  8. 19 Feb, 2019 4 commits
  9. 18 Feb, 2019 1 commit
  10. 14 Feb, 2019 1 commit
  11. 12 Feb, 2019 1 commit
    • Julius Goryavsky's avatar
      MDEV-18426: Most of the mtr tests in the galera_3nodes suite fail · 5b827511
      Julius Goryavsky authored
      Most of the mtr tests in the galera_3nodes suite fail
      for a variety of reasons with a variety of errors.
      
      This patch fixes several substantial flaws
      in the galera_3nodes suite tests and in the mtr framework
      service files, adapting the tests from galera_3nodes
      for the current version of MariaDB.
      
      This patch also synchronizes some galera_3nodes-related
      files with the latest changes made for MDEV-17835 (v2 patch)
      and for MDEV-18379 in other branches (10.2 and 10.3).
      
      Closes #1161
      5b827511
  12. 11 Feb, 2019 1 commit
  13. 07 Feb, 2019 1 commit
  14. 06 Feb, 2019 1 commit
  15. 05 Feb, 2019 1 commit
  16. 04 Feb, 2019 1 commit
  17. 03 Feb, 2019 1 commit
  18. 02 Feb, 2019 2 commits
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.1 · 213ece2f
      Marko Mäkelä authored
      This is joint work with Oleksandr Byelkin.
      213ece2f
    • Marko Mäkelä's avatar
      Fix embedded innodb_plugin after 560799eb · c1e1764f
      Marko Mäkelä authored
      wsrep_certification_rules: Define as a weak global symbol.
      While there are separate _embedded.a for statically
      linked storage engine plugins, there is only one ha_innodb.so
      which is supposed to work with both values of WITH_WSREP.
      
      The merge from 10.0-galera introduced a reference to a global
      variable that is only defined when the server is built WITH_WSREP.
      We must define that symbol as weak global, so that when
      a dynamically linked InnoDB or XtraDB is used with the embedded
      server (which never includes write-set replication patches),
      the variable will be read as 0, instead of causing a failure to
      load the InnoDB or XtraDB plugin.
      c1e1764f
  19. 01 Feb, 2019 3 commits
  20. 31 Jan, 2019 3 commits