1. 21 Jan, 2008 1 commit
  2. 27 Dec, 2007 1 commit
    • unknown's avatar
      scripts/make_binary_distribution.sh: · 07aab86f
      unknown authored
      Fix the code to get the "libgcc" file name so that the failure of Intel's ICC
      to provide this information does not cause any problems.
      
      This fixes  bug#33536  Option "--print-libgcc-file" does not work with ICC compiler
      
      
      scripts/make_binary_distribution.sh:
        The (old) code to get the "libgcc" file name does not really work when using Intel's ICC.
        ICC accepts the "--print-libgcc-file" option but ignores it, does not produce any output.
        
        However, ICC tricks automake into taking it for a GCC ("GXX" variable is set, see
        http://www.gnu.org/software/autoconf/manual/html_node/C_002b_002b-Compiler.html#C_002b_002b-Compiler
        and its discussion of the "AC_PROG_CXX" macro).
        
        There are two possible approaches:
        a) Check "$CC" or "$CXX" to tell ICC from GCC, and do not ask ICC for the "libgcc" file name.
        b) Just ask it, but protect that code so that its failure does not cause any damage.
        
        This patch takes the second route:
        1) Put the call "@CC@ ... --print-libgcc-file" into a pipeline, followed by "|| true",
           so that (for the shell semantics) the command cannot fail.
           (ICC will exit non-zero because it is not given a source file.)
        2) Explicitly redirect any error messages.
        3) Do not use the compiler's return code but rather the (non)empty variable to check success.
        4) Ensure that the contents really is a file before taking it as a file name.
        
        Item 1) is especially important when the tool gets a "set -e" (this happens in 5.1, currently)
        which would make the failing compiler call a fatal thing.
        
        This fixes  bug#33536  Option "--print-libgcc-file" does not work with ICC compiler
      07aab86f
  3. 17 Dec, 2007 3 commits
  4. 13 Dec, 2007 1 commit
  5. 10 Dec, 2007 1 commit
  6. 06 Dec, 2007 2 commits
  7. 05 Dec, 2007 1 commit
  8. 01 Dec, 2007 2 commits
  9. 30 Nov, 2007 5 commits
    • unknown's avatar
      Merge four.local.lan:/work/merge/mysql-4.1-dev · d09dfdab
      unknown authored
      into  four.local.lan:/work/trees/mysql-4.1-build-src-clean
      
      
      d09dfdab
    • unknown's avatar
      Merge mysql.com:/home/hf/work/31900/my41-31900 · d87a75c1
      unknown authored
      into  mysql.com:/home/hf/work/mrg/my41-mrg
      
      
      d87a75c1
    • unknown's avatar
      Fix for · 56b00941
      unknown authored
         Bug#31030 rpl000015.test fails if $MYSQL_TCP_PORT != 3306
      Note:
        This bug does not occur in MySQL 5.0 and up, because
        ChangeSet 1.2328.2.1 2006/11/27 for MySQL 5.0 prevents this.
        The 5.0 fix uses the environment variable DEFAULT_MASTER_PORT
        which is set by mysql-test-run.pl.
        mysql-test-run.pl in 4.1 does not set this variable.
        There are two alternatives:
        1) Backport the 5.0 fix for this test including modifications
           to mysql-test-run.pl and mysql-test-run-shell.
           This is a not acceptable impact on an old MySQL version.
        2) Fix the problem different than in 5.0 like in the current
           ChangeSet + do not apply these changes when upmerging to 5.0
      
      
      mysql-test/r/rpl000015.result:
        Updated result
      mysql-test/t/disabled.def:
        Enable rpl000015
      mysql-test/t/rpl000015.test:
        Unify the MASTER_PORT number
      56b00941
    • unknown's avatar
      my_global.h: · 44ebdc09
      unknown authored
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      
      
      include/my_global.h:
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      44ebdc09
    • unknown's avatar
  10. 29 Nov, 2007 2 commits
    • unknown's avatar
      my_global.h: · f177f5f9
      unknown authored
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      
      
      include/my_global.h:
        Added 64 bit Mac OS X hard coded settings, for universal binaries
      f177f5f9
    • unknown's avatar
      Bug #29085 A small double precision number becomes zero. · 23e402bf
      unknown authored
      Denormalized DOUBLE-s can't be properly handled by old MIPS processors.
      So we need to enable specific mode for them so IRIX will do use
      software round to handle such numbers. 
      
      
      sql/mysqld.cc:
        Bug #29085 A small double precision number becomes zero.
        
        reset_floating_point_exeption() renamed as set_proper_floating_point_mode()
        #ifdef __sgi code added to enable denormalized DOUBLE-s on IRIX
      23e402bf
  11. 27 Nov, 2007 1 commit
    • unknown's avatar
      Bug#32707: misdimensioned buffer in protocol layer · 7c0db983
      unknown authored
      Miscalculation in protocol-layer: size buffer correctly so
      even really long error messages cannot overflow our buffer.
      
      
      sql/protocol.cc:
        size buffer correctly so really long error messages cannot overflow it.
      7c0db983
  12. 26 Nov, 2007 2 commits
    • unknown's avatar
      Bug #31900 Wrong confusing comment in mysql_com.h header file. · 7257ed0e
      unknown authored
      comment fixed as we truly need const_item to be 1 to mark
      constant function
      
      
      include/mysql_com.h:
        Bug #31900 Wrong confusing comment in mysql_com.h header file.
        
        comment fixed
      7257ed0e
    • unknown's avatar
      Bug#31752: check strmake() bounds · a905ac34
      unknown authored
      strmake() calls are easy to get wrong. Add checks in extra
      debug mode to identify possible exploits.
      
      Remove some dead code.
      
      Remove some off-by-one errors identified with new checks.
      
      
      sql/log.cc:
        fix off-by-one buffer-length argument to prevent stack smashing
      sql/repl_failsafe.cc:
        fix off-by-one buffer-length argument to prevent stack smashing
      sql/set_var.cc:
        fix off-by-one buffer-length argument to prevent stack smashing
        (already approved, backports #31588)
      sql/sql_show.cc:
        misdimensioned buffers: functions further down the callstack
        expect bufsize of FN_REFLEN
      sql/unireg.cc:
        When EXTRA_DEBUG is enabled, strmake() will write funny patterns to
        buffers it operates on to identify possibly overflows. This leads to
        badness in mysql_create_frm(), so we explicitly put any unused bytes
        (back) into a defined state. Not a bug-fix, but part of the strmake()
        bug detector.
      strings/strmake.c:
        strmake() takes maximum string length rather than buffer-length
        (string length + 1 to accomodate \0 terminator) as argument.
        Since this is easy to get wrong, add extra debug code to identify
        off-by-ones so we can prevent stack smashing.
        
        Alternative "BAD_STRING_COMPILER" removed after checking
        with Monty.
      a905ac34
  13. 24 Nov, 2007 1 commit
  14. 21 Nov, 2007 1 commit
  15. 20 Nov, 2007 1 commit
  16. 19 Nov, 2007 1 commit
    • unknown's avatar
      Bug #30284 spatial key corruption. · da1efa33
      unknown authored
      SPATIAL key is fine actually, but the chk_key() function
      mistakenly returns error. It tries to compare checksums
      of btree and SPATIAL keys while the checksum for the SPATIAL isn't
      calculated (always 0). Same thing with FULLTEXT keys is handled
      using full_text_keys counter, so fixed by counting both
      SPATIAL and FULLTEXT keys in that counter.
      
      
      myisam/mi_check.c:
        Bug #30284 spatial key corruption
        
        full_text_keys counts both FULL_TEXT and SPATIAL keys
      mysql-test/r/gis.result:
        Bug #30284 spatial key corruption
        
        test result
      mysql-test/t/gis.test:
        Bug #30284 spatial key corruption.
        
        test case
      da1efa33
  17. 17 Nov, 2007 1 commit
  18. 16 Nov, 2007 2 commits
  19. 14 Nov, 2007 5 commits
  20. 13 Nov, 2007 2 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1-opt · 9248b402
      unknown authored
      into  mysql.com:/home/hf/work/31305/my41-31305
      
      
      9248b402
    • unknown's avatar
      Bug #31158 Spatial, Union, LONGBLOB vs BLOB bug (crops data) · eb347921
      unknown authored
      max_length parameter for BLOB-returning functions must be big enough
      for any possible content. Otherwise the field created for a table
      will be too small.
      
      
      mysql-test/r/gis.result:
        Bug #31158  Spatial, Union, LONGBLOB vs BLOB bug (crops data)
        
        test result
      mysql-test/t/gis.test:
        Bug #31158  Spatial, Union, LONGBLOB vs BLOB bug (crops data)
        
        test case
      sql/field.cc:
        Bug #31158  Spatial, Union, LONGBLOB vs BLOB bug (crops data)
        
        max_field_size used instead of numeric value
      sql/field.h:
        Bug #31158  Spatial, Union, LONGBLOB vs BLOB bug (crops data)
        
        max_field_size constant defined
      sql/item_geofunc.cc:
        Bug #31158  Spatial, Union, LONGBLOB vs BLOB bug (crops data)
        
        max_length parameter fixed
      eb347921
  21. 12 Nov, 2007 4 commits