An error occurred fetching the project authors.
  1. 21 Apr, 2006 1 commit
  2. 20 Apr, 2006 2 commits
    • unknown's avatar
      func_gconcat.result, func_gconcat.test: · d27c7a7c
      unknown authored
        Remove duplicate test case for bug#14169
      
      
      mysql-test/t/func_gconcat.test:
        Remove duplicate test case for bug#14169
      mysql-test/r/func_gconcat.result:
        Remove duplicate test case for bug#14169
      d27c7a7c
    • unknown's avatar
      Post merge fix · b30d80e8
      unknown authored
      b30d80e8
  3. 19 Apr, 2006 2 commits
    • unknown's avatar
      Temporarily commented out a query from the test case for bug 14169 to make it... · e4d653ab
      unknown authored
      Temporarily commented out a query from the test case for bug 14169 to make it pass with --ps-protocol.
      
      
      mysql-test/r/func_gconcat.result:
        Added DROP TABLE command to the test case for bug 14169.
      e4d653ab
    • unknown's avatar
      func_gconcat.result: · 913c8fa1
      unknown authored
        Corrected test case for the bug#14169 to make it pass in --ps-protocol mode.
      
      
      mysql-test/r/func_gconcat.result:
        Corrected test case for the bug#14169 to make it pass in --ps-protocol mode.
      913c8fa1
  4. 12 Apr, 2006 1 commit
    • unknown's avatar
      Fixed bug#14169: type of group_concat() result changed to blob if tmp_table was · a2066982
      unknown authored
      used
      
      In a simple queries a result of the GROUP_CONCAT() function was always of 
      varchar type.
      But if length of GROUP_CONCAT() result is greater than 512 chars and temporary
      table is used during select then the result is converted to blob, due to
      policy to not to store fields longer than 512 chars in tmp table as varchar
      fields.
      
      In order to provide consistent behaviour, result of GROUP_CONCAT() now
      will always be converted to blob if it is longer than 512 chars.
      Item_func_group_concat::field_type() is modified accordingly.
      
      
      mysql-test/t/func_gconcat.test:
        Added test case for bug#14169: type of group_concat() result changed to blob if tmp_table was used
      mysql-test/r/func_gconcat.result:
        Added test case for bug#14169: type of group_concat() result changed to blob if tmp_table was used
      sql/unireg.h:
        Added the CONVERT_IF_BIGGER_TO_BLOB constant
      sql/sql_select.cc:
        Fixed bug#14169: type of group_concat() result changed to blob if tmp_table was used
        The unnamed constant 255 in the create_tmp_field() and create_tmp_field_from_item() functions now defined as the CONVERT_IF_BIGGER_TO_BLOB constant.
        The create_tmp_field() function now converts the Item_sum string result to a blob field based on its char length.
      sql/item_sum.h:
        Fixed bug#14169: type of group_concat() result changed to blob if tmp_table was used
        To the Item_func_group_concat calls added the member function field_type() which returns the BLOB or VAR_STRING type based on the items length.
      sql/item_func.cc:
        Fixed bug#14169: type of group_concat() result changed to blob if tmp_table was used
        In the Item_func::tmp_table_field() function the unnamed constant 255 is changed to the CONVERT_IF_BIGGER_TO_BLOB constant.
        The Item_func::tmp_table_field() function now measures the result length in chars rather than bytes when converting string result to a blob.
      a2066982
  5. 07 Apr, 2006 1 commit
  6. 29 Mar, 2006 1 commit
    • unknown's avatar
      Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries · b2531546
      unknown authored
      The GROUP_CONCAT uses its own temporary table. When ROLLUP is present
      it creates the second copy of Item_func_group_concat. This copy receives the
      same list of arguments that original group_concat does. When the copy is
      set up the result_fields of functions from the argument list are reset to the
      temporary table of this copy.
      As a result of this action data from functions flow directly to the ROLLUP copy
      and the original group_concat functions shows wrong result.
      Since queries with COUNT(DISTINCT ...) use temporary tables to store
      the results the COUNT function they are also affected by this bug.
      
      The idea of the fix is to copy content of the result_field for the function
      under GROUP_CONCAT/COUNT from  the first temporary table to the second one,
      rather than setting result_field to point to the second temporary table.
      To achieve this goal force_copy_fields flag is added to Item_func_group_concat
      and Item_sum_count_distinct classes. This flag is initialized to 0 and set to 1
      into the make_unique() member function of both classes.
      To the TMP_TABLE_PARAM structure is modified to include the similar flag as
      well.
      The create_tmp_table() function passes that flag to create_tmp_field().
      When the flag is set the create_tmp_field() function will set result_field
      as a source field and will not reset that result field to newly created 
      field for Item_func_result_field and its descendants. Due to this there
      will be created copy func to copy data from old result_field to newly 
      created field.
      
      
      mysql-test/t/func_gconcat.test:
        Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
      mysql-test/r/func_gconcat.result:
        Added test for bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
      sql/sql_table.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added 0 as a last parameter to create_tmp_field()  to force old behaviour.
      sql/sql_select.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        
        Added the flag 'make_copy_field' to create_tmp_field(), so that for Item_result_field descendants create_tmp_field() sets the item's result field as a source field and deny resetting that result field to a new value.
      sql/sql_class.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the flag 'force_copy_fields' to the structure TMP_TABLE_PARAM in order to make create_tmp_field() force the creation of 'copy_field' objects.
      sql/mysql_priv.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the bool parameter 'make_copy_field' to create_tmp_field().
      sql/item_sum.cc:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added initialization of the force_copy_fields flag and passing it to create_tmp_table() through TMP_TBLE_PARAM in the Item_func_group_concat and Item_sum_count_distinct member functions.
      sql/item_sum.h:
        Fixed bug#15560: GROUP_CONCAT wasn't ready for WITH ROLLUP queries
        Added the flag 'force_copy_fields' to the Item_func_group_concat and Item_sum_count_distinct classes.
      b2531546
  7. 21 Jan, 2006 1 commit
    • unknown's avatar
      Merging · 49a09cc3
      unknown authored
      mysql-test/r/func_gconcat.result:
        merging
      mysql-test/r/type_float.result:
        merging
      49a09cc3
  8. 18 Nov, 2005 1 commit
  9. 02 Nov, 2005 1 commit
    • unknown's avatar
      func_gconcat.result: · 6b2379af
      unknown authored
        Fixed wrong test case
      table.cc:
        Fixed wrong DBUG_ENTER placement
      
      
      sql/table.cc:
        Fixed wrong DBUG_ENTER placement
      mysql-test/r/func_gconcat.result:
        Fixed wrong test case
      6b2379af
  10. 15 Oct, 2005 2 commits
    • unknown's avatar
      Fixed bug #12762: · 6a0695fe
      unknown authored
      allowed set functions aggregated in outer subqueries, allowed nested set functions.
      
      
      mysql-test/r/func_gconcat.result:
        Changed a query when fixing bug #12762.
      mysql-test/r/subselect.result:
        Added test cases for bug #12762.
        Allowed set functions aggregated in outer subqueries. Allowed nested set functions.
      mysql-test/t/func_gconcat.test:
        Changed a query when fixing bug #12762.
      mysql-test/t/subselect.test:
        Added test cases for bug #12762.
        Allowed set functions aggregated in outer subqueries. Allowed nested set functions.
      sql/item.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added a parameter to Item::split_sum_func2 aliowing to defer splitting for set functions
        aggregated in outer subquries.
        Changed Item_field::fix_fields to calculate attributes used when checking context conditions
        for set functions.
        Allowed alliases for set functions defined in outer subqueries.
      sql/item.h:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added a parameter to Item::split_sum_func2 aliowing to defer splitting for set functions
        aggregated in outer subquries.
      sql/item_cmpfunc.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added a parameter to Item::split_sum_func2 aliowing to defer splitting for set functions
        aggregated in outer subquries.
      sql/item_func.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added a parameter to Item::split_sum_func2 aliowing to defer splitting for set functions
        aggregated in outer subquries.
      sql/item_row.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added a parameter to Item::split_sum_func2 aliowing to defer splitting for set functions
        aggregated in outer subquries.
      sql/item_strfunc.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added a parameter to Item::split_sum_func2 aliowing to defer splitting for set functions
        aggregated in outer subquries.
      sql/item_subselect.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries and a bitmap of nesting levels showing
        in what subqueries a set function can be aggregated.
      sql/item_sum.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added Item_sum methods to check context conditions imposed on set functions.
      sql/item_sum.h:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Added Item_sum methods to check context conditions imposed on set functions.
      sql/mysql_priv.h:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced a type of bitmaps to be used for nesting constructs.
      sql/sql_base.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries and a bitmap of nesting levels showing
        in what subqueries a set function can be aggregated.
      sql/sql_class.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced a bitmap of nesting levels showing in what subqueries a set function can be aggregated.
      sql/sql_class.h:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced a bitmap of nesting levels showing in what subqueries a set function can be aggregated.
      sql/sql_delete.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced a bitmap of nesting levels showing in what subqueries a set function can be aggregated.
      sql/sql_lex.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries and a bitmap of nesting levels showing
        in what subqueries a set function can be aggregated.
      sql/sql_lex.h:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries and a bitmap of nesting levels showing
        in what subqueries a set function can be aggregated.
      sql/sql_parse.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries.
      sql/sql_prepare.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced a bitmap of nesting levels showingin what subqueries a set function can be aggregated.
      sql/sql_select.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries and a bitmap of nesting levels showing
        in what subqueries a set function can be aggregated.
      sql/sql_update.cc:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced a bitmap of nesting levels showing in what subqueries a set function can be aggregated.
      sql/sql_yacc.yy:
        Fixed bug #12762:
        allowed set functions aggregated in outer subqueries, allowed nested set functions.
        Introduced next levels for subqueries.
      6a0695fe
    • unknown's avatar
      Fix for bug #9855 (Inconsistend column type in create select) · 0f1516b9
      unknown authored
      mysql-test/r/func_gconcat.result:
        result fixed
      mysql-test/r/subselect.result:
        result fixed
      mysql-test/r/type_float.result:
        result fixed
      mysql-test/t/type_float.test:
        testcase added
      sql/item_func.cc:
        Now we set decimals to NOT_FIXED_DEC if the max_length is longer than
        maximum possible double length
      0f1516b9
  11. 07 Sep, 2005 1 commit
    • unknown's avatar
      func_gconcat.result, func_gconcat.test: · d877cdf3
      unknown authored
        Added test cases for bug #12863.
      item_sum.cc, item_sum.h:
        Fixed bug #12863.
        Added a flag to Item_func_group_concat set to FALSE after
        concatenation of the first element of a group.
      
      
      sql/item_sum.h:
        Fixed bug #12863.
        Added a flag to Item_func_group_concat set to FALSE after
        concatenation of the first element of a group.
      sql/item_sum.cc:
        Fixed bug #12863.
        Added a flag to Item_func_group_concat set to FALSE after
        concatenation of the first element of a group.
      mysql-test/t/func_gconcat.test:
        Added test cases for bug #12863.
      mysql-test/r/func_gconcat.result:
        Added test cases for bug #12863.
      d877cdf3
  12. 05 Sep, 2005 1 commit
    • unknown's avatar
      func_gconcat.test, func_gconcat.result: · 5168730f
      unknown authored
        Test case for bug #12859 group_concat in subquery cause incorrect not null.
      
      
      mysql-test/r/func_gconcat.result:
        Test case for bug #12859 group_concat in subquery cause incorrect not null.
      mysql-test/t/func_gconcat.test:
        Test case for bug #12859 group_concat in subquery cause incorrect not null.
      5168730f
  13. 31 Aug, 2005 1 commit
    • unknown's avatar
      Fix bug #12861 client hang with group_concat insubquery FROM DUAL. · fc45b816
      unknown authored
      Item_func_group_concat::fix_fields() set maybe_null flag to 0, and set it to
      1 only if some of it's arguments may be null. When used in subquery in tmp 
      table created field which can't be null. When no data retireved result field
      have to be set to null and error mentioned in bug report occurs. Also this 
      bug can occur if selecting from not null field in empty table.
      
      Function group_concat now marked maybe_null from the very beginning not only
      if some of it's argument may be null.
      
      
      sql/item_sum.cc:
        Fix bug #12861 client hang with group_concat insubquery FROM DUAL.
      mysql-test/r/func_gconcat.result:
        Test case for bug #12861 client hang with group_concat insubquery FROM DUAL.
      mysql-test/t/func_gconcat.test:
        Test case for bug #12861 client hang with group_concat insubquery FROM DUAL.
      fc45b816
  14. 30 Aug, 2005 1 commit
    • unknown's avatar
      Bug #12829 · 52758f7c
      unknown authored
      Cannot convert the charset of a GROUP_CONCAT result:
      
      item_sum.cc:
        "result" character set was not set into proper value.
      
      func_gconcat.result, func_gconcat.test:
        Fixing tests accordingly.
      
      
      sql/item_sum.cc:
        Bug #12829
        Cannot convert the charset of a GROUP_CONCAT result:
        "result" character set was not set into proper value.
      mysql-test/t/func_gconcat.test:
        Bug #12829
      mysql-test/r/func_gconcat.result:
        Bug #12829
      52758f7c
  15. 29 Jul, 2005 1 commit
    • unknown's avatar
      func_gconcat.result, func_gconcat.test: · 21d2fb62
      unknown authored
        Added a test case for bug #12095.
      sql_class.h:
        Fixed bug #12095: a join query with GROUP_CONCAT over a single row table.
        Added a flag to the TMP_TABLE_PARAM class forcing to put constant
        items generated after elimination of a single row table into temp table
        in some cases (e.g. when GROUP_CONCAT is calculated over a single row
        table).
        bk ci sql/item_sum.cc
        Fixed bug #12095: a join query with GROUP_CONCAT over a single row table.
        If GROUP_CONCAT is calculated we always put its argument into a temp
        table, even when the argument is a constant item.
      sql_select.cc:
        Fixed bug #12095: a join query with GROUP_CONCAT over one row table.
        If temp table is used to calculate GROUP_CONCAT the argument should
        be always put into this table, even when it is a constant item.
      
      
      sql/sql_select.cc:
        Fixed bug #12095: a join query with GROUP_CONCAT over one row table.
        If temp table is used to calculate GROUP_CONCAT the argument should
        be always put into this table, even when it is a constant item.
      sql/sql_class.h:
        Fixed bug #12095: a join query with GROUP_CONCAT over a single row table.
        Added a flag to the TMP_TABLE_PARAM class forcing to put constant
        items generated after elimination of a single row table into temp table
        in some cases (e.g. when GROUP_CONCAT is calculated over a single row
        table).
        bk ci sql/item_sum.cc
        Fixed bug #12095: a join query with GROUP_CONCAT over a single row table.
        If GROUP_CONCAT is calculated we always put its argument into a temp
        table, even when the argument is a constant item.
      mysql-test/t/func_gconcat.test:
        Added a test case for bug #12095.
      mysql-test/r/func_gconcat.result:
        Added a test case for bug #12095.
      21d2fb62
  16. 26 Jul, 2005 2 commits
    • unknown's avatar
      Bug#10201 group_concat returns string with binary collation · 4d7aaed1
      unknown authored
      item.cc:
        After merge fixes.
      func_gconcat.result:
        After merge fixes
      
      
      mysql-test/r/func_gconcat.result:
        After merge fixes
      sql/item.cc:
        After merge fixes.
      4d7aaed1
    • unknown's avatar
      func_gconcat.result, func_gconcat.test: · 8624bcfd
      unknown authored
        Adding test
      item_sum.cc:
        Adding a call for collation/charset aggregation,
            to collect attributes from the arguments. The actual bug fix.
      item_func.h, item_func.cc, item.h, item.cc:
        - Removing collation aggrgation functions from Item_func class
            in item.cc, and adding it as non-class functions in item.cc
            to be able to reuse this code for group_concat.
            - Adding replacement for these functions into Item_func class
            as wrappers for moved functions, to minizize patch size,
      
      
      sql/item.cc:
        - Removing collation aggrgation functions from Item_func class
            in item.cc, and adding it as non-class functions in item.cc
            to be able to reuse this code for group_concat.
            - Adding replacement for these functions into Item_func class
            as wrappers for moved functions, to minizize patch size,
      sql/item.h:
        - Removing collation aggrgation functions from Item_func class
            in item.cc, and adding it as non-class functions in item.cc
            to be able to reuse this code for group_concat.
            - Adding replacement for these functions into Item_func class
            as wrappers for moved functions, to minizize patch size,
      sql/item_func.cc:
        - Removing collation aggrgation functions from Item_func class
            in item.cc, and adding it as non-class functions in item.cc
            to be able to reuse this code for group_concat.
            - Adding replacement for these functions into Item_func class
            as wrappers for moved functions, to minizize patch size,
      sql/item_func.h:
        - Removing collation aggrgation functions from Item_func class
            in item.cc, and adding it as non-class functions in item.cc
            to be able to reuse this code for group_concat.
            - Adding replacement for these functions into Item_func class
            as wrappers for moved functions, to minizize patch size,
      sql/item_sum.cc:
        Adding a call for collation/charset aggregation,
            to collect attributes from the arguments. The actual bug fix.
      mysql-test/t/func_gconcat.test:
        Adding test
      mysql-test/r/func_gconcat.result:
        Adding test
      8624bcfd
  17. 03 Jun, 2005 1 commit
    • unknown's avatar
      Move USE_PRAGMA_IMPLEMENTATION to proper place · 72dd44b9
      unknown authored
      Ensure that 'null_value' is not accessed before val() is called in FIELD() functions
      Fixed initialization of key maps. This fixes some problems with keys when you have more than 64 keys
      Fixed that ROLLUP don't always create a temporary table. This fix ensures that func_gconcat.test results are now predictable
      
      
      mysql-test/r/func_gconcat.result:
        Move innodb specific test to innodb.test
        Changed table name r2 -> t2
        More test to see how ROLLUP was optimized
      mysql-test/r/innodb.result:
        Moved test here form func_gconcat
      mysql-test/r/olap.result:
        New test results after optimization
      mysql-test/t/func_gconcat.test:
        Move innodb specific test to innodb.test
        Changed table name r2 -> t2
        More test to see how ROLLUP was optimized
      mysql-test/t/innodb.test:
        Moved test here form func_gconcat
      sql/field.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_berkeley.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_blackhole.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_heap.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_innodb.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_isam.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_isammrg.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_myisam.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_myisammrg.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/ha_ndbcluster.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/handler.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/hash_filo.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_cmpfunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_func.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
        Ensure that 'null_value' is not accessed before val() is called
      sql/item_geofunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_strfunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_subselect.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_sum.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_timefunc.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/item_uniq.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/log_event.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/mysql_priv.h:
        Change key_map_full to not be const as we are giving it a proper value on startup
      sql/mysqld.cc:
        Move key_map variables here and initialize key_map_full properly
      sql/opt_range.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/opt_range.h:
        Fix that test_quick_select() works with any ammount of keys
      sql/procedure.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/protocol.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/protocol_cursor.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/set_var.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_analyse.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_class.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_crypt.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_insert.cc:
        Fixed that max_rows is ulong
      sql/sql_list.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_map.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_olap.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_select.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
        Fixed that ROLLUP don't have to always create a temporary table
        Added new argument to remove_const() to make above possible
        Fixed some errors that creapt up when we don't always do a temporary table for ROLLUP
      sql/sql_string.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_table.cc:
        Simple optimizations
        Fixed wrong checking of build_table_path() in undef-ed code
      sql/sql_udf.cc:
        Move USE_PRAGMA_IMPLEMENTATION to proper place
      sql/sql_yacc.yy:
        removed extra {}
      72dd44b9
  18. 31 May, 2005 1 commit
  19. 17 Mar, 2005 2 commits
    • unknown's avatar
      Cleanup of Item_func_group_concat · 6fc7c074
      unknown authored
      mysql-test/r/func_gconcat.result:
        Test result fixed.
      sql/item_sum.cc:
        Cleanup of Item_func_group_concat:
        - last unobvious things commented
        - don't store NULLs in the tree.
        - remove unneeded variables.
        - use setup_order, not setup_group to setup group concat order list
      sql/item_sum.h:
        Cleanup for Item_func_group_concat: remove unneded variables, methods,
        move a bunch of variables to private: section.
      6fc7c074
    • unknown's avatar
      after merge fix · 0c0a2d55
      unknown authored
      0c0a2d55
  20. 16 Mar, 2005 1 commit
  21. 15 Jan, 2005 2 commits
    • unknown's avatar
      After merge fixes · 6ead8600
      unknown authored
      Fix for BIT(X) field as string
      
      
      mysql-test/r/func_gconcat.result:
        Fix wrong merge
      mysql-test/r/func_sapdb.result:
        Use results so that dimitry can fix them properly
      mysql-test/r/innodb.result:
        Update test after fast TRUNCATE in InnoDB
      mysql-test/r/ps_1general.result:
        After megre fixes
      mysql-test/r/type_bit.result:
        New test to verify patch for Bit fields
      mysql-test/t/ps_1general.test:
        After merge fixes
      mysql-test/t/type_bit.test:
        New test to verify patch for Bit fields
      sql/field.cc:
        Fix for new my_strntod()
        Fix for BIT(X) field as string
      sql/item.h:
        Fix for new my_strntod()
      sql/item_func.h:
        Fix for new my_strntod()
      sql/item_sum.h:
        Fix for new my_strntod()
      sql/procedure.h:
        Fix for new my_strntod()
      sql/sql_base.cc:
        Port fix for INSERT DELAYED with prepared statements to 5.0
      6ead8600
    • unknown's avatar
      func_gconcat.result, func_gconcat.test: · 16f3170e
      unknown authored
        Added a test case for bug #7769.
      item_sum.h:
        Fixed bug #7769: a crash for queries with group_concat and
        having when the query table was empty.
        The bug was due an unsafe dereferencing.
      
      
      sql/item_sum.h:
        Fixed bug #7769: a crash for queries with group_concat and
        having when the query table was empty.
        The bug was due an unsafe dereferencing.
      mysql-test/t/func_gconcat.test:
        Added a test case for bug #7769.
      mysql-test/r/func_gconcat.result:
        Added a test case for bug #7769.
      16f3170e
  22. 10 Nov, 2004 1 commit
    • unknown's avatar
      A fix (bug #6475: Another server crash in 5.0.2 · 0c9bae6e
      unknown authored
             bug #6515: count(distinct...) crashes the server)
      
      
      mysql-test/r/count_distinct.result:
        A test case (bug #6515: count(distinct...) crashes the server)
      mysql-test/r/func_gconcat.result:
        A test case (bug #6475: Another server crash in 5.0.2)
      mysql-test/t/count_distinct.test:
        A test case (bug #6515: count(distinct...) crashes the server)
      mysql-test/t/func_gconcat.test:
        A test case (bug #6475: Another server crash in 5.0.2)
      sql/sql_select.cc:
        A fix (bug #6475: Another server crash in 5.0.2
               bug #6515: count(distinct...) crashes the server)
        In order to prevent repeated setup() call in the JOIN::make_sum_func_list(),
        the code was splitted: new setup_sum_funcs() was introduced.
        Note: we don't call setup_sum_funcs() in the opt_range.cc:get_best_group_min_max().
      0c9bae6e
  23. 10 Oct, 2004 1 commit
    • unknown's avatar
      Blob support for the group_concat() function. · b123f514
      unknown authored
      (Bug #4315: GROUP_CONCAT with ORDER BY returns strange results for TEXT fields
       Bug #5564: Strange behaviour with group_concat and distinct
       Bug #5970: group_concat doesn't print warnings)
      
      
      b123f514
  24. 01 Sep, 2004 1 commit
  25. 23 Aug, 2004 1 commit
    • unknown's avatar
      after review fixes: · 13f7338a
      unknown authored
       allowed parsing of table fields inside aggregate functions
       added new tests of fields resolving in grouping
      
      
      mysql-test/r/func_gconcat.result:
        allowed parsing of table fields inside aggregate functions
      mysql-test/r/subselect.result:
        added new tests of fields resolving in grouping
      mysql-test/t/func_gconcat.test:
        allowed parsing of table fields inside aggregate functions
      mysql-test/t/subselect.test:
        added new tests of fields resolving in grouping
      sql/item_subselect.cc:
        allowed parsing of table fields inside aggregate functions
      13f7338a
  26. 13 Aug, 2004 1 commit
    • unknown's avatar
      skip resolving field in table list if table list is not accessable due to groupping (BUG#4814) · d0c87702
      unknown authored
      mysql-test/r/func_gconcat.result:
        fix of test queries
      mysql-test/r/subselect.result:
        resolving fields of grouped outer SELECT
      mysql-test/t/func_gconcat.test:
        fix of test queries
      mysql-test/t/subselect.test:
        resolving fields of grouped outer SELECT
      sql/item.cc:
        skip resolving field in table list if table list is not accessable due to groupping
        layout fixed
      sql/item_subselect.cc:
        detection of place of subquery
      sql/item_subselect.h:
        detection of place of subquery
      sql/mysql_priv.h:
        enum_parsing_place made global type
      sql/sql_lex.cc:
        enum_parsing_place made global type
      sql/sql_lex.h:
        enum_parsing_place made global type
      sql/sql_yacc.yy:
        enum_parsing_place made global type
      d0c87702
  27. 10 Aug, 2004 1 commit
    • unknown's avatar
      BUG#4315 · 700c2d62
      unknown authored
      BUG#4535
      BUG#4686
      
      
      mysql-test/r/func_gconcat.result:
        add testes of blobs and null values
      mysql-test/t/func_gconcat.test:
        add testes of blobs and null values
      sql/item_sum.cc:
        replace code with maybe_null and change store mode of fields
      700c2d62
  28. 20 Jul, 2004 1 commit
    • unknown's avatar
      mark subquery in the FROM clause like derived and quoate all identifiers (BUG#4609) · ec33aa2b
      unknown authored
      mysql-test/r/bench_count_distinct.result:
        Quoting of fields and tables names
      mysql-test/r/case.result:
        Quoting of fields and tables names
      mysql-test/r/fulltext.result:
        Quoting of fields and tables names
      mysql-test/r/func_default.result:
        Quoting of fields and tables names
      mysql-test/r/func_gconcat.result:
        Quoting of fields and tables names
      mysql-test/r/func_group.result:
        Quoting of fields and tables names
      mysql-test/r/func_if.result:
        Quoting of fields and tables names
      mysql-test/r/func_in.result:
        Quoting of fields and tables names
      mysql-test/r/func_regexp.result:
        Quoting of fields and tables names
      mysql-test/r/func_test.result:
        Quoting of fields and tables names
      mysql-test/r/gis.result:
        Quoting of fields and tables names
      mysql-test/r/group_by.result:
        Quoting of fields and tables names
      mysql-test/r/having.result:
        Quoting of fields and tables names
      mysql-test/r/insert_update.result:
        Quoting of fields and tables names
      mysql-test/r/join_nested.result:
        Quoting of fields and tables names
      mysql-test/r/olap.result:
        Quoting of fields and tables names
      mysql-test/r/query_cache.result:
        Quoting of fields and tables names
      mysql-test/r/select.result:
        Quoting of fields and tables names
      mysql-test/r/subselect.result:
        Quoting of fields and tables names
      mysql-test/r/union.result:
        Quoting of fields and tables names
      mysql-test/r/varbinary.result:
        Quoting of fields and tables names
      mysql-test/r/view.result:
        Quoting of fields and tables names
        test of view with quated fields
      mysql-test/t/view.test:
        test of view with quated fields
      sql/item.cc:
        Quoting of fields and tables names
      sql/item.h:
        Quoting of fields and tables names
      sql/sql_select.cc:
        Quoting of fields and tables names
      sql/sql_view.cc:
        mark subquery in the FROM clause like derived
      ec33aa2b
  29. 21 Jun, 2004 1 commit
  30. 08 Jun, 2004 1 commit
    • unknown's avatar
      a fix · 66c40872
      unknown authored
      (Bug #4035 GROUP_CONCAT with HAVING clause truncates field                       
      Bug #4057 LEFT() function in HAVING clause truncates query result).
      
      
      mysql-test/r/func_gconcat.result:
        a test case
        Bug #4035 GROUP_CONCAT with HAVING clause truncates field                       
        Bug #4057 LEFT() function in HAVING clause truncates query result
      mysql-test/t/func_gconcat.test:
        a test case
        Bug #4035 GROUP_CONCAT with HAVING clause truncates field                       
        Bug #4057 LEFT() function in HAVING clause truncates query result
      sql/item_strfunc.cc:
        a fix (Bug #4057 LEFT() function in HAVING clause truncates query result)
      sql/item_strfunc.h:
        a fix (Bug #4057 LEFT() function in HAVING clause truncates query result)
      sql/item_sum.cc:
        a fix (Bug #4035 GROUP_CONCAT with HAVING clause truncates field)
      sql/item_sum.h:
        a fix (Bug #4035 GROUP_CONCAT with HAVING clause truncates field)
      66c40872
  31. 01 Jun, 2004 1 commit
    • unknown's avatar
      Removed compiler warnings · ce0d0153
      unknown authored
      libmysqld/Makefile.am:
        Removed define that is now defined by configure and my_global.h
      mysql-test/r/func_gconcat.result:
        Fixed test result after removing end space
      sql/share/romanian/errmsg.txt:
        Fixed wrong error message
      sql/sql_insert.cc:
        Removed compiler warning
      ce0d0153
  32. 15 May, 2004 1 commit
    • unknown's avatar
      results fix · a936a280
      unknown authored
      mysql-test/r/func_encrypt.result:
        right SELECT print
      mysql-test/r/func_gconcat.result:
        make results stable
      mysql-test/t/func_gconcat.test:
        make results stable
      a936a280
  33. 14 May, 2004 1 commit
  34. 13 May, 2004 1 commit