1. 23 Jun, 2007 1 commit
    • unknown's avatar
      Fix for BUG#29318 "Statements prepared with PREPARE and with one · ba7e22db
      unknown authored
      parameter don't use query cache"
      Thanks to the fix of BUG#26842, statements prepared with SQL PREPARE
      and having parameters can now use the query cache.
      
      
      mysql-test/include/query_cache_sql_prepare.inc:
        now, statements prepared with SQL PREPARE use the query cache even
        when they have parameters.
      mysql-test/r/query_cache_ps_no_prot.result:
        updated result: we see caching happened.
      mysql-test/r/query_cache_ps_ps_prot.result:
        updated result: we see caching happened
      sql/sql_prepare.cc:
        query expansion does not insert user variables' references anymore,
        it now inserts parameters' values (BUG#26842's fix did this);
        so we can use the query cache.
      ba7e22db
  2. 22 Jun, 2007 5 commits
    • unknown's avatar
      Fix broken automatic dependency tracking of Automake in sql/: · a50a88e2
      unknown authored
      The embedded library is still broken, but there the situation
      with dependencies is even more broken.
      
      
      sql/Makefile.am:
        Fix broken automatic dependency tracking of Automake in sql/:
        use a convenience library to specify additional includes that
        are required to compile files ha_ndbcluster_*, and then
        add this convenience library to the main project.
        The embedded library is still broken, but there the situation
        with dependencies is even more broken.
      a50a88e2
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28846/my51-bug28846 · 40315b49
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/t/sp-error.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      40315b49
    • unknown's avatar
      Bug #28846 Use of undocumented Prepared Statements crashes server · 1eee6b13
      unknown authored
      - Manual merge patch.
      
      
      sql/sql_yacc.yy:
        Corrected merge error. ALTER VIEW rules has been split in two and both
        rules need to be checked for SP-context.
      1eee6b13
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug28846/my50-bug28846 · a348b369
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug28846/my51-bug28846
      
      
      mysql-test/r/ps_1general.result:
        Auto merged
      mysql-test/r/sp-dynamic.result:
        Auto merged
      mysql-test/r/sp-error.result:
        Auto merged
      mysql-test/t/ps_1general.test:
        Auto merged
      mysql-test/t/sp-error.test:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge 5.0->5.1
      a348b369
    • unknown's avatar
      Bug#28846 Use of undocumented Prepared Statements crashes server · 099be801
      unknown authored
      ALTER VIEW is currently not supported as a prepared statement
      and should be disabled as such as they otherwise could cause server crashes.
      
      ALTER VIEW is currently not supported when called from stored
      procedures or functions for related reasons and should also be disabled.
      
      This patch disables these DDL statements and adjusts the appropriate test
      cases accordingly.
      
      Additional tests has been added to reflect on the fact that we do support
      CREATE/ALTER/DROP TABLE for Prepared Statements (PS), Stored Procedures (SP)
      and PS within SP.
      
      
      mysql-test/r/ps_1general.result:
        - Updated test to reflect on the new policy to disallow ALTER VIEW within SP.
      mysql-test/r/sp-dynamic.result:
        - Added PS ALTER TABLE test from within SP-context to demonstrate that CREATE/ALTER/DROP
        TABLE statements is working.
        - Added PS CREATE/ALTER/DROP VIEW tests from within SP-context to show that
        ALTER VIEW is not supported, CREATE VIEW/DROP VIEW are supported.
      mysql-test/r/sp-error.result:
        - Updated test to reflect on the new policy to disallow VIEW DDL within SP.
      mysql-test/t/ps_1general.test:
        - Updated test to reflect on the new policy to disallow VIEW DDL within SP.
      mysql-test/t/sp-dynamic.test:
        - Add PS ALTER TABLE test from within SP to demonstrate that CREATE/ALTER/DROP
        TABLE statements are supported.
      mysql-test/t/sp-error.test:
        - Updated test to reflect on the new policy to disallow ALTER VIEW
        within SP-context.
        - Changed error code 1314 to the more abstract ER_SP_BADSTATEMENT.
      sql/sql_class.h:
        - Added comment for clarity
      sql/sql_parse.cc:
        - Added comment for clarity
      sql/sql_prepare.cc:
        - Disallow ALTER VIEW as prepared statements until they are
          properly supported. Note that SQLCOM_CREATE_VIEW also handles ALTER VIEW
          statements.
      sql/sql_view.cc:
        - converted to doxygen comments
        - Added comment for clarity
      sql/sql_yacc.yy:
        - Disallow ALTER VIEW statements within a SP.
        If the parser is operating within the SP context, this is shown
        on the sp->sphead pointer. If this flag is set for view DDL operations
        we stop parsing with the error 'ER_SP_BAD_STATEMENT'.
      099be801
  3. 20 Jun, 2007 4 commits
    • unknown's avatar
      Enable the disabled test case for Bug#28075 (pushbuild by now · 72253445
      unknown authored
      should be fixed).
      
      
      72253445
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · 5a945c3d
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/t/ndb_index_ordered.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/item_timefunc.cc:
        Auto merged
      mysql-test/t/greedy_optimizer.test:
        Manual merge.
      mysql-test/t/join.test:
        Manual merge.
      tests/mysql_client_test.c:
        Manual merge.
      5a945c3d
    • unknown's avatar
      Disable randomly failing tests: · 3f03ff95
      unknown authored
      rpl_udf -- Bug#28993 rpl_udf test causes server crash and valgrind
      warning in pushbuild
      rpl_ndb_circular -- Bug#29233 rpl_ndb_circular fails randomly
      ndb_dd_sql_features -- Bug#29102 ndb_dd_sql_features fails in
      pushbuild
      
      
      mysql-test/t/disabled.def:
        Disable randomly failing tests rpl_udf, rpl_ndb_circular, 
        ndb_dd_sql_features
      3f03ff95
    • unknown's avatar
      Fix a typo. · 3fc5d1bb
      unknown authored
      3fc5d1bb
  4. 19 Jun, 2007 9 commits
  5. 18 Jun, 2007 7 commits
  6. 17 Jun, 2007 14 commits