1. 28 Aug, 2017 1 commit
  2. 24 Aug, 2017 1 commit
  3. 23 Aug, 2017 2 commits
    • Sachin Setiya's avatar
      Fix Merge Error · 5077cc0b
      Sachin Setiya authored
      5077cc0b
    • Marko Mäkelä's avatar
      MDEV-13167 InnoDB key rotation is not skipping unused pages · 97f9d3c0
      Marko Mäkelä authored
      In key rotation, we must initialize unallocated but previously
      initialized pages, so that if encryption is enabled on a table,
      all clear-text data for the page will eventually be overwritten.
      But we should not rotate keys on pages that were never allocated
      after the data file was created.
      
      According to the latching order rules, after acquiring the
      tablespace latch, no page latches of previously allocated user pages
      may be acquired. So, key rotation should check the page allocation
      status after acquiring the page latch, not before. But, the latching
      order rules also prohibit accessing pages that were not allocated first,
      and then acquiring the tablespace latch. Such behaviour would indeed
      result in a deadlock when running the following tests:
      encryption.innodb_encryption-page-compression
      encryption.innodb-checksum-algorithm
      
      Because the key rotation is accessing potentially unallocated pages, it
      cannot reliably check if these pages were allocated. It can only check
      the page header. If the page number is zero, we can assume that the
      page is unallocated.
      
      fil_crypt_rotate_page(): Detect uninitialized pages by FIL_PAGE_OFFSET.
      Page 0 is never encrypted, and on other pages that are initialized,
      FIL_PAGE_OFFSET must contain the page number.
      
      fil_crypt_is_page_uninitialized(): Remove. It suffices to check the
      page number field in fil_crypt_rotate_page().
      97f9d3c0
  4. 22 Aug, 2017 1 commit
  5. 21 Aug, 2017 4 commits
  6. 20 Aug, 2017 1 commit
  7. 19 Aug, 2017 1 commit
  8. 18 Aug, 2017 1 commit
  9. 17 Aug, 2017 2 commits
  10. 16 Aug, 2017 3 commits
  11. 15 Aug, 2017 4 commits
    • Jan Lindström's avatar
      Fix test failure on test MW-86 and remove MW-360 test. · 5017c261
      Jan Lindström authored
      Merged from mysql-wsrep-bugs following:
      
      GCF-1058 MTR test galera.MW-86 fails on repeated runs
      Wait for the sync point sync.wsrep_apply_cb to be reached before
      executing the test and clearing the debug flag sync.wsrep_apply_cb.
      
      The race scenario:
      
      Intended behavior:
      node2: set sync.wsrep_apply_cb in order to start waiting in the background INSERT
      node1: INSERT start
      node2 (background): INSERT start
      node1: INSERT end
      node2: send signal to background INSERT: "stop waiting and continue executing"
      node2: clear sync.wsrep_apply_cb as no longer needed
      node2 (background): consume the signal
      node2 (background): INSERT end
      node2: DROP TABLE
      node2: check no pending signals are left - ok
      
      What happens occasionally (unexpected):
      node2: set sync.wsrep_apply_cb in order to start waiting in the background INSERT
      node1: INSERT start
      node2 (background): INSERT start
      node1: INSERT end
      // The background INSERT still has _not_ reached the place where it starts
      // waiting for the signal:
      // DBUG_EXECUTE_IF("sync.wsrep_apply_cb", "now wait_for...");
      node2: send signal to background INSERT: "stop waiting and continue executing"
      node2: clear sync.wsrep_apply_cb as no longer needed
      // The background INSERT reaches DBUG_EXECUTE_IF("sync.wsrep_apply_cb", ...)
      // but sync.wsrep_apply_cb has already been cleared and the "wait" code is not
      // executed. The signal remains unconsumed.
      node2 (background): INSERT end
      node2: DROP TABLE
      node2: check no pending signals are left - failure, signal.wsrep_apply_cb is
      pending (not consumed)
      
      Remove MW-360 test case as it is not intended for MariaDB (uses
      MySQL GTID).
      5017c261
    • Sergei Golubchik's avatar
      Merge branch '10.0' into 10.1 · 48fe8326
      Sergei Golubchik authored
      48fe8326
    • Sergey Vojtovich's avatar
      MDEV-8579 - Some sysvars in I_S are missing any meaningful help (comment) text · 3e20a42b
      Sergey Vojtovich authored
      Follow-up to original patch: fixing test cases.
      3e20a42b
    • =Ian Gilfillan's avatar
      f066c89a
  12. 14 Aug, 2017 19 commits