1. 21 Mar, 2006 2 commits
    • unknown's avatar
      Merge mysql.com:/home/bkroot/mysql-5.0 · bda51a42
      unknown authored
      into  mysql.com:/home/bk/b18293-mysql-5.0
      
      
      bda51a42
    • unknown's avatar
      BUG#18293 (Values in stored procedures written to binlog unescaped): · 83ba974a
      unknown authored
      Generating character set-independent quoting of strings for the
      binary log when executing statements from inside stored procedure.
      
      
      mysql-test/r/ctype_cp932_binlog.result:
        Result change
      mysql-test/t/ctype_cp932_binlog.test:
        Adding check that string literals are written correctly for multi-byte
        character sets.
      sql/item.cc:
        Cutting out character set-independent string escaping code and putting it
        in a separate function.
      sql/log_event.cc:
        Adding characters set-independent code to separate function.
      sql/mysql_priv.h:
        Adding new function.
      sql/sp_head.cc:
        Escaping string value representing a string item.
      83ba974a
  2. 20 Mar, 2006 2 commits
    • unknown's avatar
      Fix for bug#18224 VIEW on information_schema crashes the server · 53862e60
      unknown authored
        additional check for subselect
      
      
      mysql-test/r/information_schema.result:
        Fix for bug#18224 VIEW on information_schema crashes the server
          test case
      mysql-test/t/information_schema.test:
        Fix for bug#18224 VIEW on information_schema crashes the server
          test case
      53862e60
    • unknown's avatar
      Fix for bug #18113 "SELECT * FROM information_schema.xxx crashes server" · ce39d294
      unknown authored
      Crash happened when one selected data from one of INFORMATION_SCHEMA
      tables and in order to build its contents server had to open view which
      used stored function and table or view on which one had not global or
      database-level privileges (e.g. had only table-level or had no
      privileges at all).
      
      The crash was caused by usage of check_grant() function, which assumes
      that either number of tables to be inspected by it is limited explicitly
      or table list used and thd->lex->query_tables_own_last value correspond
      to each other (the latter should be either 0 or point to next_global
      member of one of elements of this table list), in conditions when
      above assumptions were not true. This fix just explicitly limits
      number of tables to be inspected. Other negative effects which are
      caused by the fact that thd->lex->query_tables_own_last might not
      be set properly during processing of I_S tables are less disastrous
      and will be reported and fixed separetely.
      
      
      
      mysql-test/r/information_schema_db.result:
        Fix for bug #18113 "SELECT * FROM information_schema.xxx crashes server"
          test case
      mysql-test/t/information_schema_db.test:
        Fix for bug #18113 "SELECT * FROM information_schema.xxx crashes server"
          test case
      sql/sql_acl.cc:
          added note
      ce39d294
  3. 18 Mar, 2006 1 commit
    • unknown's avatar
      Merge · c560a5b1
      unknown authored
      
      sql/ha_innodb.cc:
        Auto merged
      c560a5b1
  4. 17 Mar, 2006 6 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · 1a78addd
      unknown authored
      into  calliope.local:/Volumes/Source/src/mysql-5.0__bug15846
      
      
      1a78addd
    • unknown's avatar
      No longer leak file descriptors in mysql_close. Fixes Bug#15846. · b835245e
      unknown authored
      
      vio/viosocket.c:
        ORs were wrong to begin with, but more importantly, we mustn't use 
        shortable-circuit logic.
        
        Also newly reap the connection-closed event handle.
      b835245e
    • unknown's avatar
      configure.in: · c0c6af35
      unknown authored
        NDB_VERSION_BUILD has to be numeric
      
      
      configure.in:
        NDB_VERSION_BUILD has to be numeric
      c0c6af35
    • unknown's avatar
      configure.in: · 3adad925
      unknown authored
        Changed release name to 5.0.19a
      ha_innodb.cc:
        InnoDB used table locks (not row locks) within stored functions. (Bug #18077)
      
      
      sql/ha_innodb.cc:
        InnoDB used table locks (not row locks) within stored functions. (Bug #18077)
      configure.in:
        Changed release name to 5.0.19a
      3adad925
    • unknown's avatar
      Merge mysql.com:/home/emurphy/src/mysql/bk-clean/mysql-4.1 · 2122a3f9
      unknown authored
      into  mysql.com:/home/emurphy/src/mysql/bk-clean/mysql-5.0
      
      
      sql/ha_innodb.cc:
        Auto merged
      2122a3f9
    • unknown's avatar
      BUG#18283 When InnoDB returns error 'lock table full', MySQL can write · 367442f7
      unknown authored
      to binlog too much.
      
      When InnoDB has to rollback a transaction because the lock table has
      filled up, it also needs to inform the upper layer that the transaction
      was rolled back so that the cached transaction is not written to the
      binary log.
      
      
      sql/ha_innodb.cc:
        When InnoDB rolls back a transaction in HA_ERR_LOCK_TABLE_FULL, it
        needs to inform the upper layer to rollback the transaction also.
      367442f7
  5. 16 Mar, 2006 6 commits
  6. 15 Mar, 2006 1 commit
    • unknown's avatar
      We should prohobit concurent read of inserting file in SP · bb69d16d
      unknown authored
      because it can couse problem with Query cache (BUG#14767)
      
      
      mysql-test/r/query_cache_notembedded.result:
        BUG#14767 test suite.
      mysql-test/t/query_cache_notembedded.test:
        BUG#14767 test suite.
      sql/sql_insert.cc:
        Query cache invalidation table we was inserting in just after
        unlocking table added to avoid the race condition as we had
        with SP.
      sql/sql_parse.cc:
        Query cache invalidation table we was inserting in just after
        unlocking table added to avoid the race condition as we had
        with SP.
      sql/sql_yacc.yy:
        We should prohibit concurent read of unserting file in SP
        because it can cause problem with query cache.
      bb69d16d
  7. 14 Mar, 2006 5 commits
  8. 13 Mar, 2006 11 commits
    • unknown's avatar
      Fixed bug#17366: Unchecked Item_int results in server crash · 8ba5a687
      unknown authored
      When there is conjunction of conds, the substitute_for_best_equal_field()
      will call the eliminate_item_equal() function in loop to build final
      expression. But if eliminate_item_equal() finds that some cond will always
      evaluate to 0, then that cond will be substituted by Item_int with value ==
      0. In this case on the next iteration eliminate_item_equal() will get that 
      Item_int and treat it as Item_cond. This is leads to memory corruption and
      server crash on cleanup phase.
      
      To the eliminate_item_equal() function was added DBUG_ASSERT for checking
      that all items treaten as Item_cond are really Item_cond.
      The substitute_for_best_equal_field() now checks that if
      eliminate_item_equal() returns Item_int and it's value is 0 then this 
      value is returned as the result of whole conjunction.
      
      
      mysql-test/t/subselect.test:
        Added test for bug#17366: Unchecked Item_int results in server crash
      mysql-test/r/subselect.result:
         Added test for bug#17366: Unchecked Item_int results in server crash
      sql/sql_select.cc:
        Fixed bug#17366: Unchecked Item_int results in server crash
         
        To the eliminate_item_equal() function was added DBUG_ASSERT for checking
        that all items treaten as Item_cond are really Item_cond.
        The substitute_for_best_equal_field() now checks that if
        eliminate_item_equal() returns something other than Item_cond and if it is
        then this value is returned as the result of whole conjunction.
      8ba5a687
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/50-work · 358e0883
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      358e0883
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/41-work · b0a73946
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-4.1
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      b0a73946
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/41-work · e5ad6196
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/50-work
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      e5ad6196
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-4.1 · 99824b4e
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-4.1
      
      
      99824b4e
    • unknown's avatar
      bug#14028 - · 9d8992f7
      unknown authored
          ndb crash if trigger record get to big, fix incorrect max size of trigger record
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Increase size of max trigger record
      9d8992f7
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7b3b008b
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      7b3b008b
    • unknown's avatar
      bug#14028 - · 0d89407a
      unknown authored
        ndb crash if trigger record get to big, fix incorrect max size of trigger record
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Increase size of max trigger record
      0d89407a
    • unknown's avatar
      Merge shellback.(none):/home/msvensson/mysql/init_rm/my50-init_rm · 38b40482
      unknown authored
      into  shellback.(none):/home/msvensson/mysql/mysql-5.0
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      38b40482
    • unknown's avatar
      Remove printouts · 9f4f77ab
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Remove extra printouts
      9f4f77ab
    • unknown's avatar
      Make mysql-test-run.pl restore the db(s) to a known state before continuing after test case failure · a7a2db66
      unknown authored
      
      mysql-test/mysql-test-run.pl:
        Take a snapshot of the data dirs just after all db's have been installed and usedthat snasphot to restore the db(s) to a known state after a test case has failed.
        Thus avoiding subsequent test cases to fail because of previous test failures.
      a7a2db66
  9. 11 Mar, 2006 2 commits
  10. 10 Mar, 2006 4 commits