1. 31 May, 2021 1 commit
  2. 28 May, 2021 1 commit
    • Anel Husakovic's avatar
      MDEV-25777: JAVA_INCLUDE_PATH and JAVA_INCLUDE_PATH2 not found with out of... · 904edfd2
      Anel Husakovic authored
      MDEV-25777: JAVA_INCLUDE_PATH and JAVA_INCLUDE_PATH2 not found with out of source configuration and Ninja generator
      
      - As solution `PLUGIN_CONNECT=NO` use early check to disable plugin:
        Solution suggested by wlad@mariadb.com
      - `JNI_FOUND` is a internal result variable and should be set with
      cached library and header variables (like `JAVA_INCLUDE_PATH`) defined.
        * Note: wrapper cmake/FindJNI.cmake runs first time and cmake native Find<module> returns only cached variable, like `JAVA_INCLUDE_PATH`, results variable are not cached).
      
      Reviewed by: serg@mariadb.com
      904edfd2
  3. 27 May, 2021 3 commits
    • Robert Bindar's avatar
    • Marko Mäkelä's avatar
      MDEV-25312 fixup: Fix .isl file parsing · f078788e
      Marko Mäkelä authored
      read_link_file(): Avoid GCC -Wtype-limits when char is unsigned,
      by always using unsigned comparison. Also, avoid buffer overflow
      when the .isl file consists entirely of spaces or control codes.
      f078788e
    • Marko Mäkelä's avatar
      MDEV-25791: Remove UNIV_INTERN · a7d68e7a
      Marko Mäkelä authored
      Back in 2006 or 2007, when MySQL AB and Innobase Oy existed as
      separately controlled entities (Innobase had been acquired by
      Oracle Corporation), MySQL 5.1 introduced a storage engine plugin
      interface and Oracle made use of it by distributing a separate
      InnoDB Plugin, which would contain some more bug fixes and
      improvements, compared to the version of InnoDB that was statically
      linked with the mysqld server that was distributed by MySQL AB.
      The built-in InnoDB would export global symbols, which would clash
      with the symbols of the dynamic InnoDB Plugin (which was supposed
      to override the built-in one when present).
      
      The solution to this problem was to declare all global symbols with
      UNIV_INTERN, so that they would get the GCC function attribute that
      specifies hidden visibility.
      
      Later, in MariaDB Server, something based on Percona XtraDB (a fork of
      MySQL InnoDB) became the statically linked implementation, and something
      closer to MySQL InnoDB was available as a dynamic plugin. Starting with
      version 10.2, MariaDB Server includes only one InnoDB implementation,
      and hence any reason to have the UNIV_INTERN definition was lost.
      
      btr_get_size_and_reserved(): Move to the same compilation unit with
      the only caller.
      
      innodb_set_buf_pool_size(): Remove. Modify innobase_buffer_pool_size
      directly.
      
      fil_crypt_calculate_checksum(): Merge to the only caller.
      
      ha_innobase::innobase_reset_autoinc(): Merge to the only caller.
      
      thd_query_start_micro(): Remove. Call thd_start_utime() directly.
      a7d68e7a
  4. 26 May, 2021 8 commits
    • Monty's avatar
    • Monty's avatar
      552bb1af
    • Monty's avatar
      Replace item->marker= # with Item->marker= DEFINE · e8a54a37
      Monty authored
      - Better, easier to read code (no used of 'random' constants).
      - All defines are now unique, so it is easier to find bugs if
        somethings goes wrong.
      
      Other things:
      - Created sub function of common code in Aggregator_distinct::setup() and
        Item_func_group_concat::setup() that set item->marker
      - More documentation
      - Folded a few long lines.
      - Allmost all changes in item.cc, sql_lex.cc and sql_window.cc are done
        with 'replace'.
      e8a54a37
    • Marko Mäkelä's avatar
      Merge 10.5 into 10.6 · 860e7543
      Marko Mäkelä authored
      860e7543
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · 365cd083
      Marko Mäkelä authored
      365cd083
    • Igor Babaev's avatar
      MDEV-23886 Reusing CTE inside a function fails with table doesn't exist · 675716e1
      Igor Babaev authored
      In the code existed just before this patch binding of a table reference to
      the specification of the corresponding CTE happens in the function
      open_and_process_table(). If the table reference is not the first in the
      query the specification is cloned in the same way as the specification of
      a view is cloned for any reference of the view. This works fine for
      standalone queries, but does not work for stored procedures / functions
      for the following reason.
      When the first call of a stored procedure/ function SP is processed the
      body of SP is parsed. When a query of SP is parsed the info on each
      encountered table reference is put into a TABLE_LIST object linked into
      a global chain associated with the query. When parsing of the query is
      finished the basic info on the table references from this chain except
      table references to derived tables and information schema tables is put
      in one hash table associated with SP. When parsing of the body of SP is
      finished this hash table is used to construct TABLE_LIST objects for all
      table references mentioned in SP and link them into the list of such
      objects passed to a pre-locking process that calls open_and_process_table()
      for each table from the list.
      When a TABLE_LIST for a view is encountered the view is opened and its
      specification is parsed. For any table reference occurred in
      the specification a new TABLE_LIST object is created to be included into
      the list for pre-locking. After all objects in the pre-locking have been
      looked through the tables mentioned in the list are locked. Note that the
      objects referenced CTEs are just skipped here as it is impossible to
      resolve these references without any info on the context where they occur.
      Now the statements from the body of SP are executed one by one that.
      At the very beginning of the execution of a query the tables used in the
      query are opened and open_and_process_table() now is called for each table
      reference mentioned in the list of TABLE_LIST objects associated with the
      query that was built when the query was parsed.
      For each table reference first the reference is checked against CTEs
      definitions in whose scope it occurred. If such definition is found the
      reference is considered resolved and if this is not the first reference
      to the found CTE the the specification of the CTE is re-parsed and the
      result of the parsing is added to the parsing tree of the query as a
      sub-tree. If this sub-tree contains table references to other tables they
      are added to the list of TABLE_LIST objects associated with the query in
      order the referenced tables to be opened. When the procedure that opens
      the tables comes to the TABLE_LIST object created for a non-first
      reference to a CTE it discovers that the referenced table instance is not
      locked and reports an error.
      Thus processing non-first table references to a CTE similar to how
      references to view are processed does not work for queries used in stored
      procedures / functions. And the main problem is that the current
      pre-locking mechanism employed for stored procedures / functions does not
      allow to save the context in which a CTE reference occur. It's not trivial
      to save the info about the context where a CTE reference occurs while the
      resolution of the table reference cannot be done without this context and
      consequentially the specification for the table reference cannot be
      determined.
      
      This patch solves the above problem by moving resolution of all CTE
      references at the parsing stage. More exactly references to CTEs occurred in
      a query are resolved right after parsing of the query has finished. After
      resolution any CTE reference it is marked as a reference to to derived
      table. So it is excluded from the hash table created for pre-locking used
      base tables and view when the first call of a stored procedure / function
      is processed.
      This solution required recursive calls of the parser. The function
      THD::sql_parser() has been added specifically for recursive invocations of
      the parser.
      
      # Conflicts:
      #	sql/sql_cte.cc
      #	sql/sql_cte.h
      #	sql/sql_lex.cc
      #	sql/sql_lex.h
      #	sql/sql_view.cc
      #	sql/sql_yacc.yy
      #	sql/sql_yacc_ora.yy
      675716e1
    • Brad Smith's avatar
      CRC32 on OpenBSD/powerpc64. · 4926498a
      Brad Smith authored
      closes #1828
      4926498a
    • nia's avatar
      threadpool_generic: support future NetBSD kqueue versions · 6d549aec
      nia authored
      In NetBSD 9.x and prior, udata is an intptr_t, but in 10.x (current
      development branch) it was changed to be a void * for compatibility
      with other BSDs a year or so ago.
      
      Unfortunately, this does not simplify the code, as NetBSD 8.x and 9.x
      are still supported and will be for a few more years.
      Signed-off-by: default avatarNia Alarie <nia@NetBSD.org>
      6d549aec
  5. 25 May, 2021 4 commits
    • Elena Stepanova's avatar
      Race condition occurs upon server restart inside test cases · 71e1ddda
      Elena Stepanova authored
      Server restart is reported as failed (with exit code 0),
      and the whole MTR worker aborts
      71e1ddda
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 1dea7f79
      Marko Mäkelä authored
      1dea7f79
    • Igor Babaev's avatar
      MDEV-23886 Reusing CTE inside a function fails with table doesn't exist · 04de6517
      Igor Babaev authored
      In the code existed just before this patch binding of a table reference to
      the specification of the corresponding CTE happens in the function
      open_and_process_table(). If the table reference is not the first in the
      query the specification is cloned in the same way as the specification of
      a view is cloned for any reference of the view. This works fine for
      standalone queries, but does not work for stored procedures / functions
      for the following reason.
      When the first call of a stored procedure/ function SP is processed the
      body of SP is parsed. When a query of SP is parsed the info on each
      encountered table reference is put into a TABLE_LIST object linked into
      a global chain associated with the query. When parsing of the query is
      finished the basic info on the table references from this chain except
      table references to derived tables and information schema tables is put
      in one hash table associated with SP. When parsing of the body of SP is
      finished this hash table is used to construct TABLE_LIST objects for all
      table references mentioned in SP and link them into the list of such
      objects passed to a pre-locking process that calls open_and_process_table()
      for each table from the list.
      When a TABLE_LIST for a view is encountered the view is opened and its
      specification is parsed. For any table reference occurred in
      the specification a new TABLE_LIST object is created to be included into
      the list for pre-locking. After all objects in the pre-locking have been
      looked through the tables mentioned in the list are locked. Note that the
      objects referenced CTEs are just skipped here as it is impossible to
      resolve these references without any info on the context where they occur.
      Now the statements from the body of SP are executed one by one that.
      At the very beginning of the execution of a query the tables used in the
      query are opened and open_and_process_table() now is called for each table
      reference mentioned in the list of TABLE_LIST objects associated with the
      query that was built when the query was parsed.
      For each table reference first the reference is checked against CTEs
      definitions in whose scope it occurred. If such definition is found the
      reference is considered resolved and if this is not the first reference
      to the found CTE the the specification of the CTE is re-parsed and the
      result of the parsing is added to the parsing tree of the query as a
      sub-tree. If this sub-tree contains table references to other tables they
      are added to the list of TABLE_LIST objects associated with the query in
      order the referenced tables to be opened. When the procedure that opens
      the tables comes to the TABLE_LIST object created for a non-first
      reference to a CTE it discovers that the referenced table instance is not
      locked and reports an error.
      Thus processing non-first table references to a CTE similar to how
      references to view are processed does not work for queries used in stored
      procedures / functions. And the main problem is that the current
      pre-locking mechanism employed for stored procedures / functions does not
      allow to save the context in which a CTE reference occur. It's not trivial
      to save the info about the context where a CTE reference occurs while the
      resolution of the table reference cannot be done without this context and
      consequentially the specification for the table reference cannot be
      determined.
      
      This patch solves the above problem by moving resolution of all CTE
      references at the parsing stage. More exactly references to CTEs occurred in
      a query are resolved right after parsing of the query has finished. After
      resolution any CTE reference it is marked as a reference to to derived
      table. So it is excluded from the hash table created for pre-locking used
      base tables and view when the first call of a stored procedure / function
      is processed.
      This solution required recursive calls of the parser. The function
      THD::sql_parser() has been added specifically for recursive invocations of
      the parser.
      04de6517
    • nia's avatar
      my_largepage: Fix build with MAP_ALIGNED by no MAP_ALIGNED_SUPER · 2eb35749
      nia authored
      This needs backporting to MariaDB 10.5.
      
      Any changes I submit are freely available under the new BSD
      license.
      Signed-off-by: default avatarNia Alarie <nia@NetBSD.org>
      2eb35749
  6. 24 May, 2021 7 commits
  7. 23 May, 2021 6 commits
  8. 22 May, 2021 10 commits