1. 09 Mar, 2007 1 commit
    • kroki/tomash@moonlight.home's avatar
      BUG#9953: CONVERT_TZ requires mysql.time_zone_name to be locked · c19affef
      kroki/tomash@moonlight.home authored
      The problem was that some facilities (like CONVERT_TZ() function or
      server HELP statement) may require implicit access to some tables in
      'mysql' database.  This access was done by ordinary means of adding
      such tables to the list of tables the query is going to open.
      However, if we issued LOCK TABLES before that, we would get "table
      was not locked" error trying to open such implicit tables.
      
      The solution is to treat certain tables as MySQL system tables, like
      we already do for mysql.proc.  Such tables may be opened for reading
      at any moment regardless of any locks in effect.  The cost of this is
      that system table may be locked for writing only together with other
      system tables, it is disallowed to lock system tables for writing and
      have any other lock on any other table.
      
      After this patch the following tables are treated as MySQL system
      tables:
        mysql.help_category
        mysql.help_keyword
        mysql.help_relation
        mysql.help_topic
        mysql.proc (it already was)
        mysql.time_zone
        mysql.time_zone_leap_second
        mysql.time_zone_name
        mysql.time_zone_transition
        mysql.time_zone_transition_type
      
      These tables are now opened with open_system_tables_for_read() and
      closed with close_system_tables(), or one table may be opened with
      open_system_table_for_update() and closed with close_thread_tables()
      (the latter is used for mysql.proc table, which is updated as part of
      normal MySQL server operation).  These functions may be used when
      some tables were opened and locked already.
      
      NOTE: online update of time zone tables is not possible during
      replication, because there's no time zone cache flush neither on LOCK
      TABLES, nor on FLUSH TABLES, so the master may serve stale time zone
      data from cache, while on slave updated data will be loaded from the
      time zone tables.
      c19affef
  2. 28 Feb, 2007 1 commit
  3. 24 Feb, 2007 6 commits
  4. 23 Feb, 2007 8 commits
  5. 22 Feb, 2007 4 commits
  6. 21 Feb, 2007 1 commit
  7. 20 Feb, 2007 5 commits
    • anozdrin/alik@alik.opbmk's avatar
      Fix for BUG#24415: Instance manager test im_daemon_life_cycle fails randomly. · 76f813a5
      anozdrin/alik@alik.opbmk authored
      The cause of im_daemon_life_cycle.imtest random failures was the following
      behaviour of some implementations of LINUX threads: let's suppose that a
      process has several threads (in LINUX threads, there is a separate process for
      each thread). When the main process gets killed, the parent receives SIGCHLD
      before all threads (child processes) die. In other words, the parent receives
      SIGCHLD, when its child is not completely dead.
      
      In terms of IM, that means that IM-angel receives SIGCHLD when IM-main is not dead
      and still holds some resources. After receiving SIGCHLD, IM-angel restarts
      IM-main, but IM-main failed to initialize, because previous instance (copy) of
      IM-main still holds server socket (TCP-port).
      
      Another problem here was that IM-angel restarted IM-main only if it was killed
      by signal. If it exited with error, IM-angel thought it's intended / graceful
      shutdown and exited itself.
      
      So, when the second instance of IM-main failed to initialize, IM-angel thought
      it's intended shutdown and quit.
      
      The fix is
        1. to change IM-angel so that it restarts IM-main if it exited with error code;
        2. to change IM-main so that it returns proper exit code in case of failure.
      76f813a5
    • anozdrin/alik@alik.opbmk's avatar
      Polishing: · 61b624eb
      anozdrin/alik@alik.opbmk authored
        1. use MySQL headers instead of system ones;
        2. move logical part of code into a separate function.
      61b624eb
    • anozdrin/alik@alik.opbmk's avatar
      Fix Windows build. · a91354c3
      anozdrin/alik@alik.opbmk authored
      a91354c3
    • anozdrin/alik@booka.'s avatar
      bfb2c3eb
    • thek@kpdesk.mysql.com's avatar
      Merge kpettersson@bk-internal:/home/bk/mysql-5.1-runtime · 9660ea64
      thek@kpdesk.mysql.com authored
      into  kpdesk.mysql.com:/home/thek/dev/mysql-5.1-runtime
      9660ea64
  8. 19 Feb, 2007 8 commits
  9. 18 Feb, 2007 1 commit
  10. 16 Feb, 2007 3 commits
  11. 15 Feb, 2007 2 commits