1. 21 Nov, 2007 1 commit
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31153/my50-bug31153 · c3cd4355
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug31153/my51-bug31153
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Null merge.
      sql/sql_base.cc:
        Manual merge
      sql/sql_lex.h:
        Manual merge
      c3cd4355
  2. 19 Nov, 2007 1 commit
    • unknown's avatar
      Bug #31153 calling stored procedure crashes server if available memory is low · f8151aca
      unknown authored
      When the server was out of memory it crashed because of invalid memory access.
      
      This patch adds detection for failed memory allocations and make the server
      output a proper error message.
      
      
      sql/mysqld.cc:
        Don't try to push_warning from within push_warning. It will cause a recursion
        until the stack is consumed.
        
        If my_net_init fails (for example: because of OOM) the temporary vio object 
        might have been attached to the thd object already. This will cause a double
        free on the vio object when the thd object is deleted later on and the server
        will crash.
      sql/sp_head.cc:
        Added check for out-of-memory on a 'new' operation.
        Refactored reset_lex method to return a error state code instead of void.
        Initialize the mem-root with init_sql_alloc to get a basic error handler for
        memory allocation problems. This alone won't prevent the server from crashing,
        NULL pointers have to be accounted for as well.
      sql/sp_head.h:
        Use the throw() clause in operator new, to indicate to the compiler that
        memory allocation can fail and return NULL, so that the compiler should
        generate code to check for NULL before invoking C++ constructors, to be
        crash safe.
      sql/sql_base.cc:
        Use init_sql_alloc to get basic out-of-memory error handling.
      sql/sql_lex.h:
        Use the throw() clause in operator new, to indicate to the compiler that
        memory allocation can fail and return NULL, so that the compiler should
        generate code to check for NULL before invoking C++ constructors, to be
        crash safe.
      sql/sql_prepare.cc:
        Use init_sql_alloc to get basic out-of-memory error handling.
      sql/sql_yacc.yy:
        Check for memory allocation failures where it matters.
      f8151aca
  3. 07 Oct, 2007 1 commit
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · d5647356
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      mysql-test/include/mix1.inc:
        Auto merged
      mysql-test/r/create.result:
        Auto merged
      mysql-test/r/innodb_mysql.result:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      libmysql/libmysql.c:
        Manual merge.
      d5647356
  4. 05 Oct, 2007 1 commit
    • unknown's avatar
      Fix for BUG#20550: Stored function: wrong RETURN type metadata · af0aaca4
      unknown authored
      when used in a VIEW.
      
      The problem was that wrong function (create_tmp_from_item())
      was used to create a temporary field for Item_func_sp.
      
      The fix is to use create_tmp_from_field().
      
      
      mysql-test/r/sp.result:
        Update result file.
      mysql-test/t/sp.test:
        Add a test case for BUG#20550.
      sql/item_func.h:
        Add a getter for Item_func_sp::sp_result_field.
      sql/sql_select.cc:
        Use create_tmp_from_field() to create a temporary field
        for Item_func_sp.
      af0aaca4
  5. 04 Oct, 2007 5 commits
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 0f769793
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      storage/ndb/test/ndbapi/testScanFilter.cpp:
        Auto merged
      0f769793
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 711be53b
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      711be53b
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/build/5.0 · 3fb8f160
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/build/5.1
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      scripts/mysql_install_db.sh:
        Auto merged
      3fb8f160
    • unknown's avatar
      Merge production.mysql.com:/usersnfs/jperkin/bk/build/5.0 · 270011cb
      unknown authored
      into  production.mysql.com:/usersnfs/jperkin/bk/bug-27692/5.0
      
      270011cb
    • unknown's avatar
      Restore creation of test databases and the anonymous user which · 4d1a88e8
      unknown authored
      were accidentally removed during a previous rototill of this
      code.  Fixes bug#27692.
        
      While it can be argued we should strive to provide a 'secure by
      default' installation, this happens to be the setup currently
      documented in the manual as the default, so defer changes that
      improve security out of the box to a co-ordinated effort later
      on.
        
      For now, make a note about the test databases and anonymous user
      in mysql_install_db and recommend that mysql_secure_installation
      be ran for users wishing to remove these defaults.
      
      [..re-commit of previously lost change..]
      
      
      scripts/mysql_system_tables_data.sql:
        Add anonymous accounts.
      scripts/mysql_install_db.sh:
        Point users at the mysql_secure_installation script.
      mysql-test/mysql-test-run.pl:
        Add a comment where removing anonymous users.
      4d1a88e8
  6. 02 Oct, 2007 1 commit
    • unknown's avatar
      testScanFilter.cpp: · c47eab5e
      unknown authored
         Updated variable size arrays to use vector like Jonas did for 5.1 so that my build would not break
      
      
      ndb/test/ndbapi/testScanFilter.cpp:
         Updated variable size arrays to use vector like Jonas did for 5.1 so that my build would not break
      c47eab5e
  7. 01 Oct, 2007 6 commits
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-5.1-build · 1b0701e4
      unknown authored
      into  mysql.com:/home/kent/bk/make-install/mysql-5.1-build
      
      1b0701e4
    • unknown's avatar
      make_binary_distribution.sh: · 2f295f62
      unknown authored
        Added special handling of "mysql_install_db" and "mysql.server" scripts,
        find executables relative to the current directory.
      
      
      scripts/make_binary_distribution.sh:
        Added special handling of "mysql_install_db" and "mysql.server" scripts,
        find executables relative to the current directory.
      2f295f62
    • unknown's avatar
      BUG#30472: libmysql doesn't reset charset, insert_id after · 2940daab
      unknown authored
      succ. mysql_change_user() call.
      
      Use 2 bytes for character set number.
      
      2940daab
    • unknown's avatar
      Merge trift2.:/MySQL/M50/push-5.0 · 8f9743d6
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      
      configure.in:
        5.0 version change does not affect 5.1 - "use local".
      8f9743d6
    • unknown's avatar
      Merge trift2.:/MySQL/M50/mysql-5.0 · 1b96170f
      unknown authored
      into  trift2.:/MySQL/M50/push-5.0
      
      1b96170f
    • unknown's avatar
      Fix bug#31150 "Test case does not cleanup": · a7e3f053
      unknown authored
      Add the cleanup by dropping the database 'track' in test "rpl_bug31076".
      
      
      mysql-test/suite/rpl/r/rpl_bug31076.result:
        Fix bug#31150 "Test case does not cleanup":
        Drop the database 'track' which was newly created for this test.
      mysql-test/suite/rpl/t/rpl_bug31076.test:
        Fix bug#31150 "Test case does not cleanup":
        Drop the database 'track' which was newly created for this test.
      a7e3f053
  8. 30 Sep, 2007 1 commit
  9. 29 Sep, 2007 7 commits
  10. 28 Sep, 2007 7 commits
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 351829bd
      unknown authored
      into  station.:/mnt/raid/alik/MySQL/devel/bug-30472/5.1-rt-bug30472
      
      351829bd
    • unknown's avatar
      Post-merge fix for Bug 21136, initial merge missed the modifications for · fb393c39
      unknown authored
      the sql_class.h file.
      
      
      sql/sql_class.h:
        Add pointers for holding lock data for temporary tables.
      fb393c39
    • unknown's avatar
      Bug#21136 CREATE TABLE SELECT within CREATE TABLE SELECT causes server crash · 9d915c6c
      unknown authored
      When CREATE TEMPORARY TABLE .. SELECT is invoked from a stored function
      which in turn is called from CREATE TABLE SELECT causes a memory leak
      because the inner create temporary table overrides the outter extra_lock
      reference when locking the table.
      
      The solution is to simply not overrride the extra_lock by only using the
      extra_lock for a non-temporary table lock.
      
      
      mysql-test/r/create.result:
        Add test case result for Bug#21136
      mysql-test/t/create.test:
        Add test case for Bug#21136
      sql/sql_insert.cc:
        For temporary tables, store the lock data within the select_create class
        since tmp tables contents are not replicated. For "real" tables, store
        the lock data in the thread extra_lock pointer.
      9d915c6c
    • unknown's avatar
      Patch for BUG#30472: libmysql doesn't reset charset, · 7ec9d9b3
      unknown authored
      insert_id after succ. mysql_change_user() call.
      
      See also WL 4066.
        
      This bug reveals two problems:
        - the problem on the client side which was described originally;
        - the problem in protocol / the server side: connection context
          on client and server should be like after mysql_real_connect()
          and be consistent. The server however just resets character
          set variables to the global defaults.
      
      The fix seems to be as follows:
        - extend the protocol so that the client be able to send
          character set information in COM_CHANGE_USER command;
        - change the server so that it understands client character set
          in the command;
        - change the client:
          - reset character set to the default value (which has been
            read from the configuration);
          - send character set in COM_CHANGE_USER command.
      
      
      client/client_priv.h:
        Declare a function, used in libmysql.c and client.c.
      libmysql/libmysql.c:
        1. Reset character set on the client in mysql_change_user().
        2. Send character set to the server in COM_CHANGE_USER command.
      mysql-test/t/mysql_client_test.test:
        mysql_client_test.log is used by the test suite.
        
        Use mysql_client_test.out.log to collect mysql_client_test
        real output.
      sql/sql_parse.cc:
        Switch character set in COM_CHANGE_USER.
      tests/mysql_client_test.c:
        Test case for BUG#30472.
      7ec9d9b3
    • unknown's avatar
      Merge trift2.:/MySQL/M51/clone-5.1 · 17b1b1be
      unknown authored
      into  trift2.:/MySQL/M51/push-5.1
      
      This is mysql-5.1.22-rc.
      
      
      mysql-test/r/innodb_mysql.result:
        Auto merged
      scripts/mysqld_safe.sh:
        Auto merged
      sql/log_event.cc:
        Auto merged
      sql/sql_select.cc:
        Manual merge - the 31001 bug is already fixed.
      mysql-test/include/mix1.inc:
        Manual merge - should not have conflicted at all.
      17b1b1be
    • unknown's avatar
      Preliminary fix for · 4d688088
      unknown authored
         Bug #30759  	mysql_install_db fails to set $extra_bindir properly in all cases.
      
      
      scripts/mysql_install_db.sh:
        Preliminary fix for
           Bug #30759  	mysql_install_db fails to set $extra_bindir properly in all cases.
        
        Provided by Daniel for the 5.1.22-rc build, to be superseded by a better patch when that is available.
      4d688088
    • unknown's avatar
      Prerequisite patch for BUG#30472: libmysql doesn't reset charset, · d502225c
      unknown authored
      insert_id after succ. mysql_change_user() call.
      
      Supply a correct packet length to dispatch command.
      
      
      sql/sp_head.cc:
        Fix packet length.
      sql/sql_parse.cc:
        Fix packet length.
      sql/sql_prepare.cc:
        Fix packet length.
      tests/mysql_client_test.c:
        Test case for COM_CHANGE_USER.
      d502225c
  11. 27 Sep, 2007 9 commits