1. 27 Jul, 2006 4 commits
    • unknown's avatar
      Revert the change after null-merge. · c4cfa9ab
      unknown authored
      
      mysys/my_bitmap.c:
        Revert the change forced during null-merge.
      c4cfa9ab
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-release · 350cc461
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-main
      
      
      sql/sql_select.cc:
        Null-merge
      tests/mysql_client_test.c:
        Null-merge
      350cc461
    • unknown's avatar
      BUG#21206: memory corruption when too many cursors are opened at once · 7dbd43b1
      unknown authored
      Too many cursors (more than 1024) could lead to memory corruption.
      This affects both, stored routines and C API cursors, and the
      threshold is per-server, not per-connection.  Similarly, the
      corruption could happen when the server was under heavy load
      (executing more than 1024 simultaneous complex queries), and this is
      the reason why this bug is fixed in 4.1, which doesn't support
      cursors.
      
      The corruption was caused by a bug in the temporary tables code, when
      an attempt to create a table could lead to a write beyond allocated
      space.  Note, that only internal tables were affected (the tables
      created internally by the server to resolve the query), not tables
      created with CREATE TEMPORARY TABLE.  Another pre-condition for the
      bug is TRUE value of --temp-pool startup option, which, however, is a
      default.
      
      The cause of a bug was that random memory was overwritten in
      bitmap_set_next() due to out-of-bound memory access.
      
      
      mysys/my_bitmap.c:
        Local 'bitmap_size' is measured in bytes, no need to multiply it by 8.
      sql/sql_select.cc:
        Clear the temp_pool_slot bit only if we have set it previously.
      tests/mysql_client_test.c:
        Add test case for bug#21206: memory corruption when too many cursors
        are opened at once.
      7dbd43b1
    • unknown's avatar
      Merge moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-release · a6557b0c
      unknown authored
      into  moonlight.intranet:/home/tomash/src/mysql_ab/mysql-5.0-main
      
      
      VC++Files/sql/mysqld.vcproj:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/sp.result:
        Auto merged
      mysql-test/r/warnings.result:
        Auto merged
      mysql-test/t/warnings-master.opt:
        Auto merged
      mysql-test/t/warnings.test:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      a6557b0c
  2. 25 Jul, 2006 3 commits
    • unknown's avatar
      "mysql-test-run.pl" must write a "Logging:" line for the evaluation of RPM build tests. · b0b0c8cc
      unknown authored
          (Re-apply a patch from the general tree to the clone.)
      
      
      mysql-test/mysql-test-run.pl:
        "mysql-test-run.pl" must write a "Logging:" line for the evaluation of RPM build tests.
        (Re-apply a patch from the general tree to the clone.)
      b0b0c8cc
    • unknown's avatar
      slave.cc: · cd64ea0e
      unknown authored
            BUG#20850: Assert during slave shutdown in many rpl_* tests
            This patch has already been applied to 5.1.
      
      
      sql/slave.cc:
            BUG#20850: Assert during slave shutdown in many rpl_* tests
            This patch has already been applied to 5.1.
      cd64ea0e
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.mrg · 39486004
      unknown authored
      into  mysql.com:/home/hf/work/mysql-5.0.mrg
      
      
      libmysqld/lib_sql.cc:
        Auto merged
      tests/mysql_client_test.c:
        merging
      39486004
  3. 24 Jul, 2006 4 commits
    • unknown's avatar
      Merge trift2.:/M41/clone-4.1 · d6d59830
      unknown authored
      into  trift2.:/M50/merge-4.1-to-5.0
      
      
      VC++Files/libmysqld/libmysqld.dsp:
        Auto merged
      VC++Files/libmysqld/libmysqld.vcproj:
        Auto merged
      VC++Files/libmysqld/libmysqld_ia64.dsp:
        Auto merged
      VC++Files/mysqldemb/mysqldemb.dsp:
        Auto merged
      VC++Files/sql/mysqld.dsp:
        Auto merged
      VC++Files/sql/mysqld.vcproj:
        Auto merged
      VC++Files/sql/mysqld_ia64.dsp:
        Auto merged
      VC++Files/sql/mysqldmax.dsp:
        Auto merged
      sql/field.cc:
        Merge a backport == Null-merge == "ul".
      sql/field.h:
        Merge a backport == Null-merge == "ul".
      sql/sql_locale.cc:
        Changes were already present (and even better) == Null-merge == "ul".
      d6d59830
    • unknown's avatar
      Merge trift2.:/M41/push-1-4.1 · 4e31c3fe
      unknown authored
      into  trift2.:/M50/merge-4.1-to-5.0
      
      
      strings/strtod.c:
        Manual merge: Null merge with header file cleanup ("my_base.h" includes "my_global.h", so we do not need both).
      4e31c3fe
    • unknown's avatar
      Merge trift2.:/M41/tmp_merge · c98ff21c
      unknown authored
      into  trift2.:/M50/merge-4.1-to-5.0
      
      
      mysql-test/r/date_formats.result:
        Auto merged
      mysql-test/t/date_formats.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_locale.cc:
        Auto merged
      sql/item_timefunc.cc:
        Merging by "ul", as asked in the original changeset.
      support-files/mysql.spec.sh:
        Manual merge, keeping alphabetic order.
      c98ff21c
    • unknown's avatar
      Merge trift2.:/M41/tmp_merge · af3f6282
      unknown authored
      into  trift2.:/M50/merge-4.1-to-5.0
      
      
      support-files/mysql.spec.sh:
        Auto merged
      configure.in:
        Manual - "use local".
      af3f6282
  4. 22 Jul, 2006 1 commit
    • unknown's avatar
      mysqlmanager.vcproj: · b15e6273
      unknown authored
        Place mysqlmanager 'pdb' file in 'client_debug' directory
      mysys.vcproj:
        Removed define of __NT__ from 'Debug' target
      mysqld.vcproj:
        Always generate 'pdb' and 'map' files
      
      
      server-tools/instance-manager/mysqlmanager.vcproj:
        Place mysqlmanager 'pdb' file in 'client_debug' directory
      VC++Files/mysys/mysys.vcproj:
        Removed define of __NT__ from 'Debug' target
      VC++Files/sql/mysqld.vcproj:
        Always generate 'pdb' and 'map' files
      b15e6273
  5. 21 Jul, 2006 2 commits
  6. 20 Jul, 2006 3 commits
  7. 19 Jul, 2006 9 commits
    • unknown's avatar
      A fix and a test case for Bug#21002 "Derived table not selecting from a · 0fa250a9
      unknown authored
      "real" table fails in JOINs".
      
      This is a regression caused by the fix for Bug 18444. 
      This fix removed the assignment of empty_c_string to table->db performed 
      in add_table_to_list, as neither me nor anyone else knew what it was 
      there for. Now we know it and it's covered with tests: the only case 
      when a table database name can be empty is when the table is a derived 
      table. The fix puts the assignment back but makes it a bit more explicit.
      
      Additionally, finally drop sp.result.orig which was checked in by mistake. 
      
      
      BitKeeper/deleted/.del-sp.result.orig:
        Delete: mysql-test/r/sp.result.orig
      mysql-test/r/derived.result:
        Updated result file.
      mysql-test/r/sp.result:
        Test results fixed (Bug#21002)
      mysql-test/t/derived.test:
        New error return for the case when MULTI-DELETE tries to delete from
        a derived table: now derived tables belong to their own db (""), and
        MUTLI-DELETE can't find the correspondent table for it in the 
        DELETE list, as it can't resolve tables in different dbs by alias
        (See Bug#21148 for details)
      mysql-test/t/sp.test:
        Add a test case for Bug#21002 "Derived table not selecting from a "real"
         table fails in JOINs"
      sql/sp.cc:
        Make empty_c_string globally accessible.
      sql/sql_class.cc:
        Add empty_c_string definition.
      sql/sql_class.h:
        Add a comment for the constructor of Table_ident which is
        used for derived tables. Make sure this constructor also initializes
        the database name, not only the table name.
      sql/sql_parse.cc:
        Don't call check_db_name for empty database. 
        Currently the only case when a table database name can be empty
        is when the table is a derived table.
        Report the right error if the database name is wrong (ER_WRONG_DB_NAME,
        not ER_WRONG_TABLE_NAME).
      0fa250a9
    • unknown's avatar
      Merge salvation.intern.azundris.com:/home/tnurnberg/mysql-5.0-release · 8a08c802
      unknown authored
      into  salvation.intern.azundris.com:/home/tnurnberg/mysql-5.0
      
      
      sql/sql_insert.cc:
        Auto merged
      8a08c802
    • unknown's avatar
      manual merge, part 2/2 · 846a99dc
      unknown authored
      
      mysql-test/r/mysqldump.result:
        manual mergies, part 2/2
      846a99dc
    • unknown's avatar
      Bug #21135 Crash in test "func_time" · d7c0c667
      unknown authored
       - backport patch from 5.0
       - "table" can be NULL in temporary fields used for type conversion
      
      
      sql/field.cc:
        table can be NULL in temporary fields used for type conversion.
        Store value in field as if db_low_byte_first was set.
      sql/field.h:
        table can be NULL in temporary fields used for type conversion.
        Store value in field as if db_low_byte_first was set.
      d7c0c667
    • unknown's avatar
      Merge salvation.intern.azundris.com:/home/tnurnberg/mysql-5.0-release · 92bbb540
      unknown authored
      into  salvation.intern.azundris.com:/home/tnurnberg/work/mysql-5.0-merge
      
      
      support-files/mysql.spec.sh:
        Auto merged
      client/mysqldump.c:
        manual merge
      mysql-test/r/mysqldump.result:
        manual merge
      mysql-test/t/mysqldump.test:
        manual merge
      92bbb540
    • unknown's avatar
      Bug#20989: View '(null).(null)' references invalid table(s)... on SQL SECURITY INVOKER · c1851446
      unknown authored
      REPLACE ... SELECT would require INSERT privileges on certain tables
      when SELECT really suffices. Require INSERT only on target table.
      
      
      mysql-test/r/insert_select.result:
        Bug#20989: View '(null).(null)' references invalid table(s)... on SQL SECURITY INVOKER
        
        Show that REPLACE ... SELECT requires INSERT privileges only on target table.
        (revised test with more view-fu)
      mysql-test/t/insert_select.test:
        Bug#20989: View '(null).(null)' references invalid table(s)... on SQL SECURITY INVOKER
        
        Show that REPLACE ... SELECT requires INSERT privileges only on target table.
        (revised test with more view-fu)
      sql/sql_insert.cc:
        Bug#20989: View '(null).(null)' references invalid table(s)... on SQL SECURITY INVOKER
        
        require SELECT rather than INSERT privs on tables that constitute the views we'll read
      c1851446
    • unknown's avatar
      "BUG #18764: Delete conditions causing inconsistencies in Federated tables" · 9378fc62
      unknown authored
      Post merge changes.
      
      
      9378fc62
    • unknown's avatar
      mysql.spec.sh: · b53e47a1
      unknown authored
        Added new "mysql_explain_log" man page
        Added missing install of "myisam_ftdump" man page
        Added missing install of "mysqlman" man page
      
      
      support-files/mysql.spec.sh:
        Added new "mysql_explain_log" man page
        Added missing install of "myisam_ftdump" man page
        Added missing install of "mysqlman" man page
      b53e47a1
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-5.0-engines · 6ab68cdf
      unknown authored
      into  govinda.patg.net:/home/patg/mysql-build/mysql-5.0-bug18764.2
      
      
      mysql-test/r/federated.result:
        "BUG #18764: Delete conditions causing inconsistencies in Federated tables"
        
        hand merge
      mysql-test/t/federated.test:
        "BUG #18764: Delete conditions causing inconsistencies in Federated tables"
        
        hand merge
      sql/ha_federated.cc:
        "BUG #18764: Delete conditions causing inconsistencies in Federated tables"
        
        hand merge
      6ab68cdf
  8. 18 Jul, 2006 11 commits
  9. 17 Jul, 2006 3 commits
    • unknown's avatar
      "BUG #18764: Delete conditions causing inconsistencies in Federated tables" · 469813c7
      unknown authored
      Removed logic in ha_federated::write_row, which checks field query ids in the
      loop which builds the query to run on the remote server.
      
      
      mysql-test/r/federated.result:
        "BUG #18764: Delete conditions causing inconsistencies in Federated tables"
        
        
        New test results for test that verifies that one can insert to rows using 
        "insert into... select * from..", delete 
        them by id, then immediately insert them in the same way they were originally 
        inserted.
      mysql-test/t/federated.test:
        "BUG #18764: Delete conditions causing inconsistencies in Federated tables"
        
        
        New test that verifies that one can insert to rows using 
        "insert into... select * from..", delete 
        them by id, then immediately insert them in the same way they were originally 
        inserted.
      sql/ha_federated.cc:
        "BUG #18764: Delete conditions causing inconsistencies in Federated tables"
        
        Removed the logic in ha_federated::write_row which checked the query id of 
        each field and compared it to the thread query id.
        
        Each field has a query id, and the problem used to be that if I did an insert
        no fields specified, the field value would contain the last inserted value 
        for that field. The way to work around this was to see if the query id for 
        that field was the same as the current query id or of the rest of the field 
        query ids. If it wasn't, that told me the query didn't have the field value 
        specified.
        
        Somewhere from when I wrote that code to now the problem went away, and there
        was no longer the need for this logic. 
        
        Also removed the bool "has_fields", which needs not exist and using 
        table->s->fields is sufficient.
      469813c7
    • unknown's avatar
      Post-merge fix. · c3f0d2f6
      unknown authored
      c3f0d2f6
    • unknown's avatar
      Bug# 20221- Dumping of multiple databases containing view(s) yields maleformed dumps. · 674636e7
      unknown authored
      
      client/mysqldump.c:
        When dumping more than one database, make sure that the proper database is selected before restoring that database's views.
        Replaced hard-coded database name length with appropiate token.
      mysql-test/r/mysqldump.result:
        Added new result and corrected results for existing test cases.
      mysql-test/t/mysqldump.test:
        Added new case for dumping and restoring multiple databases each containing a view.
      674636e7