- 28 Feb, 2008 1 commit
-
-
gshchepa/uchum@host.loc authored
Assertion `0' failed If ROW item is a part of an expression that also has aggregate function calls (COUNT/SUM/AVG...), a "splitting" with an Item::split_sum_func2 function is applied to that ROW item. Current implementation of Item::split_sum_func2 replaces this Item_row with a newly created Item_aggregate_ref reference to it. Then the row cache tries to work with the Item_aggregate_ref object as with the Item_row object: row cache calls row-emulation methods such as cols and element_index. Item_aggregate_ref (like it's parent Item_ref) inherits dummy implementations of those methods from the hierarchy root Item, and call to them leads to failed assertions and wrong data output. Row-emulation virtual functions (cols, element_index, addr, check_cols, null_inside and bring_value) of Item_ref have been overloaded to forward calls to an underlying item reference.
-
- 14 Feb, 2008 1 commit
-
-
ssh://bk-internal.mysql.com//home/bk/mysql-5.0-optkaa@kaamos.(none) authored
into kaamos.(none):/data/src/opt/mysql-5.0-opt
-
- 13 Feb, 2008 3 commits
-
-
gshchepa/uchum@host.loc authored
into host.loc:/home/uchum/work/5.0-opt
-
gshchepa/uchum@host.loc authored
for wildcard values. The server ignored escape character before wildcards during the calculation of priority values for sorting of a privilege list. (Actually the server counted an escape character as an ordinary wildcard like % or _). I.e. the table name template with a wildcard character like 'tbl_1' had higher priority in a privilege list than concrete table name without wildcards like 'tbl\_1', and some privileges of 'tbl\_1' was hidden by privileges for 'tbl_1'. The get_sort function has been modified to ignore escaped wildcards as usual.
-
gshchepa/uchum@host.loc authored
type conversion. Instead of copying of whole character string from a temporary buffer, the server copied a short-living pointer to that string into a long-living structure. That has been fixed.
-
- 12 Feb, 2008 3 commits
-
-
kaa@kaamos.(none) authored
into kaamos.(none):/data/src/opt/mysql-5.0-opt
-
evgen@moonbone.local authored
into moonbone.local:/work/31590-bug-5.0-opt-mysql
-
kaa@mbp. authored
or trigger crashes server Under some circumstances a combination of VIEWs, subselects with outer references and PS/SP/triggers could lead to use of uninitialized memory and server crash as a result. Fixed by changing the code in Item_field::fix_fields() so that in cases when the field is a VIEW reference, we first check whether the field is also an outer reference, and mark it appropriately before returning.
-
- 11 Feb, 2008 1 commit
-
-
tnurnberg@white.intern.koehntopp.de authored
into mysql.com:/misc/mysql/21567/50-21567
-
- 10 Feb, 2008 4 commits
-
-
holyfoot/hf@hfmain.(none) authored
into mysql.com:/home/hf/work/33796/my50-33796
-
holyfoot/hf@hfmain.(none) authored
into mysql.com:/home/hf/work/33796/my50-33796
-
Field data for a query was stored to the stmt->alloc that is emptied with mysql_stmt_close statement only. That means a lot of memory can be occupied without a reason if used doesn't call mysql_stmt_close often.
-
into mysql.com:/home/tnurnberg/21567/50-21567
-
- 08 Feb, 2008 3 commits
-
-
gshchepa/uchum@host.loc authored
into host.loc:/home/uchum/work/5.0-opt
-
gshchepa/uchum@host.loc authored
SET column storing procedure has been modified to be 64bit-clean.
-
evgen@sunlight.local authored
The out of memory error was thrown when the sort buffer size were too small. This led to a user confusion. Now filesort throws the error message about sort buffer being too small.
-
- 07 Feb, 2008 7 commits
-
-
sergefp@pslp.mylan authored
into mysql.com:/home/psergey/mysql-5.0-bug27732
-
gshchepa/uchum@host.loc authored
into host.loc:/home/uchum/work/5.0-opt
-
gshchepa/uchum@host.loc authored
Minor post-fix for bug#34223.
-
sergefp@mysql.com authored
The bug was that handler::clone/handler::ha_open() call caused allocation of cloned_copy->ref on the handler->table->mem_root. The allocated memory could not be reclaimed until the table is flushed, so it was possible to exhaust memory by repeatedly running index_merge queries without doing table flushes. The fix: - make handler::clone() allocate new_handler->ref on the passed mem_root - make handler::ha_open() not allocate this->ref if it has already been allocated There is no testcase as it is not possible to check small leaks from testsuite.
-
gshchepa/uchum@host.loc authored
into host.loc:/home/uchum/work/5.0-opt
-
gshchepa/uchum@host.loc authored
Minor post-fix for bug#30059.
-
gshchepa/uchum@host.loc authored
and my_innodb_commit_concurrency global variables. Type of the my_innodb_autoextend_increment and the my_innodb_commit_concurrency variables has been changed to GET_ULONG.
-
- 06 Feb, 2008 1 commit
-
-
gshchepa/uchum@host.loc authored
Server handles truncation for assignment of too-long values into CHAR/VARCHAR/TEXT columns in a different ways when the truncated characters are spaces: 1. CHAR(N) columns silently ignore end-space truncation; 2. TEXT columns post a truncation warning/error in the non-strict/strict mode. 3. VARCHAR columns always post a truncation note in any mode. Space truncation processing has been synchronised over CHAR/VARCHAR/TEXT columns: current behavior of VARCHAR columns has been propagated as standard. Binary-encoded string/BLOB columns are not affected.
-
- 05 Feb, 2008 1 commit
-
-
Don't block SIGINT (Control-C) when --gdb is passed to mysqld. Was broken at least on OS X. (kudos to Mattias Jonsson)
-
- 01 Feb, 2008 2 commits
-
-
kaa@mbp.local authored
into mbp.local:/Users/kaa/src/opt/mysql-5.0-opt
-
kaa@mbp.local authored
on table creates The problem was in incompatible syntax for key definition in CREATE TABLE. 5.0 supports only the following syntax for key definition (see "CREATE TABLE syntax" in the manual): {INDEX|KEY} [index_name] [index_type] (index_col_name,...) While 5.1 parser supports the above syntax, the "preferred" syntax was changed to: {INDEX|KEY} [index_name] (index_col_name,...) [index_type] The above syntax is used in 5.1 for the SHOW CREATE TABLE output, which led to dumps generated by 5.1 being incompatible with 5.0. Fixed by changing the parser in 5.0 to support both 5.0 and 5.1 syntax for key definition.
-
- 31 Jan, 2008 1 commit
-
-
evgen@moonbone.local authored
Simple subselects are pulled into upper selects. This operation substitutes the pulled subselect for the first item from the select list of the subselect. If an alias is defined for a subselect it is inherited by the replacement item. As this is done after fix_fields phase this alias isn't showed if the replacement item is a stored function. This happens because the Item_func_sp::make_field function makes send field from its result_field and ignores the defined alias. Now when an alias is defined the Item_func_sp::make_field function sets it for the returned field.
-
- 27 Jan, 2008 1 commit
-
-
igor@olga.mysql.com authored
Two disjuncts containing equalities of the form key=const1 and key=const2 can be merged into one if const1 is equal to const2. To check it the common collation of the constants were used rather than the collation of the field key. For example when the default collation of the constants was cases insensitive while the collation of the field was case sensitive, then two or-ed equality predicates key='b' and key='B' incorrectly were merged into one f='b'. As a result ref access was used instead of range access and wrong result sets were returned in many cases. Fixed the problem by comparing constant in the or-ed predicate with collation of the key field.
-
- 20 Jan, 2008 1 commit
-
-
kaa@kaamos.(none) authored
of cleanups in the test case for bug33794.
-
- 18 Jan, 2008 2 commits
-
-
mhansson@lamia.dupka authored
into lamia.dupka:/home/mhansson/my50-bug33143-again-pushee
-
sergefp@mysql.com authored
The problem occurred when one had a subquery that had an equality X=Y where Y referred to a named select list expression from the parent select. MySQL crashed when trying to use the X=Y equality for ref-based access. Fixed by allowing non-Item_field items in the described case.
-
- 17 Jan, 2008 1 commit
-
-
mhansson/martin@linux-st28.site authored
into linux-st28.site:/home/martin/mysql/src/bug33143/my50-bug33143-again-pushee
-
- 14 Jan, 2008 1 commit
-
-
mhansson/martin@linux-st28.site authored
The ROUND(X, D) function would change the Item::decimals field during execution to achieve the effect of a dynamic number of decimal digits. This caused a series of bugs: Bug #30617:Round() function not working under some circumstances in InnoDB Bug #33402:ROUND with decimal and non-constant cannot round to 0 decimal places Bug #30889:filesort and order by with float/numeric crashes server Fixed by never changing the number of shown digits for DECIMAL when used with a nonconstant number of decimal digits.
-
- 12 Jan, 2008 1 commit
-
-
mhansson@lamia.dupka authored
into lamia.dupka:/home/mhansson/my50-bug31797-pushee
-
- 11 Jan, 2008 3 commits
-
-
mhansson/martin@linux-st28.site authored
into linux-st28.site:/home/martin/mysql/src/bug31797/my50-bug31797-pushee
-
mhansson/martin@linux-st28.site authored
The name resolution for correlated subqueries and HAVING clauses failed to distinguish which of two was being performed when there was a reference to an outer aliased field. Fixed by adding the condition that HAVING clause name resulotion is being performed.
-
evgen@moonbone.local authored
value when inserting into a view. The mysql_prepare_insert function checks all fields of the target table that directly or indirectly (through a view) are specified in the INSERT statement to have a default value. This check can be skipped if the INSERT statement doesn't mention any insert fields. In case of a view this allows fields that aren't mentioned in the view to bypass the check. Now fields of the target table are always checked to have a default value when insert goes into a view.
-
- 10 Jan, 2008 2 commits
-
-
kaa@kaamos.(none) authored
into kaamos.(none):/data/src/opt/mysql-5.0-opt
-
evgen@moonbone.local authored
into moonbone.local:/work/33675-bug-5.0-opt-mysql
-