1. 16 Dec, 2016 3 commits
    • Marko Mäkelä's avatar
      MDEV-6076: Preserve PAGE_ROOT_AUTO_INC when emptying pages. · c64edc6b
      Marko Mäkelä authored
      Thanks to Zhangyuan from Alibaba for pointing out this bug.
      
      btr_page_empty(): When a clustered index root page is emptied,
      preserve PAGE_ROOT_AUTO_INC. This would occur during a page split.
      
      page_create_empty(): Preserve PAGE_ROOT_AUTO_INC when a clustered
      index root page becomes empty. Use a faster method for writing
      the field.
      
      page_zip_copy_recs(): Reset PAGE_MAX_TRX_ID when copying
      clustered index pages. We must clear the field when the root page
      was a leaf page and it is being split, so that PAGE_MAX_TRX_ID
      will continue to be 0 in clustered index non-root pages.
      
      page_create_zip(): Add debug assertions for validating
      PAGE_MAX_TRX_ID and PAGE_ROOT_AUTO_INC.
      c64edc6b
    • Marko Mäkelä's avatar
      MDEV-6076: Optimize the test. · cb0ce5c2
      Marko Mäkelä authored
      Remove unnecessary restarts by testing multiple tables across a restart.
      This change almost halves the execution time.
      Some further restarts could be removed with additional effort.
      cb0ce5c2
    • Marko Mäkelä's avatar
      MDEV-6076 Persistent AUTO_INCREMENT for InnoDB · 8777458a
      Marko Mäkelä authored
      This should be functionally equivalent to WL#6204 in MySQL 8.0.0, with
      the notable difference that the file format changes are limited to
      repurposing a previously unused data field in B-tree pages.
      
      For persistent InnoDB tables, write the last used AUTO_INCREMENT
      value to the root page of the clustered index, in the previously
      unused (0) PAGE_MAX_TRX_ID field, now aliased as PAGE_ROOT_AUTO_INC.
      Unlike some other previously unused InnoDB data fields, this one was
      actually always zero-initialized, at least since MySQL 3.23.49.
      
      The writes to PAGE_ROOT_AUTO_INC are protected by SX or X latch on the
      root page. The SX latch will allow concurrent read access to the root
      page. (The field PAGE_ROOT_AUTO_INC will only be read on the
      first-time call to ha_innobase::open() from the SQL layer. The
      PAGE_ROOT_AUTO_INC can only be updated when executing SQL, so
      read/write races are not possible.)
      
      During INSERT, the PAGE_ROOT_AUTO_INC is updated by the low-level
      function btr_cur_search_to_nth_level(), adding no extra page
      access. [Adaptive hash index lookup will be disabled during INSERT.]
      
      If some rare UPDATE modifies an AUTO_INCREMENT column, the
      PAGE_ROOT_AUTO_INC will be adjusted in a separate mini-transaction in
      ha_innobase::update_row().
      
      When a page is reorganized, we have to preserve the PAGE_ROOT_AUTO_INC
      field.
      
      During ALTER TABLE, the initial AUTO_INCREMENT value will be copied
      from the table. ALGORITHM=COPY and online log apply in LOCK=NONE will
      update PAGE_ROOT_AUTO_INC in real time.
      
      innodb_col_no(): Determine the dict_table_t::cols[] element index
      corresponding to a Field of a non-virtual column.
      (The MySQL 5.7 implementation of virtual columns breaks the 1:1
      relationship between Field::field_index and dict_table_t::cols[].
      Virtual columns are omitted from dict_table_t::cols[]. Therefore,
      we must translate the field_index of AUTO_INCREMENT columns into
      an index of dict_table_t::cols[].)
      
      Upgrade from old data files:
      
      By default, the AUTO_INCREMENT sequence in old data files would appear
      to be reset, because PAGE_MAX_TRX_ID or PAGE_ROOT_AUTO_INC would contain
      the value 0 in each clustered index page. In new data files,
      PAGE_ROOT_AUTO_INC can only be 0 if the table is empty or does not contain
      any AUTO_INCREMENT column.
      
      For backward compatibility, we use the old method of
      SELECT MAX(auto_increment_column) for initializing the sequence.
      
      btr_read_autoinc(): Read the AUTO_INCREMENT sequence from a new-format
      data file.
      
      btr_read_autoinc_with_fallback(): A variant of btr_read_autoinc()
      that will resort to reading MAX(auto_increment_column) for data files
      that did not use AUTO_INCREMENT yet. It was manually tested that during
      the execution of innodb.autoinc_persist the compatibility logic is
      not activated (for new files, PAGE_ROOT_AUTO_INC is never 0 in nonempty
      clustered index root pages).
      
      initialize_auto_increment(): Replaces
      ha_innobase::innobase_initialize_autoinc(). This initializes
      the AUTO_INCREMENT metadata. Only called from ha_innobase::open().
      
      ha_innobase::info_low(): Do not try to lazily initialize
      dict_table_t::autoinc. It must already have been initialized by
      ha_innobase::open() or ha_innobase::create().
      
      Note: The adjustments to class ha_innopart were not tested, because
      the source code (native InnoDB partitioning) is not being compiled.
      8777458a
  2. 15 Dec, 2016 7 commits
  3. 14 Dec, 2016 3 commits
    • Igor Babaev's avatar
      Adjusted test results after merge. · 5cf6fd3e
      Igor Babaev authored
      5cf6fd3e
    • Igor Babaev's avatar
      Fixed bug mdev-11488. · 441fa005
      Igor Babaev authored
      The patch for bug mdev-10882 tried to fix it by providing an
      implementation of the virtual method build_clone for the class
      Item_cache. It's turned out that it is not easy provide a valid
      implementation for Item_cache::build_clone(). At the same time
      if the condition that can be pushed into a materialized view
      contains a cached item this item can be substituted for a basic
      constant of the same value. In such a way we can avoid building
      proper clones for Item_cache objects when constructing pushdown
      conditions.
      441fa005
    • Daniel Black's avatar
      Travis: add lib{stemmer,xml2,pcre3}-dev · e9ada862
      Daniel Black authored
      e9ada862
  4. 13 Dec, 2016 3 commits
  5. 12 Dec, 2016 24 commits