1. 10 Aug, 2005 1 commit
    • unknown's avatar
      BUG#12228: Post review fixes: Added test case, code cleanup. · c6a42c58
      unknown authored
      
      mysql-test/r/sp-threads.result:
        Testcase for BUG#12228
      mysql-test/t/sp-threads.test:
        Testcase for BUG#12228
      sql/sp_cache.cc:
        BUG#12228: Post-review fixes: small code cleanup
      sql/sp_cache.h:
        BUG#12228: Post-review fixes: fixed the comment
      sql/sql_parse.cc:
        BUG#12228: Post-review fixes: in mysql_parse, flush obsolete SPs from the caches only if 
         the query hasn't been handled by the query cache.
      sql/sql_prepare.cc:
        BUG#12228: Post-review fixes: in mysql_stmt_prepare/execute, flush SP caches 
         "closer to the execution"
      c6a42c58
  2. 09 Aug, 2005 1 commit
  3. 08 Aug, 2005 1 commit
    • unknown's avatar
      Fix for BUG#12228: SP cache code: · c0dcf465
      unknown authored
      * Cleanup SP Cache code, now SP Cache only deletes sp_head objects in 
        sp_cache_flush_obsolete() invalidates all pointers to routines in the cache.
      * Use new SP Cache use contract in the code.
      
      There is no test case because it doesn't seem to be possible to cause thread races to end
      the same way they end in heavy-load test. This patch removes the crash in heavy test.
      
      
      mysql-test/r/type_bit.result:
        Drop the tables this test tries to create
      mysql-test/r/view.result:
        Drop function this test creates
      mysql-test/t/type_bit.test:
        Drop the tables this test tries to create
      mysql-test/t/view.test:
        Drop function this test creates
      sql/sp.cc:
        Fix for BUG#12228: When a routine is deleted/modified, invalidate all cached SPs in all
        threads. We need to do so because sp_lex_keeper::{prelocking_tables, query_tables_own_last}
        in one SP may depend on another SP sp_lex_keeper::m_lex is using.
      sql/sp_cache.cc:
        Fix for BUG#12228:
        * Move class sp_cache to here from sp_cache.h, document the functions.
        * sp_cache_insert, sp_cache_remove, sp_cache_invalidate and sp_cache_lookup must not delete
          sp_head* objects as they may be called during SP execution when sp_head objects are used.
        * Added sp_cache_flush_obsolete() function that may delete sp_head objects.
        * Removed sp_cache_remove as there is no need for it now - when we change one SP we should
          invalidate all other SPs, because sp_lex_keeper::{prelocking_tables, 
          query_tables_own_last} from one SP depend on content of another SP (used in 
          sp_lex_keeper::m_lex).
      sql/sp_cache.h:
        Fix for BUG#12228:
        * Move class sp_cache to sp_cache.cc it is not needed in .h file
        * Added comments
      sql/sql_parse.cc:
        Fix for BUG#12228: Call new sp_cache_flush_obsolete() function before running the query
      sql/sql_prepare.cc:
        Fix for BUG#12228: Call new sp_cache_flush_obsolete() function before preparing/executing a PS
      c0dcf465
  4. 05 Aug, 2005 10 commits
    • unknown's avatar
      testcase added to fix for bug #12281 (Geometry & trigger crash) · 3eb39935
      unknown authored
      
      mysql-test/r/gis.result:
        test result fixed
      mysql-test/t/gis.test:
        testcase added
      3eb39935
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 2f014d89
      unknown authored
      into deer.(none):/home/hf/work/mysql-5.0.12281
      
      2f014d89
    • unknown's avatar
      Fix for bug #12281 (Geometry: crash in trigger) · fe9eb03c
      unknown authored
      Field_geom lack size_of method
      
      
      sql/field.h:
        size_of implemented
      fe9eb03c
    • unknown's avatar
      post-review fix · 07ae5d15
      unknown authored
      
      server-tools/instance-manager/listener.cc:
        some more cleanup
      07ae5d15
    • unknown's avatar
      chmod -x new IM files · 7c3a37e9
      unknown authored
      
      server-tools/instance-manager/WindowsService.cpp:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/WindowsService.h:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/port.h:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/mysqlmanager.vcproj:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/IMService.cpp:
        Change mode to -rw-rw-r--
      server-tools/instance-manager/IMService.h:
        Change mode to -rw-rw-r--
      7c3a37e9
    • unknown's avatar
      IM port cleanup · 33f06e22
      unknown authored
      
      server-tools/instance-manager/IMService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.cpp:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/WindowsService.h:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/instance.cc:
        cleanup & coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/listener.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/manager.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/options.cc:
        coding style fixes: tabs, trailing spaces, offset e.t.c
      server-tools/instance-manager/user_map.cc:
        simplify password file processing
      33f06e22
    • unknown's avatar
      Merge pchardin@bk-internal.mysql.com:/home/bk/mysql-5.0 · c3d7a03f
      unknown authored
      into  mysql.com:/home/cps/mysql/trees/mysql-5.0
      
      c3d7a03f
    • unknown's avatar
      IM port fixes: fix crash on startup, add more error checking, get rid of unnecessary code. · 300e4c2a
      unknown authored
      
      server-tools/instance-manager/commands.cc:
        fix memory leak
      server-tools/instance-manager/guardian.cc:
        don't check pthread_mutex_lock/unlock return value, as it never returns error if properly
        used (no self deadlocks) and initialized
      server-tools/instance-manager/guardian.h:
        prototype fixed
      server-tools/instance-manager/instance_map.cc:
        don't check pthread_mutex_lock/unlock status, as it never returns error if
        properly used (no self deadlocks) and initialized
      server-tools/instance-manager/instance_map.h:
        prototype fixed
      server-tools/instance-manager/listener.cc:
        initialize highest-numbered descriptor to 0 for select before setting it with max(n, sockets[i]),
        ifdef unix-specific code
      server-tools/instance-manager/manager.cc:
        remove commented stuff
      server-tools/instance-manager/options.cc:
        fix crash in load_defaults, which happened on all Unix systems due to
        const char *Options::config_file= NULL. Check return value for GetModuleFileName.
        Get rid of obscure default_config_file[FN_REFLEN]= "/etc/my.cnf"; which was never used
      300e4c2a
    • unknown's avatar
      fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames · 5efbe0a9
      unknown authored
      
      mysql-test/r/information_schema.result:
        fix the test case for fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      mysql-test/r/information_schema_db.result:
        fix the test case for fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      sql/sql_show.cc:
        reorder the structure
        fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      sql/table.h:
        reorder the enum
        fix for bug #12315 - SHOW TABLE STATUS FROM `information_schema`; does not sort tablenames
      5efbe0a9
    • unknown's avatar
      Fix gcc -ansi -pedantic compilation failure. · f01ca726
      unknown authored
      
      client/client_priv.h:
        Fix a compile failure.
      f01ca726
  5. 04 Aug, 2005 27 commits