1. 24 Sep, 2009 1 commit
  2. 23 Sep, 2009 9 commits
    • Staale Smedseng's avatar
      Bug #43414 Parenthesis (and other) warnings compiling MySQL · 6a89842e
      Staale Smedseng authored
      with gcc 4.3.2
      
      Cleaning up warnings not present in 5.0.
      6a89842e
    • Alexander Nozdrin's avatar
      A patch for Bug#47474 (mysqld hits Dbug_violation_helper assert · d4991387
      Alexander Nozdrin authored
      when compiled with Sun Studio compiler).
      
      The thing is that Sun Studio compiler calls destructor of stack
      objects when pthread_exit() is called. That triggered an assertion
      in DBUG_ENTER()/DBUG_RETURN() validation logic (if DBUG_ENTER() is
      used in the beginning of function, all returns should be replaced
      by DBUG_RETURN/DBUG_VOID_RETURN macros).
      
      A fix is to explicitly use DBUG_LEAVE macro.
      d4991387
    • Satya B's avatar
      merge to mysql-5.1-bugteam · e6afad88
      Satya B authored
      e6afad88
    • Satya B's avatar
      Additional Fix for BUG#44030 - Error: (1500) Couldn't read the MAX(ID) autoinc · 1eef7665
      Satya B authored
                                     value from the index (PRIMARY)
      
      
      With the fix for BUG#46760, we correctly flag the presence of row_type 
      only when it's actually changed and enables the FAST ALTER TABLE which was
      disabled with the BUG#39200.
      
      So the changes made by BUG#46760 makes MySQL data dictionaries to be out of 
      sync but they are handled already by InnoDB with this BUG#44030.
      
      The test was originally written to handle this but we requested Innodb to
      update the test as the data dictionaries were in sync after the fix for 
      BUG#39200.
      
      Adjusting the innodb-autoinc testcase as mentioned in the comments.
      
      mysql-test/lib/mtr_cases.pm:
        Re-enable the innodb-autoinc test case for plugin as we have a common
        result file.
      mysql-test/r/innodb-autoinc.result:
        Additional Fix for BUG#44030 - Error: (1500) Couldn't read the MAX(ID) autoinc 
                                       value from the index (PRIMARY)
        
        Adjust the innodb-autoinc testcase as the patch for BUG#46760 enables the 
        FAST ALTER TABLE and makes the data dictonaries go out of sync. This is 
        expected in the testcase.
      mysql-test/t/innodb-autoinc.test:
        Additional Fix for BUG#44030 - Error: (1500) Couldn't read the MAX(ID) autoinc 
                                       value from the index (PRIMARY)
        
        Adjust the innodb-autoinc testcase as the patch for BUG#46760 enables the 
        FAST ALTER TABLE and makes the data dictonaries go out of sync. This is 
        expected in the testcase.
      1eef7665
    • Georgi Kodinov's avatar
      automerge · 9a42d81f
      Georgi Kodinov authored
      9a42d81f
    • Sergey Glukhov's avatar
      Bug#45989 memory leak after explain encounters an error in the query · beb519e3
      Sergey Glukhov authored
      the fix is reverted from 5.1, mysql-pe as 
      unnecessary(no valgrind warnings there).
      
      sql/sql_select.cc:
        the fix is reverted from 5.1, mysql-pe as 
        unnecessary(no valgrind warnings there).
      beb519e3
    • Georgi Kodinov's avatar
      automerge · 9910148c
      Georgi Kodinov authored
      9910148c
    • Georgi Kodinov's avatar
      automerge · 4f2949b8
      Georgi Kodinov authored
      4f2949b8
    • Georgi Kodinov's avatar
      automerge · 8705b0e1
      Georgi Kodinov authored
      8705b0e1
  3. 22 Sep, 2009 2 commits
    • Davi Arnaut's avatar
      Bug#45498: Socket variable not available on Windows · 83bc7980
      Davi Arnaut authored
      The "socket" variable is not available on Windows even though
      the --socket option can be used to specify the pipe name for
      local connections that use a named pipe.
      
      The solution is to ensure that the variable is always defined.
      
      
      mysql-test/r/windows.result:
        Add test case result for Bug#45498
      mysql-test/t/windows.test:
        Add test case for Bug#45498
      sql/set_var.cc:
        socket variable must always be present.
      83bc7980
    • Anurag Shekhar's avatar
      merged with local branch. · fe0437d3
      Anurag Shekhar authored
      fe0437d3
  4. 21 Sep, 2009 3 commits
  5. 18 Sep, 2009 9 commits
    • Georgi Kodinov's avatar
      automerge · 6435ecbb
      Georgi Kodinov authored
      6435ecbb
    • Georgi Kodinov's avatar
      automerge · 4ac69482
      Georgi Kodinov authored
      4ac69482
    • Georgi Kodinov's avatar
      automerge · 3df67bc2
      Georgi Kodinov authored
      3df67bc2
    • Georgi Kodinov's avatar
      automerge · 50800923
      Georgi Kodinov authored
      50800923
    • Georgi Kodinov's avatar
      Bug#46760: Fast ALTER TABLE no longer works for InnoDB · 01e5bc70
      Georgi Kodinov authored
            
      Despite copying the value of the old table's row type
      we don't always have to mark row type as being specified.
      Innodb uses this to check if it can do fast ALTER TABLE
      or not.
      Fixed by correctly flagging the presence of row_type 
      only when it's actually changed.
      Added a test case for 39200.
      01e5bc70
    • Anurag Shekhar's avatar
      merging with latest changes in bugteam. · f2f2e981
      Anurag Shekhar authored
      f2f2e981
    • unknown's avatar
      Bug #42914 Log event that larger than max_allowed_packet results in stop of slave I/O thread, · 64badb5f
      unknown authored
                 But there is no Last_IO_Error reported.
      
      On the master, if a binary log event is larger than max_allowed_packet,
      ER_MASTER_FATAL_ERROR_READING_BINLOG and the specific reason of this error is
      sent to a slave when it requests a dump from the master, thus leading
      the I/O thread to stop.
      
      On a slave, the I/O thread stops when receiving a packet larger than max_allowed_packet.
      
      In both cases, however, there was no Last_IO_Error reported.
      
      This patch adds code to report the Last_IO_Error and exact reason before stopping the
      I/O thread and also reports the case the out memory pops up while
      handling packets from the master.
      
      
      sql/sql_repl.cc:
        The master send the Specific reasons instead of "error reading log entry" to the slave which is requesting a dump.
        if an fatal error is returned by read_log_event function.
      64badb5f
    • Alexey Kopytov's avatar
      Automerge. · ce55f84d
      Alexey Kopytov authored
      ce55f84d
    • Alexey Kopytov's avatar
      Bug #43606: 4GB Limit on huge_pages shared memory set-up · 4826b61c
      Alexey Kopytov authored
      Large pages allocator could not allocate more than 4 GB due to
      incorrect size alignment.
      
      mysys/my_largepage.c:
        Large pages allocator could not allocate more than 4 GB due to
        incorrect size alignment.
      4826b61c
  6. 17 Sep, 2009 6 commits
    • Staale Smedseng's avatar
      Merge from 5.0 · d6ca0cbb
      Staale Smedseng authored
      d6ca0cbb
    • Staale Smedseng's avatar
      Bug #43414 Parenthesis (and other) warnings compiling MySQL · e5888b16
      Staale Smedseng authored
      with gcc 4.3.2
            
      This is the fifth patch cleaning up more GCC warnings about
      variables used before initialized using the new macro
      UNINIT_VAR().
      e5888b16
    • Anurag Shekhar's avatar
      Bug #45840 read_buffer_size allocated for each partition when · 5999113f
      Anurag Shekhar authored
       "insert into.. select * from"
      
      When inserting into a partitioned table using 'insert into
      <target> select * from <src>', read_buffer_size bytes of memory
      are allocated for each partition in the target table.
      
      This resulted in large memory consumption when the number of
      partitions are high.
      
      This patch introduces a new method which tries to estimate the
      buffer size required for each partition and limits the maximum
      buffer size used to maximum of 10 * read_buffer_size, 
      11 * read_buffer_size in case of monotonic partition functions.
      
      sql/ha_partition.cc:
        Introduced a method ha_partition::estimate_read_buffer_size
        to estimate buffer size required for each partition. 
        Method ha_partition::start_part_bulk_insert updated
        to update the read_buffer_size before calling bulk upload
        in storage engines.
        Added thd in ha_partition::start_part_bulk_insert method signature.
      sql/ha_partition.h:
        Introduced a method ha_partition::estimate_read_buffer_size.
        Added thd in ha_partition::start_part_bulk_insert method signature.
      5999113f
    • Sergey Glukhov's avatar
      Bug#42364 SHOW ERRORS returns empty resultset after dropping non existent table · 2535ede7
      Sergey Glukhov authored
      additional backport of of bug43138 fix
      
      
      mysql-test/t/myisam-system.test:
        additional backport of of bug43138 fix
      sql/sql_db.cc:
        additional backport of of bug43138 fix
      2535ede7
    • Georgi Kodinov's avatar
      Bug #46917: mysqd-nt installs wrong · 31809edc
      Georgi Kodinov authored
      When parsing the service installation parameter in 
      default_service_handling() make sure the value of the
      optional parameter doesn't overwrite it's name.
      31809edc
    • Satya B's avatar
      Applying InnoDB snapshot 5.1-ss5282, Fixes BUG#44030 · 7cf8f7a4
      Satya B authored
      1. Fixes BUG#44030 - Error: (1500) Couldn't read the MAX(ID) autoinc value 
                           from the index (PRIMARY)
      
      2. Disables the innodb-autoinc test for innodb plugin temporarily.
         The testcase for this bug has different result file for InnoDB plugin.
         Should add the testcase to Innodb suite with a different result file.
      
      Detailed revision comments:
      
      r5243 | sunny | 2009-06-04 03:17:14 +0300 (Thu, 04 Jun 2009) | 14 lines
      branches/5.1: When the InnoDB and MySQL data dictionaries go out of sync, before
      the bug fix we would assert on missing autoinc columns. With this fix we allow
      MySQL to open the table but set the next autoinc value for the column to the
      MAX value. This effectively disables the next value generation. INSERTs will
      fail with a generic AUTOINC failure. However, the user should be able to
      read/dump the table, set the column values explicitly, use ALTER TABLE to
      set the next autoinc value and/or sync the two data dictionaries to resume
      normal operations.
      
      Fix Bug#44030 Error: (1500) Couldn't read the MAX(ID) autoinc value from the
      index (PRIMARY)
      
      rb://118
      
      r5252 | sunny | 2009-06-04 10:16:24 +0300 (Thu, 04 Jun 2009) | 2 lines
      branches/5.1: The version of the result file checked in was broken in r5243.
      
      r5259 | vasil | 2009-06-05 10:29:16 +0300 (Fri, 05 Jun 2009) | 7 lines
      branches/5.1:
      
      Remove the word "Error" from the printout because the mysqltest suite
      interprets it as an error and thus the innodb-autoinc test fails.
      
      Approved by:	Sunny (via IM)
      r5466 | vasil | 2009-07-02 10:46:45 +0300 (Thu, 02 Jul 2009) | 6 lines
      branches/5.1:
      
      Adjust the failing innodb-autoinc test to conform to the latest behavior
      of the MySQL code. The idea and the comment in innodb-autoinc.test come
      from Sunny.
      
      7cf8f7a4
  7. 16 Sep, 2009 2 commits
  8. 15 Sep, 2009 2 commits
  9. 13 Sep, 2009 2 commits
    • Luis Soares's avatar
      BUG#47016: rpl_do_grant fails on PB-2 with a failing connect · 63a81c09
      Luis Soares authored
            
      The test case rpl_do_grant fails sporadically on PB2 with "Access
      denied for user 'create_rout_db'@'localhost' ...". Inspecting the
      test case, one may find that if issues a GRANT on the master
      connection and immediately after it creates two new connections
      (one to the master and one to the slave) using the credentials
      set with the GRANT.
            
      Unfortunately, there is no synchronization between master and
      slave after the grant and before the connections are
      established. This can result in slave not having executed the
      GRANT by the time the connection is attempted.
            
      This patch fixes this by deploying a sync_slave_with_master
      between the grant and the connections attempt.
      63a81c09
    • Luis Soares's avatar
      BUG#47014: rpl_drop_temp fails on PB-2 with results mismatch · 3c916057
      Luis Soares authored
            
      The test case creates two temporary tables, then closes the
      connection, waits for it to disconnect, then syncs the slave with
      the master, checks for remaining opened temporary tables on
      slave (which should be 0) and finally drops the used
      database (mysqltest).
            
      Unfortunately, sometimes, the test fails with one open table on
      the slave. This seems to be caused by the fact that waiting for
      the connection to be closed is not sufficient. The test needs to
      wait for the DROP event to be logged and only then synchronize
      the slave with the master and proceed with the check. This is
      caused by the asynchronous nature of the disconnect wrt
      binlogging of the DROP temporary table statement.
            
      We fix this by deploying a call to wait_for_binlog_event.inc
      on the test case, which makes execution to wait for the DROP
      temp tables event before synchronizing master and slave.
      3c916057
  10. 11 Sep, 2009 2 commits
    • Mattias Jonsson's avatar
      merge · 23dc8abe
      Mattias Jonsson authored
      23dc8abe
    • Ramil Kalimullin's avatar
      Fix for bug#47130: misplaced or redundant check for null pointer? · b6c16b32
      Ramil Kalimullin authored
      Problem: LOGGER::general_log_write() relied on valid "thd" parameter passed
      but had inconsistent "if (thd)" check.
      
      Fix: as we always pass a valid "thd" parameter to the method, 
      redundant check removed.
      
      
      sql/log.cc:
        Fix for bug#47130: misplaced or redundant check for null pointer?
          - code clean-up, as we rely on the "thd" parameter in the
        LOGGER::general_log_write(), redundant "if (thd)" check removed, 
        added assert(thd) instead.
      b6c16b32
  11. 10 Sep, 2009 2 commits