1. 25 Jan, 2012 5 commits
    • Tor Didriksen's avatar
      c7964159
    • Tor Didriksen's avatar
      Bug#13463415 63502: INCORRECT RESULTS OF BIGINT AND DECIMAL COMPARISON · 042bd151
      Tor Didriksen authored
      Bug#11758543 50756: BIGINT '100' MATCHES 1.001E2
      
      Expressions of the form
            BIGINT_COL <compare> <non-integer constant>
      
            should be done either as decimal, or float.
      
            Currently however, such comparisons are done as int,
            which means that the constant may be truncated,
            and yield false positives/negatives for all queries
            where compare is '>' '<' '>=' '<=' '=' '!='.
      
            BIGINT_COL IN <list of contstants>
            and
            BIGINT_COL BETWEEN <constant> AND <constant>
            are also affected.
      
      
      
      mysql-test/r/bigint.result:
        New tests.
      mysql-test/r/func_in.result:
        BIGINT <=> string comparison should be done as float,
        so a warning for the value 'abc' is appropriate.
      mysql-test/t/bigint.test:
        New tests.
      sql/item_cmpfunc.cc:
        In convert_constant_item() we verify that the constant item
        can be stored in the given field.
        For BIGINT columns (MYSQL_TYPE_LONGLONG) we must verify that the
        stored constant value is actually comparable as int,
        i.e. that the value was not truncated.
        
        For between: compare as int only if both arguments convert correctly to int.
      042bd151
    • Dmitry Shulga's avatar
      Fixed bug#11753187 (formerly known as bug 44585): SP_CACHE BEHAVES AS · 97883d3c
      Dmitry Shulga authored
      MEMORY LEAK.
      
      Background:
       - There are caches for stored functions and stored procedures (SP-cache);
       - There is no similar cache for events;
       - Triggers are cached together with TABLE objects;
       - Those SP-caches are per-session (i.e. specific to each session);
       - A stored routine is represented by a sp_head-instance internally;
       - SP-cache basically contains sp_head-objects of stored routines, which
         have been executed in a session;
       - sp_head-object is added into the SP-cache before the corresponding
         stored routine is executed;
       - SP-cache is flushed in the end of the session.
      
      The problem was that SP-cache might grow without any limit. Although this
      was not a pure memory leak (the SP-cache is flushed when session is closed),
      this is still a problem, because the user might take much memory by
      executing many stored routines.
      
      The patch fixes this problem in the least-intrusive way. A soft limit
      (similar to the size of table definition cache) is introduced. To represent
      such limit the new runtime configuration parameter 'stored_program_cache'
      is introduced. The value of this parameter is stored in the new global
      variable stored_program_cache_size that used to control the size of SP-cache
      to overflow. 
      
      The parameter 'stored_program_cache' limits number of cached routines for
      each thread. It has the following min/default/max values given from support:
        min = 256, default = 256, max = 512 * 1024.
      Also it should be noted that this parameter limits the size of 
      each cache (for stored procedures and for stored functions) separately.
      
      The SP-cache size is checked after top-level statement is parsed.
      If SP-cache size exceeds the limit specified by parameter
      'stored_program_cache' then SP-cache is flushed and memory allocated for
      cache objects is freed. Such approach allows to flush cache safely 
      when there are dependencies among stored routines.
      
      
      sql/mysqld.cc:
        Added global variable stored_program_cache_size to store value of
        configuration parameter 'stored-program-cache'.
      sql/mysqld.h:
        Added declaration of global variable stored_program_cache_size.
      sql/sp_cache.cc:
        Extended interface for sp_cache by adding helper routine
        sp_cache_enforce_limit to control size of stored routines cache for
        overflow. Also added method enforce_limit into class sp_cache that
        implements control of cache size for overflow.
      sql/sp_cache.h:
        Extended interface for sp_cache by adding standalone routine
        sp_cache_enforce_limit to control size of stored routines cache
        for overflow.
      sql/sql_parse.cc:
        Added flush of sp_cache after processing of next sql-statement
        received from a client.
      sql/sql_prepare.cc:
        Added flush of sp_cache after preparation/execution of next prepared
        sql-statement received from a client.
      sql/sys_vars.cc:
        Added support for configuration parameter stored-program-cache.
      97883d3c
    • Marko Mäkelä's avatar
      Merge mysql-5.1 to mysql-5.5. · 82fec153
      Marko Mäkelä authored
      82fec153
    • Marko Mäkelä's avatar
      btr_cur_search_to_nth_level(): Add a debug assertion · a5d2554d
      Marko Mäkelä authored
      and some Valgrind instrumentation.
      a5d2554d
  2. 24 Jan, 2012 4 commits
  3. 23 Jan, 2012 4 commits
    • Nuno Carvalho's avatar
      BUG#12364404 - UNDETERMINISTIC WAIT LOOP IN WAIT_FOR_NDB_TO_BINLOG.INC · 825c74f6
      Nuno Carvalho authored
      The wait_for_ndb_to_binlog.inc include file used by the blow rpl_tests
      common for rpl and rpl_ndb suite is simply doing a "sleep 5", this is
      not deterministic and wastes lot of test time uneccessarily. The test
      should be rewritten to check if the condition it wait for has been
      reached or not.
      
      For NDB engine all events will be added by NDB injector so tests only 
      can continue after injector is ready, this test waits for proper
      injector thread state.
      825c74f6
    • Manish Kumar's avatar
      BUG#11752315 - 43460: STOP SLAVE UNABLE TO COMPLETE WHEN SLAVE THREAD IS TRYING TO RECONNECT TO · e69da6dc
      Manish Kumar authored
      Problem : The basic problem is the way the thread sleeps in mysql-5.5 and also in mysql-5.1
                when we execute a stop slave on windows platform.
                On windows platform if the stop slave is executed after the master dies, we have 
                this long wait before the stop slave return a value. This is because there is a 
                sleep of the thread. The sleep is uninterruptable in the two above version,
                which was fixed by Davi patch for the BUG#11765860 for mysql-trunk. Backporting 
                his patch for mysql-5.5 fixes the problem. 
      
      Solution : A new pair of mutex and condition variable is introduced to synchronize thread 
                 sleep and finalization. A new mutex is required because the slave threads are 
                 terminated while holding the slave thread locks (run_lock), which can not be 
                 relinquished during termination as this would affect the lock order.
      
      mysql-test/suite/rpl/r/rpl_start_stop_slave.result:
        The result file associated with the test added.
      mysql-test/suite/rpl/t/rpl_start_stop_slave.test:
        A test to check the new functionality.
      sql/rpl_mi.cc:
        The constructor using the new mutex and condition variables for the master_info.
      sql/rpl_mi.h:
        The condition variable and mutex have been added for the master_info.
      sql/rpl_rli.cc:
        The constructor using the new mutex and condition variables for the realy_log_info.
      sql/rpl_rli.h:
        The condition variable and mutex have been added for the relay_log_info.
      sql/slave.cc:
        Use a timed wait on a condition variable to implement a interruptible sleep. 
        The wait is registered with the THD object so that the thread will be woken 
        up if killed.
      e69da6dc
    • Alexander Barkov's avatar
      Merging Bug#11752408 from mysql-5.1 · 31a1f8ef
      Alexander Barkov authored
      31a1f8ef
    • Alexander Barkov's avatar
      Bug#11752408 - 43593: DUMP/BACKUP/RESTORE/UPGRADE TOOLS FAILS BECAUSE OF UTF8_GENERAL_CI · e449cf48
      Alexander Barkov authored
      Introducing new collations:
      utf8_general_mysql500_ci and ucs2_general_mysql500_ci,
      to reproduce behaviour of utf8_general_ci and ucs2_general_ci
      from mysql-5.1.23 (and earlier).
      
      The collations are added to simplify upgrade from mysql-5.1.23 and earlier.
      
      Note: The patch does not make new server start over old data automatically.
      Some manual upgrade procedures are assumed.
      
      Paul: please get in touch with me to discuss upgrade procedures
      when documenting this bug.
      
      modified:
        include/m_ctype.h
        mysql-test/r/ctype_utf8.result
        mysql-test/t/ctype_utf8.test
        mysys/charset-def.c
        strings/ctype-ucs2.c
        strings/ctype-utf8.c
      e449cf48
  4. 20 Jan, 2012 4 commits
    • Inaam Rana's avatar
      Bug#13612811 VALGRIND ERROR IN OS_AIO_INIT · 9cb16ec5
      Inaam Rana authored
      Fix valgrind warning introduced by fix for bug 11765450.
      9cb16ec5
    • Mattias Jonsson's avatar
      Bug#13500478 63623: TEST CASE PARTITION_BINLOG_STMT · cfbe0fe0
      Mattias Jonsson authored
      CREATES A FILE IN AN IMPROPER LOCATION.
      
      Fixed by using $MYSQLTEST_VARDIR, as proposed by
      Davi Arnaut.
      
      Thank you Davi!
      cfbe0fe0
    • Georgi Kodinov's avatar
      Addendum to the fix for bug #11754014 · f73bc024
      Georgi Kodinov authored
      - Fixed the checks to properly check for plugin_dir containing a trailing slash or backslash.
      - Fixed a under-configuration in udf_skip_grants that was preventing the test 
        from running even when there was a udf plugin.
      f73bc024
    • Dmitry Shulga's avatar
      Patch for bug#13070308 - VALGRIND failure in XA test. · 75249699
      Dmitry Shulga authored
      The issue is that xa.test failed sporadically on some platforms.
      The reason for the test failure is a race condition in xa.test.
      The race condition occures between connection that executes statement
      INSERT INTO t2 SELECT FROM t1 and other connection that tries to run
      statements DELETE FROM t1 and COMMIT. If COMMIT statement had been executed
      before the statement INSERT INTO t2 SELECT FROM t1 was locked by lock
      on table t1 (as a result of query from table t1) then the INSERT statement
      is executed successfully and a following test for deadlock would failed.
      
      This patch fixes this race condition by moving COMMIT statement after commit
      of distributed transaction from concurrent session.
      75249699
  5. 19 Jan, 2012 2 commits
  6. 17 Jan, 2012 4 commits
    • Andrei Elkin's avatar
      merging from the 5.5 repo to local branch. · 8c894564
      Andrei Elkin authored
      8c894564
    • Andrei Elkin's avatar
      BUG#13593869 - 64035: SEVERAL ERRORS IN COM_BINLOG_DUMP/MYSQL_BINLOG_SEND CRASH THE SERVER · 7cdd7a74
      Andrei Elkin authored
      The server crashes when receiving a COM_BINLOG_DUMP command with a position of 0 or
      larger than the file size.
      The execution proceeds to an error block having the last read replication coordinates 
      pointer be NULL and its dereferencing crashed the server.
      
      Fixed with making "public" previously used only for heartbeat coordinates.
      
      
      mysql-test/extra/rpl_tests/rpl_start_stop_slave.test:
        regression test for bug#3593869-64035 is added.
      mysql-test/suite/rpl/r/rpl_cant_read_event_incident.result:
        results updated (error mess format is changed).
      mysql-test/suite/rpl/r/rpl_log_pos.result:
        results updated (error mess format is changed).
      mysql-test/suite/rpl/r/rpl_manual_change_index_file.result:
        results updated (error mess format is changed).
      mysql-test/suite/rpl/r/rpl_packet.result:
        results updated (error mess format is changed).
      mysql-test/suite/rpl/r/rpl_stm_start_stop_slave.result:
        results updated (error mess format is changed).
      mysql-test/suite/rpl/t/rpl_stm_start_stop_slave.test:
        Slave is stopped by bug#3593869-64035 tests so 
        -let $rpl_only_running_threads= 1 is set prior to rpl_end.
      sql/share/errmsg-utf8.txt:
        Increasing the max length of explanatory message to 512.
      sql/sql_repl.cc:
        Making `coord' to carry the last read from binlog event coordinates
        regardless of heartbeat.
        Renaming, small cleanup and simplifying the code after if (coord) becomes unnecessary.
        Adding yet another 3rd pair of coordinates - the starting replication - 
        into error text.
      7cdd7a74
    • Georgi Kodinov's avatar
      merged bug #11754014 · a72f7ee6
      Georgi Kodinov authored
      a72f7ee6
    • Nirbhay Choubey's avatar
      Bug #11760384 52792: MYSQLDUMP IN XML MODE DOES NOT · 2bffb8b1
      Nirbhay Choubey authored
                           DUMP ROUTINES
      
      Minor post-fix to avoid build failure when built with
      Werror.
      2bffb8b1
  7. 16 Jan, 2012 10 commits
  8. 12 Jan, 2012 4 commits
  9. 11 Jan, 2012 3 commits