An error occurred fetching the project authors.
  1. 09 Apr, 2022 1 commit
  2. 06 Jun, 2021 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-25602 get rid of __WIN__ in favor of standard _WIN32 · 3d6eb7af
      Vladislav Vaintroub authored
      This fixed the MySQL bug# 20338 about misuse of double underscore
      prefix __WIN__, which was old MySQL's idea of identifying Windows
      Replace it by _WIN32 standard symbol for targeting Windows OS
      (both 32 and 64 bit)
      
      Not that connect storage engine is not fixed in this patch (must be
      fixed in "upstream" branch)
      3d6eb7af
  3. 01 Sep, 2020 1 commit
  4. 30 Jul, 2020 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-21101 unexpected wait_timeout with pool-of-threads · 71015d84
      Vladislav Vaintroub authored
      Due to restricted size of the threadpool, execution of client queries can
      be delayed (queued) for a while. This delay was interpreted as client
      inactivity, and connection is closed, if client idle time + queue time
      exceeds wait_timeout.
      
      But users did not expect queue time to be included into wait_timeout.
      
      This patch changes the behavior. We don't close connection anymore,
      if there is some unread data present on connection,
      even if wait_timeout is exceeded. Unread data means that client
      was not idle, it sent a query, which we did not have time to process yet.
      71015d84
  5. 29 Apr, 2020 1 commit
  6. 10 Mar, 2020 1 commit
  7. 28 Jul, 2019 1 commit
  8. 04 Jul, 2019 1 commit
  9. 11 May, 2019 1 commit
  10. 20 Aug, 2018 1 commit
  11. 11 Aug, 2018 2 commits
  12. 20 Feb, 2018 1 commit
  13. 06 Feb, 2018 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from... · 6c279ad6
      Vladislav Vaintroub authored
      MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from 'size_t' to 'type', possible loss of data)
      
      Handle string length as size_t, consistently (almost always:))
      Change function prototypes to accept size_t, where in the past
      ulong or uint were used. change local/member variables to size_t
      when appropriate.
      
      This fix excludes rocksdb, spider,spider, sphinx and connect for now.
      6c279ad6
  14. 26 Jan, 2018 1 commit
  15. 11 Dec, 2017 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-14113 Use abortive TCP close, in case server closes the connection · 70d6c944
      Vladislav Vaintroub authored
      first, and we do not not care whether client has received all data.
      
      This is a TCP optimization to avoid TIME_WAIT in TCP connection teardown.
      
      This patch would abort connection on timeout, which usually happens when
      client reads a large result set, at slower pace then the server can
      write.
      
      The patch also cleans up socket timeout handling, so that Windows
      is consistent with another platforms (using nonblocking socket IO
       + waiting in poll/select on single socket, rather than setsockopt).
      This makes identifying timeouts easier.
      
      
      Also removed the superficial shutdown() before closesocket() in a few
      places where it was used, because it  was never needed , and
      reportedly breaks SO_LINGER on Windows.
      70d6c944
  16. 17 Nov, 2017 1 commit
  17. 28 Sep, 2017 1 commit
  18. 22 Aug, 2017 1 commit
  19. 21 Aug, 2016 1 commit
    • Monty's avatar
      Cleanups and minor fixes · 8d5a0d65
      Monty authored
      - Fixed typos
      - Added --core-on-failure to mysql-test-run
      - More DBUG_PRINT in viosocket.c
      - Don't forget CLIENT_REMEMBER_OPTIONS for compressed slave protocol
      - Removed not used stage variables
      8d5a0d65
  20. 01 Jun, 2016 1 commit
  21. 03 May, 2015 1 commit
  22. 19 Feb, 2014 1 commit
    • Sergey Vojtovich's avatar
      MDEV-5314 - Compiling fails on OSX using clang · d12c7adf
      Sergey Vojtovich authored
      This is port of fix for MySQL BUG#17647863.
      
      revno: 5572
      revision-id: jon.hauglid@oracle.com-20131030232243-b0pw98oy72uka2sj
      committer: Jon Olav Hauglid <jon.hauglid@oracle.com>
      timestamp: Thu 2013-10-31 00:22:43 +0100
      message:
        Bug#17647863: MYSQL DOES NOT COMPILE ON OSX 10.9 GM
      
        Rename test() macro to MY_TEST() to avoid conflict with libc++.
      d12c7adf
  23. 23 May, 2013 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-4566 : Failing DBUG_ASSERT() in SELECT SLEEP(), with threadpool. · 08ce9bfe
      Vladislav Vaintroub authored
      This bug only happens with long sleep()s ( > 5 sec), and in debug version.
      
      Analysis: 
      The assertion is caused by nested thd_wait_begin() calls, which is not an expected condition.
      -  "outer" thd_wait_begin()) , in Item_func_sleep::val_int()
      -  "inner" thd_wait_begin() in Interruptible_wait::wait(). This function periodically checks whether connection is still valid, via THD::is_connection(), which ends up  calling vio_io_wait()  with timeout parameter set to  0.
      
      
      Fix is not to call thd wait callback in vio_io_wait(), if timeout parameter is 0. There is no "waiting" in this case.
      08ce9bfe
  24. 05 May, 2013 1 commit
    • Michael Widenius's avatar
      Fixed errors and compiler warnings found by buildbot · 5333dafa
      Michael Widenius authored
      Solaris fixes:
      - Fixed that wait_timeout_func and wait_timeout tests works on solaris
      - We have to compile without NO_ALARM on Solaris as Solaris doesn't support timeouts on sockets with setsockopt(.. SO_RCVTIMEO).
      - Fixed that compile-solaris-amd64-debug works (before that we got a wrong ELF class: ELFCLASS64 on linkage)
      - Added missing sync_with_master
      Other bug fixes:
      - Free memory for rpl_global_gtid_binlog_state before exit() to avoid 'accessing uninitalized mutex' error.
      
      
      
      BUILD/FINISH.sh:
        Fixed issues on Solaris with ksh
      BUILD/compile-solaris-amd64-debug:
        Added missing -m64 flag
      configure.cmake:
        We have to compile without NO_ALARM on Solaris as Solaris doesn't support timeouts on sockets with setsockopt(.. SO_RCVTIMEO)
      mysql-test/suite/rpl/t/rpl_gtid_mdev4473.test:
        - Added missing sync_with_master (fix by knielsen)
      sql-common/client.c:
        Added () to get rid of compiler warning
      sql/item_strfunc.cc:
        Fixed compiler warning
      sql/log.cc:
        Free memory for static variable rpl_global_gtid_binlog_state before exit()
        - If we are compiling with safemalloc, we would try to call sf_free() for some members after sf_terminate() was called, which would result of trying to access the uninitalized mutex 'sf_mutex'
      sql/multi_range_read.cc:
        Fixed compiler warnings of converting double to ulong.
      sql/opt_range.cc:
        Fixed compiler warnings of converting double to ulong or uint
        - Better to have all variables that can be number of rows as 'ha_rows'
      sql/rpl_gtid.cc:
        Added rpl_binlog_state::free() to be able to free memory for static objects before exit()
      sql/rpl_gtid.h:
        Added rpl_binlog_state::free() to be able to free memory for static objects before exit()
      sql/set_var.cc:
        Fixed compiler warning
      sql/sql_join_cache.cc:
        Fixed compiler warnings of converting double to uint
      sql/sql_show.cc:
        Added cast to get rid of compiler warning
      sql/sql_statistics.cc:
        Remove code that didn't do anything.
        (store_record() with record[0] is a no-op)
      storage/xtradb/os/os0file.c:
        Added  __attribute__ ((unused))
      support-files/compiler_warnings.supp:
        Ignore warnings from atomic_add_64_nv
        (was not able to fix this with a cast as the macro is a bit different between systems)
      vio/viosocket.c:
        Added more DBUG_PRINT
      5333dafa
  25. 04 Apr, 2013 1 commit
  26. 25 Feb, 2013 2 commits
  27. 19 Feb, 2013 1 commit
  28. 12 Oct, 2012 1 commit
    • unknown's avatar
      MDEV-3802: Millisecond timeout support in non-blocking client library + fix incorrect blocking. · 52c84d14
      unknown authored
      After the merge of VIO stuff from MySQL 5.6, there were some bugs left
      in the non-blocking client library:
      
       - vio_io_wait() was introduced without any support for non-blocking operation,
         so async queries could turn into sync.
      
       - Timeouts were changed to milliseconds, but this was not reflected in the
         non-blocking API, also semantics was changed so signed -1 was used for
         "no timeout" rather than unsigned 0.
      
      Fix by implementing and using my_io_wait_async() in the non-blocking case. And
      by introducing a new mysql_get_timeout_value_ms() API function that provides
      the timeout with millisecond granularity. The old mysql_get_timeout_value()
      is kept and fixed to work correctly, converting the timeout to whole seconds.
      52c84d14
  29. 27 Sep, 2012 1 commit
    • Sergei Golubchik's avatar
      fixes for test failures · 474fe6d9
      Sergei Golubchik authored
      and small collateral changes
      
      mysql-test/lib/My/Test.pm:
        somehow with "print" we get truncated writes sometimes
      mysql-test/suite/perfschema/r/digest_table_full.result:
        md5 hashes of statement digests differ, because yacc token codes are different in mariadb
      mysql-test/suite/perfschema/r/dml_handler.result:
        host table is not ported over yet
      mysql-test/suite/perfschema/r/information_schema.result:
        host table is not ported over yet
      mysql-test/suite/perfschema/r/nesting.result:
        this differs, because we don't rewrite general log queries, and multi-statement
        packets are logged as a one entry. this result file is identical to what mysql-5.6.5
        produces with the --log-raw option.
      mysql-test/suite/perfschema/r/relaylog.result:
        MariaDB modifies the binlog index file directly, while MySQL 5.6 has a feature "crash-safe binlog index" and modifies a special "crash-safe" shadow copy of the index file and then moves it over. That's why this test shows "NONE" index file writes in MySQL and "MANY" in MariaDB.
      mysql-test/suite/perfschema/r/server_init.result:
        MariaDB initializes the "manager" resources from the "manager" thread, and starts this thread only when --flush-time is not 0. MySQL 5.6 initializes "manager" resources unconditionally on server startup.
      mysql-test/suite/perfschema/r/stage_mdl_global.result:
        this differs, because MariaDB disables query cache when query_cache_size=0. MySQL does not
        do that, and this causes useless mutex locks and waits.
      mysql-test/suite/perfschema/r/statement_digest.result:
        md5 hashes of statement digests differ, because yacc token codes are different in mariadb
      mysql-test/suite/perfschema/r/statement_digest_consumers.result:
        md5 hashes of statement digests differ, because yacc token codes are different in mariadb
      mysql-test/suite/perfschema/r/statement_digest_long_query.result:
        md5 hashes of statement digests differ, because yacc token codes are different in mariadb
      mysql-test/suite/rpl/r/rpl_mixed_drop_create_temp_table.result:
        will be updated to match 5.6 when alfranio.correia@oracle.com-20110512172919-c1b5kmum4h52g0ni and anders.song@greatopensource.com-20110105052107-zoab0bsf5a6xxk2y are merged
      mysql-test/suite/rpl/r/rpl_non_direct_mixed_mixing_engines.result:
        will be updated to match 5.6 when anders.song@greatopensource.com-20110105052107-zoab0bsf5a6xxk2y is merged
      474fe6d9
  30. 14 Aug, 2012 1 commit
  31. 28 Feb, 2012 1 commit
  32. 17 Feb, 2012 2 commits
    • Tatjana Azundris Nuernberg's avatar
      BUG#13431369 - MAIN.VARIABLES-NOTEMBEDDED CRASHES THE SERVER SPORADICALLY ON WINDOWS · b6b47f88
      Tatjana Azundris Nuernberg authored
      On shutdown(), Windows can drop traffic still queued for sending even if that
      wasn't specifically requested. As a result, fatal errors (those after
      signaling which the server will drop the connection) were sometimes only
      seen as "connection lost" on the client side, because the server-side
      shutdown() erraneously discarded the correct error message before sending
      it.
      
      If on Windows, we now use the Windows API to access the (non-broken) equivalent
      of shutdown().
      
      Backport from trunk
      
      include/violite.h:
        export mysql_socket_shutdown(). It lives in vio in the backport.
      sql/mysqld.cc:
        Go through our own shutdown() rather than straight to the POSIX one.
      vio/viosocket.c:
        Define mysql_socket_shutdown(). On UNIXoid systems, it's just a wrapper for shutdown(), but
        on Window, it uses DisconnectEx, which is magic.
      b6b47f88
    • Tatjana Azundris Nuernberg's avatar
      BUG#13431369 - MAIN.VARIABLES-NOTEMBEDDED CRASHES THE SERVER SPORADICALLY ON WINDOWS · da2cc0cd
      Tatjana Azundris Nuernberg authored
      On shutdown(), Windows can drop traffic still queued for sending even if that
      wasn't specifically requested. As a result, fatal errors (those after
      signaling which the server will drop the connection) were sometimes only
      seen as "connection lost" on the client side, because the server-side
      shutdown() erraneously discarded the correct error message before sending
      it.
      
      If on Windows, we now use the Windows API to access the (non-broken) equivalent
      of shutdown().
      
      Backport from trunk
      da2cc0cd
  33. 24 Jan, 2012 1 commit
  34. 17 Jan, 2012 1 commit
  35. 06 Jan, 2012 1 commit
    • unknown's avatar
      MWL#192: non-blocking client API, after-review fixes. · 17940b65
      unknown authored
      Main change is that non-blocking operation is now an option that must be
      explicitly enabled with mysql_option(mysql, MYSQL_OPT_NONBLOCK, ...)
      before any non-blocing operation can be used.
      
      Also the CLIENT_REMEMBER_OPTIONS flag is now always enabled and thus
      effectively ignored (it was not really useful anyway, and this simplifies
      things when non-blocking mysql_real_connect() fails).
      17940b65
  36. 08 Dec, 2011 1 commit
  37. 29 Nov, 2011 1 commit
    • Michael Widenius's avatar
      Fixed compiler warnings · 47575bd0
      Michael Widenius authored
      dbug/tests.c:
        Added __attribute__((unused)) to get rid of compiler warning
      server-tools/instance-manager/guardian.cc:
        Added __attribute__((unused)) to get rid of compiler warning
      sql/filesort.cc:
        Added __attribute__((unused)) to get rid of compiler warning
      sql/slave.cc:
        Added __attribute__((unused)) to get rid of compiler warning
      sql/sql_load.cc:
        Added __attribute__((unused)) to get rid of compiler warning
      sql/sql_table.cc:
        Added __attribute__((unused)) to get rid of compiler warning
      storage/maria/ma_blockrec.c:
        Added __attribute__((unused)) to get rid of compiler warning
      storage/maria/ma_check.c:
        Added missing cast
      storage/maria/ma_loghandler.c:
        Added __attribute__((unused)) to get rid of compiler warning
      storage/maria/ma_recovery.c:
        Added __attribute__((unused)) to get rid of compiler warning
      storage/pbxt/src/cache_xt.cc:
        Added __attribute__((unused)) to get rid of compiler warning
      storage/xtradb/fil/fil0fil.c:
        Removed not used variable
      storage/xtradb/handler/ha_innodb.cc:
        Use unused variable
      vio/viosocket.c:
        Remove usage of not used variable
      vio/viosslfactories.c:
        Added cast
      47575bd0