- 22 Sep, 2017 5 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
Implement Field_timestamp::save_in_field(timestamp_field) that stores timestamp values without converting them to MYSQL_TIME and back, because this conversion is lossy around DST change time. This fixes main.old-mode test. This is 10.2 version of f8a800be
-
Sergei Golubchik authored
Implement a special Copy_func function for timestamps, that copies timestamps without converting them to MYSQL_TIME (the conversion is lossy around DST change time). This fixes ALTER TABLE part of main.old-mode test. This is 10.2 version of f4f48e06
-
Sergei Golubchik authored
make insert NULL into a timestamp mark the field as having an explicit value. So that the field won't be assigned the value again in TABLE::update_default_field() make Item_func_now_local::save_in_field(timestamp_field) not to go through MYSQL_TIME - this conversion is lossy around DST change times. This fixes inserting a default value into a timestamp field.
-
Sergei Golubchik authored
But without f4f48e06..f8a800be - fixes for MDEV-12672 and related issues. 10.2 specific fix follows...
-
- 21 Sep, 2017 16 commits
-
-
Sergei Golubchik authored
don't do it via MYSQL_TIME, that conversion is lossy around DST change dates.
-
Sergei Golubchik authored
Implement a special Copy_field method for timestamps, that copies timestamps without converting them to MYSQL_TIME (the conversion is lossy around DST change dates).
-
Sergei Golubchik authored
libmariadbclient_18 version nodes, specially for debian builds
-
Sergei Golubchik authored
-
Sergei Golubchik authored
followup for 378beed0 - only count WARN_LEVEL_ERROR, not warnings or notes.
-
Sergei Golubchik authored
tabtyp was defined under ODBC_SUPPORT, but used outside of it too (under JDBC_SUPPORT).
-
Vladislav Vaintroub authored
Even if cmake can find pkg-config (e.g the one supplied with strawberry perl ), we cannot link with pkg-config-found libraries or use the headers -they are mingw, 32bit-only.
-
Monty authored
- Added missing test case for MyISAM
-
Marko Mäkelä authored
-
Marko Mäkelä authored
Node pointer recors contain dict_index_get_n_unique_in_tree_nonleaf(index)+1 instead of index->n_uniq+1 fields. rec_get_offsets_func(): Remove the incorrect assertion. Later in the function there are assertion for checking the exact field count.
-
Sergei Golubchik authored
don't prepare for checking view's CHECK OPTION, if there is no CHECK OPTION in the first place.
-
Sachin Setiya authored
Binlog_background_thread does not make a call to set_time(), And when we call binlog_checkpoint_log_event->write() , we write the wrong timestamp. In this patch we correct this by calling thd->set_time().
-
Marko Mäkelä authored
-
Marko Mäkelä authored
When the debug parameter 'bool leaf' was added to rec_get_offsets(), also some debug assertions for reading the heap_no of ROW_FORMAT=REDUNDANT records were added. However, the heap number is uninitialized when offsets are being computed for to-be-inserted records. For debug builds, initialize the heap number to a dummy value, so that the record will be interpreted as 'user record'. The infimum and supremum pseudo-records are never copied from the page frame and never inserted; they are part of the page creation. rec_convert_dtuple_to_rec_old(): Remove a bogus memset() in debug builds.
-
sachin authored
Problem:- To create file in /tmp dir mysqld require permission initrc_tmp_t. And mysqld does not have his permission. Solution:- Instead of giving mysqld permission of initrc_tmp_t , we redirected log to file in /tmp dir through shell. I also removed a earlier workarround in mysqld_safe.sh , which create tmp log file in datadir.
-
Marko Mäkelä authored
-
- 20 Sep, 2017 19 commits
-
-
Sergei Golubchik authored
followup for b5ead3a6 libmariadb3 does not replace 10.1's libmariadbclient18 anymore, but it still conflicts with it, both install dialog.so
-
Marko Mäkelä authored
-
Marko Mäkelä authored
This fixes a regression that only affects debug builds, caused by commit 48192f96 which is necessary preparation for MDEV-11369 instant ADD COLUMN. (Although that is a 10.3 task, to ease merges between 10.2 and 10.3, this change that improves debug checks was pushed to 10.2 already.) Unlike btr_pcur_restore_position(), rtr_cur_restore_position() can create a search tuple out of a non-leaf page record. So, we must pass 'bool leaf' parameter to dict_index_build_data_tuple(). dict_index_build_data_tuple(): Add a debug-only parameter 'bool leaf'. rec_copy_prefix_to_dtuple(): Make the parameter debug-only. row_sel_get_clust_rec_for_mysql(): In the debug code for spatial index, remove an unnecessary call to buf_page_get_gen(), and use the already latched block directly.
-
Sergei Golubchik authored
MDEV-13290: Assertion Assertion `!is_set() || (m_status == DA_OK_BULK && is_bulk_op())' or `! is_set()' failed followup for 97c2a735 - don't use thd->is_error(), the error could've been set before TABLE_LIST::cleanup_items. Use the error handler to count errors. This fixes rpl.rpl_row_binlog_max_cache_size - it was failing when ER_STMT_CACHE_FULL happened duing multi-table update. Because multi_update::abort_result_set() calls do_updates() to update as much as possible, so one cannot rely on thd->is_error() after that.
-
Sergei Golubchik authored
-
Marko Mäkelä authored
-
Sergei Golubchik authored
disable Mongo in 10.0, compiler warnings.
-
Sergei Golubchik authored
-
Marko Mäkelä authored
MDEV-13851 Always check table options in ALTER TABLE…ALGORITHM=INPLACE In the merge of MySQL 5.7.9 to MariaDB 10.2.2, some code was included that prevents ADD SPATIAL INDEX from being executed with ALGORITHM=INPLACE. Also, the constant ADD_SPATIAL_INDEX was introduced as an alias to ADD_INDEX. We will remove that alias now, and properly implement the same ADD SPATIAL INDEX restrictions as MySQL 5.7 does: 1. table-rebuilding operations are not allowed if SPATIAL INDEX survive it 2. ALTER TABLE…ADD SPATIAL INDEX…LOCK=NONE is not allowed ha_innobase::prepare_inplace_alter_table(): If the ALTER TABLE requires actions within InnoDB, enforce the table options (MDEV-13851). In this way, we will keep denying ADD SPATIAL INDEX for tables that use encryption (MDEV-11974), even if ALGORITHM=INPLACE is used.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
This should affect debug builds only. Debug builds will check that the status bits of ROW_FORMAT!=REDUNDANT records match the is_leaf parameter. The only observable change to non-debug should be the addition of the is_leaf parameter to the function rec_copy_prefix_to_dtuple(), and the removal of some calls to update the adaptive hash index (it is only built for the leaf pages). This change should have been made in MySQL 5.0.3, instead of introducing the status flags in the ROW_FORMAT=COMPACT record header.
-
Vicențiu Ciorbaru authored
-
Vicențiu Ciorbaru authored
-
Vicențiu Ciorbaru authored
-
Vicențiu Ciorbaru authored
-
Vicențiu Ciorbaru authored
-
Jan Lindström authored
-
Marko Mäkelä authored
The only universal index in InnoDB was the change buffer. It suffices to keep the DICT_IBUF flag (which, like DICT_UNIVERSAL, is not written to any persistent data structure).
-
Marko Mäkelä authored
The function check_mdl_lock_works() is for debug builds only.
-