1. 29 Jun, 2010 2 commits
  2. 26 Jun, 2010 1 commit
    • Jon Olav Hauglid's avatar
      Bug #49891 View DDL breaks REPEATABLE READ · e79d4189
      Jon Olav Hauglid authored
      The problem was that if a query accessing a view was blocked due to
      conflicting locks on tables in the view definition, it would be possible
      for a different connection to alter the view definition before the view
      query completed. When the view query later resumed, it used the old view
      definition. This meant that if the view query was later repeated inside
      the same transaction, the two executions of the query would give different
      results, thus breaking repeatable read. (The first query used the old
      view definition, the second used the new view definition).
      
      This bug is no longer repeatable with the recent changes to the metadata
      locking subsystem (revno: 3040). The view query will no longer back-off
      and release the lock on the view definiton. Instead it will wait for
      the conflicting lock(s) to go away while keeping the view definition lock.
      This means that it is no longer possible for a concurrent connection to
      alter the view definition. Instead, any such attempt will be blocked.
      
      In the case from the bug report where the same view query was executed
      twice inside the same transaction, any ALTER VIEW from other connections
      will now be blocked until the transaction has completed (or aborted).
      The view queries will therefore use the same view definition and we will
      have repeatable read.
      
      Test case added to innodb_mysql_lock.test.
      This patch contains no code changes.
      e79d4189
  3. 25 Jun, 2010 2 commits
  4. 23 Jun, 2010 3 commits
    • Jon Olav Hauglid's avatar
      Backport from mysql-6.0-codebase of: · be3005d9
      Jon Olav Hauglid authored
      ------------------------------------------------------------
      revno: 3672
      committer: lars-erik.bjork@sun.com
      branch nick: 48067-mysql-6.0-codebase-bugfixing
      timestamp: Mon 2009-10-26 13:51:43 +0100
      message:
        This is a patch for bug#48067
        "A temp table with the same name as an existing table, makes drop
        database fail"
              
        When dropping the database, mysql_rm_known_files() reads the contents
        of the database directory, and creates a TABLE_LIST object, for each
        .frm file encountered. Temporary tables, however, are not associated 
        with any .frm file.
              
        The list of tables to drop are passed to mysql_rm_table_part2().
        This method prefers temporary tables over regular tables, so if
        there is a temporary table with the same name as a regular, the
        temporary is removed, leaving the regular table intact.
        Regular tables are only deleted if there are no temporary tables
        with the same name.
              
        This fix ensures, that for all TABLE_LIST objects that are created
        by mysql_rm_known_files(), 'open_type' is set to 'OT_BASE_ONLY', to
        indicate that this is a regular table. In all cases in
        mysql_rm_table_part2() where we prefer a temporary table to a
        non-temporary table, we chek if 'open_type' equals 'OT_BASE_ONLY'.
      be3005d9
    • sunanda's avatar
      Updated the version number · e0aba0c8
      sunanda authored
      e0aba0c8
    • sunanda's avatar
  5. 22 Jun, 2010 2 commits
  6. 21 Jun, 2010 3 commits
  7. 20 Jun, 2010 1 commit
    • Magne Mahre's avatar
      Post-push fixup for WL#5349 · eda2ff81
      Magne Mahre authored
      InnoDB came in a new version "simultanously" with the
      commit.  This patch is a minor change to the new innodb
      regression test suite. 
      eda2ff81
  8. 18 Jun, 2010 3 commits
    • Konstantin Osipov's avatar
      A new implementation for the TABLE_SHARE cache in MDL · 94174db1
      Konstantin Osipov authored
      subsystem. Fix a number of caveates that the previous
      implementation suffered from, including unprotected
      access to shared data and lax resource accounting
      (share->ref_count) that could lead to deadlocks.
      
      The new implementation still suffers from a number
      of potential deadlocks in some edge cases, and this is 
      still not enabled by default. Especially since performance
      testing has shown that it gives only marginable (not even 
      exceeding measuring accuracy) improvements.
      
      @todo: 
      - Remove calls to close_cached_tables() with REFRESH_FAST,
      and have_lock, because they break the MDL cache. 
      - rework FLUSH TABLES <list> to not use close_cached_tables()
      - make sure that whenever we set TABLE_SHARE::version to
      0 we free MDL cache references to it.
      94174db1
    • Daniel Fischer's avatar
      merge · 9891642e
      Daniel Fischer authored
      9891642e
    • Joerg Bruehe's avatar
      Automerge from parent copy. · 105b4c38
      Joerg Bruehe authored
      105b4c38
  9. 17 Jun, 2010 19 commits
  10. 16 Jun, 2010 3 commits
  11. 15 Jun, 2010 1 commit
    • Joerg Bruehe's avatar
      Fix bug#27072: RPM autostarts the server · 9b42527d
      Joerg Bruehe authored
      This is the fix for 5.5, where the behaviour on both installation
      and upgrade is changed:
      On installation, we do not start the server, to allow automated
      installs (which happen in some indeterminate machine status).
      If the server was stopped when the upgrade begins, we assume the
      administrator is taking manual action, so we do not start the (new)
      server at the end of the upgrade.
      We still install the start/stop script, so it will be started on reboot.
      9b42527d