An error occurred fetching the project authors.
  1. 10 Aug, 2004 1 commit
    • unknown's avatar
      Fix for bug #4508 "CONVERT_TZ() function with new time zone as param crashes server". · cfa6cf90
      unknown authored
      Instead of trying to open time zone tables during calculation of CONVERT_TZ() function
      or setting of @@time_zone variable we should open and lock them with the rest of 
      statement's table (so we should add them to global table list) and after that use such 
      pre-opened tables for loading info about time zones.
      
      
      mysql-test/r/timezone2.result:
        Added test for bug #4508
      mysql-test/t/timezone2.test:
        Added test for bug #4508
      scripts/mysql_create_system_tables.sh:
        Added one more test time zone to time zone tables which is needed for test for bug #4508.
      sql/item_create.cc:
        CONVERT_TZ() now is treated as special function.
      sql/item_create.h:
        CONVERT_TZ() now is treated as special function.
      sql/item_timefunc.cc:
        Item_func_convert_tz now uses list of pre-opened time zone tables instead of trying to
        open them ad-hoc. Also it avoid calling of current_thd.
      sql/item_timefunc.h:
        Added comment describing special nature of CONVERT_TZ() function.
        Optimization: Added own fix_fields() method and tz_tables member for caching pointer
        to list of open time zone tables to Item_func_convert_tz class.
      sql/lex.h:
        CONVERT_TZ() now is treated as special function.
      sql/mysql_priv.h:
        Removed function which is no longer used.
      sql/set_var.cc:
        Now my_tz_find() accepts list of pre-opened time zone tables as last argument 
        and no longer needs pointer to current THD.
      sql/set_var.h:
        Exported sys_time_zone, which is now used in sql_yacc.yy for quick finding out if we are
        setting @@time_zone variable.
      sql/sql_base.cc:
        Moved propagation of pointers to open tables from global list to local select lists to
        open_and_lock_tables(), also added implicit usage of time zone tables as condition for
        such propagation.
      sql/sql_lex.cc:
        Added fake_time_zone_tables_list which is used to indicate that time zone tables are
        implicitly used in statement.
        st_select_lex_unit::create_total_list(): if time zone tables are implicitly used in
        statement add them to global tables list.
      sql/sql_lex.h:
        Added LEX::time_zone_tables_used member which is used to indicate that time zone tables 
        are implicitly used in this statement (by pointing to fake_time_zone_table_list) and 
        for holding pointer to those tables after they've been opened.
      sql/sql_parse.cc:
        We should also create global table list if statement uses time zone tables implicitly.
        Added initialization of LEX::time_zone_tables_used to mysql_query_init().
      sql/sql_prepare.cc:
        We should also create global table list if statement uses time zone tables implicitly.
      sql/sql_select.cc:
        Removed functions which are no longer used.
      sql/sql_yacc.yy:
        CONVERT_TZ() and @@time_zone variable are handled in special way since they implicitly 
        use time zone tables.
      sql/tztime.cc:
        Fix for bug #4508 "CONVERT_TZ() function with new time zone as param crashes server".
        If statement uses CONVERT_TZ() function or @@time_zone variable is set then it implicitly
        uses time zone tables. We need to open and lock such tables with all other tables of 
        such statement.
        
        All code responsible for opening table was removed from tz_load_from_db() and function was 
        renamed to tz_load_from_open_tables() (which uses list of pre-opened tables).
        We also have new functions for construction and initialization of table list of time
        zone tables.
        my_tz_find() now always require list of pre-opened time zone tables and no longer needs
        current THD. So we have to pre-open them in my_tz_init().
        Also now we try to open time zone tables only if they were found during startup.
      sql/tztime.h:
        New function for construction of table list of time zone tables my_tz_get_table_list().
        Now my_tz_find() requires list of pre-pened time zone tables instead of current thread.
      cfa6cf90
  2. 30 Jul, 2004 1 commit
  3. 28 Jul, 2004 1 commit
  4. 20 Jul, 2004 1 commit
    • unknown's avatar
      Added innodb_locks_unsafe_for_binlog option. This option turns off Innodb · 0390acec
      unknown authored
        next-key locking. Using this option the locks InnoDB sets on index 
        records do not affect the ``gap'' before that index record. Thus, this option
        allows phantom problem.
      
      
      innobase/include/srv0srv.h:
        Added srv_locks_unsafe_for_binlog for innodb_locks_unsafe_for_binlog option.
      innobase/row/row0sel.c:
        If innodb_locks_unsafe_for_binlog option is used, we lock only the record, i.e. 
        next-key locking is not used. Therefore, setting lock to the index record
        do not affect the ``gap'' before that index record. Thus, this option
        allows phantom problem, because concurrent insert operations are allowed inside 
        the select range.
      innobase/srv/srv0srv.c:
        Added srv_locks_unsafe_for_binlog for innodb_locks_unsafe_for_binlog option.
      sql/ha_innodb.cc:
        Added innobase_locks_unsafe_for_binlog and srv_locks_unsafe_for_binlog for 
        innodb_locks_unsafe_for_binlog option.
      sql/ha_innodb.h:
        Added innobase_locks_unsafe_for_binlog for innodb_locks_unsafe_for_binlog option.
      sql/mysqld.cc:
        Added OPT_INNODB_LOCKS_UNSAFE_FOR_BINLOG, innobase_locks_unsafe_for_binlog for
        innodb_locks_unsafe_for_binlog option.
      sql/set_var.cc:
        Added innodb_locks_unsafe_for_binlog and innobase_locks_unsafe_for_binlog for
        innodb_locks_unsafe_for_binlog option.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      0390acec
  5. 10 Jul, 2004 1 commit
  6. 08 Jul, 2004 1 commit
    • unknown's avatar
      New handler::index_flags() definition to make it easy to check the full used... · 9236c380
      unknown authored
      New handler::index_flags() definition to make it easy to check the full used key and a specific key part.
      Added key part to optimize_range() to fix problems when using fields in key parts.
      
      
      
      sql/examples/ha_archive.h:
        New handler::index_flags() definition
      sql/examples/ha_example.h:
        New handler::index_flags() definition
      sql/field.cc:
        New optimize_range() definition
      sql/field.h:
        New optimize_range() definition
      sql/ha_berkeley.cc:
        New handler::index_flags() definition
      sql/ha_berkeley.h:
        New handler::index_flags() definition
      sql/ha_heap.h:
        New handler::index_flags() definition
      sql/ha_innodb.h:
        New handler::index_flags() definition
      sql/ha_isam.h:
        New handler::index_flags() definition
      sql/ha_isammrg.h:
        New handler::index_flags() definition
      sql/ha_myisam.h:
        New handler::index_flags() definition
      sql/ha_myisammrg.h:
        New handler::index_flags() definition
      sql/ha_ndbcluster.cc:
        New handler::index_flags() definition
      sql/ha_ndbcluster.h:
        New handler::index_flags() definition
      sql/handler.h:
        New handler::index_flags() definition
      sql/log.cc:
        Fixed compiler warnings
      sql/log_event.cc:
        Fixed compiler warnings (and renamed short variable name)
      sql/opt_range.cc:
        New handler::index_flags() definition
      sql/opt_sum.cc:
        New handler::index_flags() definition
      sql/set_var.cc:
        Removed compiler warnings
      sql/sql_db.cc:
        Removed compiler warnings
      sql/sql_select.cc:
        New handler::index_flags() definition
      sql/sql_show.cc:
        Removed compiler warnings
      sql/sql_update.cc:
        Removed compiler warnings
      sql/table.cc:
        New handler::index_flags() definition
      9236c380
  7. 24 Jun, 2004 1 commit
    • unknown's avatar
      Fix for Bug#4030 "Client side conversion string -> date type doesn't · 04f3836f
      unknown authored
      work (prepared statements)" and after-review fixes:
      - str_to_TIME renamed to str_to_datetime to pair with str_to_time
      - functions str_to_time and str_to_TIME moved to sql-common
      - send_data_str now supports MYSQL_TYPE_TIME, MYSQL_TIME_DATE,
        MYSQL_TIME_DATETIME types of user input buffers.
      - few more comments in the client library
      - a test case added.
      
      
      VC++Files/libmysql/libmysql.dsp:
        new file: my_time.c
      VC++Files/libmysqld/libmysqld.dsp:
        new file: my_time.c
      VC++Files/sql/mysqld.dsp:
        new file: my_time.c
      include/Makefile.am:
        - mysql_time.h added to the list of installed client library headers
      include/mysql.h:
        - declarations for MYSQL_TIME and enum_mysql_timestamp_type moved to 
        mysql_time.h, which is in shared use of client library and mysys.
      libmysql/Makefile.shared:
        - my_time.lo added to the list of libmysql objects
      libmysql/libmysql.c:
        Fix for bug#4030 "Client side conversion string -> date type doesn't work
         (prepared statements)" and cleanup.
        - added case labels for TIME/DATE/DATETIME types to send_data_str
        - comments for read_binary_{date,time,datetime}, fetch_result_*, fetch_results.
      libmysqld/Makefile.am:
        - my_time.c added
      sql-common/Makefile.am:
        - my_time.c added to the list of files included into source distribution.
      sql/Makefile.am:
        my_time.c added to the list of mysqld sources.
      sql/field.cc:
        - TIMESTAMP_{TIME,DATE,DATETIME,...} renamed to 
          MYSQL_TIMESTAMP_{TIME,DATETIME,DATE,...}
      sql/item.cc:
        - TIMESTAMP_{TIME,DATE,DATETIME,...} renamed to 
          MYSQL_TIMESTAMP_{TIME,DATETIME,DATE,...}
      sql/item_timefunc.cc:
        - TIMESTAMP_{TIME,DATE,DATETIME,...} renamed to 
          MYSQL_TIMESTAMP_{TIME,DATETIME,DATE,...}
      sql/mysql_priv.h:
        - added typedefs for TIME and timestamp_type
        - removed declarations for str_to_time and str_to_TIME (now this functions
          reside in mysys)
      sql/mysqld.cc:
        - log_10_int moved to mysys (it's used by str_to_TIME and str_to_time)
        - enum values TIMESTAMP_{TIME,DATE,DATETIME} were renamed to
          MYSQL_TIMESTAMP_{TIME,DATE,DATETIME}
      sql/set_var.cc:
        - TIMESTAMP_{TIME,DATE,DATETIME,...} renamed to 
          MYSQL_TIMESTAMP_{TIME,DATETIME,DATE,...}
      sql/set_var.h:
        - fixed timestamp_type usage to be compatible with typedef.
      sql/sql_prepare.cc:
        - TIMESTAMP_{TIME,DATE,DATETIME} were renamed to
          MYSQL_TIMESTAMP_{TIME,DATE,DATETIME}
        - embedded library implementation of set_param_{time,date,datetime} is
        much simplier now, as MYSQL_TIME is the same as TIME.
      sql/sql_yacc.yy:
        - s/\<TIMESTAMP_/MYSQL_TIMESTAMP/gc
      sql/structs.h:
        - declarations for TIME and timestamp_type replaced with typedefs
        - str_to_datetime arguments moved to mysys headers
      sql/time.cc:
        - str_to_time and str_to_TIME moved to mysys
        - TIMESTAMP_{TIME,DATE,DATETIME,...} renamed to 
          MYSQL_TIMESTAMP_{TIME,DATETIME,DATE,...} as these names are now
          exported to client.
        - str_to_TIME renamed to str_to_datetime to pair with str_to_time
        - str_to_TIME_with_warn renamed accordingly
      sql/tztime.cc:
        - TIMESTAMP_{TIME,DATE,DATETIME,...} renamed to 
          MYSQL_TIMESTAMP_{TIME,DATETIME,DATE,...}
      tests/client_test.c:
        - a test case for Bug#4030 "Client side conversion string -> date type 
        doesn't work (prepared statements)"
      04f3836f
  8. 18 Jun, 2004 1 commit
    • unknown's avatar
      WL#1264 "Per-thread time zone support infrastructure". · 6415966e
      unknown authored
      Added basic per-thread time zone functionality (based on public
      domain elsie-code). Now user can select current time zone
      (from the list of time zones described in system tables).
      All NOW-like functions honor this time zone, values of TIMESTAMP
      type are interpreted as values in this time zone, so now
      our TIMESTAMP type behaves similar to Oracle's TIMESTAMP WITH
      LOCAL TIME ZONE (or proper PostgresSQL type).
        
      WL#1266 "CONVERT_TZ() - basic time with time zone conversion 
      function".
        
      Fixed problems described in Bug #2336 (Different number of warnings 
      when inserting bad datetime as string or as number). This required
      reworking of datetime realted warning hadling (they now generated 
      at Field object level not in conversion functions).
        
      Optimization: Now Field class descendants use table->in_use member
      instead of current_thd macro.
      
      
      include/my_global.h:
        Added macro for reading of 32-bit ints stored in network order from
        unaligned memory location.
      include/mysqld_error.h:
        Added error-code for invalid timestamp warning and error-code
        for wrong or unknown time zone specification.
      libmysqld/Makefile.am:
        Added main per-thread time zone support file to libmysqld
      libmysqld/lib_sql.cc:
        Added initialization of time zones infrastructure to embedded server.
      mysql-test/r/connect.result:
        Updated test result since now mysql database contains more
        system tables.
      mysql-test/r/date_formats.result:
        Now when truncation occurs during conversion to datetime value we are producing Warnings 
        instead of Notes. Also we are giving more clear warnings about this in some cases.
      mysql-test/r/func_sapdb.result:
        New warnings about truncation occured during conversion to datetime value added due
        their better handling.
      mysql-test/r/func_time.result:
        New warnings about truncation occured during conversion to datetime value added due
        their better handling.
      mysql-test/r/select.result:
        New warnings about truncation occured during conversion to datetime value added due
        their better handling. Also tweaked test a bit to made it less ambigious for reader.
      mysql-test/r/system_mysql_db.result:
        Updated test result because new system tables holding time zone descriptions were 
        added.
      mysql-test/r/timezone.result:
        Updated timezone.test to use new system variable which shows system time zone.
        Added test of warning which is produced if someone tries to store non-existing (due 
        falling into spring time-gap) datetime value into TIMESTAMP field.
      mysql-test/r/type_datetime.result:
        Separated and extended test of values and warnings produced for bad values stored in 
        DATETTIME fields.
      mysql-test/r/type_time.result:
        Now we are producing more consistent warning when we are truncating datetime value while
        storing it in TIME field.
      mysql-test/r/type_timestamp.result:
        Separated and extended test of values and warnings produced for bad
        values stored in TIMESTAMP fields.
      mysql-test/t/select.test:
        Updated test to make it less ambigous for reader.
      mysql-test/t/timezone.test:
        Updated timezone.test to use new system variable which shows system time zone.
        Added test of warning which is produced if someone tries to store non-existing (due 
        falling into spring time-gap) datetime value into TIMESTAMP field.
      mysql-test/t/type_datetime.test:
        Separated and extended test of values and warnings produced for bad
        values stored in DATETTIME fields.
      mysql-test/t/type_timestamp.test:
        Separated and extended test of values and warnings produced for bad
        values stored in TIMESTAMP fields.
      scripts/mysql_create_system_tables.sh:
        Added creation of tables with time zone descriptions.
        Also added descriptions of time zones used in tests.
      scripts/mysql_fix_privilege_tables.sql:
        Added mysql.time_zone* tables family.
      sql/Makefile.am:
        Added files implementing time zone support to server, also added
        rules for building of mysql_tzinfo_to_sql converter and test_time
        test.
      sql/field.cc:
        Now we are using per-thread time zone for TIMESTAMP <-> whatever conversion.
        Fixed generation of warnings for datetime types (DATETIME/TIMESTAMP/DATE/...) and
        any other Field to datetime conversion (now we are generating warnings no in lower
        level functions like in str_to_TIME() but in Field methods. This allows generate
        better and more consistent warnings and to reuse code of str_to_TIME() outside of
        server).
        
        Added 3rd parameter to set_warning() method to be able to not increment cut fields
        but still produce a warning. Also added set_datetime_warning() family of auxiliary 
        methods which allow easier generate datetime related warnings.
        Also replaced occurences of current_thd with table->in_use member, added
        asserts for catching all places there we need to set table->in_use
        accordingly. Renamed fix_datetime() function to number_to_TIME() and
        moved it to sql/time.cc there it fits better.
      sql/field.h:
        Added comment about places where we can use table->in_use member
        instead of current_thd.
        Added 3rd parameter to Field::set_warning() method and set_datetime_warning()
        family of methods.
      sql/field_conv.cc:
        Field::set_warning() method with 2 arguments was replaced with more 
        generic set_warning() method with 3 arguments.
      sql/ha_berkeley.cc:
        Now we set table->in_use for temporary tables so we have to use
        table->tmp_table for checking if table is temporary.
      sql/item.cc:
        Replaced calls to str_to_time() and str_to_TIME() funcs with their warning
        generating analogs.
      sql/item_create.cc:
        Added creation of CONVERT_TZ function as FUNC_ARG3.
      sql/item_create.h:
        Added creation of CONVERT_TZ function as FUNC_ARG3.
      sql/item_timefunc.cc:
        Added support of per-thread time zone to NOW-like and FROM_UNIXTIME,
        UNIX_TIMESTAMP functions. 
        Added support for CONVERT_TZ function.
        Removed call to str_to_timestamp function which caused non-optimal
        behavior in certain cases. Replaced calls to str_to_time() function 
        with its warning generating analog.
      sql/item_timefunc.h:
        Added support of per-thread time zone to NOW-like and
        FROM_UNIXTIME, UNIX_TIMESTAMP functions.
        Added support of CONVERT_TZ function.
      sql/lex.h:
        Added support of CONVERT_TZ function.
      sql/log.cc:
        Added support for replication of statements depending on time zone.
      sql/mysql_priv.h:
        Now including headers with per-thread time zone support functions
        and classes. Added portable replacement of time_t - my_time_t type. 
        Added time zone as one of query distinguishing parameters for
        query cache. 
        Fixed declarations of str_to_TIME, str_to_time and 
        my_system_gmt_sec (former my_gmt_sec) since now they have one more
        out parameter which informs about wrong datetime value or data 
        truncation during conversion.
        Added warning generating version of str_to_TIME() and str_to_time()
        functions.
        Thrown away str_to_datetime/timestamp functions since they are not
        needed any longer. Added number_to_TIME function.
      sql/mysqld.cc:
        Added per-thread time zone support initialization.
        Added new startup parameter --default-time-zone.
      sql/set_var.cc:
        Added support for per-thread time_zone variable.
        Renamed old timezone variable to system_time_zone.
      sql/set_var.h:
        Added support for per-thread time_zone variable.
      sql/share/czech/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/danish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/dutch/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/english/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/estonian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/french/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/german/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/greek/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/hungarian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/italian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/japanese/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/korean/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/norwegian-ny/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/norwegian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/polish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/portuguese/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/romanian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/russian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/serbian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/slovak/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/spanish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/swedish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/ukrainian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/slave.cc:
        In order to support replication of statements using time zones in 4.1 we should 
        ensure that both master and slave have same default time zone.
      sql/sql_base.cc:
        Now we are setting TABLE::in_use member for all tables (which assume
        calls to Field::store or val_ methods).
      sql/sql_cache.cc:
        Added time zone as one more query distinguishing parameter
        for query cache.
      sql/sql_class.cc:
        Added THD::time_zone_used variable indicating that this query
        uses per thread time zone.
      sql/sql_class.h:
        Added per-thread time zone variable. Added THD::time_zone_used
        variable indicating that this query uses per thread time zone
        so if this is updating query the time zone should be logged to 
        binlog.
      sql/sql_insert.cc:
        We should set TABLE::in_use member pointing to thread which is called
        INSERT DELAYED and not to worker thread.
      sql/sql_load.cc:
        Field::set_warning() now has one more argument now.
      sql/sql_parse.cc:
        Resetting THD::time_zone_used variable in the end of query
        processing.
      sql/sql_select.cc:
        Now we are setting TABLE::in_use member for all tables (which assume
        calls to Field::store or val_ methods).
      sql/sql_show.cc:
        Now using per thread time zone for extended show tables.
      sql/time.cc:
        Added support for per-thread time zones for TIMESTAMP type and
        reworked generation of warnings for TIMESTAMP and DATETIME types.
        (Introduced new TIME_to_timestamp() function. Removed hours 
        normalisation from former my_gmt_sec() since it was not working 
        and not used anywhere now, but breaks parameter constness, added
        to this function generation of warning if we are falling in spring 
        time-gap. Removed str_to_timestamp and str_to_datetime functions 
        which are no longer used. Moved fix_datetime function from
        sql/field.cc to this file as number_to_TIME() function. Added
        out parameter for str_to_TIME and str_to_time functions which
        indicates if value was truncated during conversion, removed direct 
        generation of warnings from this functions.)
      sql/unireg.cc:
        Now we are setting TABLE::in_use member for all tables (which assume
          calls to Field::store or val_ methods).
      BitKeeper/etc/ignore:
        Added sql/test_time sql/mysql_tzinfo_to_sql libmysqld/tztime.cc to the ignore list
      6415966e
  9. 10 Jun, 2004 1 commit
    • unknown's avatar
      WL#1595 "Optionally fsync() the binlog after every statement": · 35eae8cd
      unknown authored
      New option --sync-binlog=x (and global settable variable) which will fsync the binlog
      after every x-th disk write to it. That is, if in autocommit mode, after every x-th statement
      written to the binlog; if using transactions, after every x-th transaction written to the binlog.
      x==0 means no fsync. x==1 is the slowest.
      There is no test added for this, I have just checked that it works as --sync-binlog=1 dramatically
      slows down mysqld.
      Made sync-frm a global settable variable.
      
      
      sql/log.cc:
        every sync_binlog_period-th disk binlog write, we fsync the binlog
      sql/mysql_priv.h:
        new option sync_binlog
      sql/mysqld.cc:
        new option sync_binlog
      sql/set_var.cc:
        Making sync-frm a settable global option.
        New settable global option sync-binlog.
      sql/set_var.h:
        new global settable variable sync_binlog needs a specific ::update because it needs to take LOCK_log
      35eae8cd
  10. 03 Jun, 2004 1 commit
    • unknown's avatar
      Implementation of WL#1824 "Add replication of character set variables in 4.1", · e784947a
      unknown authored
      by binlogging some SET ONE_SHOT CHARACTER_SETetc,
      which will be enough until we have it more compact and more complete in 5.0. With the present patch,
      replication will work ok between 4.1.3 master and slaves, as long as:
      - master and slave have the same GLOBAL.COLLATION_SERVER
      - COLLATION_DATABASE and CHARACTER_SET_DATABASE are not used
      - application does not use the fact that table is created with charset of the USEd db (BUG#2326).
      all of which are not too hard to fulfill. 
      ONE_SHOT is reserved for internal use of mysqlbinlog|mysql and works only for charsets,
      so we give error if used for non-charset vars.
      Fix for BUG#3875 "mysqlbinlog produces wrong ouput  if query uses
       variables containing quotes" and BUG#3943 "Queries with non-ASCII literals are not replicated
       properly after SET NAMES".
      Detecting that master and slave have different global charsets or server ids.
      
      
      mysql-test/r/rpl_server_id1.result:
        it's normal to not run as I have added a test to compare server ids of master and slave
        at startup and stop if equal (unless --replicate-same-server-id)
      mysql-test/r/rpl_user_variables.result:
        result update (as we now print charset of user var).
      mysql-test/r/user_var.result:
        result update
      mysql-test/t/rpl_server_id1.test:
        no need to select as slave is not running
      mysql-test/t/user_var.test:
        testing if the content of user vars is escaped when mysqlbinlog prints them,
        and if the name is backquoted.
      sql/lex.h:
        new keyword ONE_SHOT
      sql/log.cc:
        when writing to the binlog, before writing the actual statement, write some SET ONE_SHOT CHARACTER_SET_CLIENT etc
        for the slave to know the charset variables (which are important as they affect the inserted data).
      sql/log_event.cc:
        print charset and collation of user var in mysqlbinlog and SHOW BINLOG EVENTS.
        escape the content of the var. Backquote its name.
        Will ask Bar to check that using my_charset_bin for escaping is ok.
      sql/set_var.cc:
        understand SET CHARACTER_SET_CLIENT=10 (don't require a string, accept a number).
        Refuse changing of GLOBAL CHARACTER_SET_SERVER/COLLATION_SERVER if binlog or slave,
        as it will make the master or slave make wrong assumptions.
        A function to catch SET ONE_SHOT on non-charset variables (which is forbidden)
      sql/set_var.h:
        no_support_one_shot to know if the var supports ONE_SHOT (only charset vars do, soon timezones).
        Accept int arg in SET CHARACTER_SET_etc
      sql/slave.cc:
        when I/O slave thread starts, verify that master's and slave charsets match.
        And by the way verify that server ids are different.
        Don't fail if UNIX_TIMESTAMP() can't be done on master (very old master), that's
        not fatal.
      sql/sql_class.cc:
        one_shot
      sql/sql_class.h:
        one_shot
      sql/sql_lex.h:
        one_shot
      sql/sql_parse.cc:
        when SET ONE_SHOT is used, verify that it's only used for charset/collation vars;
        otherwise refuse.
      sql/sql_yacc.yy:
        ONE_SHOT keyword in SET
      e784947a
  11. 01 Jun, 2004 1 commit
    • unknown's avatar
      Changed --log-warnings to be integer instead of boolean. Given --skip-log-warnings · 42283b79
      unknown authored
      will disable warnings, --log-warnings will increment warning level by one, or the
      level can be given as an optional argument. Default level is 1.
      
      Changed aborted connection warning to be logged only if the level is > 1.
      
      
      sql/sql_class.h:
        Changed boolean into ulong.
      sql/sql_parse.cc:
        Changed aborted connection warning to be logged only if the level is > 1.
      42283b79
  12. 27 May, 2004 1 commit
    • unknown's avatar
      WL#1163 (Make spatial code separable for other parts) · f2a53248
      unknown authored
      --with-geometry and
      --with-embedded-privilege-control
      configure switches added
      
      
      acconfig.h:
        necessary lines added
      myisam/mi_open.c:
        #include added
      mysql-test/t/gis-rtree.test:
        test modified to take HAVE_GEOMETRY in account
      mysql-test/t/gis.test:
        test modified to take HAVE_GEOMETRY in account
      sql/mysql_priv.h:
        option's variables added
      sql/mysqld.cc:
        option's handling added
      sql/set_var.cc:
        option's descriptions added
      f2a53248
  13. 25 May, 2004 1 commit
    • unknown's avatar
      Added tests for archive. Cleaned up a merge mistake and added some information... · e98e4d3e
      unknown authored
      Added tests for archive. Cleaned up a merge mistake and added some information on how well archive compresses. 
      
      
      sql/examples/ha_archive.cc:
        Added in example information from testing archive with Slashdot's comments.
      sql/handler.h:
        Fixed broken merge.
      sql/set_var.cc:
        Adding in "have_archive" to variables shown to make tests work.
      e98e4d3e
  14. 24 May, 2004 1 commit
    • unknown's avatar
      New MYSQL_SERVER_SUFFIX usage (for easier compilation) · 072d1044
      unknown authored
      Update of VC++ project files.
      
      
      VC++Files/mysqlmanager/childfrm.cpp:
        Rename: VC++Files/mysqlmanager/CHILDFRM.CPP -> VC++Files/mysqlmanager/childfrm.cpp
      VC++Files/mysqlmanager/childfrm.h:
        Rename: VC++Files/mysqlmanager/CHILDFRM.H -> VC++Files/mysqlmanager/childfrm.h
      VC++Files/mysqlmanager/mainfrm.cpp:
        Rename: VC++Files/mysqlmanager/MAINFRM.CPP -> VC++Files/mysqlmanager/mainfrm.cpp
      VC++Files/mysqlmanager/mainfrm.h:
        Rename: VC++Files/mysqlmanager/MAINFRM.H -> VC++Files/mysqlmanager/mainfrm.h
      VC++Files/mysqlmanager/mysqlmanager.dsp:
        Rename: VC++Files/mysqlmanager/MySqlManager.dsp -> VC++Files/mysqlmanager/mysqlmanager.dsp
      VC++Files/mysqlmanager/mysqlmanager.mak:
        Rename: VC++Files/mysqlmanager/MySqlManager.mak -> VC++Files/mysqlmanager/mysqlmanager.mak
      VC++Files/mysqlmanager/resource.h:
        Rename: VC++Files/mysqlmanager/RESOURCE.H -> VC++Files/mysqlmanager/resource.h
      VC++Files/mysqlmanager/stdafx.cpp:
        Rename: VC++Files/mysqlmanager/STDAFX.CPP -> VC++Files/mysqlmanager/stdafx.cpp
      VC++Files/mysqlmanager/stdafx.h:
        Rename: VC++Files/mysqlmanager/STDAFX.H -> VC++Files/mysqlmanager/stdafx.h
      VC++Files/mysqlmanager/toolsql.cpp:
        Rename: VC++Files/mysqlmanager/TOOLSQL.CPP -> VC++Files/mysqlmanager/toolsql.cpp
      VC++Files/mysqlmanager/toolsql.h:
        Rename: VC++Files/mysqlmanager/TOOLSQL.H -> VC++Files/mysqlmanager/toolsql.h
      VC++Files/mysqlmanager/RES/bitmap1.bmp:
        Rename: VC++Files/mysqlmanager/RES/BITMAP1.BMP -> VC++Files/mysqlmanager/RES/bitmap1.bmp
      VC++Files/mysqlmanager/RES/bitmap3.bmp:
        Rename: VC++Files/mysqlmanager/RES/BITMAP3.BMP -> VC++Files/mysqlmanager/RES/bitmap3.bmp
      VC++Files/mysqlmanager/RES/bmp00001.bmp:
        Rename: VC++Files/mysqlmanager/RES/BMP00001.BMP -> VC++Files/mysqlmanager/RES/bmp00001.bmp
      VC++Files/mysqlmanager/RES/bmp00002.bmp:
        Rename: VC++Files/mysqlmanager/RES/BMP00002.BMP -> VC++Files/mysqlmanager/RES/bmp00002.bmp
      VC++Files/mysqlmanager/RES/database.bmp:
        Rename: VC++Files/mysqlmanager/RES/DATABASE.BMP -> VC++Files/mysqlmanager/RES/database.bmp
      VC++Files/mysqlmanager/RES/fontd.bmp:
        Rename: VC++Files/mysqlmanager/RES/FONTD.BMP -> VC++Files/mysqlmanager/RES/fontd.bmp
      VC++Files/mysqlmanager/RES/fontu.bmp:
        Rename: VC++Files/mysqlmanager/RES/FONTU.BMP -> VC++Files/mysqlmanager/RES/fontu.bmp
      VC++Files/mysqlmanager/RES/query_ex.bmp:
        Rename: VC++Files/mysqlmanager/RES/QUERY_EX.BMP -> VC++Files/mysqlmanager/RES/query_ex.bmp
      VC++Files/mysqlmanager/RES/toolbar.bmp:
        Rename: VC++Files/mysqlmanager/RES/TOOLBAR.BMP -> VC++Files/mysqlmanager/RES/toolbar.bmp
      BUILD/compile-pentium-valgrind-max:
        Use MYSQL_SERVER_SUFFIX
      VC++Files/bdb/bdb.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysql.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqladmin.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqldump.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqlimport.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/client/mysqlshow.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/copy_mysql_files.bat:
        Assume we are in correct directory
      VC++Files/innobase/innobase.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
        Remove old files
      VC++Files/isamchk/isamchk.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/libmysqld/libmysqld.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/my_print_defaults/my_print_defaults.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/myisamchk/myisamchk.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/myisamlog/myisamlog.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/myisampack/myisampack.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysql.dsw:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysqlbinlog/mysqlbinlog.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysqlcheck/mysqlcheck.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/mysys/mysys.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/pack_isam/pack_isam.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/perror/perror.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/replace/replace.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      VC++Files/sql/mysqld.dsp:
        Use new version of MYSQL_SERVER_SUFFIX
      include/my_global.h:
        Added QUOTE and STRINGIFY
      include/mysql_version.h.in:
        New MYSQL_SERVER_SUFFIX handling
      innobase/eval/eval0eval.c:
        Fixed compiler warning
      libmysql/libmysql.c:
        Use STRINGIFY()
      sql/mysqld.cc:
        New MYSQL_SERVER_SUFFIX handling
      sql/mysqld_suffix.h:
        New MYSQL_SERVER_SUFFIX handling
      sql/set_var.cc:
        Use STRINGIFY()
      zlib/contrib/asm386/zlibvc.dsp:
        Updated for 4.0
      072d1044
  15. 19 May, 2004 3 commits
    • unknown's avatar
      Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt' · 0178851c
      unknown authored
      Ensured that all projects compile
      Removed compiler warnings
      Better setting of server_version variable.
      Fix that make_win_src_distribution creates the privilege tables.
      
      
      VC++Files/bdb/bdb.dsp:
        Small, automatic changes
      VC++Files/client/mysql.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqladmin.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqlclient.dsp:
        Removed files that should only be used with mysql command line client
      VC++Files/client/mysqldump.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqlimport.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/client/mysqlshow.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/comp_err/comp_err.dsp:
        Automatic changes
      VC++Files/dbug/dbug.dsp:
        Automatic changes
      VC++Files/heap/heap.dsp:
        automatic changes
      VC++Files/innobase/innobase.dsp:
        Automatic changes
      VC++Files/isam/isam.dsp:
        Automatic changes
      VC++Files/isamchk/isamchk.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/libmysql/libmysql.dsp:
        Automatic changes
      VC++Files/libmysqld/examples/test_libmysqld.dsp:
        Add missing files
      VC++Files/libmysqld/libmysqld.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/libmysqltest/myTest.dsp:
        Automatic changes
      VC++Files/merge/merge.dsp:
        Automatic changes
      VC++Files/my_print_defaults/my_print_defaults.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisam/myisam.dsp:
        automatic changes
      VC++Files/myisam_ftdump/myisam_ftdump.dsp:
        automatic changes
      VC++Files/myisamchk/myisamchk.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisamlog/myisamlog.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisammrg/myisammrg.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/myisampack/myisampack.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysql.dsw:
        Automatic changes
      VC++Files/mysqlbinlog/mysqlbinlog.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysqlcheck/mysqlcheck.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysqldemb/mysqldemb.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/mysqlserver/mysqlserver.dsp:
        Automatic changes
      VC++Files/mysqlshutdown/mysqlshutdown.dsp:
        Automatic changes
      VC++Files/mysqlwatch/mysqlwatch.dsp:
        Automatic changes
      VC++Files/mysys/mysys.dsp:
        Automatic changes
      VC++Files/pack_isam/pack_isam.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/perror/perror.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/regex/regex.dsp:
        Automatic changes
      VC++Files/replace/replace.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/sql/mysqld.dsp:
        Added support for projects 'classic', 'classic nt', 'pro' and 'pro nt'
      VC++Files/strings/strings.dsp:
        Removed duplicate code for strnlen
      VC++Files/test1/test1.dsp:
        Automatic changes
      VC++Files/thr_test/thr_test.dsp:
        Automatic changes
      VC++Files/vio/vio.dsp:
        Automatic changes
      VC++Files/zlib/contrib/asm386/zlibvc.dsp:
        Automatic changes
      VC++Files/zlib/zlib.dsp:
        Automatic changes
      extra/my_print_defaults.c:
        Fixed bug in --verbose
      include/m_string.h:
        Portability fix
      include/mysql_embed.h:
        Better setting of server_version variable
      include/mysql_version.h.in:
        Better license text handling
      innobase/pars/pars0lex.l:
        Remove compiler warnings
      innobase/trx/trx0sys.c:
        Remove compiler warnings
      libmysqld/lib_sql.cc:
        Better setting of server_version variable
      libmysqld/libmysqld.def:
        Add functions needed for mysql command line client
      myisam/myisam_ftdump.c:
        Remove compiler warnings
      mysys/sha1.c:
        Remove compiler warnings
      scripts/make_win_src_distribution.sh:
        Safety fix
      scripts/mysql_install_db.sh:
        Backport from 4.1 to allow make_win_src_distribution create the privilege tables
      sql/Makefile.am:
        Add new file mysqld_suffix.h
        Remove not used file sql_olap.h
      sql/ha_innodb.cc:
        Remove not used variable
      sql/mysqld.cc:
        Better setting of server_version variable
      sql/set_var.cc:
        Fixed bug when showing lower_case_file_system
      strings/ctype-tis620.c:
        Remove compiler warnings
      0178851c
    • unknown's avatar
      Fix for BUG#3829 "Setting server_id on fly doesn't allow replication to start" · bf47ff08
      unknown authored
      (fix by our Harrison Fisk): when one does SET GLOBAL SERVER_ID=x, we must set
      server_id_supplied to 1.
      
      
      sql/mysql_priv.h:
        server_id_supplied must be here to be visible in set_var.cc
      sql/mysqld.cc:
        rephrasing warnings when server id is not set explicitely.
      sql/set_var.cc:
        when one does SET GLOBAL SERVER_ID=x; it should be considered as explicitely setting
        the server id, so do server_id_supplied=1.
      sql/slave.cc:
        Correcting wrong comment
      bf47ff08
    • unknown's avatar
      Fix for Bug#3754 "SET GLOBAL myisam_max_sort_file_size doesn't · b7a0883c
      unknown authored
      work as expected": precision-losing conversion removed from 
      sys_var_thd_ulonglong.
      
      
      mysql-test/r/variables.result:
        Test case for Bug#3754
      mysql-test/t/variables.test:
        Test case for Bug#3754
      sql/set_var.cc:
        Fix for Bug#3754: precision-losing conversion removed from 
        sys_var_thd_ulonglong.
      b7a0883c
  16. 06 May, 2004 2 commits
    • unknown's avatar
      Fixed (portability) bug in handler.h, and tried to silence cast warnings on some platforms. · b220b976
      unknown authored
      sql/handler.h:
        Fixed (portability) bug. No qualified method names in the class definition.
      sql/item_cmpfunc.h:
        Attempt to silence cast warnings on some platforms.
      sql/item_subselect.h:
        Attempt to silence cast warnings on some platforms.
      sql/set_var.cc:
        Silence warning (missing cast).
      sql/spatial.h:
        Attempt to silence cast warnings on some platforms.
      sql/sql_cache.cc:
        Silence warning (wrong cast).
      sql/sql_lex.h:
        Attempt to silence cast warnings on some platforms.
      b220b976
    • unknown's avatar
      Windows VC++ compability fix · e7752b7b
      unknown authored
      sql/set_var.cc:
        Fix VC++ compiler error
      e7752b7b
  17. 01 May, 2004 1 commit
  18. 27 Apr, 2004 1 commit
    • unknown's avatar
      After merge fixes · 6fdb9848
      unknown authored
      Changed 'SHOW FIELD STATUS' to use 'Engine' instead of 'Type'
      
      
      client/client_priv.h:
        Added option 'create_options' for mysqldump
      client/mysqldump.c:
        Changed '--all' to '--create-options' as the old name was meaningless
      innobase/buf/buf0buf.c:
        After merge fixes
      innobase/buf/buf0lru.c:
        After merge fixes
      innobase/buf/buf0rea.c:
        After merge fixes
      innobase/dict/dict0load.c:
        After merge fixes
      innobase/fil/fil0fil.c:
        After merge fixes
      innobase/ibuf/ibuf0ibuf.c:
        After merge fixes
      innobase/include/fil0fil.h:
        After merge fixes
      innobase/include/row0mysql.h:
        After merge fixes
      innobase/include/ut0mem.h:
        After merge fixes
      innobase/log/log0recv.c:
        After merge fixes
      innobase/row/row0mysql.c:
        After merge fixes
      innobase/row/row0sel.c:
        After merge fixes
      innobase/srv/srv0start.c:
        After merge fixes
      innobase/sync/sync0rw.c:
        After merge fixes
      innobase/sync/sync0sync.c:
        After merge fixes
      myisam/ft_boolean_search.c:
        After merge fixes
      myisam/ft_nlq_search.c:
        After merge fixes
      mysql-test/r/mysqldump.result:
        After merge fixes
      mysql-test/t/mysqldump.test:
        Make result file smaller
        Some new tests
      sql/ha_innodb.cc:
        After merge fixes
      sql/set_var.cc:
        Removed compiler warning
      sql/slave.cc:
        After merge fixes
      sql/slave.h:
        After merge fixes
      sql/sql_show.cc:
        Type -> Engine
      6fdb9848
  19. 15 Apr, 2004 1 commit
    • unknown's avatar
      Added NDB storage engine · 31bbe692
      unknown authored
      include/my_base.h:
        Added three new errorcodes to be returned by the handler
      sql/Makefile.am:
        Add new files discover.cc, ha_ndbcluster.cc and ha_ndbcluster.h
        Add include path of NDB files
      sql/handler.cc:
        Added variable for keeping track of number of "discovers"
        Added NDB to list of storage engines
        Added calls to NDB for commit, rollback etc.
        Added function ha_discover for discovering a table from handler
      sql/handler.h:
        Added NDB to list of storage engines
        Added vbariable in transaction for keeping a ndb transaction handle
      sql/lex.h:
        Changed AND to AND_SYM and OR to OR_SYM to avoid nameclash
      sql/mysql_priv.h:
        Added prototypes for new functions readfrm, writefrm and create_table_from_handler
      sql/mysqld.cc:
        Added NDB support
        Disable NDB with --skip-ndbcluster
      sql/set_var.cc:
        Add posibilty to show if NDB handler is supported
      sql/ha_ndbcluster.cc:
        Add ifdef for whole file for not compiling anything if NDB sholdn't be included
        Updated timestamp handling to use new vars timestamp_default_now and timestamp_on_update_now
      sql/sql_base.cc:
        If frm file is not found on disk, ask handler if it knows about the table. Then retry the open.
        This new functionality is called "discover" and can be used by any handler.
      sql/sql_class.h:
        Added variable for keeping a NDB connection handle
      sql/sql_table.cc:
        Before trying to create a table, ask handler if a table with that name already exists.
        If user said CREATE TABLE IF NOT EXISTS, disocver the table from handler
      sql/sql_yacc.yy:
        Add NDBCLUSTER_SYM
        Change AND to AND_SYM
        Change OR to OR_SYM
      sql/table.cc:
        Fixe for probelm when NullS is returned from bas_ext of a handler.
      31bbe692
  20. 09 Apr, 2004 2 commits
    • unknown's avatar
      after review PS fixes · 77330300
      unknown authored
      sql/item_cmpfunc.cc:
        merged in one if
      sql/mysql_priv.h:
        removed unused paremeter of check_one_table_access
        declaration of new function for SP share code
      sql/set_var.cc:
        function descriotion added
        unneeded parantses removed
      sql/sql_acl.cc:
        new parameter to limit number of checked tables for check_grant
      sql/sql_acl.h:
        new parameter to limit number of checked tables for check_grant
      sql/sql_delete.cc:
        preparation moved in separate function
      sql/sql_insert.cc:
        preparation moved in separate function
      sql/sql_lex.cc:
        comment style fixed
        unneeded assignment removed
      sql/sql_parse.cc:
        new parameter to limit number of checked tables for check_grant
        table list manipulation removed (because of above)
        new precheck function
      sql/sql_prepare.cc:
        function rewrited to shere code with sql_prepare.cc
        flow control fixed
      sql/sql_show.cc:
        new parameter to limit number of checked tables for check_grant
      sql/sql_update.cc:
        preparation moved in separate function
      sql/table.h:
        flag renamed
      77330300
    • unknown's avatar
  21. 07 Apr, 2004 2 commits
    • unknown's avatar
      new error for unsupported command in PS · 9802b134
      unknown authored
      fixed IN subselect with basic constant left expression
      SQLCOM_CREATE_TABLE, SQLCOM_UPDATE_MULTI, SQLCOM_REPLACE_SELECT, SQLCOM_INSERT_SELECT, QLCOM_DELETE_MULTI fixed to be compatible with PS (BUG#3398, BUG#3406)
      fixed multiupdate privelege check (BUG#3408)
      fixed multiupdate tables check (BUG#3411)
      unchecked commands now is rejected by PS protocol to avoid serever crash
      fixed cleunup procedure to be compatible sith DO/SET (BUG#3393)
      
      
      include/mysqld_error.h:
        new error for unsupported command in PS
      mysql-test/r/multi_update.result:
        test sutes (BUG#3408, BUG#3411)
      mysql-test/t/multi_update.test:
        test sutes (BUG#3408, BUG#3411)
      sql/item_cmpfunc.cc:
        fixed IN subselect with basic constant left expression
      sql/mysql_priv.h:
        some function frop sql_parse.h become public
      sql/set_var.cc:
        check for SET command via PS
      sql/set_var.h:
        check for SET command via PS
      sql/share/czech/errmsg.txt:
        new error for unsupported command in PS
      sql/share/danish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/dutch/errmsg.txt:
        new error for unsupported command in PS
      sql/share/english/errmsg.txt:
        new error for unsupported command in PS
      sql/share/estonian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/french/errmsg.txt:
        new error for unsupported command in PS
      sql/share/german/errmsg.txt:
        new error for unsupported command in PS
      sql/share/greek/errmsg.txt:
        new error for unsupported command in PS
      sql/share/hungarian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/italian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/japanese/errmsg.txt:
        new error for unsupported command in PS
      sql/share/korean/errmsg.txt:
        new error for unsupported command in PS
      sql/share/norwegian-ny/errmsg.txt:
        new error for unsupported command in PS
      sql/share/norwegian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/polish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/portuguese/errmsg.txt:
        new error for unsupported command in PS
      sql/share/romanian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/russian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/serbian/errmsg.txt:
        new error for unsupported command in PS
      sql/share/slovak/errmsg.txt:
        new error for unsupported command in PS
      sql/share/spanish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/swedish/errmsg.txt:
        new error for unsupported command in PS
      sql/share/ukrainian/errmsg.txt:
        new error for unsupported command in PS
      sql/sql_lex.cc:
        first table unlincking procedures for CREATE command
      sql/sql_lex.h:
        first table unlincking procedures for CREATE command
      sql/sql_parse.cc:
        used function to exclude first table from list
        SQLCOM_CREATE_TABLE, SQLCOM_UPDATE_MULTI, SQLCOM_REPLACE_SELECT, SQLCOM_INSERT_SELECT, QLCOM_DELETE_MULTI fixed to be compatible with PS (BUG#3398, BUG#3406)
        fixed multiupdate privelege check (BUG#3408)
        fixed multiupdate tables check (BUG#3411)
      sql/sql_prepare.cc:
        fixed a lot of commands to be compatible with PS
        unchecked commands now is rejected to avoid serever crash
      sql/sql_select.cc:
        allow empty result for PS preparing
      sql/sql_union.cc:
        fixed cleunup procedure to be compatible sith DO/SET (BUG#3393)
      sql/sql_update.cc:
        fixed update to use correct tables lists (BUG#3408)
      sql/table.h:
        flag to support multi update tables check (BUG#3408)
      tests/client_test.c:
        removed unsupported tables
        fixed show table test
        added new tests
      9802b134
    • unknown's avatar
      75e208ee
  22. 05 Apr, 2004 1 commit
    • unknown's avatar
      Fixed many compiler warnings · 3a0254a6
      unknown authored
      Fixed bugs in group_concat with ORDER BY and DISTINCT (Bugs #2695, #3381 and #3319)
      Fixed crash when doing rollback in slave and the io thread catched up with the sql thread
      Set locked_in_memory properly
      
      
      include/mysql_com.h:
        Fixed compiler warning
      libmysqld/emb_qcache.cc:
        Removed not used variable
      libmysqld/lib_sql.cc:
        Removed not used variable
      myisam/mi_locking.c:
        Added comment
      myisam/mi_rnext.c:
        Fixed bug in concurrent insert
      myisam/mi_rprev.c:
        Simple optimization
      mysql-test/r/func_gconcat.result:
        New tests
      mysql-test/t/func_gconcat.test:
        New tests
      mysql-test/t/func_group.test:
        Cleanup
      sql-common/client.c:
        Removed compiler warning
      sql/derror.cc:
        Better comments
      sql/field.cc:
        Removed not used function/variable
      sql/field.h:
        Removed not needed variable
      sql/ha_innodb.cc:
        Removed not used function
      sql/item.cc:
        Fixed compiler warning
      sql/item_cmpfunc.cc:
        Fixed compiler warning
      sql/item_func.cc:
        Fixed compiler warning
      sql/item_geofunc.cc:
        Fixed compiler warning
      sql/item_sum.cc:
        Fixed bugs in group_concat and added more comments
        (Bugs #2695, #3381 and #3319)
        - field->abs_offset was not needed
        - Wrong assumption of field order in temporary table
        - Some not used variables removed
        - Added ORDER BY fields after argument fields so that code in sql_select.cc can move all fields to point to temporary tables, if needed.
        - Optimized loops
      sql/item_sum.h:
        Bug fixing and cleanup of group_concat()
      sql/log.cc:
        Removed wrong comment
      sql/log_event.cc:
        Removed compiler warning
      sql/mysqld.cc:
        Set locked_in_memory properly
      sql/protocol.cc:
        Removed compiler warning
      sql/set_var.cc:
        Code cleanup
      sql/slave.cc:
        Fixed crash when doing rollback in slave and the io thread catched up with the sql thread
      sql/sql_cache.cc:
        Removed compiler warnings
      sql/sql_derived.cc:
        Removed not used variable
      sql/sql_insert.cc:
        Removed compiler warnings
      sql/sql_lex.cc:
        Removed not used lable
      sql/sql_lex.h:
        Removed compiler warnings
      sql/sql_parse.cc:
        Removed compiler warnings
      sql/sql_prepare.cc:
        Removed compiler warnings
      sql/sql_select.cc:
        Removed not used variables
        Added function comments
      sql/sql_show.cc:
        Removed compiler warnings
      sql/sql_yacc.yy:
        Fix for ORDER BY handling in GROUP_CONCAT()
      3a0254a6
  23. 03 Apr, 2004 1 commit
    • unknown's avatar
      BUG#3328 · f093ea1c
      unknown authored
      I can't see group_concat_max_len in a list of variables
      
      
      sql/set_var.cc:
        add sys_group_concat_max_len.name
      f093ea1c
  24. 29 Mar, 2004 1 commit
  25. 27 Mar, 2004 1 commit
    • unknown's avatar
      A previous changeset by me today about SQL_LOG_BIN had the problem · dcb14d22
      unknown authored
      that it tested the privilege in ::update() whereas it should be
      in ::check() (see email from Serg, subject
      "Re: bk commit - 4.1 tree (guilhem:1.1706)").
      So I add instead a check_func function to sys_var_thd_bit.
      I do the same addition to sys_var_thd_ulong, to unify handling
      of PSEUDO_THREAD_ID with the one of SQL_LOG_BIN. So class
      sys_var_pseudo_thread_id is not needed anymore, removing it.
      
      
      mysql-test/r/rpl_temporary.result:
        result update
      mysql-test/t/rpl_temporary.test:
        tests after new way of fixing; verify that when second variable
        assignment is refused then first is not done.
      sql/set_var.cc:
        a check_func (check_log_update) when setting SQL_LOG_BIN,
        and one when setting PSEUDO_THREAD_ID.
        Removing class sys_var_pseudo_thread_id.
        Updates for new prototypes of constructor in sys_var_thd_bit
        and sys_var_thd_ulong.
      sql/set_var.h:
        Adding check_func to sys_var_thd_bit.
        Adding check_func to sys_var_thd_ulong, so class sys_var_pseudo_thread_id
        is not needed anymore, removing it.
      dcb14d22
  26. 26 Mar, 2004 1 commit
    • unknown's avatar
      Changing SET SQL_LOG_BIN so that it explicitely throws an error if · 9b450d44
      unknown authored
      user is not SUPER, instead of setting the value but ignoring it
      silently internally.
      
      
      mysql-test/r/rpl_temporary.result:
        result update
      mysql-test/t/rpl_temporary.test:
        adding test for privileges for SET SQL_LOG_BIN
      sql/log.cc:
        don't need to check SUPER
      sql/set_var.cc:
        refuse SET SQL_LOG_BIN if not SUPER
      sql/sql_insert.cc:
        Don't need to check SUPER
      9b450d44
  27. 25 Mar, 2004 1 commit
  28. 20 Mar, 2004 2 commits
    • unknown's avatar
      more sys_var_str fixes · bec195aa
      unknown authored
      mysql-test/r/variables.result:
        more tests
      mysql-test/t/variables.test:
        more tests
      sql/set_var.cc:
        don't crash on NULL
      bec195aa
    • unknown's avatar
      select @@smth=@@sys_str_var crash fixed · 1af8bd5a
      unknown authored
      mysql-test/r/variables.result:
        new test
      mysql-test/t/ctype_utf8.test:
        typos fixed
      mysql-test/t/variables.test:
        new test
      sql/mysqld.cc:
        sys_str_var->value must be not NULL
      sql/set_var.cc:
        initialize sys_str_var->value from a constructor
      sql/set_var.h:
        initialize sys_str_var->value from a constructor
      1af8bd5a
  29. 17 Mar, 2004 1 commit
    • unknown's avatar
      WL #1510 "Implement support for "commercial" binaries on handshake", · 1b8f0058
      unknown authored
      client library:
      - implemented 'check_license' function
      
      
      include/errmsg.h:
        WL #1510: new error code
      include/mysql_version.h.in:
        WL #1510: fallback define for LICENSE
      libmysql/errmsg.c:
        WL #1510: error message to print in case when client and server license 
        mismatch.
      libmysql/libmysql.c:
        WL#1510: implementation of 'check_license' function
      sql/set_var.cc:
        removed unused variable 'license'
      1b8f0058
  30. 11 Mar, 2004 2 commits
    • unknown's avatar
      Fix for BUG#2921 "Replication problem on mutex lock in mySQL-4.0.18": · 92fe7556
      unknown authored
      re-using unused LOCK_active_mi to serialize all administrative
      commands related to replication:
      START SLAVE, STOP SLAVE, RESET SLAVE, CHANGE MASTER, init_slave()
      (replication autostart at server startup), end_slave() (replication
      autostop at server shutdown), LOAD DATA FROM MASTER.
      This protects us against a handful of deadlocks (like BUG#2921
      when two START SLAVE, but when two STOP SLAVE too).
      Removing unused variables.
      
      
      sql/item_func.cc:
        We don't need LOCK_active_mi just to MASTER_POS_WAIT().
      sql/repl_failsafe.cc:
        no need for macro
      sql/set_var.cc:
        no need for macro
      sql/slave.cc:
        Re-using unused LOCK_active_mi to serialize all administrative
        commands related to replication:
        START SLAVE, STOP SLAVE, RESET SLAVE, CHANGE MASTER, init_slave()
        (replication autostart at server startup), end_slave() (replication
        autostop at server shutdown), LOAD DATA FROM MASTER.
        This protects us against a handful of deadlocks.
        Removing unused variables.
      sql/slave.h:
        Re-using LOCK_active_mi to serialize administrative replication commands.
        Macros unneeded. Removing unneeded variables.
      sql/sql_parse.cc:
        found unused variable.
        Replacing macros.
      sql/sql_show.cc:
        replacing macros
      92fe7556
    • unknown's avatar
      Small fixes. · e6270d31
      unknown authored
      client/mysqlbinlog.cc:
        Patched patch for Bug#2491.
      sql/set_var.cc:
        Added max_insert_delayed_threads into 'SHOW VARIABLES'.
      e6270d31
  31. 08 Mar, 2004 2 commits
    • unknown's avatar
      Reapply change after merge. · 53d4a566
      unknown authored
      53d4a566
    • unknown's avatar
      Make SHOW VARIABLES output really alphabetic. · 63682d0d
      unknown authored
      Note: the patch removes an extra declaration of
      the read_only variable. It also assumes that '_'
      sorts before [a-z].
      
      
      mysql-test/r/fulltext_var.result:
        Fix test result to account for SHOW VARIABLES
        output reordering.
      sql/set_var.cc:
        Make SHOW VARIABLES output really alphabetic.
      63682d0d
  32. 07 Mar, 2004 1 commit