An error occurred fetching the project authors.
  1. 02 Nov, 2005 1 commit
    • unknown's avatar
      found problem removed · d419281c
      unknown authored
      sql/sql_parse.cc:
        allow query_tables_own_last work correctly
      sql/table.cc:
        fixed returning value for libmysqld
      d419281c
  2. 31 Oct, 2005 1 commit
    • unknown's avatar
      postreview fixes · 672f2412
      unknown authored
      sql/item_func.cc:
        some optimisation
      sql/sql_acl.cc:
        some optimisation
      sql/sql_base.cc:
        some optimisation
      sql/sql_parse.cc:
        some optimisation
      sql/table.cc:
        some optimisation
      672f2412
  3. 27 Oct, 2005 2 commits
    • unknown's avatar
      fixe of typos, comments & layout · 03cafab5
      unknown authored
      sql/item_func.cc:
        fixed typo
      sql/sql_acl.cc:
        comment fixed
      sql/sql_parse.cc:
        comment fixed
      sql/sql_view.cc:
        layout fixed
      sql/table.cc:
        typo fixed
        layout fixed
      sql/table.h:
        typo fixed
      03cafab5
    • unknown's avatar
      support of view underlying tables and SP functions security check added (BUG#9505) (WL#2787) · 9c6c527c
      unknown authored
      mysql-test/r/information_schema.result:
        error message changed
      mysql-test/r/sp.result:
        error message changed
      mysql-test/r/sql_mode.result:
        fixed test suite
      mysql-test/r/view.result:
        error message changed
      mysql-test/r/view_grant.result:
        test of underlying view tables check
      mysql-test/t/sql_mode.test:
        fixed test suite
      mysql-test/t/view_grant.test:
        test of underlying view tables check
      sql/item.cc:
        check of underlying tables privilege added
      sql/item.h:
        Name the resolution context points to the security  context of view (if item belong to the view)
      sql/item_func.cc:
        a view error hiding for execution of prepared function belonged to a view
        fixed checking privileges if stored functions belonds to some view
      sql/mysql_priv.h:
        refult of derived table processing functions changed to bool
        Security_context added as an argument to find_field_in_table()
      sql/share/errmsg.txt:
        error message fixed
      sql/sql_acl.cc:
        Storing requested privileges of tables added
        View underlying tables privilege check added
      sql/sql_base.cc:
        View underlying tables privilege check added
      sql/sql_cache.cc:
        Code cleunup: we should not register underlying tables of view second time
      sql/sql_delete.cc:
        ancestor -> merge_underlying_list renaming
      sql/sql_derived.cc:
        refult of derived table processing functions changed to bool
        do not give SELECT_ACL for TEMPTABLE views
      sql/sql_lex.h:
        The comment added
      sql/sql_parse.cc:
        registration of requested privileges added
      sql/sql_prepare.cc:
        registration of requested privileges added
      sql/sql_update.cc:
        manipulation of requested privileges for underlying tables made the same as for table which we are updating
      sql/sql_view.cc:
        underlying tables of view security check support added
      sql/table.cc:
        renaming and fixing view preparation methods, methods for checking underlyoing tables security context added
      sql/table.h:
        storege for reuested privileges added
      9c6c527c
  4. 21 Oct, 2005 1 commit
    • unknown's avatar
      fix for bug#14089 FROM list subquery always fails when · cb76c37b
      unknown authored
                        information_schema is current database
        skip the check of I_S tables if table is derived table
      
      
      mysql-test/r/information_schema.result:
        fix for bug#14089 FROM list subquery always fails when 
                          information_schema is current database
          test case
      mysql-test/t/information_schema.test:
        fix for bug#14089 FROM list subquery always fails when 
                          information_schema is current database
          test case
      cb76c37b
  5. 19 Oct, 2005 1 commit
    • unknown's avatar
      A fix and a test case for Bug#13587 "Server crash when SP is created · 9a5dd3b4
      unknown authored
      without database"
      
      
      mysql-test/r/sp-error.result:
        Test results fixed (a test case for Bug#13587)
      mysql-test/t/sp-error.test:
        A test case for Bug#13587 "Server crash when SP is created without 
        database"
      sql/sql_parse.cc:
        - move initialization of lex->sphead->m_db before it's used.
        - cleanup; comment why right now can't be cleaned any more
      9a5dd3b4
  6. 13 Oct, 2005 1 commit
    • unknown's avatar
      BUG#13343 CREATE|etc TRIGGER|VIEW|USER don't commit the transaction (inconsistency) · aa3cd970
      unknown authored
      Updated more DDL statements to cause implicit commit.
      
      
      mysql-test/r/rpl_ddl.result:
        updated results to test for implicit commit for:
        CREATE OR REPLACE VIEW
        ALTER VIEW
        DROP VIEW
        CREATE TRIGGER
        DROP TRIGGER
        CREATE USER
        RENAME USER
        DROP USER
      mysql-test/t/rpl_ddl.test:
        updated results to test for implicit commit for:
        CREATE OR REPLACE VIEW
        ALTER VIEW
        DROP VIEW
        CREATE TRIGGER
        DROP TRIGGER
        CREATE USER
        RENAME USER
        DROP USER
      sql/sql_parse.cc:
        added implicit commit for:
        CREATE OR REPLACE VIEW
        ALTER VIEW
        DROP VIEW
        CREATE TRIGGER
        DROP TRIGGER
        CREATE USER
        RENAME USER
        DROP USER
      aa3cd970
  7. 12 Oct, 2005 1 commit
    • unknown's avatar
      after merge fix · 6223fcd8
      unknown authored
      config/ac-macros/yassl.m4:
        added HAVE_YASSL variable
      sql/mysqld.cc:
        added HAVE_YASSL define
      6223fcd8
  8. 11 Oct, 2005 2 commits
    • unknown's avatar
      Reviewing new pushed code · d6ccd7c7
      unknown authored
      - CHAR() now returns binary string as default
      - CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
      - Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        (Some old systems returns ETIME and it's safer to test for both values
         than to try to write a wrapper for each old system)
      - Fixed new introduced bug in NOT BETWEEN X and X
      - Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      - Use octet2hex() for all conversion of string to hex
      - Simplify and optimize code
      
      
      client/mysqldump.c:
        Simple optimizations of new code
        Indentation fixes
      client/mysqltest.c:
        Removed not needed variable
      include/mysql_com.h:
        Made octec2hex() more usable
      mysql-test/r/ctype_utf8.result:
        CHAR() now returns binary string as default
      mysql-test/r/func_str.result:
        CHAR() now returns binary string as default
      mysql-test/r/range.result:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/r/user_var-binlog.result:
        CHAR() now returns binary string as default
      mysql-test/r/view.result:
        More tests of view rename
      mysql-test/t/ctype_utf8.test:
        CHAR() now returns binary string as default
      mysql-test/t/func_str.test:
        CHAR() now returns binary string as default
      mysql-test/t/range.test:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/t/view.test:
        More tests of view rename
      mysys/mf_keycache.c:
        Indentation changes
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/my_os2cond.c:
        Fix to MySQL coding style
        Optimized functions
      mysys/thr_lock.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/thr_mutex.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/instance.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/thread_registry.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/ha_federated.cc:
        Use octet2hex()
      sql/ha_ndbcluster.cc:
        Removed not used variable
      sql/handler.cc:
        Simplify code
        Use *NONE* instead of 'none' for not existing storage engine
        Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      sql/item.h:
        Remove not needed test for *ref.  (If ref is set, it should never point at 0)
      sql/item_func.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        Simplify code
        More comments
        Require that last argument to find_and_check_access() is given
        (Made code shorter and faster)
      sql/item_strfunc.cc:
        Changed CHAR() to return result in binary collation
        CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
        
        Bar will shortly add the following syntax:
        CHAR(.... USING character_set)
        and ensure that
        CONVERT(CHAR(....) USING utf8) cuts not legal utf8 strings
        Use ocet2hex()
      sql/item_strfunc.h:
        CHAR() now returns a binary string
      sql/log_event.cc:
        Use octet2hex()
        Simplify code
      sql/parse_file.cc:
        Indentation fixes
        Use for() instead of while()
      sql/password.c:
        Make octet2hex() more generally usable by returning pointer to end 0
      sql/slave.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_base.cc:
        Indentation fixes
      sql/sql_insert.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_manager.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_parse.cc:
        Don't check thd->db when checking for function privileges
      sql/sql_prepare.cc:
        Fixed wrong merge
      sql/sql_select.cc:
        Fixed new bug for NOT BETWEEN X and X
      sql/sql_show.cc:
        Removed not used variable
      sql/sql_table.cc:
        Indentation fixed
        Removed DBUG_PRINT that is obvious from context
      sql/sql_view.cc:
        Simplify code
      sql/unireg.cc:
        Use octet2hex()
      d6ccd7c7
    • unknown's avatar
      Fix for bug #13667 (Inconsistency for decimal(m,d) specification. · 8e762938
      unknown authored
      mysql-test/r/type_newdecimal.result:
        result fixed
      mysql-test/t/type_newdecimal.test:
        testcase added
      sql/sql_parse.cc:
        we should check if 'decimals' is not null
      8e762938
  9. 10 Oct, 2005 4 commits
  10. 08 Oct, 2005 2 commits
  11. 07 Oct, 2005 1 commit
    • unknown's avatar
      Fix for bug#13202 SELECT * INTO OUTFILE ... FROM information_schema.schemata now fails · e0fc2b87
      unknown authored
        allow select into outfile from I_S tables
        it is enough to add FILE_ACL for I_S tables only to 'check_table_access' function
        as we use 'any_db' for 'check_access' function in places where FILE_ACL is required
      
      
      mysql-test/t/outfile.test:
        Fix for bug#13202 SELECT * INTO OUTFILE ... FROM information_schema.schemata now fails
          test case
      e0fc2b87
  12. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · 872a537c
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      872a537c
  13. 05 Oct, 2005 1 commit
  14. 30 Sep, 2005 1 commit
  15. 28 Sep, 2005 1 commit
    • unknown's avatar
      Fix for bug #13546 "Build errors with --with-embedded-server · 317f9655
      unknown authored
      --with-embedded-privilege-control options". One more (hopefully last) build
      failure which was introduced during work on WL#2787 "Add view definer/owner
      to the view definition..."
      
      
      libmysqld/lib_sql.cc:
        create_embedded_thd()/check_embedded_connection():
          Several security related THD members (user, host, ip, priv_user, ...) have
          moved to the Security_context class. New THD::security_ctx member points to
          active security context.
      sql/sql_acl.cc:
        acl_getroot():
          Updated function description to refelect the fact that THD::user/host/ip/...
          members were moved to separate Security_context class.
      sql/sql_parse.cc:
        check_user():
          Updated function description to refelect the fact that THD::user/host/ip/...
          members were moved to separate Security_context class.
      317f9655
  16. 23 Sep, 2005 1 commit
    • unknown's avatar
      Several fixes revelaled by Intel compiler. · 83263892
      unknown authored
      cmd-line-utils/readline/complete.c:
        Added a cast.
      dbug/my_main.c:
        Added an include to avoid implicit declaration of
        my_thread_global_init()
      include/my_global.h:
        undef cannot be used on this predefined name.
        Since it is a custom fix for gcc 2.8.0, let's make it only
        effective in that case.
      include/my_sys.h:
        Added a new type, TYPE_NOT_SET.
      myisam/ft_boolean_search.c:
        Added casts.
      myisam/mi_key.c:
        Added cast.
      myisam/mi_open.c:
        Added cast.
        Changed function types.
      myisam/mi_test1.c:
        Added cast.
      myisam/myisamchk.c:
        Added cast.
      myisam/myisamdef.h:
        Changed function type.
      myisam/myisampack.c:
        Added casts.
      myisam/sp_key.c:
        Added cast.
      mysys/mf_iocache.c:
        Fixed invalid use of 0 to info->type. According to comment it
        should not have been set, but in earlier code by setting it
        to 0 would have been same as setting it to READ_CACHE. This
        probably was not desired, potential bug.
      server-tools/instance-manager/instance_options.cc:
        Fixed a typo.
      server-tools/instance-manager/protocol.cc:
        Changed enum to int.
        Changed char to uchar.
        Added casts.
      sql/mysql_priv.h:
        Bit overflow.
      sql/sql_base.cc:
        Removed unused label. The code below label was unused too, because
        there is a return just before.
      sql/sql_parse.cc:
        Removed unneccessary extra argument.
      83263892
  17. 21 Sep, 2005 2 commits
    • unknown's avatar
      aftermerge fix · 1f603a9e
      unknown authored
      1f603a9e
    • unknown's avatar
      postmerge fixes · 20647176
      unknown authored
      libmysqld/lib_sql.cc:
        struct st_security_context nad to class Security_context
      sql/item_func.cc:
        fixed method call, name and contence to be compatible with new code
      sql/item_func.h:
        fixed method to be compatible wit new code
      sql/sql_parse.cc:
        fixed typo
        removed compiler warnings
      20647176
  18. 20 Sep, 2005 1 commit
    • unknown's avatar
      WL#2787 (Add view definer/owner to the view definition (.frm) to check... · a95d74bb
      unknown authored
      WL#2787 (Add view definer/owner to the view definition (.frm) to check privileges on used tables and stored routines when using a VIEW.)
      Part 2 postreview fixes.
      
      
      sql/ha_innodb.cc:
        Renamed structure st_security_context to class Security_context
      sql/item_func.cc:
        Renamed structure st_security_context to class Security_context
      sql/item_strfunc.cc:
        fixed USER() function
      sql/log.cc:
        variable used to optimize access to security context
      sql/mysql_priv.h:
        Renamed structure st_security_context to class Security_context
      sql/mysqld.cc:
        main security context used direcly
      sql/sp_head.cc:
        Renamed structure st_security_context to class Security_context
        removed unneed variable
      sql/sp_head.h:
        Comment inmroved
        Renamed structure st_security_context to class Security_context
      sql/sql_acl.cc:
        Renamed structure st_security_context to class Security_context
        fixed function comment and return value
        variable used to optimize access to security context
        Renamed method of Security_ontext
      sql/sql_acl.h:
        fixed return value type
      sql/sql_class.cc:
        Renamed structure st_security_context to class Security_context
      sql/sql_class.h:
        Renamed structure st_security_context to class Security_context
        Method renamed
      sql/sql_db.cc:
        Renamed structure st_security_context to class Security_context
        fixed layout
      sql/sql_parse.cc:
        registration of wanted access for underlying tables
      sql/sql_show.cc:
        Renamed structure st_security_context to class Security_context
        fixed layout
      sql/sql_yacc.yy:
        Renamed structure st_security_context to class Security_context
      a95d74bb
  19. 19 Sep, 2005 1 commit
    • unknown's avatar
      ndb - imlp. show engine ndb status; · 4b25110c
      unknown authored
        that dump free list allocation per connection
      
      
      sql/ha_ndbcluster.cc:
        imlp. show engine ndb status;
          that dump free list allocation per connection
      sql/ha_ndbcluster.h:
        imlp. show engine ndb status;
          that dump free list allocation per connection
      sql/mysqld.cc:
        imlp. show engine ndb status;
          that dump free list allocation per connection
      sql/sql_lex.h:
        imlp. show engine ndb status;
          that dump free list allocation per connection
      sql/sql_parse.cc:
        imlp. show engine ndb status;
          that dump free list allocation per connection
      sql/sql_yacc.yy:
        imlp. show engine ndb status;
          that dump free list allocation per connection
      4b25110c
  20. 15 Sep, 2005 1 commit
    • unknown's avatar
      WL#2787 (part 2, ver 3 (merged)) changed securety context switching · e80e4b10
      unknown authored
      libmysqld/lib_sql.cc:
        changed securety context switching
      mysql-test/r/rpl_sp.result:
        now it show real information from changed security context of SP (checked)
      sql/ha_innodb.cc:
        changed securety context switching
      sql/item.cc:
        changed securety context switching
      sql/item_func.cc:
        changed securety context switching
      sql/item_strfunc.cc:
        changed securety context switching
      sql/log.cc:
        changed securety context switching
      sql/mysql_priv.h:
        changed securety context switching
      sql/mysqld.cc:
        changed securety context switching
      sql/repl_failsafe.cc:
        changed securety context switching
      sql/set_var.cc:
        changed securety context switching
      sql/slave.cc:
        changed securety context switching
      sql/sp.cc:
        changed securety context switching
      sql/sp_head.cc:
        changed securety context switching
        in case of inability to switch context  we return error now
      sql/sp_head.h:
        changed securety context switching
      sql/sql_acl.cc:
        changed securety context switching
      sql/sql_acl.h:
        changed securety context switching
      sql/sql_base.cc:
        changed securety context switching
      sql/sql_class.cc:
        changed securety context switching
      sql/sql_class.h:
        changed securety context switching
      sql/sql_db.cc:
        changed securety context switching
      sql/sql_insert.cc:
        changed securety context switching
      sql/sql_parse.cc:
        changed securety context switching
      sql/sql_show.cc:
        changed securety context switching
      sql/sql_trigger.cc:
        changed securety context switching
      sql/sql_view.cc:
        changed securety context switching
      sql/sql_yacc.yy:
        changed securety context switching
      e80e4b10
  21. 14 Sep, 2005 4 commits
    • unknown's avatar
      BUG#12870 (CREATE PROCEDURE followed by ROLLBACK is not replicated) · e7e0af1d
      unknown authored
      Fixed by making CREATE/ALTER/DROP PROCEDURE cause implicit commit.
      
      
      mysql-test/r/rpl_ddl.result:
        Updated results to include testing of implicit commit for
        create/alter/drop procedure
      mysql-test/t/rpl_ddl.test:
        BUG#12870 test implicit commit for create/alter/drop procedure.
      sql/sql_parse.cc:
        CREATE/ALTER/DROP PROCEDURE/SPFUNCTION now causes implicit commit.
      e7e0af1d
    • unknown's avatar
      fix for BUG#11139 (multi-delete with alias breaking replication if table rules are · f03d54f1
      unknown authored
       present): the problem originally was that the tables in auxilliary_tables did not have 
      the correct real_name, which caused problems in the second call to tables_ok(). 
      The fix corrects the real_name problem, and also sets the updating flag properly, 
      which makes the second call to tables_ok() unnecessary.
      
      
      mysql-test/r/rpl_multi_delete2.result:
        updates for for BUG#11139
      mysql-test/t/rpl_multi_delete2-slave.opt:
        updates for for BUG#11139
      mysql-test/t/rpl_multi_delete2.test:
        updates for for BUG#11139
      sql/mysql_priv.h:
        fix for BUG#11139 (multi-delete with alias breaking replication if table rules are
         present)
      sql/slave.cc:
        fix for BUG#11139 (multi-delete with alias breaking replication if table rules are
         present)
      sql/sql_parse.cc:
        fix for BUG#11139 (multi-delete with alias breaking replication if table rules are
         present)
      sql/sql_yacc.yy:
        fix for BUG#11139 (multi-delete with alias breaking replication if table rules are
         present)
      f03d54f1
    • unknown's avatar
      part 1 (ver 2, postreview fix) of WL#2787 · 938a4ba3
      unknown authored
      view definer information syntax/storage/replication
      fixed SOURCE field of .frm
      
      
      mysql-test/r/func_in.result:
        definer information added to CREATE VIEW
      mysql-test/r/lowercase_view.result:
        definer information added to CREATE VIEW
      mysql-test/r/mysqldump.result:
        definer information added to CREATE VIEW
      mysql-test/r/rpl_view.result:
        check log of queries
      mysql-test/r/skip_grants.result:
        --skip-grants do not allow use user information
      mysql-test/r/sql_mode.result:
        definer information added to CREATE VIEW
      mysql-test/r/temp_table.result:
        definer information added to CREATE VIEW
      mysql-test/r/view.result:
        definer information added to CREATE VIEW
        test of storing/restoring definer information
      mysql-test/r/view_grant.result:
        test of grant check of definer information
        definer information added to CREATE VIEW
      mysql-test/t/rpl_view.test:
        check log of queries
      mysql-test/t/skip_grants.test:
        --skip-grants do not allow use user information
      mysql-test/t/view.test:
        test of storing/restoring definer information
      mysql-test/t/view_grant.test:
        test of grant check of definer information
      sql/mysql_priv.h:
        CREATE/ALTER VIEW print support
        set current user as definer procedure
      sql/share/errmsg.txt:
        new errors/warnings
      sql/sql_acl.cc:
        make find_acl_user public to allow to check user
      sql/sql_acl.h:
        make find_acl_user public to allow to check user
      sql/sql_lex.h:
        storing definer information
      sql/sql_parse.cc:
        send CREATE/ALTER VIEW for replication with full list of options
        set current user as definer procedure
      sql/sql_show.cc:
        new CREATE VIEW options printed
      sql/sql_view.cc:
        check of definer clause
        changes in .frm file
        definer information storage support
        now we store only original SELECT in SOURCE field of .frm
      sql/sql_yacc.yy:
        definer information sintax support
        getting SOURCE field information for .frm
      sql/table.h:
        definer information storage
      938a4ba3
    • unknown's avatar
      formatting typo fix · 3c88faaa
      unknown authored
      3c88faaa
  22. 13 Sep, 2005 1 commit
    • unknown's avatar
      Bug#9683 INFORMATION_SCH: Creation of temporary table allowed in · 553d6985
      unknown authored
               Information_schema DB 
      Bug#9846 Inappropriate error displayed while
               dropping table from 'INFORMATION_SCHEMA'
      Bug#10734 Grant of privileges other than 'select' and 
               'create view' should fail on schema 
      Bug#10708 SP's can use INFORMATION_SCHEMA as ROUTINE_SCHEMA
      
       cumulative fix for bugs above(after review, 2nd version)
       added privilege check for information schema db & tables
      
      553d6985
  23. 12 Sep, 2005 1 commit
    • unknown's avatar
      Fix for BUG#6808. · fa47a0e0
      unknown authored
      The problem was in that add_table_to_list was testing for duplicate tables
      in a list of tables that included the created view.
      
      
      mysql-test/r/view.result:
        Test for BUG#6808
      mysql-test/t/view.test:
        Test for BUG#6808
      sql/sql_parse.cc:
        When testing for table name uniquness, skip the first table the current
        statement is CREATE VIEW. Notice that the first table is skipped differently
        for CREATE TABLE ... SELECT ... statements, so we don't have to handle that
        case here (see production 'create_select', the call 'to save_and_clear').
      fa47a0e0
  24. 10 Sep, 2005 2 commits
    • unknown's avatar
      Removed redundant reset_one_shot_variables calls · 5bfcf9b8
      unknown authored
      sql/sql_parse.cc:
        Optimization, this reset is executed below anyway
      5bfcf9b8
    • unknown's avatar
      Fix for BUG#12943. · 58cc5073
      unknown authored
      The problem was that in the first production in rule 'join_table', that
      processes simple cross joins, the parser was processing the second join operand
      before the first one due to unspecified priorities of JOINs. As a result in the
      case of cross joins the parser constructed a tree with incorrect nesting:
      the expression "t1 join t2 join t3 on some_cond" was interpreted as
      "t1 join (t2 join t3 on some_cond)" instead of
      "(t1 join t2) join t3 on some_cond".
      Because of this incorrect nesting the method make_join_on_context picked an
      incorrect table as the first table of the name resolution context.
      
      The solution assignes correct priorities to the related production.
      
      
      mysql-test/r/select.result:
        Added test for BUG#12943.
      mysql-test/t/select.test:
        Added test for BUG#12943.
      sql/sql_parse.cc:
        Fixed typo.
      sql/sql_yacc.yy:
        Provide explicit priorities of the JOIN operator and the 'table_ref' rule,
        to enforce left-associativity of [INNER | CROSS] JOIN.
      58cc5073
  25. 09 Sep, 2005 1 commit
  26. 07 Sep, 2005 1 commit
    • unknown's avatar
      Fix for BUG#12637: Make SPs+user variables replication work: · c4dc984a
      unknown authored
      * Allocate thd->user_var_events elements on appropriate mem_root
      * If several SP statements are binlogged as a single statement, collect all user var
        accesses they make (grep for StoredRoutinesBinlogging for details)
      
      
      mysql-test/r/rpl_sp_effects.result:
        Testcase for BUG#12637
      mysql-test/r/sp.result:
        re-enabled test case for BUG#12297
      mysql-test/t/rpl_sp_effects.test:
        Testcase for BUG#12637
      mysql-test/t/sp.test:
        re-enabled test case for BUG#12297
      sql/item_func.cc:
        Fix for BUG#12637: Make SPs+user variables replication work:
        * Allocate thd->user_var_events elements on appropriate mem_root
        * If several SP statements are binlogged as a single statement, collect all user var
          accesses they make.
      sql/log.cc:
        Fix for BUG#12637: Make SPs+user variables replication work:
        * Allocate thd->user_var_events elements on appropriate mem_root
        * If several SP statements are binlogged as a single statement, collect all user var
          accesses they make.
      sql/sp_head.cc:
        Fix for BUG#12637: Make SPs+user variables replication work:
        * Allocate thd->user_var_events elements on appropriate mem_root
        * If several SP statements are binlogged as a single statement, collect all user var
          accesses they make.
      sql/sp_head.h:
        Remove compiler warning.
      sql/sql_class.h:
        Fix for BUG#12637: Make SPs+user variables replication work.
      sql/sql_parse.cc:
        Fix for BUG#12637: Make SPs+user variables replication work.
      c4dc984a
  27. 05 Sep, 2005 1 commit
    • unknown's avatar
      mysqld.cc, mysql_priv.h, sql_parse.cc: · 0fb6a488
      unknown authored
        bug#9948
        changed client-charset behavior in 4.1.x libmysql, which issue BC prob
        after review fixes
      
      
      sql/mysql_priv.h:
        bug#9948
        changed client-charset behavior in 4.1.x libmysql, which issue BC prob
        after review fixes
      sql/mysqld.cc:
        bug#9948
        changed client-charset behavior in 4.1.x libmysql, which issue BC prob
        after review fixes
      0fb6a488
  28. 04 Sep, 2005 1 commit
  29. 03 Sep, 2005 1 commit
    • unknown's avatar
      Backport of JimW's localhost patch to 4.1 tree. · c1063196
      unknown authored
      Handle systems like default FC4 where 127.0.0.1 doesn't always map to 'localhost' first. 
      (Bug #11822)
      
      
      sql/hostname.cc:
        Short-circuit ip_to_hostname() lookup for INADDR_LOOPBACK to allways return 'localhost'.
      sql/sql_parse.cc:
        Push special handling of 127.0.0.1 into ip_to_hostname().
      c1063196