1. 14 Feb, 2018 9 commits
  2. 13 Feb, 2018 4 commits
  3. 12 Feb, 2018 3 commits
    • Marko Mäkelä's avatar
      MDEV-15270 Mariabackup should not try to use doublewrite buffer · 00f0c039
      Marko Mäkelä authored
      When Mariabackup gets a bad read of the first page of the system
      tablespace file, it would inappropriately try to apply the doublewrite
      buffer and write changes back to the data file (to the source file)!
      This is very wrong and must be prevented.
      
      The correct action would be to retry reading the system tablespace
      as well as any other files whose first page was read incorrectly.
      Fixing this was not attempted.
      
      xb_load_tablespaces(): Shorten a bogus message to be more relevant.
      The message can be displayed by --backup or --prepare.
      
      xtrabackup_backup_func(), os_file_write_func(): Add a missing space
      to a message.
      
      Datafile::restore_from_doublewrite(): Do not even attempt the
      operation in Mariabackup.
      
      recv_init_crash_recovery_spaces(): Do not attempt to restore the
      doublewrite buffer in Mariabackup (--prepare or --export), because
      all pages should have been copied correctly in --backup already,
      and because --backup should ignore the doublewrite buffer.
      
      SysTablespace::read_lsn_and_check_flags(): Do not attempt to initialize
      the doublewrite buffer in Mariabackup.
      
      innodb_make_page_dirty(): Correct the bounds check.
      
      Datafile::read_first_page(): Correct the name of the parameter.
      00f0c039
    • Marko Mäkelä's avatar
      MDEV-13869 MariaDB slow start · 33f70c4d
      Marko Mäkelä authored
      When code from MySQL 5.7.9 was merged to MariaDB 10.2.2
      in commit 2e814d47
      an assignment validate=true was inadvertently added to the function
      dict_check_sys_tables().
      
      This causes InnoDB to open every single .ibd file on startup, even
      when no crash recovery was needed.
      
      Simply removing the assignment would make some tests fail. We do the
      best to retain almost the same level of inconsistency detection.
      In the test innodb.table_flags, access to one of the tables will not
      be blocked despite inconsistent flags.
      
      dict_check_sys_tables(): Remove the problematic assignment, and skip
      validation in normal startup.
      
      dict_load_table_one(): If the .ibd file cannot be opened, mark the
      table as corrupted and unreadable.
      
      fil_node_open_file(): Validate FSP_SPACE_FLAGS with the expected
      flags. If reading the tablespace fails, invalidate node->handle
      instead of letting it remain stale. This bug was caught by a
      fil_validate() assertion failure.
      
      fsp_flags_try_adjust(): If the tablespace file is invalid, do nothing.
      33f70c4d
    • Elena Stepanova's avatar
      7a106d19
  4. 11 Feb, 2018 1 commit
  5. 10 Feb, 2018 5 commits
  6. 09 Feb, 2018 6 commits
  7. 08 Feb, 2018 12 commits