An error occurred fetching the project authors.
  1. 06 Nov, 2006 1 commit
  2. 09 Oct, 2006 1 commit
    • cmiller@zippy.cornsilk.net's avatar
      Bug#17583: mysql drops connection when stdout is not writable · 4812d81e
      cmiller@zippy.cornsilk.net authored
      When the client program had its stdout file descriptor closed by the calling
      shell, after some amount of work (enough to fill a socket buffer) the server 
      would complain about a packet error and then disconnect the client.
      
      This is a serious security problem.  If stdout is closed before the mysql is
      exec()d, then the first socket() call allocates file number 1 to communicate
      with the server.  Subsequent write()s to that file number (as when printing
      results that come back from the database) go back to the server instead in 
      the command channel.  So, one should be able to craft data which, upon being
      selected back from the server to the client, and injected into the command
      stream become valid MySQL protocol to do something nasty when sent /back/ to 
      the server.
      
      The solution is to close explicitly the file descriptor that we *printf() to, 
      so that the libc layer and the OS layer both agree that the file is closed.
      4812d81e
  3. 04 Oct, 2006 1 commit
    • cmiller@zippy.cornsilk.net's avatar
      Bug#19356: Assert on undefined @uservar in prepared statement execute · 66659796
      cmiller@zippy.cornsilk.net authored
      The executing code had a safety assertion so that it refused to free Items
      that it didn't create.  However, there is a case, undefined user variables,
      which would put Items into the list to be freed.
      
      Instead, do something that is more risky in expectation that the code will 
      be refactored soon, as Kostja wants to do:  Remove the assertions from 
      prepare() and execute().  Put one assertion at a higher level, before 
      stmt->set_params_from_vars(), which may then create new to-be-freed Items .
      66659796
  4. 03 Oct, 2006 1 commit
    • cmiller@zippy.cornsilk.net's avatar
      Bug #14262: SP: DROP PROCEDURE|VIEW (maybe more) write to binlog too late \ · 5512100c
      cmiller@zippy.cornsilk.net authored
      	(race cond)
      
      It was possible for one thread to interrupt a Data Definition Language 
      statement and thereby get messages to the binlog out of order.  Consider:
      
      Connection 1: Drop Foo x
      Connection 2: Create or replace Foo x
      Connection 2: Log "Create or replace Foo x"
      Connection 1: Log "Drop Foo x"
      
      Local end would have Foo x, but the replicated slaves would not.
      
      The fix for this is to wrap all DDL and logging of a kind in the same mutex.  
      Since we already use mutexes for the various parts of altering the server, 
      this only entails moving the logging events down close to the action, inside 
      the mutex protection.
      5512100c
  5. 27 Sep, 2006 1 commit
    • cmiller@zippy.cornsilk.net's avatar
      Bug#21476: (Thread stack overrun not caught, causing SEGV) · c0ab40d3
      cmiller@zippy.cornsilk.net authored
      The STACK_MIN_SIZE is currently set to 8192, when we actually need 
      (emperically discovered) 9236 bytes to raise an fatal error, on Ubuntu 
      Dapper Drake, libc6 2.3.6-0ubuntu2, Linux kernel 2.6.15-27-686, on x86.
      
      I'm taking that as a new lower bound, plus 100B of wiggle-room for sundry
      word sizes and stack behaviors.
      
      The added test verifies in a cross-platform way that there are no gaps 
      between the space that we think we need and what we actually need to report 
      an error.
      
      DOCUMENTERS:  This also adds "let" to the mysqltest commands that evaluate
      an argument to expand variables therein.  (Only right of the "=", of course.)
      c0ab40d3
  6. 22 Sep, 2006 1 commit
  7. 08 Sep, 2006 1 commit
  8. 29 Aug, 2006 1 commit
    • anozdrin/alik@alik.'s avatar
      Preliminary patch for the following bugs: · 1a7cb415
      anozdrin/alik@alik. authored
        - BUG#15934: Instance manager fails to work;
        - BUG#18020: IM connect problem;
        - BUG#18027: IM: Server_ID differs;
        - BUG#18033: IM: Server_ID not reported;
        - BUG#21331: Instance Manager: Connect problems in tests;
      
      The only test suite has been changed
      (server codebase has not been modified).
      1a7cb415
  9. 23 Aug, 2006 1 commit
  10. 02 Aug, 2006 1 commit