An error occurred fetching the project authors.
- 30 Apr, 2007 1 commit
-
-
unknown authored
mysqldump didn't properly handle getting no data on SHOW CREATE PROCEDURE. If S/C/P fails (due to dumping user's insufficient privileges on mysql.proc, say), mysqldump will print a comment to that effect to the output and return an error-code. If the -f (force) option is used, the dump will continue, otherwise, it will abort right there and then. Also fixes Bug#22761, "mysqldump reports no errors when using --routines without mysql.proc privileges" --- Merge tnurnberg@bk-internal.mysql.com:/home/bk/mysql-5.0-maint into mysql.com:/home/tnurnberg/27293/50-27293 client/mysqldump.c: Bug#27293: mysqldump crashes when dumping procedure defined by different user handle failure of SHOW CREATE PROCEDURE, give user diagnostics, heed -f (force) option mysql-test/r/mysqldump.result: Bug#27293: mysqldump crashes when dumping procedure defined by different user show that trying to mysqldump --routines with insufficient privileges will no longer crash the client --- manual merge mysql-test/t/mysqldump.test: Bug#27293: mysqldump crashes when dumping procedure defined by different user show that trying to mysqldump --routines with insufficient privileges will no longer crash the client --- manual merge
-
- 02 Apr, 2007 1 commit
-
-
unknown authored
mysql-test/t/mysqldump.test: Fix for failing Windows test.
-
- 27 Mar, 2007 1 commit
-
-
unknown authored
- mysqldump executes a SHOW CREATE VIEW statement to generate the text that it outputs. When the function name is retrieved it's database name is unconditionally prepended. This change causes the function's database name to be prepended only when it was used to define the function. mysql-test/r/information_schema.result: Bug#23491 MySQLDump prefix function call in a view by database name - Updated Results. mysql-test/r/mysqldump.result: Bug#23491 MySQLDump prefix function call in a view by database name - Added new results. mysql-test/r/sp-code.result: Bug#23491 MySQLDump prefix function call in a view by database name - Updated Results. mysql-test/r/udf.result: Bug#23491 MySQLDump prefix function call in a view by database name - Updated Results. mysql-test/t/mysqldump.test: Bug#23491 MySQLDump prefix function call in a view by database name - Added new testcase. sql/item_func.cc: Bug#23491 MySQLDump prefix function call in a view by database name - Use new m_explicit_name member when deciding whether or not to prepend the db name while building the function name. sql/sp.cc: Bug#23491 MySQLDump prefix function call in a view by database name - Use new sp_name constructor. sql/sp_head.h: Bug#23491 MySQLDump prefix function call in a view by database name - Add m_explicit_name member to sp_name object. - Redefined sp_name constructor to include new member. sql/sql_yacc.yy: Bug#23491 MySQLDump prefix function call in a view by database name - Use new sp_name constructors.
-
- 26 Mar, 2007 1 commit
-
-
unknown authored
opt_complete_insert was improperly used by accident. Use complete_insert flag instead. client/mysqldump.c: Fix for bug #25993: mysqldump crashes with merge table and -c option - use complete_insert instead of opt_complete_insert. mysql-test/r/mysqldump.result: Fix for bug #25993: mysqldump crashes with merge table and -c option - test result. mysql-test/t/mysqldump.test: Fix for bug #25993: mysqldump crashes with merge table and -c option - test case.
-
- 22 Mar, 2007 1 commit
-
-
unknown authored
Fixes to buffer overlows from long command line args, and unchecked dyn_str return codes. Also light refactoring. client/mysqldump.c: Bug#26346 stack + buffer overrun in mysqldump mysql-test/r/mysqldump.result: Bug#26346 stack + buffer overrun in mysqldump mysql-test/t/mysqldump.test: Bug#26346 stack + buffer overrun in mysqldump
-
- 19 Feb, 2007 2 commits
- 21 Nov, 2006 2 commits
- 15 Nov, 2006 1 commit
-
-
unknown authored
mysql-test/r/init_connect.result: Restore global variable to the value it's set to when server is started mysql-test/r/key_cache.result: Restore global variable values to original mysql-test/r/mysqldump.result: Drop the user that was created. Specifying "drop user myDB_user" is equal to "drop user myDB_user@%" mysql-test/r/rpl_deadlock.result: Restore global variable values to original mysql-test/r/rpl_drop_db.result: Remove the conflicting file and drop database mysqltest1 before test exits mysql-test/r/rpl_ignore_revoke.result: As changes to mysql.* are ignored - explicitly delete the user on slave mysql-test/r/rpl_init_slave.result: Restore global variable values to original mysql-test/r/rpl_max_relay_size.result: Restore global variable values to original mysql-test/r/rpl_sp.result: Restore global variable values to original mysql-test/r/rpl_timezone.result: Restore global variable values to original mysql-test/r/rpl_variables.result: Restore global variable values to original mysql-test/r/view_grant.result: Use same user in all places in the same test "readonly" is equal to "readonly@%" not "readonly@localhost" mysql-test/t/init_connect.test: Restore global variable to the value it's set to when server is started mysql-test/t/key_cache.test: Restore global variable values to original mysql-test/t/mysqldump.test: Drop the user that was created. Specifying "drop user myDB_user" is equal to "drop user myDB_user@%" mysql-test/t/rpl_deadlock.test: Restore global variable values to original mysql-test/t/rpl_drop_db.test: Remove the conflicting file and drop database mysqltest1 before test exits mysql-test/t/rpl_ignore_revoke.test: As changes to mysql.* are ignored - explicitly delete the user on slave mysql-test/t/rpl_init_slave.test: Restore global variable values to original mysql-test/t/rpl_max_relay_size.test: Restore global variable values to original mysql-test/t/rpl_sp.test: Restore global variable values to original mysql-test/t/rpl_timezone.test: Restore global variable values to original mysql-test/t/rpl_variables.test: Restore global variable values to original mysql-test/t/view_grant.test: Use same user in all places in the same test "readonly" is equal to "readonly@%" not "readonly@localhost"
-
- 18 Oct, 2006 1 commit
-
-
unknown authored
The mysqldump command with both the --xml and --hex-blob options will output blob data encoded as hexBinary. The proper XML datatype is xs:hexBinary. The correct XML datatype is specified be setting the xsi_type attribute equal to xs:hexBinary for each encoded element. client/mysqldump.c: Bug#19745: mysqldump --xml produces invalid xml - Moved hex-blob code to it's own function. - Rewrote print_xml_tag function to accept zero or more attribute/value pair(s) which are appended to a separate tag name. - --xml option respects the --hex-blob option by ouputting blob data in hex encoded format. Each hex encoded field tag will also contain an xsi:type attribute with an xs:hexBinary value. - --extended-insert and --xml are mutually exclusive. Otherwise, the xml file will contain INSERT commands. - Minor comment cleanup. mysql-test/r/mysqldump.result: Bug#19745: mysqldump --xml produces invalid xml -Added results. mysql-test/t/mysqldump.test: Bug#19745: mysqldump --xml produces invalid xml -Added test.
-
- 15 Sep, 2006 1 commit
-
-
unknown authored
-
- 14 Sep, 2006 1 commit
-
-
unknown authored
Bug#21424 mysqldump failing to export/import views. Dumps are created for the tables in each specified database then for the views in each specified database. This bug occurs when any database's views depend on the mysql database's table data while being restored. Added command line option --flush-privileges to the mysqldump utility which causes a FLUSH PRIVILIGES statement to be written to the dump after the mysql database. client/mysqldump.c: When the flush-privileges command line option is specified, make sure to FLUSH PRIVILEGES after only the mysql database's tables' data is restored so that grant tables are current. mysql-test/r/mysqldump.result: Added Results. mysql-test/t/mysqldump.test: Expanded existing test case for bug 21527 to also test for bug 21424. Exercises new --flush-priviliges command line option. Test ignores log tables.
-
- 01 Sep, 2006 1 commit
-
-
unknown authored
so that 4.1 and 5.0 tests are all in the right place and no tests are duplicated. client/mysqldump.c: Restore fix for bug 21215 accidently removed during merge mysql-test/r/mysqldump.result: Update results mysql-test/t/mysqldump.test: Fix order of tests so that all the tests new to the 5.0 tree come after "End of 4.1 tests", and so that each leaves things in the state it found them (particularly by returning to the 'test' database. Also remove some tests that were duplicated.
-
- 28 Aug, 2006 1 commit
-
-
unknown authored
init_dumping now accepts a function pointer to the table or view specific init_dumping function. This allows both tables and views to use the init_dumping function. client/mysqldump.c: Added functions for table and view specific dumping initalization. mysql-test/r/mysqldump.result: Added Result. mysql-test/t/mysqldump.test: Added test case.
-
- 17 Aug, 2006 1 commit
-
-
unknown authored
The problem was that the error handling was using a too-small buffer to print the error message generated. We fix this by not using a buffer at all, but by using fprintf() directly. There were also some problems with the error handling in table dumping that was exposed by this fix that were also corrected. client/mysqldump.c: Use fprintf() instead of my_printf_error() to avoid buffer overflow issues. Since ME_BELL wasn't specified, calling my_printf_error() offered no advantage except for adding my_progname, which we just go ahead and do manually. Also, fix the error handling in dumpTable() when queries to get data fail and --force was specified. mysql-test/r/mysqldump.result: Add new results mysql-test/t/mysqldump.test: Add new regression test
-
- 14 Aug, 2006 1 commit
-
-
unknown authored
mysql-test/r/mysqldump.result: Update results. mysql-test/t/mysqldump.test: Fix a bug in the test case that left user mysqltest_1@localhost around (this broke furhter tests).
-
- 03 Aug, 2006 1 commit
-
-
unknown authored
-
- 02 Aug, 2006 1 commit
-
-
unknown authored
Quote PKEY. mysql-test/t/mysqldump.test: Test for BUG#13926: --order-by-primary fails if PKEY contains quote character mysql-test/r/mysqldump.result: Test results for BUG#13926: --order-by-primary fails if PKEY contains quote character client/mysqldump.c: Fix for BUG#13926: --order-by-primary fails if PKEY contains quote character. Quote PKEY.
-
- 24 Jul, 2006 1 commit
-
-
unknown authored
- Add call to 'safe_exit' function when db query fails. client/mysqldump.c: Add a call to 'safe_exit' to remember the error code and exit unless --force was give.n mysql-test/r/mysqldump.result: Add test result mysql-test/t/mysqldump.test: Add test case
-
- 17 Jul, 2006 1 commit
-
-
unknown authored
client/mysqldump.c: When dumping more than one database, make sure that the proper database is selected before restoring that database's views. Replaced hard-coded database name length with appropiate token. mysql-test/r/mysqldump.result: Added new result and corrected results for existing test cases. mysql-test/t/mysqldump.test: Added new case for dumping and restoring multiple databases each containing a view.
-
- 14 Jul, 2006 1 commit
-
-
unknown authored
mysqldump did not select the correct database before trying to dump views from it. this resulted in an empty result set, which in turn startled mysql-dump into a core-dump. this only happened for views, not for tables, and was only visible with multiple databases that weren't by sheer luck in the order mysqldump required, anyway. this fixes by selecting the correct database before dumping views; it also catches the empty set-condition if it should occur for other reasons. client/mysqldump.c: Bug#21014: Segmentation fault of mysqldump on view failsafe: if "select ... from information_schema.views" returns an empty set, don't deref NULL; throw an error instead. fix: select the correct database not only before dumping tables, but before dumping views, as well. mysql-test/r/mysqldump.result: Bug#21014: Segmentation fault of mysqldump on view show that mysqldump selects the correct database before trying to dump views from it. mysql-test/t/mysqldump.test: Bug#21014: Segmentation fault of mysqldump on view show that mysqldump selects the correct database before trying to dump views from it.
-
- 13 Jul, 2006 1 commit
-
-
unknown authored
mysqldump did not select the correct database before trying to dump views from it. this resulted in an empty result set, which in turn startled mysql-dump into a core-dump. this only happened for views, not for tables, and was only visible with multiple databases that weren't by sheer luck in the order mysqldump required, anyway. this fixes by selecting the correct database before dumping views; it also catches the empty set-condition if it should occur for other reasons. client/mysqldump.c: Bug#21014: Segmentation fault of mysqldump on view failsafe: if "select ... from information_schema.views" returns an empty set, don't deref NULL; throw an error instead. fix: select the correct database not only before dumping tables, but before dumping views, as well. mysql-test/r/mysqldump.result: Bug#21014: Segmentation fault of mysqldump on view show that mysqldump selects the correct database before trying to dump views from it. mysql-test/t/mysqldump.test: Bug#21014: Segmentation fault of mysqldump on view show that mysqldump selects the correct database before trying to dump views from it.
-
- 07 Jul, 2006 1 commit
-
-
unknown authored
BitKeeper/etc/ignore: Modify ignore list to work with BitKeeper 4 mysql-test/t/mysqldump.test: Fix the test for Bug#18462 to use MYSQLTEST_VARDIR instead of mysql-test/ directory for temporary files.
-
- 30 Jun, 2006 1 commit
-
-
unknown authored
heap/hp_test1.c: Changed type from last commit mysql-test/mysql-test-run.sh: Fixed problem with running with --gdb and two masters Don't disable ndb becasue we run gdb mysql-test/t/mysqldump.test: Don't read ~/.my.cnf sql/ha_ndbcluster.cc: Portability fix
-
- 22 Jun, 2006 1 commit
-
-
unknown authored
mysqldump.test calls my_print_defaults in a way that includes the systemwide my.cnf, so the results will be beyond our control and depend on whatever the user has in their my.cnf, namely the [mysqldump] section. call my_print_defaults with --config-file rather than --defaults-extra-file to prevent inclusion of system-wide defaults and use our config-file only. mysql-test/t/mysqldump.test: call my_print_defaults with our setup only, do not include the systemwide my.cnf as that would make the results unpredictable.
-
- 19 Jun, 2006 1 commit
-
-
unknown authored
mysql-test/r/mysqldump.result: Changed to other database (BUG#20531 hinders usage of 'test' database) mysql-test/t/mysqldump.test: Changed to other database (BUG#20531 hinders usage of 'test' database)
-
- 15 Jun, 2006 1 commit
-
-
unknown authored
mysql-test/r/mysqldump.result: Remove comments in mysqldump output mysql-test/t/mysqldump.test: Remove comments in mysqldump output
-
- 31 May, 2006 1 commit
-
-
unknown authored
(The above problem only occurs with -T -- create a separate file for each table / view.) This ChangeSet results in correct output of view- information while omitting the information for the view's stand-in table. The rationale is that with -T, the user is likely interested in transferring part of a database, not the db in its entirety (that would be difficult as replay order is obscure, the files being named for the table/view they contain rather than getting a sequence number). client/mysqldump.c: Added missing fclose(). Before, a view's stand-in table would get dumped in get_table_structure(), and the file would remain open. get_view_structure() would re-open the same file and write to it, resulting in garbage. The way we handle it now, the table-struct gets closed, then the opening of the view-struct (same name) overwrites it. (The SQL for the view drop-if-exists the table, anyway.) If this were not desired and we wanted SQL for the views that contains the create for the stand-in table, we'd hand a mode to open_sql_file_for_table(), which would feature O_APPEND in get_view_structure(), but not in get_table_structure(). mysql-test/r/mysqldump.result: prove mysqldump -T (each item gets its own file) dumps views correctly mysql-test/t/mysqldump.test: prove mysqldump -T (each item gets its own file) dumps views correctly
-
- 30 May, 2006 1 commit
-
-
unknown authored
'show create' works even on views that are short of a base-table (this throw a warning though, like you would expect). Unfortunately, this is not what mysqldump uses; it creates stand-in tables and hence requests 'show fields' on the view which fails with missing base-tables. The --force option prevents the dump from stopping at this point; furthermore this patch dumps a comment showing create for the offending view for better diagnostics. This solution was confirmed by submitter as solving their/clients' problem. Problem might become non-issue once mysqldump no longer creates stand-in tables. client/mysqldump.c: Dump a comment showing create for a view if we can't show fields for it for better diagnostics. mysql-test/r/mysqldump.result: add test for #17371 - be defensive. if we can't do a full dump on a view (incl. 'show fields' for a stand-in table), at least create a comment with the 'show create' info when --force is given. mysql-test/t/mysqldump.test: add test for #17371 - be defensive. if we can't do a full dump on a view (incl. 'show fields' for a stand-in table), at least create a comment with the 'show create' info when --force is given.
-
- 29 May, 2006 1 commit
-
-
unknown authored
-
- 26 May, 2006 1 commit
-
-
unknown authored
Get output from modified test (dropping t1). mysqldump.test: Drop t1 at end so that the next test doesn't trip over it. mysql-test/t/mysqldump.test: Drop t1 at end so that the next test doesn't trip over it. mysql-test/r/mysqldump.result: Get output from modified test (dropping t1).
-
- 25 May, 2006 1 commit
-
-
unknown authored
client/mysqldump.c: Better view handling: Distinguish better between tables and views in the output. Add many comments about the distinctions between tables and views, and the tradeoffs that we make, notably that, since we don't maintain dependencies. get_table_structure: Clarify in the output that a view is first created as a workaround for the lack of dependencies. dump_table: Return if we're trying to dump a view. dump_all_views_in_db: Don't call init_dumping. It's already been done in dump_all_tables_in_db. This is the problem reported in BUG#17201. Change the variable was_views to seen_views, and clarify the comment. The previous name was not overly "intuitive". mysql-test/r/mysqldump.result: We no longer have spurious text in the results. Add results for the final test (BUG#17201) mysql-test/t/mysqldump.test: Add a new test (BUG#17201)
-
- 19 May, 2006 1 commit
-
-
unknown authored
client/mysqldump.c: Fix for bug #18536: mysqldump does not maintain table orders as per --tables option - use list to store table names instead of hash. mysql-test/r/mysqldump.result: Fix for bug #18536: mysqldump does not maintain table orders as per --tables option - test result. mysql-test/t/mysqldump.test: Fix for bug #18536: mysqldump does not maintain table orders as per --tables option - test case.
-
- 11 May, 2006 1 commit
-
-
unknown authored
- Check that length of value is longer than 1 before decrementing length by 2. - Backport from 5.0, make it possible to use my_print_defaults in tests mysql-test/mysql-test-run.pl: Backport from 5.0, make it possible to use my_print_defaults from tests mysql-test/mysql-test-run.sh: Backport from 5.0, make it possible to use my_print_defaults from tests mysql-test/r/mysqldump.result: Update result mysql-test/t/mysqldump.test: Test that my_print default don't segfault when encountering an option without closing " mysys/default.c: Check that length of value is longer than 1 before deciding to decrement its length by 2. mysql-test/std_data/bug15328.cnf: New BitKeeper file ``mysql-test/std_data/bug15328.cnf''
-
- 04 May, 2006 1 commit
-
-
unknown authored
mysqldump / SHOW CREATE TABLE will show the NEXT available value for the PK, rather than the *first* one that was available (that named in the original CREATE TABLE ... AUTO_INCREMENT = ... statement). This should produce correct and robust behaviour for the obvious use cases -- when no data were inserted, then we'll produce a statement featuring the same value the original CREATE TABLE had; if we dump with values, INSERTing the values on the target machine should set the correct next_ID anyway (and if not, we'll still have our AUTO_INCREMENT = ... to do that). Lastly, just the CREATE statement (with no data) for a table that saw inserts would still result in a table that new values could safely be inserted to). There seems to be no robust way however to see whether the next_ID field is > 1 because it was set to something else with CREATE TABLE ... AUTO_INCREMENT = ..., or because there is an AUTO_INCREMENT column in the table (but no initial value was set with AUTO_INCREMENT = ...) and then one or more rows were INSERTed, counting up next_ID. This means that in both cases, we'll generate an AUTO_INCREMENT = ... clause in SHOW CREATE TABLE / mysqldump. As we also show info on, say, charsets even if the user did not explicitly give that info in their own CREATE TABLE, this shouldn't be an issue. As per above, the next_ID will be affected by any INSERTs that have taken place, though. This /should/ result in correct and robust behaviour, but it may look non-intuitive to some users if they CREATE TABLE ... AUTO_INCREMENT = 1000 and later (after some INSERTs) have SHOW CREATE TABLE give them a different value (say, CREATE TABLE ... AUTO_INCREMENT = 1006), so the docs should possibly feature a caveat to that effect. It's not very intuitive the way it works now (with the fix), but it's *correct*. We're not storing the original value anyway, if we wanted that, we'd have to change on-disk representation? If we do dump/load cycles with empty DBs, nothing will change. This changeset includes an additional test case that proves that tables with rows will create the same next_ID for AUTO_INCREMENT = ... across dump/restore cycles. Confirmed by support as likely solution for client's problem. mysql-test/r/auto_increment.result: test for creation of AUTO_INCREMENT=... clause mysql-test/r/gis-rtree.result: Add AUTO_INCREMENT=... clauses where appropriate mysql-test/r/mysqldump.result: show that AUTO_INCREMENT=... will survive dump/restore cycles mysql-test/r/symlink.result: Add AUTO_INCREMENT=... clauses where appropriate mysql-test/t/auto_increment.test: test for creation of AUTO_INCREMENT=... clause mysql-test/t/mysqldump.test: show that AUTO_INCREMENT=... will survive dump/restore cycles sql/sql_show.cc: Add AUTO_INCREMENT=... to output of SHOW CREATE TABLE if there is an AUTO_INCREMENT column, and NEXT_ID > 1 (the default). We must not print the clause for engines that do not support this as it would break the import of dumps, but as of this writing, the test for whether AUTO_INCREMENT columns are allowed and wether AUTO_INCREMENT=... is supported is identical, !(file->table_flags() & HA_NO_AUTO_INCREMENT)) Because of that, we do not explicitly test for the feature, but may extrapolate its existence from that of an AUTO_INCREMENT column.
-
- 02 Mar, 2006 1 commit
-
-
unknown authored
client/mysqltest.c: Prepend the command to execute by system with "sh" to make it executed by cygwin's bash mysql-test/t/mysqldump.test: Change from " to ' to avoid bash's filename expanding. I.e to avoid that "[mysqltest1]" will be llok for any dirs in mysql-test/* that are named m, y, s, q etc. And ther is actually one dir called t, so we will get a match and thus echo "t" to the file.
-
- 24 Feb, 2006 1 commit
-
-
unknown authored
(Backported from mysql-5.1-new) mysql-test/t/mysqldump.test: Fix mysqldump.test to work with non-standard --vardir.
-
- 23 Feb, 2006 1 commit
-
-
unknown authored
Add new parameter to do_eval so that only unescaped variables in input string is expanded and rest of string is left untouched. client/mysqltest.c: Add new parameter to 'do_eval' that will add any escape chars found in the input string to the output string. This is used in 'do_system' and in 'do_exec' where only unescaped variables will be expanded, rest of the string will be left untouched. mysql-test/r/mysqltest.result: Update test result mysql-test/t/mysqldump.test: Revert previous patch that added extra \\ in "exec" command mysql-test/t/mysqltest.test: Revert previous patch that added extra \\ in exec command
-
- 21 Feb, 2006 1 commit
-
-
unknown authored
Bug#14857 Reading dump files with single statement stored routines fails.Bug #14857 Reading dump files with single statement stored routines fails. - Add tests, fixed by patch for 16878 mysql-test/r/mysqldump.result: Update test results mysql-test/t/mysqldump.test: Add tests for bug 14857
-