- 04 Jan, 2019 1 commit
-
-
Marko Mäkelä authored
-
- 03 Jan, 2019 8 commits
-
-
Marko Mäkelä authored
Fix an inadvertently inverted condition that caused galera.galera_sst_mariabackup_table_options test failure.
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
MDEV-18129 Backup fails for encrypted tables: mariabackup: Database page corruption detected at page 1 If an encrypted table is created during backup, then mariabackup --backup could wrongly fail. This caused a failure of the test mariabackup.huge_lsn once on buildbot. This is due to the way how InnoDB creates .ibd files. It would first write a dummy page 0 with no encryption information. Due to this, xb_fil_cur_open() could wrongly interpret that the table is not encrypted. Subsequently, page_is_corrupted() would compare the computed page checksum to the wrong checksum. (There are both "before" and "after" checksums for encrypted pages.) To work around this problem, we introduce a Boolean option --backup-encrypted that is enabled by default. With this option, Mariabackup will assume that a nonzero key_version implies that the page is encrypted. We need this option in order to be able to copy encrypted tables from MariaDB 10.1 or 10.2, because unencrypted pages that were originally created before MySQL 5.1.48 could contain nonzero garbage in the fields that were repurposed for encryption. Later, MDEV-18128 would clean up the way how .ibd files are created, to remove the need for this option. page_is_corrupted(): Add missing const qualifiers, and do not check space->crypt_data unless --skip-backup-encrypted has been specified. xb_fil_cur_read(): After a failed page read, output a page dump.
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 02 Jan, 2019 8 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Daniel Bartholomew authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
-
- 30 Dec, 2018 1 commit
-
-
Sergei Golubchik authored
-
- 29 Dec, 2018 7 commits
-
-
Sergei Golubchik authored
-
Marko Mäkelä authored
-
Marko Mäkelä authored
This is a regression caused by commit 8c43f963 that was part of the MDEV-12112 fixes. page_is_corrupted(): Never interpret page_no=0 as encrypted.
-
Eugene Kosov authored
This is a regression after MDEV-13671. The bug is related to key part prefix lengths wich are stored in SYS_FIELDS. Storage format is not obvious and was handled incorrectly which led to data dictionary corruption. SYS_FIELDS.POS actually contains prefix length too in case if any key part has prefix length. innobase_rename_column_try(): fixed prefixes handling Tests for prefixed indexes added too. Closes #1063
-
Marko Mäkelä authored
-
Marko Mäkelä authored
-
Vladislav Vaintroub authored
would not hide more interesting information, like invalid memory accesses. some "leaks" are expected - partly this is due to weird options parsing, that runs twice, and does not free memory after the first run. - also we do not mind to exit() whenever it makes sense, without full cleanup.
-
- 28 Dec, 2018 3 commits
-
-
Marko Mäkelä authored
-
Eugene Kosov authored
MDEV-17470 Orphan temporary files after interrupted ALTER cause InnoDB: Operating system error number 17 and eventual fatal error 71 Orphan #sql* tables may remain after ALTER TABLE was interrupted by timeout or KILL or client disconnect. This is a regression caused by MDEV-16515. Similar to temporary tables (MDEV-16647), we had better ignore the KILL when dropping the original table in the final part of ALTER TABLE. Closes #1020
-
Marko Mäkelä authored
This fixes a regression that was introduced in MySQL 5.6.6 in an error handling code path, in the following change: commit 024f363d6b5f09b20d1bba411af55be95c7398d3 Author: kevin.lewis@oracle.com <> Date: Fri Jun 15 09:01:42 2012 -0500 Bug #14169459 INNODB; DROP TABLE DOES NOT DELETE THE IBD FILE FOR A TEMPORARY TABLE.
-
- 27 Dec, 2018 2 commits
-
-
Marko Mäkelä authored
Now that InnoDB startup drops tables whose name starts with #sql, the table ID alone should be enough to create a unique table name. dict_temp_file_num, dict_mem_init(): Remove. dict_mem_create_temporary_tablename(): Use a combination of "#sql-ib" and the ID of the table that is being rebuilt in TRUNCATE TABLE, or discarded in the commit of table-rebuilding ALTER TABLE...ALGORITHM=INPLACE, or deferred to the DROP queue. Thanks to Sergey Vojtovich for pointing this out.
-
Teodor Mircea Ionita authored
-
- 26 Dec, 2018 1 commit
-
-
Alexander Barkov authored
-
- 25 Dec, 2018 1 commit
-
-
Sergei Petrunia authored
-
- 24 Dec, 2018 2 commits
-
-
Daniel Bartholomew authored
-
Sergei Golubchik authored
fix the AWS SDK build eligibility checks. followup for 779151db
-
- 23 Dec, 2018 2 commits
-
-
Jan Lindström authored
MDEV-18064: Packaging is broken for debian-based systems
-
Julius Goryavsky authored
Packaging is broken for debian-based systems after removing xtrabackup scripts. This is due to the fact that links to the scripts are not removed from the installation file (from the debian/mariadb-server-10.3.install). Also in this fix some comments have been added to the documentation, indicating that using xtrabackup[-v2] is an deprecated, therefore user should use mariabackup instead. https://jira.mariadb.org/browse/MDEV-18064
-
- 22 Dec, 2018 1 commit
-
-
Rakshit Kumar authored
Docs grammar fixed
-
- 21 Dec, 2018 3 commits
-
-
Vladislav Vaintroub authored
-
Elena Stepanova authored
-
Elena Stepanova authored
-