An error occurred fetching the project authors.
  1. 05 Oct, 2022 1 commit
    • Marko Mäkelä's avatar
      Remove HAVE_SNPRINTF · df97eb14
      Marko Mäkelä authored
      This fixes up commit 77c184df
      which explicitly specifies that we use ISO/IEC 9899:1999 (C99),
      which includes the snprintf() function.
      df97eb14
  2. 09 Aug, 2022 1 commit
  3. 02 Aug, 2022 1 commit
    • Sergei Golubchik's avatar
      MDEV-23097 heap-use-after-free in mysqlimport · 07a670b8
      Sergei Golubchik authored
      mysqlimport starts many worker threads. when one of the worker
      encounters an error, it frees global memory and calls exit().
      
      it suppresses memory leak detector, because, as the comment says
      "dirty exit, some threads are still running", indeed, it cannot
      free the memory from other threads.
      
      but precisely because some threads are still running, they
      might use this global memory, so it cannot be freed.
      
      fix: if we know that some threads are still running and accept
      that we cannot free all memory anyway, let's not free global
      allocations either
      07a670b8
  4. 08 Jun, 2020 1 commit
  5. 18 Jul, 2019 1 commit
    • Monty's avatar
      Fixed that mariadb-# binaries reads their corresponding entry from my.cnf · 47334649
      Monty authored
      - Added mariadb-# to load_default_groups to all mariadb-# scripts and
        mariadb-binaries.
      - Added mariadbd and mariadbd-"version" to load_default_groups for the
        mysqld/mariadb server
      - Added mariadb-client to load_default_groups for the mysql/mariadb client
      
      Other things
      - Ignored mysql-test/lib/My/SafeProcess/wsrep_check_version
      - mysql_install_db will now automatically detect if run from srcdir
      47334649
  6. 17 Jun, 2019 2 commits
    • Vladislav Vaintroub's avatar
      MDEV-19750 mysql command wrong encoding · 5804bb4e
      Vladislav Vaintroub authored
      Restore the detection of default charset in command line utilities.
      It worked up to 10.1, but was broken by Connector/C.
      
      Moved code for detection of default charset from sql-common/client.c
      to mysys, and make command line utilities to use this code if charset
      was not specified on the command line.
      5804bb4e
    • Georg Richter's avatar
      MDEV-14101 Provide an option to select TLS protocol version · d1308013
      Georg Richter authored
      Server and command line tools now support option --tls_version to specify the
      TLS version between client and server. Valid values are TLSv1.0, TLSv1.1, TLSv1.2, TLSv1.3
      or a combination of them. E.g.
      
      --tls_version=TLSv1.3
      --tls_version=TLSv1.2,TLSv1.3
      
      In case there is a gap between versions, the lowest version will be used:
      --tls_version=TLSv1.1,TLSv1.3 -> Only TLSv1.1 will be available.
      
      If the used TLS library doesn't support the specified TLS version, it will use
      the default configuration.
      
      Limitations:
      
      SSLv3 is not supported. The default configuration doesn't support TLSv1.0 anymore.
      TLSv1.3 protocol currently is only supported by OpenSSL 1.1.0 (client and server) and
      GnuTLS 3.6.5 (client only).
      
      Overview of TLS implementations and protocols
      
      Server:
      
      +-----------+-----------------------------------------+
      | Library   | Supported TLS versions                  |
      +-----------+-----------------------------------------+
      | WolfSSL   | TLSv1.1, TLSv1,2                        |
      +-----------+-----------------------------------------+
      | OpenSSL   | (TLSv1.0), TLSv1.1, TLSv1,2, TLSv1.3    |
      +-----------+-----------------------------------------+
      | LibreSSL  | (TLSv1.0), TLSv1.1, TLSv1,2, TLSv1.3    |
      +-----------+-----------------------------------------+
      
      Client (MariaDB Connector/C)
      +-----------+-----------------------------------------+
      | Library   | Supported TLS versions                  |
      +-----------+-----------------------------------------+
      | GnuTLS    | (TLSv1.0), TLSv1.1, TLSv1.2, TLSv1.3    |
      +-----------+-----------------------------------------+
      | Schannel  | (TLSv1.0), TLSv1.1, TLSv1.2             |
      +-----------+-----------------------------------------+
      | OpenSSL   | (TLSv1.0), TLSv1.1, TLSv1,2, TLSv1.3    |
      +-----------+-----------------------------------------+
      | LibreSSL  | (TLSv1.0), TLSv1.1, TLSv1,2, TLSv1.3    |
      +-----------+-----------------------------------------+
      d1308013
  7. 15 May, 2019 1 commit
  8. 11 May, 2019 1 commit
  9. 06 May, 2019 1 commit
  10. 09 Dec, 2018 1 commit
  11. 20 Aug, 2018 1 commit
  12. 16 Mar, 2018 2 commits
  13. 06 Feb, 2018 1 commit
    • Vladislav Vaintroub's avatar
      MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from... · 6c279ad6
      Vladislav Vaintroub authored
      MDEV-15091 : Windows, 64bit: reenable and fix warning C4267 (conversion from 'size_t' to 'type', possible loss of data)
      
      Handle string length as size_t, consistently (almost always:))
      Change function prototypes to accept size_t, where in the past
      ulong or uint were used. change local/member variables to size_t
      when appropriate.
      
      This fix excludes rocksdb, spider,spider, sphinx and connect for now.
      6c279ad6
  14. 19 Dec, 2017 1 commit
    • Sergey Vojtovich's avatar
      MDEV-14265 - RPMLint warning: shared-lib-calls-exit · 2cd31691
      Sergey Vojtovich authored
      find_type_or_exit() client helper did exit(1) on error, exit(1) moved to
      clients.
      
      mysql_read_default_options() did exit(1) on error, error is passed through and
      handled now.
      
      my_str_malloc_default() did exit(1) on error, replaced my_str_ allocator
      functions with normal my_malloc()/my_realloc()/my_free().
      
      sql_connect.cc did many exit(1) on hash initialisation failure. Removed error
      check since my_hash_init() never fails.
      
      my_malloc() did exit(1) on error. Replaced with abort().
      
      my_load_defaults() did exit(1) on error, replaced with return 2.
      
      my_load_defaults() still does exit(0) when invoked with --print-defaults.
      2cd31691
  15. 06 Jul, 2017 1 commit
  16. 10 Mar, 2017 1 commit
  17. 09 Mar, 2017 1 commit
  18. 25 Aug, 2016 1 commit
  19. 19 Aug, 2016 2 commits
  20. 03 Jun, 2016 1 commit
  21. 02 Jun, 2016 1 commit
  22. 30 May, 2016 1 commit
    • Arun Kuruvila's avatar
      Bug#23035296: MAIN.MYSQLDUMP FAILS BECUASE OF UNEXPECTED · 5dc6a77b
      Arun Kuruvila authored
                    ERROR MESSAGE
      
      Description:- Mtr test, "main.mysqldump" is failing with an
      assert when "mysqlimport" client utility is executed with
      the option "--use_threads".
      
      Analysis:- "mysqlimport" uses the option, "--use_threads",
      to spawn worker threads to complete its job in parallel. But
      currently the main thread is not waiting for the worker
      threads to complete its cleanup, rather just wait for the
      worker threads to say its done doing its job. So the cleanup
      is done in a race between the worker threads and the main
      thread. This lead to an assertion failure.
      
      Fix:- "my_thread_join()" is introduced in the main thread to
      join all the worker threads it have spawned. This will let
      the main thread to wait for all the worker threads to
      complete its cleanup before calling "my_end()".
      5dc6a77b
  23. 19 Feb, 2016 1 commit
  24. 14 Oct, 2015 1 commit
    • Arun Kuruvila's avatar
      Bug #21235226 : THE --ENABLE-CLEARTEXT-PLUGIN IS NOT · a86191c6
      Arun Kuruvila authored
                      IMPLEMENTED IN ALL CLIENT PROGRAMS
      
      Description: Option "enable-cleartext-plugin" is not
      available for the following client utilities:-
      mysqldump
      mysqlimport
      mysqlshow
      mysqlcheck
      
      Analysis: The unavailability of this option limits the
      features like PAM authentication from using the above
      mentioned utilities.
      
      Fix: Option "enable-cleartext-plugin" is implemented in the
      above mentioned client utilities.
      a86191c6
  25. 09 Oct, 2015 1 commit
    • Sergei Golubchik's avatar
      fixes for buildbot: · 16c4b3c6
      Sergei Golubchik authored
      * OSX (mysqlimport freeing unallocated memory)
      * Windows (didn't compile MSI)
      * fulltest2 (innodb crashes in --embedded --big)
      16c4b3c6
  26. 27 Jul, 2015 1 commit
  27. 30 Jun, 2015 1 commit
    • Arun Kuruvila's avatar
      Bug #20772273 : MYSQLIMPORT --USE-THREADS DOESN'T USE · 7c5d18e2
      Arun Kuruvila authored
                      MULTIPLE THREADS
      
      Description:- The utility "mysqlimport" does not use
      multiple threads for the execution with option
      "--use-threads". "mysqlimport" while importing multiple
      files and multiple tables, uses a single thread even if the
      number of threads are specified with "--use-threads" option.
      
      Analysis:- This utility uses ifdef HAVE_LIBPTHREAD to check
      for libpthread library and if defined uses libpthread
      library for mutlithreaing. Since HAVE_LIBPTHREAD is not
      defined anywhere in the source, "--use-threads" option is
      silently ignored.
      
      Fix:- "-DTHREADS" is set to the COMPILE_FLAGS  which will
      enable pthreads. HAVE_LIBPTHREAD macro is removed.
      7c5d18e2
  28. 05 Oct, 2014 1 commit
    • Sergei Golubchik's avatar
      fix main.mysqldump test failing after Mroonga merge. · 3050b290
      Sergei Golubchik authored
      mysqlimport had code for multi-threaded import. By mistake it was disabled for
      many years, at least since 5.5 (more likely even in 5.1), but mysqlimport happily
      accepted (and ignored) --use-threads option ever since.
      
      After Mroonga merge HAVE_LIBPTHREAD became defined and multi-threaded import
      suddenly came to life. As it exit() the program brutally on any error (never mind
      that some import threads may be running) mysys rightfully complains. Safemalloc
      complains too in debug builds.
      
      Fix: don't try a clean exit on an error, don't shutdown mysys and tell safemalloc
      to shut up. Yes, and remove #ifdef HAVE_LIBPTHREAD, since 5.5 the client library
      is always multi-threaded.
      3050b290
  29. 22 Jan, 2014 1 commit
    • Michael Widenius's avatar
      Fix for MDEV-5547: Bad error message when moving very old .frm files to MariaDB 5.5. · 04bee0af
      Michael Widenius authored
      mysql_upgrade --help now also prints out --default options and variable values.
      mysql_upgrade now prints permission errors.
      mysql_upgrade doesn't print some non essential info if --silent is used.
      Added handler error message about incompatible versions
      Fixed that mysqlbug and mysql_install_db have the executable flag set.
      Removed executable flag for some non executable files.
      Changed in mysql_install_db askmonty.org to mariadb.com.
      Ensured that all client executables prints --default options the same way.
      Allow REPAIR ... USE_FRM for old .frm files if the are still compatible.
      Extended shown error for storage engine messages.
      
      
      client/mysql.cc:
        print_defaults() should be first (as in all other programs)
      client/mysql_upgrade.c:
        --help now also prints out --default options and variable values
        Print out error if wrong permissions
        Don't print info if --silent
      client/mysqladmin.cc:
        print_defaults() should be first (as in all other programs)
      client/mysqlbinlog.cc:
        Added print_defaults() to --help
      client/mysqlcheck.c:
        Added empty line in --help
      client/mysqlimport.c:
        Added empty line in --help
      client/mysqlshow.c:
        Made --help compatible
      client/mysqlslap.c:
        Made --help compatible
      client/mysqltest.cc:
        Added print_defaults() to --help
      include/handler_ername.h:
        Added handler error message
      include/my_base.h:
        Added handler error message
      mysql-test/r/mysql_upgrade.result:
        Updated results
      mysql-test/r/repair.result:
        Added test case for better error messages
      mysql-test/std_data/host_old.MYD:
        Added test case for better error messages
      mysql-test/std_data/host_old.MYI:
        Added test case for better error messages
      mysql-test/std_data/host_old.frm:
        Added test case for better error messages
      mysql-test/t/repair.test:
        Added test case for better error messages
      mysys/my_handler_errors.h:
        Added handler error message
      scripts/CMakeLists.txt:
        Fixed that mysqlbug and mysql_install_db have the executable flag set
      scripts/mysql_install_db.sh:
        askmonty.org -> mariadb.com
      sql/ha_partition.cc:
        Sometimes table_type() can be called for errors even if partition didn't manage to open any files
      sql/handler.cc:
        Write clear text for not handled, but defined error messages.
      sql/share/errmsg-utf8.txt:
        Extended shown error for storage engine messages
      sql/sql_admin.cc:
        Allow REPAIR ... USE_FRM for old .frm files if the are still compatible
      storage/myisam/ha_myisam.cc:
        Use new error message
      04bee0af
  30. 03 Oct, 2013 1 commit
  31. 14 Aug, 2012 1 commit
  32. 07 Aug, 2012 2 commits
    • Nirbhay Choubey's avatar
      Bug#13928675 MYSQL CLIENT COPYRIGHT NOTICE MUST · 5ad8292c
      Nirbhay Choubey authored
                   SHOW 2012 INSTEAD OF 2011
      
      * Added a new macro to hold the current year :
        COPYRIGHT_NOTICE_CURRENT_YEAR
      * Modified ORACLE_WELCOME_COPYRIGHT_NOTICE macro
        to take the initial year as parameter and pick
        current year from the above mentioned macro.
      5ad8292c
    • Nirbhay Choubey's avatar
      Bug#13928675 MYSQL CLIENT COPYRIGHT NOTICE MUST · d4e4538b
      Nirbhay Choubey authored
                   SHOW 2012 INSTEAD OF 2011
      
      * Added a new macro to hold the current year :
        COPYRIGHT_NOTICE_CURRENT_YEAR
      * Modified ORACLE_WELCOME_COPYRIGHT_NOTICE macro
        to take the initial year as parameter and pick
        current year from the above mentioned macro.
      d4e4538b
  33. 23 Mar, 2012 1 commit
  34. 12 Dec, 2011 1 commit
    • Sergei Golubchik's avatar
      move safemalloc out of dbug. · 6cc9d0ff
      Sergei Golubchik authored
      remeber a real backtrace for every allocation.
      make safemalloc to tract C++ new/delete too.
      collateral fixes to make the test suite pass.
      6cc9d0ff
  35. 22 Jul, 2011 2 commits
    • Alexander Nozdrin's avatar
      For for Bug#12696072: FIX OUTDATED COPYRIGHT NOTICES IN RUNTIME RELATED CLIENT · cb523995
      Alexander Nozdrin authored
      TOOLS
      
      Backport a fix for Bug 57094 from 5.5.
      The following revision was backported:
      
      # revision-id: alexander.nozdrin@oracle.com-20101006150613-ls60rb2tq5dpyb5c
      # parent: bar@mysql.com-20101006121559-am1e05ykeicwnx48
      # committer: Alexander Nozdrin <alexander.nozdrin@oracle.com>
      # branch nick: mysql-5.5-bugteam-bug57094
      # timestamp: Wed 2010-10-06 19:06:13 +0400
      # message:
      #   Fix for Bug 57094 (Copyright notice incorrect?).
      #   
      #   The fix is to:
      #     - introduce ORACLE_WELCOME_COPYRIGHT_NOTICE define to have a single place
      #       to specify copyright notice;
      #     - replace custom copyright notices with ORACLE_WELCOME_COPYRIGHT_NOTICE
      #       in programs.
      cb523995
    • Alexander Nozdrin's avatar
      For for Bug#12696072: FIX OUTDATED COPYRIGHT NOTICES IN RUNTIME RELATED CLIENT · f7618904
      Alexander Nozdrin authored
      TOOLS
      
      Backport a fix for Bug 57094 from 5.5.
      The following revision was backported:
      
      # revision-id: alexander.nozdrin@oracle.com-20101006150613-ls60rb2tq5dpyb5c
      # parent: bar@mysql.com-20101006121559-am1e05ykeicwnx48
      # committer: Alexander Nozdrin <alexander.nozdrin@oracle.com>
      # branch nick: mysql-5.5-bugteam-bug57094
      # timestamp: Wed 2010-10-06 19:06:13 +0400
      # message:
      #   Fix for Bug 57094 (Copyright notice incorrect?).
      #   
      #   The fix is to:
      #     - introduce ORACLE_WELCOME_COPYRIGHT_NOTICE define to have a single place
      #       to specify copyright notice;
      #     - replace custom copyright notices with ORACLE_WELCOME_COPYRIGHT_NOTICE
      #       in programs.
      f7618904