1. 28 Jul, 2020 2 commits
  2. 27 Jul, 2020 1 commit
    • Marko Mäkelä's avatar
      MDEV-23295 ROW_FORMAT mismatch in instant ALTER TABLE · fd9ca2a7
      Marko Mäkelä authored
      An instant ADD/DROP/reorder column could create a dummy table
      object with the wrong ROW_FORMAT when innodb_default_row_format
      was changed between CREATE TABLE and ALTER TABLE.
      
      prepare_inplace_alter_table_dict(): If we had promised that
      ALGORITHM=INPLACE is supported, we must preserve the ROW_FORMAT.
      
      dict_table_t::prepare_instant(): Add debug assertions to catch
      ROW_FORMAT mismatch.
      
      The rest of the changes are related to adding
      Alter_inplace_info::inplace_supported to cache the return value of
      handler::check_if_supported_inplace_alter().
      fd9ca2a7
  3. 26 Jul, 2020 1 commit
  4. 24 Jul, 2020 10 commits
    • Marko Mäkelä's avatar
      MDEV-22651: Bogus assertion in dict_table_t::init_instant() · 05d62518
      Marko Mäkelä authored
      In commit 0e5a4ac2 (MDEV-15562)
      we introduced a bogus debug assertion, demanding that dict_col_t::len
      never exceed some maximum value. The intention was to match what
      dict_index_add_col() is doing. But, the assignment field->fixed_len = 0
      applies to dict_field_t::fixed_len, not dict_col_t::len!
      05d62518
    • Teemu Ollakka's avatar
    • Jan Lindström's avatar
      Add missing includes. · 468e56bf
      Jan Lindström authored
      468e56bf
    • Jan Lindström's avatar
      Update Galera global warning ignore list. · bec81db1
      Jan Lindström authored
      bec81db1
    • Teemu Ollakka's avatar
      MDEV-21718 Assertion in wsrep::client_state::before_command(). · 1e2a4ed7
      Teemu Ollakka authored
      An assertion
      
        `server_state_.rollback_mode() == wsrep::server_state::rm_async`
      
      fired in before_command() when
      - thread-handling was set to pool-of-threads and
      - a BF abort happened between client session calls to
        wait_rollback_complete_and_acquire_ownership() and before_command().
      
      This commit introduces a test case to reproduce the crash and
      updates wsrep-lib submodule to fixed version.
      1e2a4ed7
    • Jan Lindström's avatar
      Silence unnecessary warning. · 134a6a8d
      Jan Lindström authored
      134a6a8d
    • Alexey Yurchenko's avatar
    • sjaakola's avatar
      MDEV-20928 mtr test galera.galera_var_innodb_disallow_writes test failure · 95132ade
      sjaakola authored
      The sporadic test hangs happen because of mutex dealock between innodb
      background threads and two test connection executions.
      The test sets variable innodb_disallow_writes, which blocks all writes
      to filesyste. The test logic is to execute an INSERT, which should hang
      because of filesytstem writes are blocked, and through another session
      verify by SELECT that this hanging happens. The SELECT session will then
      release innodb_disallow_writes blocking.
      
      However, filesystem write  blocking affects also innodb background threads
      and they may hang while keeping some other resources locked.
      As an example, in one test hang situation, buffer pool access was blocked.
      And, if buffer pool is blocked, the test connections will be blocked as well,
      and the SELECT session will not be able to continue to release the
      innodb_disallow_writes.
      
      The fix in this commit is refactoring of the test logic.
      The test will now set first innodb_disallow_writes blocking, and then record
      a hash of data directory's filesystem contents. This works as checksum of the
      state of data on the datadirectory.
      
      Then some SQL load is tried on both nodes, these sessions will be blocking
      due to frozen file system state. The test will have a short sleep to allow
      innodb background threads to loop and possibly encounter innodb_disallow_writes
      blocking as well.
      
      After the sleep, the test will record file system checksun for the second time,
      and then release the innodb_disallow-writes blocking.
      
      Finally, the two checksums are compared, they should be identical to verify that
      nothing was written on datadirectory during the test execution.
      
      The checksum is implemented by md5sum hash over all files found in datadirectory
      by find command. all these file hashes are hashed together by one more md5sum.
      
      The test therefore depends on md5sum and find. find may work differently with some
      OS distributions, e.g. freebsd may be problematic.
      95132ade
    • mkaruza's avatar
      MDEV-22458: Server with WSREP hangs after INSERT, wrong usage of mutex... · 4b4372af
      mkaruza authored
      MDEV-22458: Server with WSREP hangs after INSERT, wrong usage of mutex 'LOCK_thd_data' and 'share->intern_lock' / 'lock->mutex'
      
      Add `find_thread_by_id_with_thd_data_lock` which will be used only when killing thread.
      This version needs to take `thd->LOCK_thd_data` lock.
      4b4372af
    • mkaruza's avatar
      MDEV-21905: Galera test galera_var_notify_cmd causes hang · 6b8b7b1e
      mkaruza authored
      Fixed wsrep_notify.sh script so it only reports status changes on
      'joined', 'synced', 'donor'.
      6b8b7b1e
  5. 23 Jul, 2020 3 commits
    • Tzachi Zidenberg's avatar
      aarch64: use compiler flag outline-atomics if available · f843e215
      Tzachi Zidenberg authored
      outline-atomics compilation flag changes behaviour of builtin_atomics,
      by adding runtime detection of LSE atomics. If these are supported, they
      will be used. This gains LSE atomics use without hurting compatibility
      with older aarch64 machines.
      f843e215
    • Tzachi Zidenberg's avatar
      MDEV-23249: Support aarch64 architecture timer · c76b45a5
      Tzachi Zidenberg authored
      aarch64 timer is available to userspace via arch register.
      clang's __builtin_readcyclecounter is wrong for aarch64 (reads the PMU
      cycle counter instead of the archi-timer register), so we don't use it.
      
      my_rdtsc unit-test on AWS m6g shows:
      frequency: 121830845
      resolution: 1
      overhead: 1
      
      This counter is not strictly increasing, but it is non-decreasing.
      c76b45a5
    • Marko Mäkelä's avatar
      MDEV-22778 Slow InnoDB shutdown on large instance · 5f2628d1
      Marko Mäkelä authored
      Starting with MDEV-17441 we would no longer have os_once,
      and we would always initialize zip_pad_info_t::mutex and
      dict_table_t::autoinc_mutex, even for tables are not in
      ROW_FORMAT=COMPRESSED nor include any AUTO_INCREMENT column.
      
      mutex_free() on those unnecessary objects would make shutdown very slow
      compared to older versions.
      
      Let us use std::mutex for those two mutexes, to reduce the overhead.
      The critical sections protected by these mutexes is very small, and
      therefore contention or the need for any instrumentation should
      be unlikely.
      5f2628d1
  6. 22 Jul, 2020 3 commits
  7. 21 Jul, 2020 4 commits
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · b1538f4d
      Marko Mäkelä authored
      b1538f4d
    • Marko Mäkelä's avatar
      MDEV-15880: ASAN heap-use-after-free with innodb_evict_tables_on_commit_debug · b75563cd
      Marko Mäkelä authored
      trx_update_mod_tables_timestamp(): When implementing
      innodb_evict_tables_on_commit_debug, do not evict tables
      on which transactional locks exist.
      
      This debug variable was broken since its introduction in
      commit 947b0b57.
      b75563cd
    • Monty's avatar
      MDEV-16929 Assertion ... in close_thread_tables upon killing connection · e26c822a
      Monty authored
      Problem was that the code didn't handle a transaction created in innodb
      as part of a failed mysql_lock_tables()
      e26c822a
    • Monty's avatar
      MDEV-21953 deadlock between BACKUP STAGE BLOCK_COMMIT and parallel repl. · fc48c8ff
      Monty authored
      The issue was:
      T1, a parallel slave worker thread, is waiting for another worker thread to
      commit. While waiting, it has the MDL_BACKUP_COMMIT lock.
      T2, working for mariabackup, is doing BACKUP STAGE BLOCK_COMMIT and blocks
      all commits.
      This causes a deadlock as the thread T1 is waiting for can't commit.
      
      Fixed by moving locking of MDL_BACKUP_COMMIT from ha_commit_trans() to
      commit_one_phase_2()
      
      Other things:
      - Added a new argument to ha_comit_one_phase() to signal if the
        transaction was a write transaction.
      - Ensured that ha_maria::implicit_commit() is always called under
        MDL_BACKUP_COMMIT. This code is not needed in 10.5
      - Ensure that MDL_Request values 'type' and 'ticket' are always
        initialized. This makes it easier to check the state of the MDL_Request.
      - Moved thd->store_globals() earlier in handle_rpl_parallel_thread() as
        thd->init_for_queries() could use a MDL that could crash if store_globals
        where not called.
      - Don't call ha_enable_transactions() in THD::init_for_queries() as this
        is both slow (uses MDL locks) and not needed.
      fc48c8ff
  8. 20 Jul, 2020 10 commits
    • Eugene Kosov's avatar
      MDEV-22899 Assertion `field->col->is_binary() || field->prefix_len %... · c4d5b6b1
      Eugene Kosov authored
      MDEV-22899 Assertion `field->col->is_binary() || field->prefix_len % field->col->mbmaxlen == 0' failed in dict_index_add_to_cache
      
      is_part_of_a_key(): detect is TEXT field is a part of some key
      
      ha_innobase::can_convert_blob(): now correctly detect whether our blob
      is a part of some key. Previously the check didn't work in some cases.
      c4d5b6b1
    • Aleksey Midenkov's avatar
      MDEV-20661 Virtual fields are not recalculated on system fields value assignment · af83ed9f
      Aleksey Midenkov authored
      Fix stale virtual field value in 4 cases: when virtual field depends
      on row_start/row_end in timestamp/trx_id versioned table. row_start
      dep is recalculated in vers_update_fields() (SQL and InnoDB
      layer). row_end dep is recalculated on history row insert.
      af83ed9f
    • Aleksey Midenkov's avatar
      MDEV-22061 InnoDB: Assertion of missing row in sec index row_start upon... · af57c658
      Aleksey Midenkov authored
      MDEV-22061 InnoDB: Assertion of missing row in sec index row_start upon REPLACE on a system-versioned table
      
      make_versioned_helper() appended new update field unconditionally
      while it should check if this field already exists in update vector.
      
      Misc renames to conform versioning prefix. vers_update_fields() name
      conforms with sql layer TABLE::vers_update_fields().
      af57c658
    • Marko Mäkelä's avatar
      Merge 10.3 into 10.4 · 4b959bd8
      Marko Mäkelä authored
      4b959bd8
    • Marko Mäkelä's avatar
      Merge 10.2 into 10.3 · acc58fd8
      Marko Mäkelä authored
      acc58fd8
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · ca9276e3
      Marko Mäkelä authored
      ca9276e3
    • Marko Mäkelä's avatar
      MDEV-23190 InnoDB data file extension is not crash-safe · 57ec42bc
      Marko Mäkelä authored
      When InnoDB is extending a data file, it is updating the FSP_SIZE
      field in the first page of the data file.
      
      In commit 8451e090 (MDEV-11556)
      we removed a work-around for this bug and made recovery stricter,
      by making it track changes to FSP_SIZE via redo log records, and
      extend the data files before any changes are being applied to them.
      
      It turns out that the function fsp_fill_free_list() is not crash-safe
      with respect to this when it is initializing the change buffer bitmap
      page (page 1, or generally, N*innodb_page_size+1). It uses a separate
      mini-transaction that is committed (and will be written to the redo
      log file) before the mini-transaction that actually extended the data
      file. Hence, recovery can observe a reference to a page that is
      beyond the current end of the data file.
      
      fsp_fill_free_list(): Initialize the change buffer bitmap page in
      the same mini-transaction.
      
      The rest of the changes are fixing a bug that the use of the separate
      mini-transaction was attempting to work around. Namely, we must ensure
      that no other thread will access the change buffer bitmap page before
      our mini-transaction has been committed and all page latches have been
      released.
      
      That is, for read-ahead as well as neighbour flushing, we must avoid
      accessing pages that might not yet be durably part of the tablespace.
      
      fil_space_t::committed_size: The size of the tablespace
      as persisted by mtr_commit().
      
      fil_space_t::max_page_number_for_io(): Limit the highest page
      number for I/O batches to committed_size.
      
      MTR_MEMO_SPACE_X_LOCK: Replaces MTR_MEMO_X_LOCK for fil_space_t::latch.
      
      mtr_x_space_lock(): Replaces mtr_x_lock() for fil_space_t::latch.
      
      mtr_memo_slot_release_func(): When releasing MTR_MEMO_SPACE_X_LOCK,
      copy space->size to space->committed_size. In this way, read-ahead
      or flushing will never be invoked on pages that do not yet exist
      according to FSP_SIZE.
      57ec42bc
    • Marko Mäkelä's avatar
      98e2c17e
    • Marko Mäkelä's avatar
      14543afd
    • Marko Mäkelä's avatar
      MDEV-22771 Instant extension of CHAR column is wrongly allowed · 0a7faed7
      Marko Mäkelä authored
      commit 854c219a (MDEV-17301)
      broke a constraint: Fixed-length columns cannot be extended in InnoDB
      without rebuilding the table.
      
      ha_innobase::can_convert_string(): Correct the condition. We must
      not allow any instantaneous change to the length of CHAR columns
      measured in characters. For any format other than ROW_FORMAT=REDUNDANT,
      we can allow the length in bytes to be extended if mbminlen<mbmaxlen held
      before the change of the character set.
      0a7faed7
  9. 18 Jul, 2020 1 commit
  10. 17 Jul, 2020 1 commit
  11. 16 Jul, 2020 4 commits