1. 29 Mar, 2007 12 commits
    • unknown's avatar
      Merge quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/41 · e76abb0d
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50
      
      
      myisam/mi_open.c:
        Auto merged
      sql-common/my_time.c:
        Auto merged
      sql/table.cc:
        Auto merged
      mysql-test/r/create.result:
        Manual merge
      mysql-test/t/create.test:
        Manual merge
      e76abb0d
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · d3643c89
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50
      
      
      d3643c89
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · 0f6bf015
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      0f6bf015
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/bug25309/my50-bug25309 · 27f8d830
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/t/openssl_1.test:
        Auto merged
      27f8d830
    • unknown's avatar
      Make the script detect --default-storage-engine=x and · 8b873c3f
      unknown authored
      mark the test as requiring that storage engine(if we need to do that)
      Make --ndb and --with-ndbcluster and alias for
      --mysqld=--default-storage-engine=ndbcluster
      
      
      8b873c3f
    • unknown's avatar
      gis_generic test cases: · 4e907a7f
      unknown authored
        Revert test case to NOT define any keys; the NDB warning can be handled, and ARCHIVE does not allow indexes
      
      
      mysql-test/include/gis_generic.inc:
        Revert test case to NOT define any keys; the NDB warning can be handled, and ARCHIVE does not allow indexes
      mysql-test/r/archive_gis.result:
        Revert test case to NOT define any keys; the NDB warning can be handled, and ARCHIVE does not allow indexes
      mysql-test/r/bdb_gis.result:
        Revert test case to NOT define any keys; the NDB warning can be handled, and ARCHIVE does not allow indexes
      mysql-test/r/innodb_gis.result:
        Revert test case to NOT define any keys; the NDB warning can be handled, and ARCHIVE does not allow indexes
      mysql-test/r/ndb_gis.result:
        Revert test case to NOT define any keys; the NDB warning can be handled, and ARCHIVE does not allow indexes
      4e907a7f
    • unknown's avatar
      Merge tsmith@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 1632a3fe
      unknown authored
      into  quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/50
      
      
      1632a3fe
    • unknown's avatar
      Merge mysql.com:/home/ram/work/mysql-5.0-maint · df990635
      unknown authored
      into  mysql.com:/home/ram/work/b26359/b26359.5.0
      
      
      mysql-test/r/strict.result:
        Auto merged
      mysql-test/t/strict.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/field.h:
        Auto merged
      df990635
    • unknown's avatar
      Apply innodb-5.0-ss1372 snapshot · 3832b71b
      unknown authored
      Bug #27381: InnoDB exits when attempting to rename table to non-existant database
        Fix Bug#27381 by calling os_file_handle_error_no_exit() instead of
        os_file_handle_error().
      
      
      innobase/dict/dict0dict.c:
        Apply innodb-5.0-ss1372 snapshot
        
        Revision r1351:
        branches/5.0: Merge r1350 from trunk:
        
        Lock the data dictionary during rollback.  This removes the rare
        debug assertion failure ut_ad(mutex_own(&(dict_sys->mutex))) in
        dict_table_get_on_id() after the rollback following crash recovery.
      innobase/os/os0file.c:
        Apply innodb-5.0-ss1372 snapshot
        
        Revision r1354:
        branches/5.0: Merge r1352 from trunk:
        (also make indentation the same as in 5.1 to ease further merges)
        
        Fix typo in comment in os/os0file.c
        
        
        
        Revision r1370:
        branches/5.0: Merge r1366 from trunk:
        
        Fix Bug#27381 by calling os_file_handle_error_no_exit() instead of
        os_file_handle_error().
      innobase/row/row0undo.c:
        Apply innodb-5.0-ss1372 snapshot
        
        Revision r1351:
        branches/5.0: Merge r1350 from trunk:
        
        Lock the data dictionary during rollback.  This removes the rare
        debug assertion failure ut_ad(mutex_own(&(dict_sys->mutex))) in
        dict_table_get_on_id() after the rollback following crash recovery.
      3832b71b
    • unknown's avatar
      Fix for bugs · 86010101
      unknown authored
      #27176: Assigning a string to an year column has unexpected results
      #26359: Strings becoming truncated and converted to numbers under STRICT mode
      
      Problems: 
      1. storing a string to an integer field we don't check 
         if strntoull10rnd() returns MY_ERRNO_EDOM error.
         Fix: check for MY_ERRNO_EDOM.
      2. storing a string to an year field we use my_strntol() function.
         Fix: use strntoull10rnd() instead.
      
      
      mysql-test/r/strict.result:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
          - test result.
      mysql-test/r/type_date.result:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
          - test result.
      mysql-test/r/type_year.result:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
          - test result.
      mysql-test/t/strict.test:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
          - test case.
      mysql-test/t/type_year.test:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
      sql/field.cc:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
          - Field_num::get_int() method introduced. It converts a string to integer
            then check errors and bounds.
          - similar Field_tiny::store(const char...),  Field_short::store(const char...),
            Field_medium::store(const char...), Field_long::store(const char...)
            rewritten, now they just call Field_num::get_int() then store value returned.
          - Field_num::check_int() simplified.
          - Field_year::store(const char...) now uses strntoull10rnd() and properly checks
            errors returned.
      sql/field.h:
        Fix for bugs
        #27176: Assigning a string to an year column has unexpected results
        #26359: Strings becoming truncated and converted to numbers under STRICT mode
         - check_int() moved to Field_num.
         - get_int() introduced.
      86010101
    • unknown's avatar
      Fix warning on Windows · db9af0d8
      unknown authored
      
      sql/log.cc:
        Change print_buffer_to_nt_eventlog() to take size_t instead of int/uint for buffer sizes
      db9af0d8
    • unknown's avatar
      Update test for bug #24563 (MBROverlaps does not seem to function propertly.);... · b9fd97f5
      unknown authored
      Update test for bug #24563 (MBROverlaps does not seem to function propertly.); ARCHIVE doesn't support AUTO_INCREMENT, so specify PK values explicitly
      
      
      mysql-test/r/archive_gis.result:
        update test result
      mysql-test/r/bdb_gis.result:
        update test result
      mysql-test/r/innodb_gis.result:
        update test result
      mysql-test/r/ndb_gis.result:
        update test result
      b9fd97f5
  2. 28 Mar, 2007 17 commits
    • unknown's avatar
      Remove warning when compiling libmysqld/log.cc · 465cf738
      unknown authored
      
      sql/log.cc:
        define print_buffer_to_file only ifdef EMBEDDED_LIBRARY, to avoid "defined but not used" warning
      465cf738
    • unknown's avatar
      Update test for bug #24563 (MBROverlaps does not seem to function propertly.): · 942bb0df
      unknown authored
      - Add primary key to test table, so NDB with binlog doesn't complain
      - Add extra results for bdb_gis.result
      
      
      mysql-test/include/gis_generic.inc:
        Update test for bug #24563 (MBROverlaps does not seem to function propertly.):
        - Add primary key to test table, so NDB with binlog doesn't complain
      mysql-test/r/archive_gis.result:
        update test results
      mysql-test/r/bdb_gis.result:
        update test results
      mysql-test/r/innodb_gis.result:
        update test results
      mysql-test/r/ndb_gis.result:
        update test results
      942bb0df
    • unknown's avatar
      Bug #26642: create index corrupts table definition in .frm · 0b72b7f0
      unknown authored
      Thanks to Martin Friebe for finding and submitting a fix for this bug!
      
      A table with maximum number of key segments and maximum length key name
      would have a corrupted .frm file, due to an incorrect calculation of the
      complete key length.  Now the key length is computed correctly (I hope) :-)
      
      MyISAM would reject a table with the maximum number of keys and the maximum
      number of key segments in all keys.  It would allow one less than this total
      maximum.  Now MyISAM accepts a table defined with the maximum.  (This is a
      very minor issue.)
      
      
      myisam/mi_open.c:
        change >= to > in a comparison (i.e., error only if key_parts_in_table
        really is greater than MAX_KEY * MAX_KEY_SEG)
      mysql-test/r/create.result:
        Add test results for bug #26642 (create index corrupts table definition in .frm)
      mysql-test/t/create.test:
        Add test case for bug #26642 (create index corrupts table definition in .frm)
      sql/table.cc:
        In create_frm(), fix formula for key_length; it was too small by (keys * 2) bytes
      0b72b7f0
    • unknown's avatar
      Merge siva.hindu.god:/home/tsmith/m/bk/maint/bmisc/50 · 3d52fb0e
      unknown authored
      into  siva.hindu.god:/home/tsmith/m/bk/maint/50
      
      
      3d52fb0e
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 96581624
      unknown authored
      into  polly.local:/home/kaa/src/maint/mysql-5.0-maint
      
      
      96581624
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/yassl_import/my50-yassl_import · 9bda2b2b
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      9bda2b2b
    • unknown's avatar
      Import yaSSL · 05853ab0
      unknown authored
      
      extra/yassl/src/ssl.cpp:
        Import patch yassl.diff
      05853ab0
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/bug27490/my50-bug27490 · 40378712
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      sql/log.cc:
        Auto merged
      40378712
    • unknown's avatar
      Merge polly.local:/tmp/maint/bug26844/my50-bug26844 · 6ba16a70
      unknown authored
      into  polly.local:/home/kaa/src/maint/mysql-5.0-maint
      
      
      6ba16a70
    • unknown's avatar
      Add back the look for exe_mysql · 1778d177
      unknown authored
      1778d177
    • unknown's avatar
      Set yaSSL to use same type as MySQL do for socket handles · ff7db598
      unknown authored
      
      extra/yassl/include/openssl/ssl.h:
        Import patch yassl.diff
      extra/yassl/src/ssl.cpp:
        Import patch yassl.diff
      ff7db598
    • unknown's avatar
      Bug#25309 SSL connections without CA certificate broken since MySQL 5.0.23 · 40df5f68
      unknown authored
       - Turn off verification of peer if both ca_path and ca_file is null
         i.e from only passing --ssl-key=<client_key> and --ssl-cert=<client_cert>
         to the mysql utility programs.
         The server will authenticate the client accoring to GRANT tables
         but the client won't authenticate the server 
      
      
      mysql-test/r/openssl_1.result:
        Update result file
      mysql-test/t/openssl_1.test:
        Test that it's possible to connect with --ssl-ca set to /dev/null
      vio/viosslfactories.c:
        Turn off verification of peer if both ca_file and ca_path is NULL
      40df5f68
    • unknown's avatar
      Turn off im if extern · 230a116e
      unknown authored
      Remove strange comment
      Add run_query function 
      
      
      230a116e
    • unknown's avatar
      Dont' redirect stderr in ActiveState perl · 2bc57a69
      unknown authored
      Improve comments
      
      
      2bc57a69
    • unknown's avatar
      Bug#27490 Function to log to NT event log could allocate memory · 1747a6b6
      unknown authored
      - Change 'print_buffer_to_nt_event_log' to overwrite the string
      if the buffer is not long enough to hold the ending CR/LF's
      - Make functions static
      - Remove the "hack" intended to force 'print_buffer_to_nt_event_log'
       never to use "new"
      
      
      sql/log.cc:
        -Change 'print_buffer_to_nt_event_log' to overwrite the string
        if the buffer is not long enough to hold the ending CR/LF's
        - Make functions static
        - Remove the "hack" intended to force 'print_buffer_to_nt_event_log'
         never to use "new"
      1747a6b6
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/bug25197/my50-bug25197 · 2473c359
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/t/func_str.test:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      2473c359
    • unknown's avatar
      Bug#25197 repeat function returns null when using table field directly as count · e9b606bf
      unknown authored
       - Add extra test case from bug#27073
       - Change "if" to be optimized for count > 0
      
      
      mysql-test/r/func_str.result:
        Add test case from bug#27073
      mysql-test/t/func_str.test:
        Add test case from bug#27073
      sql/item_strfunc.cc:
        Change the if statemnet to be optimized for the normal case where count > 0
      e9b606bf
  3. 27 Mar, 2007 5 commits
  4. 26 Mar, 2007 4 commits
    • unknown's avatar
      Fix for bug #26844 "Memory allocation failures ignored by slave IO thread". · 3d90a07a
      unknown authored
      Pass ME_NOREFRESH flag to an error handler in my_malloc() and _mymalloc() in case of memory allocation failure, so that it gets logged to the error log.
      
      
      mysys/my_malloc.c:
        Pass ME_NOREFRESH flag to an error handler in my_malloc() in case of memory allocation failure, so that it gets logged to the error log.
      mysys/safemalloc.c:
        Pass ME_NOREFRESH flag to an error handler in _mymalloc() in case of memory allocation failure, so that it gets logged to the error log.
      3d90a07a
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1-maint · e77cdbe2
      unknown authored
      into  mysql.com:/home/ram/work/b25301/b25301.4.1
      
      
      sql-common/my_time.c:
        Auto merged
      e77cdbe2
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0-maint · 9dfe413a
      unknown authored
      into  mysql.com:/home/ram/work/b25301/b25301.5.0
      
      
      sql-common/my_time.c:
        Auto merged
      9dfe413a
    • unknown's avatar
      Fix for bug #25993: mysqldump crashes with merge table and -c option · 9b2e0127
      unknown authored
        
      opt_complete_insert was improperly used by accident.
      Use complete_insert flag instead.
      
      
      client/mysqldump.c:
        Fix for bug #25993: mysqldump crashes with merge table and -c option
          - use complete_insert instead of opt_complete_insert.
      mysql-test/r/mysqldump.result:
        Fix for bug #25993: mysqldump crashes with merge table and -c option
          - test result.
      mysql-test/t/mysqldump.test:
        Fix for bug #25993: mysqldump crashes with merge table and -c option
          - test case.
      9b2e0127
  5. 23 Mar, 2007 2 commits
    • unknown's avatar
      Bug #24563: MBROverlaps does not seem to function propertly. · eee28a26
      unknown authored
      Fix is to rewrite the MBR::overlaps() function, to compute the dimension of both
      arguments, and the dimension of the intersection; test that all three dimensions are the
      same (e.g., all are Polygons).
      
      Add tests for all MBR* functions for various combinations of shapes, lines and points.
      
      
      mysql-test/include/gis_generic.inc:
        Add tests & checks for bug #24563 and bug #24588 - some GIS functions missing in
        5.1; many GIS functions not tested; Overlaps() function was incorrect when MBR shifted
        only along one axis; Overlaps() needs to take dimension of shape into account.
      mysql-test/r/archive_gis.result:
        Update test results.
      mysql-test/r/bdb_gis.result:
        Update test results.
      mysql-test/r/gis.result:
        Update test results.
      mysql-test/r/innodb_gis.result:
        Update test results.
      mysql-test/r/ndb_gis.result:
        Update test results.
      mysql-test/t/gis.test:
        Add tests & checks for bug #24563 and bug #24588 - some GIS functions missing in
        5.1; many GIS functions not tested; Overlaps() function was incorrect when MBR shifted
        only along one axis; Overlaps() needs to take dimension of shape into account.
      sql/spatial.h:
        Add MBR::dimension() (map MBR to integral dimension: point -> 0, line -> 1,
        polygon -> 2, invalid -> -1)
        
        Fix MBR::overlaps() to handle MBRs which are shifted on one dimension only, and to
        take MBR dimension into account.  Also, test both within() and contains() predicates (so
        that overlaps(a, b) == overlaps(b, a)).
      eee28a26
    • unknown's avatar
      bug#26346 · 139c950f
      unknown authored
      Added some fixes for an existing memory leak and unitilialized variables, both caught by gcc.
      
      
      139c950f