1. 28 Apr, 2021 6 commits
  2. 27 Apr, 2021 9 commits
    • Sergei Golubchik's avatar
      Bug#29363867: LOST CONNECTION TO MYSQL SERVER DURING QUERY · 91599701
      Sergei Golubchik authored
      plugin variables in SET  only locked the plugin till the end of the
      statement. If SET with a plugin variable was prepared, it was possible
      to uninstall the plugin before EXECUTE. Then EXECUTE would crash,
      trying to resolve a now-invalid pointer to a disappeared variable.
      
      Fix: keep plugins locked until the prepared statement is closed.
      91599701
    • Sergei Golubchik's avatar
    • Sergei Golubchik's avatar
      MDEV-25326 mysql_install_db help text incomplete · 883b723d
      Sergei Golubchik authored
      encourage the use of mysql_secure_installation,
      that can always set the root password correctly for all root accounts,
      no matter how many are there and what the structure of privilege tables is
      883b723d
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-25503 InnoDB hangs on startup during recovery · b862377c
      Thirunarayanan Balathandayuthapani authored
      InnoDB startup hangs if a DDL transaction needs to be
      rolled back and a recovered transaction on statistics
      tables exists. In that case, InnoDB should rollback
      the transaction which holds locks on innodb_table_stats
      or innodb_index_stats during trx_rollback_or_clean_recovered().
      b862377c
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-22928 InnoDB fails to fetch index type when index mismatch happens · 2b0d5b78
      Thirunarayanan Balathandayuthapani authored
      InnoDB fails to fetch the index type when innodb dictionary
      doesn't match with frm. InnoDB should return corrupted if it
      can't find the index in ha_innobase::index_type().
      2b0d5b78
    • Nikita Malyavin's avatar
      MDEV-24583 SELECT aborts after failed REPLACE into table with vcol · 43e879c7
      Nikita Malyavin authored
      table->move_fields wasn't undone in case of error.
      
      1. move_fields is unconditionally undone even when error is occurred
      2. cherry-pick an assertion in `ptr_in_record`, which is already in 10.5
      43e879c7
    • Nikita Malyavin's avatar
      MDEV-19011 Assertion `file->s->base.reclength < file->s->vreclength' failed · f85afa51
      Nikita Malyavin authored
      The assertion is improved: storage engines like myisam always have to store
      at least one field, so the assertion does not cover tables with no stored
      columns.
      f85afa51
    • Nikita Malyavin's avatar
      MDEV-16962 Assertion failed in open_purge_table upon concurrent ALTER/FLUSH · 6ba5f81c
      Nikita Malyavin authored
      So we are having a race condition of three of threads, resulting in a
      deadlock backoff in purge, which is unexpected.
      
      More precisely, the following happens:
      T1: NOCOPY ALTER TABLE begins, and eventually it holds MDL_SHARED_NO_WRITE
       lock;
      T2: FLUSH TABLES begins. it sets share->tdc->flushed = true
      T3: purge on a record with virtual column begins. it is going to open a
       table. MDL_SHARED_READ lock is acquired therefore.
      Since share->tdc->flushed is set, it waits for a TDC purge end.
      T1: is going to elevate MDL LOCK to exclusive and therefore has to set
       other waiters to back off.
      T3: receives VICTIM status, reports a DEADLOCK, sets OT_BACKOFF_AND_RETRY
       to Open_table_context::m_action
      
      My fix is to allow opening table in purge while flushing. It is already
      done the same way in other maintainance facilities like REPAIR TABLE.
      
      Another way would be making an actual backoff, but Open_table_context
      does not allow to distinguish it from other failure types, which still
      seem to be unexpected. Making this would require hacking into
      Open_table_context interface for no benefit, in comparison to passing
      MYSQL_OPEN_IGNORE_FLUSH during table open.
      6ba5f81c
    • Nikita Malyavin's avatar
      revive innodb_debug_sync · 300253ac
      Nikita Malyavin authored
      innodb_debug_sync was introduced in commit
      b393e2cb and reverted in
      commit fc58c172 due to memory leak reported
      by valgrind, see MDEV-21336.
      
      The leak is now fixed by adding `rw_lock_free(&slot->debug_sync_lock)`
      after background thread working loop is finished, and the patch is
      reapplied, with respect to c++98 fixes by Marko.
      
      The missing DEBUG_SYNC for MDEV-18546 in row0vers.cc is also reapplied.
      300253ac
  3. 26 Apr, 2021 1 commit
    • Daniel Black's avatar
      MDEV-25513: raise systemd LimitNOFILE limits to match server defaults · a35cde8c
      Daniel Black authored
      Quoting MDEV reporter Daniel Lewart:
      
      Starting MariaDB with default configuration causes the following problems:
      
          "[Warning] Could not increase number of max_open_files to more than 16384 (request: 32186)"
          silently reduces table_open_cache_instances from 8 (default) to 4
      
      Default Server System Variables:
      
          extra_max_connections = 1
          max_connections = 151
          table_open_cache = 2000
          table_open_cache_instances = 8
          thread_pool_size = 4
      
      LimitNOFILE=16834 is in the following files:
      
          support-files/mariadb.service.in
          support-files/mariadb@.service.in
      
      Looking at sql/mysqld.cc lines 3837-3917:
      wanted_files= (extra_files + max_connections + extra_max_connections +
      tc_size * 2 * tc_instances);
      wanted_files+= threadpool_size;
      
      Plugging in the default values:
      wanted_files = (30 + 151 + 1 + 2000 * 2 * 8 + 4) = 32186
      
      However, systemd configuration has LimitNOFILE = 16384, which is far smaller.
      
      I suggest increasing LimitNOFILE to 32768.
      a35cde8c
  4. 25 Apr, 2021 2 commits
  5. 24 Apr, 2021 2 commits
    • Marko Mäkelä's avatar
      MDEV-23026/MDEV-25474 fixup: Assertion ib_table->stat_initialized · 14a18d7d
      Marko Mäkelä authored
      It is possible that an object that was originally created by
      open_purge_table() will remain cached and reused for SQL execution.
      Our previous fix wrongly assumed that ha_innobase::open() would
      always be called before SQL execution starts. Therefore, we must
      invoke dict_stats_init() in ha_innobase::info_low() instead of
      only doing it in ha_innobase::open().
      
      Note: Concurrent execution of dict_stats_init() on the same table
      is possible, but it also was possible between two calls to
      ha_innobase::open(), with no ill effects observed.
      
      This should fix the assertion failure on stat_initialized.
      A possibly easy way to reproduce it would have been
      to run the server with innodb_force_recovery=2 (disable the purge of
      history), update a table so that an indexed virtual column will be
      affected, and finally restart the server normally (purge enabled),
      to observe a crash when the table is accessed from SQL.
      
      The problem was first observed and this fix verified by
      Elena Stepanova. Also Thirunarayanan Balathandayuthapani
      repeated the problem.
      14a18d7d
    • Marko Mäkelä's avatar
      MDEV-25459 MVCC read from index on CHAR or VARCHAR wrongly omits rows · 25ed665a
      Marko Mäkelä authored
      row_sel_sec_rec_is_for_clust_rec(): If the field in the
      clustered index record stored off page, always fetch it,
      also when the secondary index field has been built on the
      entire column. This was broken ever since the InnoDB Plugin
      for MySQL Server 5.1 introduced ROW_FORMAT=DYNAMIC and
      ROW_FORMAT=COMPRESSED for InnoDB tables. That code was first
      introduced in this tree in
      commit 3945d5e5.
      
      For the original ROW_FORMAT=REDUNDANT and the MySQL 5.0.3
      ROW_FORMAT=COMPRESSED, there was no problem, because for
      those tables we always stored at least a 768-byte prefix of
      each column in the clustered index record.
      
      row_sel_sec_rec_is_for_blob(): Allow prefix_len==0 for matching
      the full column.
      25ed665a
  6. 23 Apr, 2021 4 commits
  7. 22 Apr, 2021 4 commits
    • Igor Babaev's avatar
      MDEV-24823 Crash with invalid multi-table update of view in 2nd execution of SP · b3b5d57e
      Igor Babaev authored
      Before this patch mergeable derived tables / view used in a multi-table
      update / delete were merged before the preparation stage.
      When the merge of a derived table / view is performed the on expression
      attached to it is fixed and ANDed with the where condition of the select S
      containing this derived table / view. It happens after the specification of
      the derived table / view has been merged into S. If the ON expression refers
      to a non existing field an error is reported and some other mergeable derived
      tables / views remain unmerged. It's not a problem if the multi-table
      update / delete statement is standalone. Yet if it is used in a stored
      procedure the select with incompletely merged derived tables / views may
      cause a problem for the second call of the procedure. This does not happen
      for select queries using derived tables / views, because in this case their
      specifications are merged after the preparation stage at which all ON
      expressions are fixed.
      This patch makes sure that merging of the derived tables / views used in a
      multi-table update / delete statement is performed after the preparation
      stage.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      b3b5d57e
    • Vladislav Vaintroub's avatar
      5c5d24c7
    • Vladislav Vaintroub's avatar
      MDEV-25456 MariaBackup logs "[ERROR]" on Invalid log block checksum · 78bb9533
      Vladislav Vaintroub authored
      Fix is to changed message to be [WARNING] for backup
      78bb9533
    • Vladislav Vaintroub's avatar
      Update timezone data on Windows · f6542a7a
      Vladislav Vaintroub authored
      There is new Yukon Standard time Windows timezone.
      
      Also fix the powershell script that generates the Windows locale mapping,
      tell powershell to use TLSv1.2 to access the github (on some reason it is
      TLS1.1 that powershell is using by default, and it does no work)
      f6542a7a
  8. 21 Apr, 2021 5 commits
  9. 20 Apr, 2021 5 commits
  10. 17 Apr, 2021 2 commits
    • Igor Babaev's avatar
      MDEV-25362 Incorrect name resolution for subqueries in ON expressions · 635b5ce3
      Igor Babaev authored
      This patch sets the proper name resolution context for outer references
      used in a subquery from an ON clause. Usually this context is more narrow
      than the name resolution context of the parent select that were used before
      this fix.
      This fix revealed another problem that concerned ON expressions used in
      from clauses of specifications of derived tables / views / CTEs. The name
      resolution outer context for such ON expression must be set to NULL to
      prevent name resolution beyond the derived table where it is used.
      The solution to resolve this problem applied in sql_derived.cc was provided
      by Sergei Petrunia <sergey@mariadb.com>.
      
      The change in sql_parse.cc is not good for 10.4+. A corresponding diff for
      10.4+ will be provided in JIRA entry for this bug.
      
      Approved by Oleksandr Byelkin <sanja@mariadb.com>
      635b5ce3
    • Rainer Orth's avatar
      MDEV-15064: IO_CACHE mysys read_pos, not libmaria rc_pos · 73bf6246
      Rainer Orth authored
      It seems some overly tolerant compilers (gcc) allow the structure
      of IO_CACHE that is defined differently in libmaria to have
      members equalivance to the iocache in mysys.
      
      More strict Solaris compilers recognise that rc_pos really
      isn't a structure member and won't compile.
      73bf6246