1. 21 Apr, 2018 1 commit
  2. 19 Apr, 2018 2 commits
    • Sergei Petrunia's avatar
      MyRocks: MDEV-15911: Reduce debug logging on default levels in error log · 0c02c91b
      Sergei Petrunia authored
      MyRocks internally will print non-critical messages to
      sql_print_verbose_info() which will do what InnoDB does in similar cases:
      check if (global_system_variables.log_warnings > 2).
      0c02c91b
    • Sachin Setiya's avatar
      MDEV-15611 Due to the failure of foreign key detection, Galera... · efae1268
      Sachin Setiya authored
      slave node killed himself.
      
      Problem:- If we try to delete table with foreign key and table whom it is
      referring with wsrep_slave_threads>1 then galera tries to execute both
      Delete_rows_log-event in parallel, which should not happen.
      
      Solution:- This is happening because we do not have foreign key info in
      write set. Upto version 10.2.7 it used to work fine. Actually it happening
      because of issue in commit 2f342c45. wsrep_must_process_fk has changed to
      make it similar to original condition.
      efae1268
  3. 18 Apr, 2018 2 commits
  4. 17 Apr, 2018 1 commit
  5. 16 Apr, 2018 6 commits
    • Igor Babaev's avatar
      MDEV-15556 MariaDB crash with big_tables=1 and CTE · e34d3184
      Igor Babaev authored
      This bug manifested itself when the optimizer chose an execution plan with
      an access of the recursive CTE in a recursive query by key and ARIA/MYISAM
      temporary tables were used to store recursive tables.
      The problem appeared due to passing an incorrect parameter to the call of
      instantiate_tmp_table() in the function With_element::instantiate_tmp_tables().
      e34d3184
    • Igor Babaev's avatar
      MDEV-15571 Wrong results with big_tables=1 and CTE · 61285078
      Igor Babaev authored
      The cause of this bug was the same as for the bug mdev-15575.
      Fixed by the patch for the latter.
      61285078
    • Igor Babaev's avatar
      MDEV-15575 different results when using CTE and big_tables=1. · 224f7af9
      Igor Babaev authored
      This bug happened due to a defect of the implementation of the handler
      function ha_delete_all_rows() for the ARIA engine.
      The function maria_delete_all_rows() truncated the table, but it didn't
      touch the write cache, so the cache's write offset was not reset.
      In the scenario like in the function st_select_lex_unit::exec_recursive
      when first all records were deleted from the table and then several new
      records were added some metadata became inconsistent with the state of
      the cache. As a result the table scan function could not read records
      at the end of the table.
      The same defect could be found in the implementation of ha_delete_all_rows()
      for the MYISAM engine mi_delete_all_rows().
      
      Additionally made late instantiation for the temporary table used to store
      rows that were used for each new iteration when executing a recursive CTE.
      224f7af9
    • Sergei Golubchik's avatar
      MDEV-15866 Mysql CRASH : Json connect + MariaDB 10.3.4 · 87af52d7
      Sergei Golubchik authored
      revert incorrect change
      87af52d7
    • Jan Lindström's avatar
      MDEV-13516: encryption.create_or_replace test fails in buildbot with InnoDB assertion failure · 3d1ad2a5
      Jan Lindström authored
      fil_crypt_rotate_pages
      	If tablespace is marked as stopping stop also page rotation
      
      fil_crypt_flush_space
      	If tablespace is marked as stopping do not try to read
      	page 0 and write it back.
      3d1ad2a5
    • Jan Lindström's avatar
      Merge pull request #665 from codership/10.2-fix-mtr-wait · 29d4ac2c
      Jan Lindström authored
      Fix mtr to be able to wait for >1 exited mysqld
      29d4ac2c
  6. 14 Apr, 2018 2 commits
  7. 13 Apr, 2018 7 commits
  8. 12 Apr, 2018 9 commits
    • Sergei Petrunia's avatar
      MDEV-14460: Memory leak with only SELECT statements · d13e3547
      Sergei Petrunia authored
      Cherry-pick this fix from the upstream:
      commit 6ddedd8f1e0ddcbc24e8f9a005636c5463799ab7
      Author: Sergei Petrunia <psergey@askmonty.org>
      Date:   Tue Apr 10 11:43:01 2018 -0700
      
          [mysql-5.6][PR] Issue #802: MyRocks: Statement rollback doesnt work correctly for nes…
      
          Summary:
          …ted statements
      
          Variant #1: When the statement fails, we should roll back to the latest
          savepoint taken at the top level.
          Closes https://github.com/facebook/mysql-5.6/pull/804
      
          Differential Revision: D7509380
      
          Pulled By: hermanlee
      
          fbshipit-source-id: 9a6f414
      d13e3547
    • Jacob Mathew's avatar
      MDEV-15692: install_spider.sql can fail with some collations · 12e2d039
      Jacob Mathew authored
      The error occurs because of how the character set and collation are chosen for
      stored procedure parameters that have a character data type.  If the character
      set and collation are not explicitly stated in the declaration, the server
      chooses the database character set and collation in effect at routine creation
      time.
      
      To fix the problem, I added explicit character set and collation attributes
      for the stored procedure parameters in the install_spider.sql script.
      
      Author:
        Jacob Mathew.
      
      Reviewer:
        Kentoku Shiba.
      
      Cherry-Picked:
        Commit ff0bf451 on bb-10.3-MDEV-15692
      12e2d039
    • Vladislav Vaintroub's avatar
      MDEV-15779 - mariabackup incremental prepare fails on CIFS mount. · c2dc72c0
      Vladislav Vaintroub authored
      CIFS does not like O_DIRECT flag (it is set successfully, but pread would
      fail).
      
      The fix is not to use O_DIRECT, there is not need for it.
      posix_fadvise() was used already that should prevent buffer cache
      pollution on Linux.
      
      As recommended by documentation of posix_fadvise(), we'll also fsync()
      tablespaces after a batch of writes.
      c2dc72c0
    • Vladislav Vaintroub's avatar
      MDEV-15780 : Mariabackup with absolute paths in innodb_data_file_path · 15071226
      Vladislav Vaintroub authored
      System tablespace can be specified with absolute path, if innodb_data_home_dir
      is empty.
      
      This was not handled well  by mariabackup
      
      1. In backup phase, empty innodb_data_home_dir variable from server was
      not recognized. full paths were stored in backup-my.ini, even if
      it stored all files locally. thus prepare phase would not find the system
      tablespace files.
      
      2. In copy-back phase, copy would not be done to the absolute destination
      path, as path would be stripped with trim_dotslash
      
      This patch fixes the above defects.
      15071226
    • Jan Lindström's avatar
      MDEV-12632: Source and destination overlap in memcpy,... · 36c01167
      Jan Lindström authored
      MDEV-12632: Source and destination overlap in memcpy, encryption.innodb-discard-import-change fails in buildbot with valgrind
      
      Problem was that if tablespace was encrypted we try to copy
      also page 0 from read buffer to write buffer that are in
      that case the same memory area.
      
      fil_iterate
      	When tablespace is encrypted or compressed its
              first page (i.e. page 0) is not encrypted or
      	compressed and there is no need to copy buffer.
      36c01167
    • Jan Lindström's avatar
      MDEV-12632: Source and destination overlap in memcpy,... · 0ae13b51
      Jan Lindström authored
      MDEV-12632: Source and destination overlap in memcpy, encryption.innodb-discard-import-change fails in buildbot with valgrind
      
      Problem was that if tablespace was encrypted we try to copy
      also page 0 from read buffer to write buffer that are in
      that case the same memory area.
      
      fil_iterate
      	When tablespace is encrypted or compressed its
              first page (i.e. page 0) is not encrypted or
      	compressed and there is no need to copy buffer.
      0ae13b51
    • Jan Lindström's avatar
      MDEV-12903: encryption.innodb_encryption_discard_import fails in buildbot with FOUND vs NOT FOUND · 2f1f1609
      Jan Lindström authored
      Wait until rotation has ended and shutdown before grep to make sure
      that dirty pages are on datafiles.
      2f1f1609
    • Jan Lindström's avatar
      MDEV-12903: encryption.innodb_encryption_discard_import fails in buildbot with FOUND vs NOT FOUND · 9518ddd1
      Jan Lindström authored
      Wait until rotation has ended and shutdown before grep to make sure
      that dirty pages are on datafiles.
      9518ddd1
    • Vicențiu Ciorbaru's avatar
      Use same connection convention of specifying IPs · 93aded05
      Vicențiu Ciorbaru authored
      If we use hostnames, it will fail during name resolution on UNIX systems
      93aded05
  9. 11 Apr, 2018 8 commits
  10. 10 Apr, 2018 2 commits