1. 30 Jun, 2021 1 commit
    • Sergei Petrunia's avatar
      MDEV-25969: Condition pushdown into derived table doesn't work if select list uses SP · eb20c91b
      Sergei Petrunia authored
      Consider a query of the form:
      
        select ... from (select item2 as COL1) as T where COL1=123
      
      Condition pushdown into derived table will try to push "COL1=123" condition
      down into table T.
      The process of pushdown involves "substituting" the item, that is,
      replacing Item_field("T.COL1") with its "producing item" item2.
      In order to use item2, one needs to clone it (call Item::build_clone).
      
      If the item is not cloneable (e.g. Item_func_sp is not), the pushdown
      process will fail and nothing at all will be pushed.
      
      Fixed by introducing transform_condition_or_part() which will try to apply
      the transformation for as many parts of condition as possible. The parts of
      condition that couldn't be transformed are dropped.
      eb20c91b
  2. 29 Jun, 2021 2 commits
  3. 28 Jun, 2021 1 commit
  4. 27 Jun, 2021 1 commit
  5. 26 Jun, 2021 2 commits
    • Igor Babaev's avatar
      8b3f816c
    • Igor Babaev's avatar
      MDEV-20411 Procedure containing CTE incorrectly stored in mysql.proc · 12c80df4
      Igor Babaev authored
      If the first token of the body of a stored procedure was 'WITH' then
      the beginning of the body was determined incorrectly and that token was
      missing in the string representing the body of the SP in mysql.proc. As a
      resultnany call of such procedure failed as the string representing the
      body could not be parsed.
      
      The patch corrects the code of the functions get_tok_start() and
      get_cpp_tok_start() of the class Lex_input_stream to make them take into
      account look ahead tokens. The patch is needed only for 10.2 as this
      problem has neen resolved in 10.3+.
      12c80df4
  6. 25 Jun, 2021 1 commit
  7. 23 Jun, 2021 3 commits
  8. 22 Jun, 2021 2 commits
  9. 21 Jun, 2021 2 commits
    • Igor Babaev's avatar
      MDEV-25679 Wrong result selecting from simple view with LIMIT and ORDER BY · cc0bd843
      Igor Babaev authored
      This bug affected queries with views / derived_tables / CTEs whose
      specifications were of the form
        (SELECT ... LIMIT <n>) ORDER BY ...
      Units representing such specifications contains one SELECT_LEX structure
      for (SELECT ... LIMIT <n>) and additionally SELECT_LEX structure for
      fake_select_lex. This fact should have been taken into account in the
      function mysql_derived_fill().
      
      This patch has to be applied to 10.2 and 10.3 only.
      cc0bd843
    • Marko Mäkelä's avatar
      Remove Travis CI status · 773a07b6
      Marko Mäkelä authored
      Builds on travis-ci.org ceased on 2021-06-15.
      773a07b6
  10. 17 Jun, 2021 1 commit
  11. 16 Jun, 2021 2 commits
  12. 15 Jun, 2021 9 commits
    • Julius Goryavsky's avatar
      MDEV-25880 part 2: Improving reliability of the SST scripts · 2edb8e12
      Julius Goryavsky authored
      Additional improvements aimed at improving operational
      reliability of the SST scripts:
      
      1) Script need to give rsync and stunnel a short time to
         terminate after "kill -9" before the first PID check
         using ps utility;
      2) The temporary file used to create the binlog index could
         sometimes remain in the data directory if tar failed and
         then may be reused without being cleaned up (the next
         time when SST was run) - now it's fixed;
      3) The temporary file used to build the binlog index is now
         created using mktemp and, if this variable is present in
         the configuration file, in tmpdir;
      4) Checking the secret tag in SST via rsync is made faster
         and does not require creating a temporary file, which
         could remain in the data directory in case of failure;
      5) Added "-F" option to grep to check the tag when using
         mariabackup/xtrabackup-v2 - to avoid possible collisions
         in case of special characters in the tag value (unlikely
         scenario, but the new check is more reliable).
      2edb8e12
    • Julius Goryavsky's avatar
      MDEV-25880: rsync may be mistakenly killed when overlapping SST · 18d5be5b
      Julius Goryavsky authored
      This commit fixes a bug was originally discovered during the
      galera_nbo_sst_slave mtr test for 10.6 branch. However it is
      relevant for all versions and can lead to intermittent SST
      crashes via rsync on very fast server restarts - when a new
      SST process (for example, after starting a new server instance)
      overlaps the old SST process started by the previous, already
      terminated server. This overlap can result in the new rsync
      being killed instead of the old rsync, or the pid file from
      the new rsync being killed, which then lead to problems.
      18d5be5b
    • Eugene Kosov's avatar
      fix clang build · 1c35a3f6
      Eugene Kosov authored
      a new warning -Wunused-but-set-variable was introduced recently to clang
      1c35a3f6
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-24713 Assertion `dict_table_is_comp(index->table)' failed in row_merge_buf_add() · 7d591cf8
      Thirunarayanan Balathandayuthapani authored
      - During online alter conversion from compact to redundant,
      virtual column field length already set during
      innobase_get_computed_value(). Skip the char(n) check for
      virtual column in row_merge_buf_add()
      7d591cf8
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-25872 InnoDB: Assertion failure in row_merge_read_clustered_index upon... · 7229107e
      Thirunarayanan Balathandayuthapani authored
      MDEV-25872 InnoDB: Assertion failure in row_merge_read_clustered_index upon ALTER on table with indexed virtual columns
      
      - InnoDB fails to check DB_COMPUTE_VALUE_FAILED error in
      row_merge_read_clustered_index() and wrongly asserts that
      the buffer shouldn't be ran out of memory. Alter table
      should give warning when the column value is being
      truncated.
      7229107e
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-14180 Automatically disable key rotation checks for file_key_managment plugin · 8c7d8b71
      Thirunarayanan Balathandayuthapani authored
      Problem:
      =======
      - InnoDB iterates the fil_system space list to encrypt the
      tablespace in case of key rotation. But it is not
      necessary for any encryption plugin which doesn't do
      key version rotation.
      
      Solution:
      =========
      - Introduce a new variable called srv_encrypt_rotate to
      indicate whether encryption plugin does key rotation
      
      fil_space_crypt_t::key_get_latest_version(): Enable the
      srv_encrypt_rotate only once if current key version is
      higher than innodb_encyrption_rotate_key_age
      
      fil_crypt_must_default_encrypt(): Default encryption tables
      should be added to default_encryp_tables list if
      innodb_encyrption_rotate_key_age is zero and encryption
      plugin doesn't do key version rotation
      
      fil_space_create(): Add the newly created space to
      default_encrypt_tables list if
      fil_crypt_must_default_encrypt() returns true
      
      Removed the nondeterministic select from
      innodb-key-rotation-disable test. By default,
      InnoDB adds the tablespace to the rotation list and
      background crypt thread does encryption of tablespace.
      So these select doesn't give reliable results.
      8c7d8b71
    • Thirunarayanan Balathandayuthapani's avatar
      MDEV-14180 preparation: Rename key_rotation_list · 7d2c338c
      Thirunarayanan Balathandayuthapani authored
      - Rename the rotation list to default_encrypt_tables in
      fil_system_t. Because rotation list naming could be
      misleading when it comes to key version rotation
      
      - Rename is_in_rotation_list to is_in_default_encrypt
      in fil_space_t
      
      - Rename keyrotate_next function to default_encrypt_next
      
      fil_system_t::default_encrypt_next(): Find the next
      suitable default encrypt table if beginning of
      default_encrypt_tables list has been scheduled
      to be deleted
      7d2c338c
    • Daniel Black's avatar
      cmake OpenBSD copyright notice correction · be243ed9
      Daniel Black authored
      Brad Smith made this OpenBSD file based of the
      FreeBSD cmake directives in commit ab589043
      by the Monty Program Ab.
      
      As such the Oracle Copyright header isn't really applicable.
      be243ed9
    • Jordy Zomer's avatar
      eventscheduler mismatch of my_{malloc,free}, delete · ec4df514
      Jordy Zomer authored
      Fix malloc/delete mismatch. This causes a double free in the cleanup.
      
      closes #1845
      ec4df514
  13. 14 Jun, 2021 1 commit
  14. 12 Jun, 2021 2 commits
  15. 11 Jun, 2021 1 commit
  16. 10 Jun, 2021 2 commits
    • Otto Kekäläinen's avatar
      MDEV-20392: Skip ABI check if 'diff' is not found · 152c83d4
      Otto Kekäläinen authored
      Not all environments have 'diff' installed. Most notably CentOS 8
      does not have diff out-of-the-box. Thus users running 'cmake .' and
      'make' would fail to build MariaDB, and they would think the error
      was in ABI incompatibilities due to the error message emitted by CMake
      when in reality simply 'diff' was missing.
      
      This fixes it and makes the developer experience better by simply
      skipping the diffing if 'diff' is not found.
      
      Closes #1846
      152c83d4
    • Marko Mäkelä's avatar
      Remove orphan type name trx_sig_t · 396864c6
      Marko Mäkelä authored
      This was missed in commit 1d0f70c2.
      396864c6
  17. 09 Jun, 2021 2 commits
  18. 08 Jun, 2021 1 commit
    • Marko Mäkelä's avatar
      MDEV-25869 Change buffer entries are lost on InnoDB restart · dfa2d0bc
      Marko Mäkelä authored
      buf_read_ibuf_merge_pages(): If space->size is 0, invoke
      fil_space_get_size() to determine the size of the tablespace
      by reading the header page. Only after that proceed to delete
      any entries that are beyond the end of the tablespace.
      Otherwise, we could be deleting valid entries that actually
      need to be applied.
      
      This fixes a regression that had been introduced in
      commit b80df9eb (MDEV-21069),
      which aimed to avoid crashes during DROP TABLE of corrupted tables.
      dfa2d0bc
  19. 06 Jun, 2021 2 commits
    • Otto Kekäläinen's avatar
      Revert "CONNECT: move jar files to /usr/share and include them in DEBs" · 3c922d6d
      Otto Kekäläinen authored
      This partially reverts commit d7321893.
      
      The *.jar files are not being built and all Debian builds are failing
      as dh_install stops on missing files. To build them we would need to also
      add new Java build dependencies.
      
      In a stable release (10.2->10.5) we shouldn't add new files and certainly
      not any new build dependencies, so reverting commit.
      
      Also, the files are located in a different path, and already included
      in the mariadb-test-data package:
      
        /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/JavaWrappers.jar
        /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/JdbcMariaDB.jar
        /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/Mongo2.jar
        /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/Mongo3.jar
      
      This change needs to be redesigned and applies only on 10.6 or newer.
      3c922d6d
    • Vladislav Vaintroub's avatar
      MDEV-23815 Windows : mysql_upgrade_wizard fails, if service name has spaces · 9f9a925c
      Vladislav Vaintroub authored
      The fix is to quote service name parameter, when it is passed to
      mysql_upgrade_service subprocess.
      9f9a925c
  20. 05 Jun, 2021 1 commit
  21. 04 Jun, 2021 1 commit
    • Anel Husakovic's avatar
      MDEV-25777: JAVA_INCLUDE_PATH and JAVA_INCLUDE_PATH2 not found with out of... · 7eed97ed
      Anel Husakovic authored
      MDEV-25777: JAVA_INCLUDE_PATH and JAVA_INCLUDE_PATH2 not found with out of source configuration and Ninja generator
      
      - As solution `PLUGIN_CONNECT=NO` use early check to disable plugin:
        Solution suggested by wlad@mariadb.com
      - `JNI_FOUND` is a internal result variable and should be set with
      cached library and header variables (like `JAVA_INCLUDE_PATH`) defined.
        * Note: wrapper cmake/FindJNI.cmake runs first time and cmake native Find<module> returns only cached variable, like `JAVA_INCLUDE_PATH`, results variable are not cached).
      
      Reviewed by: serg@mariadb.com
      7eed97ed