1. 13 Oct, 2019 4 commits
  2. 12 Oct, 2019 12 commits
  3. 11 Oct, 2019 22 commits
    • Julius Goryavsky's avatar
      MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 · 2ae02c29
      Julius Goryavsky authored
      When the mysqld_multi script passes the --defaults-group-suffix
      option to mysqld, it must remove the initial substring with the
      group name ("mysqld") from option value, because otherwise substring
      "mysqld" will be added to the group name and then the group name
      will contain the word "mysqld" twice, which is wrong, because
      mysqld itself adds the suffix received to the group name.
      2ae02c29
    • Julius Goryavsky's avatar
      MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 · 4ca0abe9
      Julius Goryavsky authored
      When the mysqld_multi script passes the --defaults-group-suffix
      option to mysqld, it must remove the initial substring with the
      group name ("mysqld") from option value, because otherwise substring
      "mysqld" will be added to the group name and then the group name
      will contain the word "mysqld" twice, which is wrong, because
      mysqld itself adds the suffix received to the group name.
      4ca0abe9
    • Julius Goryavsky's avatar
      MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 · 0ecc85c5
      Julius Goryavsky authored
      When the mysqld_multi script passes the --defaults-group-suffix
      option to mysqld, it must remove the initial substring with the
      group name ("mysqld") from option value, because otherwise substring
      "mysqld" will be added to the group name and then the group name
      will contain the word "mysqld" twice, which is wrong, because
      mysqld itself adds the suffix received to the group name.
      0ecc85c5
    • Julius Goryavsky's avatar
      MDEV-20728: /usr/sbin/mysqld: unknown variable 'defaults-group-suffix=mysqld1 · 36824d2b
      Julius Goryavsky authored
      When the mysqld_multi script passes the --defaults-group-suffix
      option to mysqld, it must remove the initial substring with the
      group name ("mysqld") from option value, because otherwise substring
      "mysqld" will be added to the group name and then the group name
      will contain the word "mysqld" twice, which is wrong, because
      mysqld itself adds the suffix received to the group name.
      36824d2b
    • Alexander Barkov's avatar
    • Marko Mäkelä's avatar
      Fix -std=c++98 -Wzero-length-array · 38736928
      Marko Mäkelä authored
      This is another follow-up fix to
      commit b393e2cb
      which turned out to be still broken.
      
      Replace the C++11 keyword 'constexpr' with #define.
      
      debug_sync_t::str: Remove the zero-length array.
      Replace sync->str with reinterpret_cast<char*>(&sync[1]).
      38736928
    • Marko Mäkelä's avatar
      After-merge fix: Correct an assertion · 1e1b53cc
      Marko Mäkelä authored
      During IMPORT TABLESPACE, we do invoke
      buf_flush_init_for_writing() with block==NULL and newest_lsn!=0.
      1e1b53cc
    • Alexander Barkov's avatar
    • Alexander Barkov's avatar
    • Marko Mäkelä's avatar
      Merge 10.1 into 10.2 · 966d97b5
      Marko Mäkelä authored
      966d97b5
    • Marko Mäkelä's avatar
      Fix CMAKE_BUILD_TYPE=Debug · 1fd1ef25
      Marko Mäkelä authored
      Remove unused variables and type mismatch that was introduced
      in commit b393e2cb
      
      Also, fix a typo in the documentation of the parameter, and
      update the test.
      1fd1ef25
    • Marko Mäkelä's avatar
      MDEV-19514 Defer change buffer merge until pages are requested · b42294bc
      Marko Mäkelä authored
      We will remove the InnoDB background operation of merging buffered
      changes to secondary index leaf pages. Changes will only be merged as a
      result of an operation that accesses a secondary index leaf page,
      such as a SQL statement that performs a lookup via that index,
      or is modifying the index. Also ROLLBACK and some background operations,
      such as purging the history of committed transactions, or computing
      index cardinality statistics, can cause change buffer merge.
      Encryption key rotation will not perform change buffer merge.
      
      The motivation of this change is to simplify the I/O logic and to
      allow crash recovery to happen in the background (MDEV-14481).
      We also hope that this will reduce the number of "mystery" crashes
      due to corrupted data. Because change buffer merge will typically
      take place as a result of executing SQL statements, there should be
      a clearer connection between the crash and the SQL statements that
      were executed when the server crashed.
      
      In many cases, a slight performance improvement was observed.
      
      This is joint work with Thirunarayanan Balathandayuthapani
      and was tested by Axel Schwenke and Matthias Leich.
      
      The InnoDB monitor counter innodb_ibuf_merge_usec will be removed.
      
      On slow shutdown (innodb_fast_shutdown=0), we will continue to
      merge all buffered changes (and purge all undo log history).
      
      Two InnoDB configuration parameters will be changed as follows:
      
      innodb_disable_background_merge: Removed.
      This parameter existed only in debug builds.
      All change buffer merges will use synchronous reads.
      
      innodb_force_recovery will be changed as follows:
      * innodb_force_recovery=4 will be the same as innodb_force_recovery=3
      (the change buffer merge cannot be disabled; it can only happen as
      a result of an operation that accesses a secondary index leaf page).
      The option used to be capable of corrupting secondary index leaf pages.
      Now that capability is removed, and innodb_force_recovery=4 becomes 'safe'.
      * innodb_force_recovery=5 (which essentially hard-wires
      SET GLOBAL TRANSACTION ISOLATION LEVEL READ UNCOMMITTED)
      becomes safe to use. Bogus data can be returned to SQL, but
      persistent InnoDB data files will not be corrupted further.
      * innodb_force_recovery=6 (ignore the redo log files)
      will be the only option that can potentially cause
      persistent corruption of InnoDB data files.
      
      Code changes:
      
      buf_page_t::ibuf_exist: New flag, to indicate whether buffered
      changes exist for a buffer pool page. Pages with pending changes
      can be returned by buf_page_get_gen(). Previously, the changes
      were always merged inside buf_page_get_gen() if needed.
      
      ibuf_page_exists(const buf_page_t&): Check if a buffered changes
      exist for an X-latched or read-fixed page.
      
      buf_page_get_gen(): Add the parameter allow_ibuf_merge=false.
      All callers that know that they may be accessing a secondary index
      leaf page must pass this parameter as allow_ibuf_merge=true,
      unless it does not matter for that caller whether all buffered
      changes have been applied. Assert that whenever allow_ibuf_merge
      holds, the page actually is a leaf page. Attempt change buffer
      merge only to secondary B-tree index leaf pages.
      
      btr_block_get(): Add parameter 'bool merge'.
      All callers of btr_block_get() should know whether the page could be
      a secondary index leaf page. If it is not, we should avoid consulting
      the change buffer bitmap to even consider a merge. This is the main
      interface to requesting index pages from the buffer pool.
      
      ibuf_merge_or_delete_for_page(), recv_recover_page(): Replace
      buf_page_get_known_nowait() with much simpler logic, because
      it is now guaranteed that that the block is x-latched or read-fixed.
      
      mlog_init_t::mark_ibuf_exist(): Renamed from mlog_init_t::ibuf_merge().
      On crash recovery, we will no longer merge any buffered changes
      for the pages that we read into the buffer pool during the last batch
      of applying log records.
      
      buf_page_get_gen_known_nowait(), BUF_MAKE_YOUNG, BUF_KEEP_OLD: Remove.
      
      btr_search_guess_on_hash(): Merge buf_page_get_gen_known_nowait()
      to its only remaining caller.
      
      buf_page_make_young_if_needed(): Define as an inline function.
      Add the parameter buf_pool.
      
      buf_page_peek_if_young(), buf_page_peek_if_too_old(): Add the
      parameter buf_pool.
      
      fil_space_validate_for_mtr_commit(): Remove a bogus comment
      about background merge of the change buffer.
      
      btr_cur_open_at_rnd_pos_func(), btr_cur_search_to_nth_level_func(),
      btr_cur_open_at_index_side_func(): Use narrower data types and scopes.
      
      ibuf_read_merge_pages(): Replaces buf_read_ibuf_merge_pages().
      Merge the change buffer by invoking buf_page_get_gen().
      b42294bc
    • Marko Mäkelä's avatar
      MDEV-20805 follow-up: Catch writes of bogus pages · c0c003be
      Marko Mäkelä authored
      buf_flush_init_for_writing(): Assert that FIL_PAGE_TYPE is set
      except when creating a new data file with a dummy first page.
      
      buf_dblwr_create(): Ensure that FIL_PAGE_TYPE on all pages
      will be initialized. Reset buf_dblwr_being_created at the end.
      c0c003be
    • Marko Mäkelä's avatar
      Merge 5.5 into 10.1 · cbfd6882
      Marko Mäkelä authored
      cbfd6882
    • Marko Mäkelä's avatar
      MDEV-20805 ibuf_add_free_page() is not initializing FIL_PAGE_TYPE first · ea61b796
      Marko Mäkelä authored
      In the function recv_parse_or_apply_log_rec_body() there are debug checks
      for validating the state of the page when redo log records are being
      applied. Most notably, FIL_PAGE_TYPE should be set before anything else
      is being written to the page.
      
      ibuf_add_free_page(): Set FIL_PAGE_TYPE before performing any other changes.
      ea61b796
    • Marko Mäkelä's avatar
      MDEV-19455: Avoid SET DEBUG_DBUG='-d,...' construct · 4ebaf813
      Marko Mäkelä authored
      Apply the correct pattern for debug instrumentation:
      
      SET @save_dbug=@@debug_dbug;
      SET debug_dbug='+d,...';
      ...
      SET debug_dbug=@save_dbug;
      
      Numerous tests use statements of the form
      
      SET debug_dbug='-d,...';
      
      which will inadvertently enable all DBUG tracing output,
      causing unnecessary waste of resources.
      4ebaf813
    • Alexander Barkov's avatar
      b5fae7f7
    • Marko Mäkelä's avatar
      MDEV-20804 Speed up main.index_merge_innodb · 5ef12244
      Marko Mäkelä authored
      The test main.index_merge_innodb is taking very much time,
      especially on later versions (10.2 and 10.3).
      
      Some of this could be attributed to the use of INSERT...SELECT,
      which is time-consumingly creating explicit record locks in InnoDB
      for the locking read in the SELECT part.
      
      In 10.3 and later, some slowness can be attributed to MDEV-12288,
      which makes the InnoDB purge thread spend time to reset transaction
      identifiers in the inserted records. If we prevent purge from
      running before all tables are dropped, the test seems to be
      10% faster on an unoptimized debug build on 10.5. (A proper fix
      would be to implement MDEV-515 and stop writing row-level undo log
      records for inserts into an empty table or partition.)
      
      At the same time, it should not hurt to make main.index_merge_myisam
      to use the sequence engine. Not only could it be a little faster,
      but the test would be slightly more readable.
      5ef12244
    • Nikita Malyavin's avatar
      MDEV-18546 ASAN heap-use-after-free in innobase_get_computed_value / row_purge · 350e46a8
      Nikita Malyavin authored
      the bug was already fixed in MDEV-17005, so now only test is added
      350e46a8
    • Nikita Malyavin's avatar
    • Marko Mäkelä's avatar
      Merge 10.4 into 10.5 · d04f2de8
      Marko Mäkelä authored
      d04f2de8
    • Marko Mäkelä's avatar
      Add encryption.innodb-redo-badkey,strict_full_crc32 · b05be3ef
      Marko Mäkelä authored
      In commit 0f7732d1
      we introduced a innodb_checksum_algorithm=full_crc32 combination
      to a number of encryption tests, and also fixed the code accordingly.
      
      The default in MariaDB 10.5 is innodb_checksum_algorithm=full_crc32.
      In a test merge to 10.5, the test encryption.innodb-redo-badkey failed
      once due to a message that had been added in that commit.
      
      Let us introduce a full_crc32 option to that test.
      And let us use strict_crc32 and strict_full_crc32 instead of the
      non-strict variants, for the previously augmented tests, to be in
      line with the earlier tests encryption.corrupted_during_recovery and
      encryption.innodb_encrypt_temporary_tables.
      b05be3ef
  4. 10 Oct, 2019 2 commits