1. 28 Nov, 2007 4 commits
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/31479-5.0 · ec8d8c8d
      unknown authored
      into  mysql.com:/Users/davi/mysql/mysql-5.1-runtime
      
      
      mysql-test/r/lock_multi.result:
        Null merge.
      mysql-test/t/lock_multi.test:
        Null merge.
      sql/sql_table.cc:
        Null merge.
      ec8d8c8d
    • unknown's avatar
      Bug#31479 Bad lock interaction if CREATE TABLE LIKE is killed · 4b002635
      unknown authored
      Kill of a CREATE TABLE source_table LIKE statement waiting for a
      name-lock on the source table causes a bad lock interaction.
      
      The mysql_create_like_table() has a bug that if the connection is
      killed while waiting for the name-lock on the source table, it will
      jump to the wrong error path and try to unlock the source table and
      LOCK_open, but both weren't locked.
      
      The solution is to simple return when the name lock request is killed,
      it's safe to do so because no lock was acquired and no cleanup is needed.
      
      Original bug report also contains description of other problems
      related to this scenario but they either already fixed in 5.1 or
      will be addressed separately (see bug report for details).
      
      
      mysql-test/r/lock_multi.result:
        Add test case result for Bug#31479
      mysql-test/t/lock_multi.test:
        Add test case for Bug#31479
      sql/sql_table.cc:
        Rerturn TRUE when the lock gets killed.
      4b002635
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · eef14158
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      eef14158
    • unknown's avatar
      Error number increased; fixing broken number. · 61fcfc67
      unknown authored
      61fcfc67
  2. 27 Nov, 2007 2 commits
  3. 26 Nov, 2007 17 commits
    • unknown's avatar
      Remove disabling of testcases · ec3976ed
      unknown authored
      ec3976ed
    • unknown's avatar
      Bug#25146 Some warnings/errors not shown when using --show-warnings · 53cf1921
      unknown authored
       - Additional patch to fix compiler warnings
      
      
      client/mysql.cc:
        Initialize warnings to 0 to avid compiler warning
        Call 'print_warnings' also when error occured
      mysql-test/r/mysql.result:
        Change test to make is possible to see that second set of warnings
        are from second invocation of mysql
      mysql-test/t/mysql.test:
        Change test to make is possible to see that second set of warnings
        are from second invocation of mysql
      53cf1921
    • unknown's avatar
      Revert · 835dcc09
      unknown authored
      835dcc09
    • unknown's avatar
      Merge kpettersson@bk-internal.mysql.com:/home/bk/mysql-5.1-runtime · 6b15ed1c
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      6b15ed1c
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug16470/my51-bug16470 · f1ad502a
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      mysql-test/r/grant.result:
        Auto merged
      mysql-test/t/grant.test:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        manual merge
      f1ad502a
    • unknown's avatar
      Merge mysql.com:/Users/davi/mysql/bugs/29592-5.0 · 08e232b9
      unknown authored
      into  mysql.com:/Users/davi/mysql/bugs/29592-5.1
      
      
      include/mysql.h:
        Auto merged
      libmysql/libmysql.c:
        Auto merged
      libmysql/libmysql.def:
        Auto merged
      libmysqld/libmysqld.def:
        Auto merged
      include/mysql_h.ic:
        Update ABI check file.
      08e232b9
    • unknown's avatar
      Bug#16470 crash on grant if old grant tables · 1ddb4722
      unknown authored
      Loading 4.1 into 5.0 or 5.1 failed silently because procs_priv table missing.
      This caused the server to crash on any attempt to store new grants because
      of uninitialized structures.
      
      This patch breaks up the grant loading function into two phases to allow
      for procs_priv table to fail with an warning instead of crashing the server.
      
      
      mysql-test/r/grant.result:
        Test case
      mysql-test/t/grant.test:
        Test case making sure that FLUSH PRIVILEGES doesn't crash the server if
        procs_priv is removed.
      sql/sql_acl.cc:
        - Refactored grant_reload into two phases: 1. open and lock tables_priv and 
          columns_priv tables, read the data, close tables. 2. open and lock
          procs_priv, read data, close table. Since the tables are independant of
          each other there will be no race conditions and it will be possible to
          handle situations where the procs_priv table isn't present.
        - Refactored the helper function grant_load into new grant_load (without
          procs_priv table) and grant_load_procs_priv.
      sql/sql_parse.cc:
        - Changed comment style to doxygen style.
      1ddb4722
    • unknown's avatar
      Bug#29592 SQL Injection issue · b8a19c22
      unknown authored
      Remove the mysql_odbc_escape_string() function. The function
      has multi-byte character escaping issues, doesn't honor the
      NO_BACKSLASH_ESCAPES mode and is not used anymore by the
      Connector/ODBC as of 3.51.17.
      
      
      include/mysql.h:
        Remove mysql_odbc_escape_string() prototype.
      include/mysql_h.ic:
        Update abi check file, mostly line changes and mysql_odbc_escape_string
        removal.
      libmysql/libmysql.c:
        Remove mysql_odbc_escape_string() body.
      libmysql/libmysql.def:
        Remove mysql_odbc_escape_string()
      libmysqld/libmysqld.def:
        Remove mysql_odbc_escape_string()
      b8a19c22
    • unknown's avatar
      bc60aa32
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-rpl-merge · 747049cc
      unknown authored
      into  pilot.mysql.com:/data/msvensson/mysql/mysql-5.1-rpl-merge
      
      
      747049cc
    • unknown's avatar
      Add suppressions for expected warning messages that appears in · a440fd39
      unknown authored
      slave's error log when running rpl_extraColmaster_*.test 
      
      
      a440fd39
    • unknown's avatar
      aa2030d6
    • unknown's avatar
      75ea7c7e
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug32436/my51-bug32436 · 1522ef3f
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/item_func.cc:
        Auto merged
      1522ef3f
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug32436/my50-bug32436 · 0b65a2e7
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/bug32436/my51-bug32436
      
      
      sql/item_func.cc:
        Auto merged
      0b65a2e7
    • unknown's avatar
      Bug #32436 KILL QUERY completely deadlocks mysqld · fea1524d
      unknown authored
      Sending several "KILL QUERY" statements to target a connection running
      "SELECT SLEEP" could freeze the server.
      
      The locking order in Item_func_sleep was wrong and this could lead to a
      dead lock.
      
      This patch solves the issue by resolving the locking order properly.
      
      
      sql/item_func.cc:
        - Moved LOCK_user_locks critical region so that it doesn't share space with
          mysys_var->mutex region; this can lead to deadlock.
      fea1524d
    • unknown's avatar
      Disabling failing test that has been reported as bug. · 72cafd47
      unknown authored
      
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Disabling failing test.
      72cafd47
  4. 23 Nov, 2007 3 commits
    • unknown's avatar
      Merge bodhi.(none):/opt/local/work/mysql-5.0-runtime · c01974f0
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_yacc.yy:
        Manual merge.
      c01974f0
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.1 · 85ff2b98
      unknown authored
      into  bodhi.(none):/opt/local/work/mysql-5.1-runtime
      
      
      85ff2b98
    • unknown's avatar
      Post-merge fixes. · 850fed3e
      unknown authored
      
      mysql-test/r/innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_binlog_grant.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraColmaster_innodb.result:
        Result change.
      mysql-test/suite/rpl/r/rpl_extraColmaster_myisam.result:
        Result change.
      mysql-test/suite/rpl/t/disabled.def:
        Enabling some tests.
      mysql-test/suite/rpl/t/rpl_binlog_grant.test:
        Adding missing master-slave.inc, causing previous tests to pollute
        the binary log.
      mysql-test/suite/rpl_ndb/t/disabled.def:
        Enabling some tests.
      850fed3e
  5. 22 Nov, 2007 11 commits
  6. 21 Nov, 2007 3 commits
    • unknown's avatar
      Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.1 · 692f0e4f
      unknown authored
      into  dl145h.mysql.com:/data0/mkindahl/mysql-5.1-rpl-merge
      
      
      client/mysql.cc:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/ctype_ucs.result:
        Auto merged
      mysql-test/r/mysql.result:
        Auto merged
      mysql-test/suite/ndb/r/ndb_dd_basic.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraCol_innodb.result:
        Auto merged
      mysql-test/suite/rpl/r/rpl_extraCol_myisam.result:
        Auto merged
      mysql-test/suite/rpl_ndb/r/rpl_ndb_extraCol.result:
        Auto merged
      mysql-test/t/ctype_uca.test:
        Auto merged
      mysql-test/t/ctype_ucs.test:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/mysql.test:
        Auto merged
      mysql-test/t/partition.test:
        Auto merged
      mysql-test/t/subselect.test:
        Auto merged
      sql/field.cc:
        Auto merged
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_show.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      mysql-test/r/innodb.result:
        Manual merge.
      692f0e4f
    • unknown's avatar
      Merge adventure.(none):/home/thek/Development/cpp/bug31153/my51-bug31153 · 569c2dcd
      unknown authored
      into  adventure.(none):/home/thek/Development/cpp/mysql-5.1-runtime
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      569c2dcd
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0-build · 787316f2
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0-build
      
      
      787316f2