1. 11 Mar, 2010 2 commits
    • jyang's avatar
      branches/zip: Once change in bug #47621 merges into zip branch, · ed1c90fa
      jyang authored
      zip only test innodb_bug44571 needs to be updated to reflect the
      column name change would be successful be done in InnoDB as well.
      ed1c90fa
    • marko's avatar
      branches/zip: Fix and clarify the latching of some buf_block_t members. · 86018ed1
      marko authored
      buf_block_t::check_index_page_at_flush: Note that this field is not
      protected by any mutex. Make it a separate field, not a bitfield that
      could share the machine word with other fields.
      
      buf_block_t::lock_hash_val: Note that this field is protected by
      buf_block_t::lock (or during block creation, by buf_pool_mutex and
      buf_block_t::mutex).
      
      buf_block_get_lock_hash_val(): Assert that block->lock is held by the
      current thread.
      
      Issue #465, rb://267 approved by Inaam Rana
      86018ed1
  2. 10 Mar, 2010 7 commits
    • marko's avatar
      branches/zip: Merge revisions 6669:6788 from branches/5.1: · 33ebfa0b
      marko authored
        ------------------------------------------------------------------------
        r6774 | calvin | 2010-03-03 23:56:10 +0200 (Wed, 03 Mar 2010) | 2 lines
        Changed paths:
           M /branches/5.1/trx/trx0sys.c
      
        branches/5.1: fix bug#51653: outdated reference to set-variable
        Non functional change.
        ------------------------------------------------------------------------
        r6780 | vasil | 2010-03-08 19:13:20 +0200 (Mon, 08 Mar 2010) | 4 lines
        Changed paths:
           M /branches/5.1/plug.in
      
        branches/5.1:
      
        Whitespace fixup.
        ------------------------------------------------------------------------
        r6783 | jyang | 2010-03-09 17:54:14 +0200 (Tue, 09 Mar 2010) | 9 lines
        Changed paths:
           M /branches/5.1/handler/ha_innodb.cc
           M /branches/5.1/mysql-test/innodb_bug21704.result
           A /branches/5.1/mysql-test/innodb_bug47621.result
           A /branches/5.1/mysql-test/innodb_bug47621.test
      
        branches/5.1: Fix bug #47621 "MySQL and InnoDB data dictionaries
        will become out of sync when renaming columns". MySQL does not
        provide new column name information to storage engine to
        update the system table. To avoid column name mismatch, we shall
        just request a table copy for now.
      
        rb://246 approved by Marko.
        ------------------------------------------------------------------------
        r6785 | vasil | 2010-03-10 09:04:38 +0200 (Wed, 10 Mar 2010) | 11 lines
        Changed paths:
           M /branches/5.1/mysql-test/innodb_bug38231.test
      
        branches/5.1:
      
        Add the missing --reap statements in innodb_bug38231.test. Probably MySQL
        enforced the presence of those recently and the test started failing like:
      
          main.innodb_bug38231                     [ fail ]
                  Test ended at 2010-03-10 08:48:32
      
          CURRENT_TEST: main.innodb_bug38231
          mysqltest: At line 49: Cannot run query on connection between send and reap
        ------------------------------------------------------------------------
        r6788 | vasil | 2010-03-10 10:53:21 +0200 (Wed, 10 Mar 2010) | 8 lines
        Changed paths:
           M /branches/5.1/mysql-test/innodb_bug38231.test
      
        branches/5.1:
      
        In innodb_bug38231.test: replace the fragile sleep 0.2 that depends on timing
        with a more robust condition which waits for the TRUNCATE and LOCK commands
        to appear in information_schema.processlist. This could also break if there
        are other sessions executing the same SQL commands, but there are none during
        the execution of the mysql test.
        ------------------------------------------------------------------------
      33ebfa0b
    • marko's avatar
    • marko's avatar
      63b19875
    • jyang's avatar
      branches/zip: Fix bug #51356: "many valgrind errors in error messages · 191261da
      jyang authored
      with concurrent ddl". Null terminate the name string returned
      from innobase_convert_identifier() call when reporting DB_DUPLICATE_KEY
      error in create_table_def().
      rb://266 approved by Marko
      191261da
    • jyang's avatar
      branches/zip: If a unique index is on a column prefix, such · 16b41a58
      jyang authored
      unique index cannot be upgrade to primary index even if there
      is no primary index already defined. Also fix possible corruption
      when initialize "ref_length" value in case there is a mismatch
      between MySQL and InnoDB primary key. Fix bug #51378: "Init
      'ref_length'  to correct value, in case an out of bound MySQL
      primary_key".
      rb://262 approved by Marko.
      16b41a58
    • marko's avatar
      branches/zip: recv_parse_log_rec(): Remove a bogus assertion about page_no. · 6c7ddbe2
      marko authored
      TODO: We might also consider removing recv_max_parsed_page_no, because
      it does not make much sense with *.ibd files.
      
      recv_report_corrupt_log(), recv_scan_log_recs(): Abort when a
      corrupted log record has been found, unless innodb_force_recovery has
      been set.
      
      This fixes Issue #464.
      rb://265 approved by Heikki Tuuri
      6c7ddbe2
    • vasil's avatar
      branches/zip: · 48cf851d
      vasil authored
      Fix typo in comment
      48cf851d
  3. 09 Mar, 2010 2 commits
  4. 08 Mar, 2010 1 commit
  5. 04 Mar, 2010 1 commit
  6. 03 Mar, 2010 3 commits
  7. 02 Mar, 2010 1 commit
    • vasil's avatar
      branches/zip: · 0ad5bf27
      vasil authored
      Add a NOTE to the comment of btr_node_ptr_get_child_page_no()
      to prevent mysterious bugs.
      0ad5bf27
  8. 01 Mar, 2010 1 commit
  9. 24 Feb, 2010 1 commit
    • marko's avatar
      branches/zip: Allocate the merge sort buffers from a heap, not stack. · 90b496f6
      marko authored
      The merge sort can use up to 48KiB of buffers when merging blocks.
      That can cause a stack overflow, especially on 64-bit systems when not
      building with inlined functions.  This was reported as Issue #462.
      
      row_merge_dup_report(): Allocate buf and offsets from a heap.
      
      row_merge_heap_create(): Allocate space for buf[3] too. Fix bogus
      sizeof arithmetics that happened to work, because
      sizeof(ulint)==sizeof(void*).
      
      row_merge_blocks(), row_merge_blocks_copy(): Allocate buf[3] from heap.
      
      row_merge_insert_index_tuples(): Allocate buf from graph_heap.
      
      rb://258 approved and tested by Sunny Bains
      90b496f6
  10. 22 Feb, 2010 1 commit
  11. 20 Feb, 2010 1 commit
    • vasil's avatar
      Non-functional change: update copyright year to 2010 of the files · 6c3ab906
      vasil authored
      that have been modified after 2010-01-01 according to svn.
      
      for f in $(svn log -v -r{2010-01-01}:HEAD |grep "^   M " |cut -b 16- |sort -u) ; do sed -i "" -E 's/(Copyright \(c\) [0-9]{4},) [0-9]{4}, (.*Innobase Oy.+All Rights Reserved)/\1 2010, \2/' $f ; done
      6c3ab906
  12. 18 Feb, 2010 1 commit
  13. 17 Feb, 2010 5 commits
  14. 16 Feb, 2010 6 commits
  15. 12 Feb, 2010 1 commit
    • inaam's avatar
      branches/zip · bc36c8eb
      inaam authored
      ChangeLog entry for r6674.
      bc36c8eb
  16. 11 Feb, 2010 5 commits
    • marko's avatar
      462933b6
    • inaam's avatar
      branches/zip bug# 49535 · ffb43707
      inaam authored
      This is a backport of r4924.
      mem_heap_get_size() scans all allocated blocks to calculate the total
      size of the heap. This patch introduces a new, total_size, field in
      mem_block_info_struct. This field is valid only for base block 
      (i.e.: the first block allocated for the heap) and is set to
      ULINT_UNDEFINED in other blocks.
      This considerably improves the performance of redo scan during recovery.
      
      rb://108 issue#216
      
      Approved by: Heikki
      
      ------------------------------------------------------------------------
      ffb43707
    • marko's avatar
      branches/zip: Relax a debug assertion about a missing BLOB. (Issue #452) · 7e07ce47
      marko authored
      When rolling back an incomplete transaction in purge, tolerate missing
      BLOBs also in update undo, when undoing an INSERT by updating a delete-marked
      record, and the delete-marked record is no longer needed.
      Previously, we only tolerated missing BLOBs in insert undo.
      This merely fixes a debug assertion; the code performed correctly
      without UNIV_DEBUG.
      
      rb://249 approved by Sunny Bains.
      7e07ce47
    • marko's avatar
      branches/zip: Introduce thr_is_recv(). · e8963afa
      marko authored
      e8963afa
    • marko's avatar
      branches/zip: Clarify the rollback of INSERT by UPDATE of delete-marked rec. · 62982447
      marko authored
      row_undo_mod_remove_clust_low(): Augment the function comment.
      
      row_undo_mod_remove_clust_low(), row_undo_mod_del_mark_or_remove_sec_low(),
      row_undo_mod_del_mark_or_remove_sec(), row_undo_mod_upd_del_sec():
      Add ut_ad(node->rec_type == TRX_UNDO_UPD_DEL_REC);
      62982447
  17. 10 Feb, 2010 1 commit