1. 01 Nov, 2005 3 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · edd45658
      unknown authored
      into moonbone.local:/work/14186-bug-4.1-mysql
      
      
      sql/sql_select.cc:
        Auto merged
      sql/sql_select.h:
        Auto merged
      edd45658
    • unknown's avatar
      Review of new pushed code · ac79bc2b
      unknown authored
      Removed wrong fix for bug #14009 (use of abs() on null value causes problems with filesort)
      Mark that add_time(), time_diff() and str_to_date() can return null values
      
      
      myisam/mi_check.c:
        keyoffset is not a position (no %lx here)
      mysql-test/r/func_sapdb.result:
        Fixed test after marking that timediff() can return NULL
      sql/item_func.cc:
        Removed wrong fix for bug #14009 (use of abs() on null value causes problems with filesort)
      sql/item_timefunc.cc:
        Mark that add_time and str_to_date() can return null values
      sql/item_timefunc.h:
        Mark that time_diff can return 0
      sql/spatial.cc:
        Simple cleanups during review of new code
      ac79bc2b
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 9f89127f
      unknown authored
      into  mysql.com:/usr/home/ram/work/mysql-4.1
      
      9f89127f
  2. 31 Oct, 2005 4 commits
  3. 29 Oct, 2005 4 commits
  4. 28 Oct, 2005 7 commits
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-4.1 · c7398a33
      unknown authored
      into mysql.com:/home/psergey/mysql-4.1-bug14139
      
      c7398a33
    • unknown's avatar
      Merge jamppa@bk-internal.mysql.com:/home/bk/mysql-4.1 · 9fa6b1e2
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-4.1
      
      9fa6b1e2
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 537a30d1
      unknown authored
      into  mysql.com:/home/alexi/dev/mysql-4.1-10511
      
      537a30d1
    • unknown's avatar
      Fix BUG#10511: Wrong padding of UCS2 CHAR columns in · 00d328e4
      unknown authored
       ON UPDATE CASCADE
      
      
      innobase/row/row0ins.c:
        Patch from Marko is applied
      00d328e4
    • unknown's avatar
      Fix bug #14138 ROLLUP and PROCEDURE ANALYSE() hang server · b5fccb70
      unknown authored
      Procedure analyse() redefines select's fields_list. setup_copy_fields() assumes
      that fields_list is a part of all_fields_list. Because select have only 
      3 columns and analyse() redefines it to have 10 columns, int overrun in
      setup_copy_fields() occurs and server goes to almost infinite loop.
      
      Because fields_list used not only to send data ad fields types, it's wrong 
      to allow procedure redefine it. This patch separates select's fileds_list 
      and procedure's one. Now if procedure is present, copy of fields_list is 
      created in procedure_fields_list and it is used for sending data and fields.
      
      
      mysql-test/t/analyse.test:
        Test case for bug #14138  ROLLUP and PROCEDURE ANALYSE() hang server
      mysql-test/r/analyse.result:
        Test case for bug #14138  ROLLUP and PROCEDURE ANALYSE() hang server
      sql/sql_select.h:
        Fix bug #14138  ROLLUP and PROCEDURE ANALYSE() hang server
        To JOIN  Added separate fields_list for procedure.
      sql/sql_select.cc:
        Fix bug #14138  ROLLUP and PROCEDURE ANALYSE() hang server
        SELECT's fields_list and procedure's fields_list made split. If procedure is defined
        then procedure's fields_list is used to send fields and data.
      b5fccb70
    • unknown's avatar
      Merge a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-4.0 · 78f3127e
      unknown authored
      into  a193-229-222-105.elisa-laajakaista.fi:/home/my/bk/mysql-4.1
      
      
      include/config-netware.h:
        Auto merged
      78f3127e
    • unknown's avatar
      NetWare specific change to use a LibC API instead of a · c66d83e5
      unknown authored
      kernel function to prevent CPU hogs.
      
      c66d83e5
  5. 27 Oct, 2005 9 commits
    • unknown's avatar
      Fix bug#14186 select datefield is null not updated · 0c094f2a
      unknown authored
      Date field was declared as not null, thus expression 'datefield is null'
      was always false. For SELECT special handling of such cases is used. 
      There 'datefield is null' converted to 'datefield eq "0000-00-00"'.
      
      In mysql_update() before creation of select added remove_eq_conds() call.
      It makes some optimization of conds and in particular performs conversion
      from 'is null' to 'eq'. 
      Also remove_eq_conds() makes some evaluation of conds and if it founds that
      conds is always false then update statement is not processed further.
      All this allows to perform some update statements process faster due to
      optimized conds, and not wasting resources if conds known to be false. 
      
      
      sql/sql_select.cc:
        Fix bug#14186  select datefield is null not updated
        Remove static from remove_eq_conds()
      sql/sql_select.h:
         Fix bug#14186  select datefield is null not updated
        Added remove_eq_conds() prototype.
      mysql-test/r/update.result:
        Test case for  bug#14186  select datefield is null not updated
      mysql-test/t/update.test:
        Test case for  bug#14186  select datefield is null not updated
      sql/sql_update.cc:
        Fix bug#14186  select datefield is null not updated
        To mysql_update() added call to remove_eq_conds() to optimize conds and convert 'datefield is null' to 'datefield eq 0000-00-00'
      0c094f2a
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-14009 · 2d9654a5
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      sql/item_func.cc:
        Auto merged
      2d9654a5
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · 11108771
      unknown authored
      into moonbone.local:/work/13855-bug-4.1-mysql
      
      11108771
    • unknown's avatar
      select.result: · ef12b2c8
      unknown authored
        After merge fix
      
      
      mysql-test/r/select.result:
        After merge fix
      ef12b2c8
    • unknown's avatar
      Manually merged · 32b21cfa
      unknown authored
      
      include/config-netware.h:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      mysql-test/r/select.result:
        Manually merged fix for bug#13855
      mysql-test/t/select.test:
        Manuall merged fix for bug#13855
      32b21cfa
    • unknown's avatar
      Merge aivanov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 7b68c0be
      unknown authored
      into  mysql.com:/home/alexi/dev/mysql-4.1-innobase
      
      7b68c0be
    • unknown's avatar
      conf_to_src.c: · 9db1fffd
      unknown authored
        Dump MY_CS_CSSORT when it's necessary.
      
      
      strings/conf_to_src.c:
        Dump MY_CS_CSSORT when it's necessary.
      9db1fffd
    • unknown's avatar
      conf_to_src.c: · 426e2f8a
      unknown authored
        Updating to conform the current CHARSET_INFO structure.
      
      
      strings/conf_to_src.c:
        Updating to conform the current structure.
      426e2f8a
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · f84aaaf9
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1.b13347
      
      f84aaaf9
  6. 26 Oct, 2005 3 commits
    • unknown's avatar
      Merge pgalbraith@bk-internal.mysql.com:/home/bk/mysql-4.1 · 52a03b2a
      unknown authored
      into  krsna.patg.net:/home/patg/mysql-build/mysql-4.1
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/mysql-test-run.sh:
        Auto merged
      52a03b2a
    • unknown's avatar
      Removed innobase/my_cnf, innobase/include/makefilewin.i, · 2b4ccca3
      unknown authored
       and innobase/*/makefilewin (which are unused now).
      
      
      BitKeeper/deleted/.del-makefilewin.i~5c8479dcb8a455b2:
        Delete: innobase/include/makefilewin.i
      BitKeeper/deleted/.del-makefilewin~78000390c783b1c5:
        Delete: innobase/btr/makefilewin
      BitKeeper/deleted/.del-makefilewin~2fc379bd4065c995:
        Delete: innobase/buf/makefilewin
      BitKeeper/deleted/.del-makefilewin~d37b6b303348c871:
        Delete: innobase/data/makefilewin
      BitKeeper/deleted/.del-makefilewin~5104767c73775697:
        Delete: innobase/dict/makefilewin
      BitKeeper/deleted/.del-makefilewin~d90f35fdc3f2ee5f:
        Delete: innobase/dyn/makefilewin
      BitKeeper/deleted/.del-makefilewin~c7b621c745e5de95:
        Delete: innobase/eval/makefilewin
      BitKeeper/deleted/.del-makefilewin~4d139e182457e553:
        Delete: innobase/fil/makefilewin
      BitKeeper/deleted/.del-makefilewin~d1a9d1f7d33fcb73:
        Delete: innobase/fsp/makefilewin
      BitKeeper/deleted/.del-makefilewin~ef3a208fa0e9b0db:
        Delete: innobase/fut/makefilewin
      BitKeeper/deleted/.del-makefilewin~f1e3b890aa1c9ea3:
        Delete: innobase/ha/makefilewin
      BitKeeper/deleted/.del-makefilewin~1c53f31b88dd36e:
        Delete: innobase/ibuf/makefilewin
      BitKeeper/deleted/.del-makefilewin~7a9d7d5a42bbfaf5:
        Delete: innobase/lock/makefilewin
      BitKeeper/deleted/.del-makefilewin~b643e38d8da389ac:
        Delete: innobase/log/makefilewin
      BitKeeper/deleted/.del-makefilewin~a40ea12eebdd6ef0:
        Delete: innobase/mach/makefilewin
      BitKeeper/deleted/.del-makefilewin~1dbc058d76ebf1db:
        Delete: innobase/mem/makefilewin
      BitKeeper/deleted/.del-makefilewin~6ba64863bce3d0b8:
        Delete: innobase/mtr/makefilewin
      BitKeeper/deleted/.del-makefilewin~15e9e5c9e8fa870b:
        Delete: innobase/os/makefilewin
      BitKeeper/deleted/.del-makefilewin~aeea7c82f21f7cf5:
        Delete: innobase/page/makefilewin
      BitKeeper/deleted/.del-makefilewin~dea10ec1c94f7be:
        Delete: innobase/pars/makefilewin
      BitKeeper/deleted/.del-makefilewin~608ed49dcd88e0f7:
        Delete: innobase/que/makefilewin
      BitKeeper/deleted/.del-makefilewin~2e0407fe123f8365:
        Delete: innobase/read/makefilewin
      BitKeeper/deleted/.del-makefilewin~fdda94ad32fa9e34:
        Delete: innobase/rem/makefilewin
      BitKeeper/deleted/.del-makefilewin~dc4b8ad5ea53bd:
        Delete: innobase/row/makefilewin
      BitKeeper/deleted/.del-makefilewin~63acd666293282a:
        Delete: innobase/srv/makefilewin
      BitKeeper/deleted/.del-makefilewin~13888739357b3025:
        Delete: innobase/sync/makefilewin
      BitKeeper/deleted/.del-makefilewin~c8273a47b90f52bb:
        Delete: innobase/thr/makefilewin
      BitKeeper/deleted/.del-makefilewin~f4b7b99a887b7de:
        Delete: innobase/trx/makefilewin
      BitKeeper/deleted/.del-makefilewin~72a64128bacce71b:
        Delete: innobase/usr/makefilewin
      BitKeeper/deleted/.del-makefilewin~389ee2dcf79afb79:
        Delete: innobase/ut/makefilewin
      BitKeeper/deleted/.del-makefilewin~14f24a4a173e2fcd:
        Delete: innobase/makefilewin
      BitKeeper/deleted/.del-my_cnf~977f69858affc57b:
        Delete: innobase/my_cnf
      innobase/include/Makefile.am:
        Removed ref to Makefilewin.i (it is unused now).
      2b4ccca3
    • unknown's avatar
      Imported fix from 5.0. · 16f910fd
      unknown authored
      16f910fd
  7. 25 Oct, 2005 10 commits
    • unknown's avatar
      mysql-test-run.pl: · 48f09e1e
      unknown authored
        Added MTR_BUILD_THREAD to control the port range
      
      
      mysql-test/mysql-test-run.pl:
        Added MTR_BUILD_THREAD to control the port range
      48f09e1e
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.1 · ab2265a3
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.1
      
      ab2265a3
    • unknown's avatar
      Merge kboortz@bk-internal.mysql.com:/home/bk/mysql-4.0 · a5166e43
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-4.0
      
      a5166e43
    • unknown's avatar
      BUG# 12123 · 7296318c
      unknown authored
      Made change to mysqlimport to set character_set_database to binary to 
      make importing various charsets/columns work correctly.
      
      
      client/mysqlimport.c:
        BUG# 12123
        
        Added 'set @@character_set_database=binary' to make loading of tables with
        mixed charset types and non-latin characters load.
      mysql-test/mysql-test-run.pl:
        BUG #12123
        
        Added $MYSQL_IMPORT in order to test mysqlimport bug.
      mysql-test/mysql-test-run.sh:
        BUG #12123
        
        Added $MYSQL_IMPORT in order to test mysqlimport bug.
      mysql-test/r/mysqldump.result:
        BUG #12123
        
        Added dumping and reloading (using mysql, mysqldump, and mysqlimport) to
        show that this fix handles dumping and reloading of non-latin1 charsets
        in table with different charset columns (mixing of charsets, also can be a
        UTF table with latin1 tables). Note the select before and after dump and 
        restore - should be exact.
      mysql-test/t/mysqldump.test:
        BUG #12123
        
        Added dumping and reloading (using mysql, mysqldump, and mysqlimport) to
        show that this fix handles dumping and reloading of non-latin1 charsets
        in table with different charset columns (mixing of charsets, also can be a
        UTF table with latin1 tables). Note the select before and after dump and 
        restore - should be exact. (results of this)
      7296318c
    • unknown's avatar
      BUG#14139: When handling "CREATE TABLE(field_X type_spec,...) SELECT smth AS field_X, ...." · 5f6606ec
      unknown authored
      avoid multiplying length of field_X by charset->mbmaxlen twice when calculating space 
      required for field_X in the new table.
      
      
      mysql-test/r/create.result:
        Testcase for BUG#14139
      mysql-test/t/create.test:
        Testcase for BUG#14139
      sql/field.cc:
        BUG#14139: Make create_length_to_internal_length() save length-in-characters in 
        create_field::chars_length.
      sql/field.h:
        BUG#14139: Add create_length::chars_length where we save length-in-characters, added comments.
      sql/sql_table.cc:
        BUG#14139: When handling "CREATE TABLE(field_X type_spec,...) SELECT smth AS field_X, ...."
        we get two instances of create_field: (1) is occurence of field_X in create list, and (2) is
        in select list. If we figure they both refer to the same field, we "join" them according to
        some rule that is not explicitly specified anywhere.
        When we do this "join", create_field::length already contains length-in-bytes for both, so
        when we transfer field length (in characters) from (1) to (2), use length-in-characters that
        we have saved in create_length::chars_length.
      5f6606ec
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-4.1-12925 · 984400fc
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-4.1-clean
      
      
      tests/mysql_client_test.c:
        Auto merged
      984400fc
    • unknown's avatar
      Fix incorrect casts in my_getopt code that capped the maximum of longlong · 53f3218a
      unknown authored
      options to the wrong value. (Bug #12925)
      
      
      mysql-test/t/mysql_client_test.test:
        Add parameter for testing getopt bug
      mysys/my_getopt.c:
        Remove incorrect and unnecessary casts
      tests/mysql_client_test.c:
        Add test case for Bug #12925 (my_getopt bug)
      53f3218a
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · e9b005ea
      unknown authored
      into moonbone.local:/work/14016-bug-4.1-mysql
      
      e9b005ea
    • unknown's avatar
      Fix bug #14016 date_format() 2nd parameter was compared using case insensitive · 0b2efd3d
      unknown authored
      collation
      
      By default constant strings in second parameter of date_time() have case
      insensitive collation. Because of this expressions date_format(f,'%m') and 
      date_format(f,'%M') wrongly becomes equal, which results in choosing wrong 
      column to sort by.
      
      Now if second parameter of date_format() is constant then it's collation is 
      changed to case sensitive.
      
      
      sql/item_timefunc.cc:
        Fix bug #14016 date_format() 2nd parameter was compared using case insensitive collation.
        If second parameter of date_format() is constant then it's collation is changed to case sensitive.
      mysql-test/r/date_formats.result:
        Test case for bug#14016 2nd parameter was compared using case insensitive collation
      mysql-test/t/date_formats.test:
        Test case for bug#14016 2nd parameter was compared using case insensitive collation
      0b2efd3d
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-4.1 · f63c5a07
      unknown authored
      into moonbone.local:/work/13392-bug-4.1-mysql
      
      f63c5a07