1. 20 Sep, 2021 1 commit
    • Julius Goryavsky's avatar
      MDEV-26441: Linux-dependent construct in SST scripts · f4d6d017
      Julius Goryavsky authored
      SST scripts currently use Linux-specific construction
      to create a temporary directory if the path prefix for
      that directory is specified by the user. This does not
      work with FreeBSD. This commit adds support for FreeBSD.
      
      No separate test required.
      f4d6d017
  2. 18 Sep, 2021 1 commit
    • Marko Mäkelä's avatar
      MDEV-26636: InnoDB defragmentation statistics cause races on TEMPORARY TABLE · 3209bc66
      Marko Mäkelä authored
      btr_defragment_save_defrag_stats_if_needed(): Do not save
      defragmentation statistics for temporary tables.
      They are exempt of defragmentation anyway
      (ha_innobase::optimize() never invokes defragmentation for them),
      and the user-visible names are not available inside InnoDB.
      
      Furthermore, InnoDB assumes that temporary tables are never accessed
      by other threads than the one that handles the session with which
      the temporary table is associated with.
      
      Furthermore, we simplify the test innodb.innodb_defrag_stats
      and include a test case that demonstrates that defragmentation
      statistics are no longer being saved for temporary tables.
      3209bc66
  3. 17 Sep, 2021 1 commit
  4. 16 Sep, 2021 2 commits
  5. 15 Sep, 2021 2 commits
  6. 13 Sep, 2021 1 commit
  7. 11 Sep, 2021 5 commits
  8. 10 Sep, 2021 2 commits
    • Marko Mäkelä's avatar
      MDEV-26537 InnoDB corrupts files due to incorrect st_blksize calculation · d09426f9
      Marko Mäkelä authored
      The st_blksize returned by fstat(2) is not documented to be
      a power of 2, like we assumed in
      commit 58252fff (MDEV-26040).
      While on Linux, the st_blksize appears to report the file system
      block size (which hopefully is not smaller than the sector size
      of the underlying block device), on FreeBSD we observed
      st_blksize values that might have been something similar to st_size.
      
      Also IBM AIX was affected by this. A simple test case would
      lead to a crash when using the minimum innodb_buffer_pool_size=5m
      on both FreeBSD and AIX:
      
      seq -f 'create table t%g engine=innodb select * from seq_1_to_200000;' \
      1 100|mysql test&
      seq -f 'create table u%g engine=innodb select * from seq_1_to_200000;' \
      1 100|mysql test&
      
      We will fix this by not trusting st_blksize at all, and assuming that
      the smallest allowed write size (for O_DIRECT) is 4096 bytes. We hope
      that no storage systems with larger block size exist. Anything larger
      than 4096 bytes should be unlikely, given that it is the minimum
      virtual memory page size of many contemporary processors.
      
      MariaDB Server on Microsoft Windows was not affected by this.
      
      While the 512-byte sector size of the venerable Seagate ST-225 is still
      in widespread use, the minimum innodb_page_size is 4096 bytes, and
      innodb_log_file_size can be set in integer multiples of 65536 bytes.
      
      The only occasion where InnoDB uses smaller data file block sizes than
      4096 bytes is with ROW_FORMAT=COMPRESSED tables with KEY_BLOCK_SIZE=1
      or KEY_BLOCK_SIZE=2 (or innodb_page_size=4096). For such tables,
      we will from now on preallocate space in integer multiples of 4096 bytes
      and let regular writes extend the file by 1024, 2048, or 3072 bytes.
      
      The view INFORMATION_SCHEMA.INNODB_SYS_TABLESPACES.FS_BLOCK_SIZE
      should report the raw st_blksize.
      
      For page_compressed tables, the function fil_space_get_block_size()
      will map to 512 any st_blksize value that is larger than 4096.
      
      os_file_set_size(): Assume that the file system block size is 4096 bytes,
      and only support extending files to integer multiples of 4096 bytes.
      
      fil_space_extend_must_retry(): Round down the preallocation size to
      an integer multiple of 4096 bytes.
      d09426f9
    • Vladislav Vaintroub's avatar
      Speedup build of the MSI package · 1c378f1b
      Vladislav Vaintroub authored
      1c378f1b
  9. 09 Sep, 2021 1 commit
  10. 07 Sep, 2021 4 commits
  11. 06 Sep, 2021 2 commits
  12. 05 Sep, 2021 2 commits
    • Daniel Black's avatar
      MDEV-12055 binlog.binlog_stm_ctype_ucs postfix · 38648bbb
      Daniel Black authored
      As highlighted in https://bugs.gentoo.org/807995,
      people occasionaly run tests in the 20:00->23:59:59 time range.
      
      Fixes 265e3253
      
      binlog.binlog_stm_ctype_ucs 'mix'        w1 [ fail ]
              Test ended at 2021-08-11 22:55:35
      
      CURRENT_TEST: binlog.binlog_stm_ctype_ucs
      --- /var/tmp/portage/dev-db/mariadb-10.5.11/work/mysql/mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.result    2021-06-18 18:19:11.000000000 +0800
      +++ /var/tmp/portage/dev-db/mariadb-10.5.11/work/mysql/mysql-test/suite/binlog/r/binlog_stm_ctype_ucs.reject    2021-08-11 22:55:34.993447479 +0800
      @@ -76,21 +76,21 @@
       /*!50003 SET @OLD_COMPLETION_TYPE=@@COMPLETION_TYPE,COMPLETION_TYPE=0*/;
       DELIMITER /*!*/;
       # at #
      -#YYMMDD HH:MM:SS server id #  end_log_pos # CRC32 XXX  Start: binlog v 4, server v #.##.## created YYMMDD HH:MM:SS
      +#210811 22:55:34 server id #  end_log_pos # CRC32 XXX  Start: binlog v 4, server v #.##.## created 210811 22:55:34
      38648bbb
    • Daniel Black's avatar
      MDEV-26529: binlog.binlog_flush_binlogs_delete_domain fails on RISC-V · 21d31b99
      Daniel Black authored
      Per https://bugs.gentoo.org/807995
      
      The test failed with:
      
      CURRENT_TEST: binlog.binlog_flush_binlogs_delete_domain
      — /tmp/mariadb-10.5.11/mysql-test/suite/binlog/r/binlog_flush_binlogs_delete_domain.result 2021-06-18 18:19:11.000000000 +0800
      +++ /tmp/mariadb-10.5.11/mysql-test/suite/binlog/r/binlog_flush_binlogs_delete_domain.reject 2021-09-01 22:55:29.406655479 +0800
      @@ -85,6 +85,6 @@
      ERROR HY000: The value of gtid domain being deleted ('4294967296') exceeds its maximum size of 32 bit unsigned integer
      FLUSH BINARY LOGS DELETE_DOMAIN_ID = (4294967295);
      Warnings:
      -Warning 1076 The gtid domain being deleted ('4294967295') is not in the current binlog state
      +Warning 1076 The gtid domain being deleted ('18446744073709551615') is not in the current binlog state
      DROP TABLE t;
      RESET MASTER;
      
      mysqltest: Result length mismatch
      
      ptr_domain_id is a uint32* so explicitly cast this when printing it out.
      
      Thanks Marek Szuba for the bug report and testing the patch.
      21d31b99
  13. 02 Sep, 2021 2 commits
  14. 01 Sep, 2021 4 commits
  15. 31 Aug, 2021 2 commits
  16. 30 Aug, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-26504 THD::copy_db_to() fails to return true if THD::db is null · ceb40ef4
      Marko Mäkelä authored
      THD::copy_db_to(): Always return true if the output parameter
      was left uninitialized. This fixes a regression that was caused
      by commit 7d0d934c (MDEV-16473).
      
      MariaDB Server 10.3 and later were unaffected by this bug
      thanks to commit a7e352b5.
      
      Possibly this bug only affects mysql_list_fields()
      in the Embedded Server (libmysqld).
      
      This bug was found by GCC 11.2.0 in CMAKE_BUILD_TYPE=RelWithDebInfo.
      ceb40ef4
    • Marko Mäkelä's avatar
      Fix GCC 11 -Wmaybe-uninitialized for PLUGIN_PERFSCHEMA · fda704c8
      Marko Mäkelä authored
      init_mutex_v1_t: Stop lying that the mutex parameter is const.
      GCC 11.2.0 assumes that it is and could complain about any mysql_mutex_t
      being uninitialized even after mysql_mutex_init() as long as
      PLUGIN_PERFSCHEMA is enabled.
      
      init_rwlock_v1_t, init_cond_v1_t: Remove untruthful const qualifiers.
      
      Note: init_socket_v1_t is expecting that the socket fd has already
      been created before PSI_SOCKET_CALL(init_socket), and therefore that
      parameter really is being treated as a pointer to const.
      fda704c8
    • Marko Mäkelä's avatar
      Update libmariadb · 969edf02
      Marko Mäkelä authored
      969edf02
  17. 29 Aug, 2021 1 commit
    • Sergei Golubchik's avatar
      mtr: fix the check where a combination is pre-selected · 600e4949
      Sergei Golubchik authored
      if all options from a combination from the combinations file are already
      present in the server's list of options, then don't try to run tests
      in other combinations from this file.
      
      old behavior was: if at least one option from a combination is
      already present in the list...
      600e4949
  18. 26 Aug, 2021 2 commits
  19. 25 Aug, 2021 2 commits