1. 31 Oct, 2018 1 commit
  2. 30 Oct, 2018 2 commits
  3. 29 Oct, 2018 3 commits
  4. 28 Oct, 2018 6 commits
    • Sergei Golubchik's avatar
      rpm fixes: more %ignore'd files · d5f564a9
      Sergei Golubchik authored
      d5f564a9
    • Sergei Golubchik's avatar
      after-merge: enable tests · cd0734d6
      Sergei Golubchik authored
      cd0734d6
    • Olivier Bertrand's avatar
      Squashed commit of connect/10.0: · 70e567f5
      Olivier Bertrand authored
      commit 02d8c21380f
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Sat Oct 6 16:27:13 2018 +0200
      
          - Fix truncating error messages on first unrecognized latin1 character
            modified:   storage/connect/ha_connect.cc
      
          - Fix MDEV-17343
            Reject multi-table UPDATE/DELETE commands that crash on some systems
            modified:   storage/connect/ha_connect.cc
            modified:   storage/connect/tabext.cpp
      
          - Try to fix failing tests (MariaDB version 10.0 only)
            modified:   storage/connect/mysql-test/connect/disabled.def
      
          - Typo
            modified:   storage/connect/global.h
      
      commit f83caed8569
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Tue Sep 25 15:49:26 2018 +0200
      
          - Try to fix failing tests (MariaDB version 10.0 only)
            modified:   storage/connect/mysql-test/connect/disabled.def
            modified:   storage/connect/mysql-test/connect/r/grant2.result
            modified:   storage/connect/mysql-test/connect/r/infoschema2-9739.result
            modified:   storage/connect/mysql-test/connect/r/mysql_exec.result
      
      commit 9fd6f178846
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Sun Sep 23 19:45:59 2018 +0200
      
          - Implement the CHECK TABLE statement and accept REPAIR and ANALYZE
            modified:   storage/connect/connect.cc
            modified:   storage/connect/ha_connect.cc
            modified:   storage/connect/ha_connect.h
            modified:   storage/connect/tabjdbc.cpp
            modified:   storage/connect/tabmysql.cpp
            modified:   storage/connect/tabodbc.cpp
      
          - MDEV-17212: Test if NumResultCols is implemented by the data source
            modified:   storage/connect/odbconn.cpp
      
          - Change error type in Optimize
            modified:   storage/connect/ha_connect.cc
      
          - Update version date
            modified:   storage/connect/ha_connect.cc
      
          - Record new result from odbc_postgresql.test
            modified:   storage/connect/mysql-test/connect/r/odbc_postgresql.result
      
      commit d8cf51319e1
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Wed Aug 8 12:18:52 2018 +0200
      
          - Comment out failing Cyrillic test in xml2.test
            modified:   storage/connect/mysql-test/connect/r/xml2.result
            modified:   storage/connect/mysql-test/connect/t/xml2.test
      
      commit 9df49e21f9e
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Tue Aug 7 15:01:06 2018 +0200
      
          - Fix MDEV-16672 Connect: Warnings with 10.0
            filamtxt.cpp: DOSFAM::RenameTempFile: Change sprintf to snprintf.
            filamvct.cpp: VECFAM::RenameTempFile: Change sprintf to snprintf.
            javaconn.cpp:
              Add JAVAConn::GetUTFString function.
              Use it instead of env->GetStringUTFChars.
              Fix wrong identation.
            javaconn.h: Add GetUTFString declaration.
            jdbconn.cpp:
              Use GetUTFString function instead of env->GetStringUTFChars.
            jmgoconn.cpp:
              Use GetUTFString function instead of env->GetStringUTFChars.
              Fix wrong identation.
            jsonudf.cpp: change 139 to BMX line 4631.
            tabjmg.cpp:
              Add ReleaseStringUTF.
              Fix wrong identation.
            tabpivot.cpp: Fix wrong identation.
            tabutil.cpp: TDBPRX::GetSubTable: Change sprintf to snprintf.
            modified:   storage/connect/filamtxt.cpp
            modified:   storage/connect/filamvct.cpp
            modified:   storage/connect/javaconn.cpp
            modified:   storage/connect/javaconn.h
            modified:   storage/connect/jdbconn.cpp
            modified:   storage/connect/jmgoconn.cpp
            modified:   storage/connect/jsonudf.cpp
            modified:   storage/connect/tabjmg.cpp
            modified:   storage/connect/tabpivot.cpp
            modified:   storage/connect/tabutil.cpp
      
          - Fix MDEV-16895 CONNECT engine's get_error_message can cause buffer
                           overflow and server crash with long queries
            ha_connect_cc: Update version.
              get_error_message: Remove charset conversion.
            modified:   storage/connect/ha_connect.cc
      
          - Fix a server crash on inserting bigint to a JDBC table
            JDBConn::SetUUID:
              Suppress check on ctyp that causes a server crash because ctyp
              can be negative and this triggers an DEBUG_ASSERT on return.
            modified:   storage/connect/jdbconn.cpp
      
          - Delete an assert(qrp) from JCATPARM *AllocCatInfo that is called with
            qrp=NULL from JDBConn::SetUUID. Also delete a clone of this function
            that was duplicated in javaconn.cpp.
            modified:   storage/connect/javaconn.cpp
            modified:   storage/connect/jdbconn.cpp
      
          - Update some disabled tests and results to avoid failure
            modified:   storage/connect/mysql-test/connect/r/jdbc.result
            modified:   storage/connect/mysql-test/connect/r/json_java_2.result
            modified:   storage/connect/mysql-test/connect/r/json_java_3.result
            modified:   storage/connect/mysql-test/connect/r/mongo_java_2.result
            modified:   storage/connect/mysql-test/connect/r/mongo_java_3.result
            modified:   storage/connect/mysql-test/connect/t/json_java_2.test
            modified:   storage/connect/mysql-test/connect/t/json_java_3.test
            modified:   storage/connect/mysql-test/connect/t/mongo_java_2.test
            modified:   storage/connect/mysql-test/connect/t/mongo_java_3.test
      
      commit 415273eb193
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Thu Jun 28 19:37:49 2018 +0200
      
          - Fix MDEV-16167 Cannot insert unsigned values into a VEC table
            modified:   storage/connect/filamvct.cpp
            modified:   storage/connect/tabvct.cpp
      
      commit 9ffcb68a9f2
      Author: Olivier Bertrand <bertrandop@gmail.com>
      Date:   Mon May 7 22:43:43 2018 +0200
      
          - Fix MDEV-15735 CONNECT [filamtxt.cpp:429]: Suspicious condition
            modified:   storage/connect/filamtxt.cpp
      
          - Fix compiler warnings
            modified:   storage/connect/domdoc.cpp
            modified:   storage/connect/ha_connect.cc
            modified:   storage/connect/json.h
            modified:   storage/connect/jsonudf.cpp
            modified:   storage/connect/tabext.cpp
            modified:   storage/connect/tabjson.cpp
            modified:   storage/connect/tabjson.h
      
          - Miscelleanous from 10.3
            modified:   storage/connect/ha_connect.cc
            modified:   storage/connect/mycat.cc
            modified:   storage/connect/user_connect.cc
      70e567f5
    • Sergei Golubchik's avatar
      CONNECT: don't mix bundled zlib and system libxml2 · 411a2540
      Sergei Golubchik authored
      System libxml2 uses system zlib, it might conflicts with the bundled.
      
      In particular, on centos5 old system zlib conflicts with the newer
      (after c5427172) bundled zlib which causes CONNECT to crash
      on xml tests.
      411a2540
    • Sergei Golubchik's avatar
      3e2394a5
    • Sergei Golubchik's avatar
      1bad8f9d
  5. 27 Oct, 2018 5 commits
  6. 25 Oct, 2018 3 commits
  7. 24 Oct, 2018 6 commits
  8. 23 Oct, 2018 2 commits
  9. 21 Oct, 2018 1 commit
    • Andrei Elkin's avatar
      MDEV-17133 dump thread reads from a past position · 5b735e8f
      Andrei Elkin authored
      According to logs analysis the Dump thread attempted to read again data which
      was already sent. The reason of regressed read turns out in an _my_b_cache_read()
      early exit branch which missed to distinguish between total zero size read (e.g
      ineffective read when Count argument is zero) from a case when the
      requested amount of data is fully read out by sole accessing the cache's
      file. In the latter case such then *effective* reading was not
      reflected in the cache's state to screw the cache's state.
      
      Fixed with a check introduced of whether the file reading was effective prior to
      early exit. When this is the case conduct standard cache state change to
      account the actual read size.
      
      Notice the bug can show up also as an error to read binlog event e.g
      through BINLOG_GTID_POS() (of MDEV-16886).
      5b735e8f
  10. 20 Oct, 2018 1 commit
  11. 19 Oct, 2018 3 commits
    • Sergei Golubchik's avatar
      MDEV-13912 mysql_upgrade: case (in)sensitivity for stored procedures · d851dd61
      Sergei Golubchik authored
      mysql_upgrade used to convert all columns of mysql.db to
      utf8_general_ci and then back to utf8_bin. In two separate ALTER's.
      
      This failed if UNIQUE indexes in mysql.db contained entries
      that differ only in the letter case.
      d851dd61
    • Sergey Vojtovich's avatar
      Remove unused code. · 64239419
      Sergey Vojtovich authored
      64239419
    • Sergey Vojtovich's avatar
      MDEV-14815 - Server crash or AddressSanitizer errors or valgrind warnings · 4ac85d6f
      Sergey Vojtovich authored
                   in thr_lock / has_old_lock upon FLUSH TABLES
      
      Explicit partition access of partitioned MEMORY table under LOCK TABLES
      may cause subsequent statements to crash the server, deadlock, trigger
      valgrind warnings or ASAN errors. Freed memory was being used due to
      incorrect cleanup.
      
      At least MyISAM and InnoDB don't seem to be affected, since their
      THR_LOCK structures don't survive FLUSH TABLES. MEMORY keeps table shared
      data (including THR_LOCK) even if there're no open instances.
      
      There's partition_info::lock_partitions bitmap, which holds bits of
      partitions allowed to be accessed after pruning. This bitmap is
      updated for each individual statement.
      
      This bitmap was abused in ha_partition::store_lock() such that when we
      need to unlock a table, locked by LOCK TABLES, only locks for partitions
      that were accessed by previous statement were released.
      
      Eventually FLUSH TABLES frees THR_LOCK_DATA objects, which are still
      linked into THR_LOCK lists. When such THR_LOCK gets reused we end up with
      freed memory access.
      
      Fixed by using ha_partition::m_locked_partitions bitmap similarly to
      ha_partition::external_lock().
      4ac85d6f
  12. 17 Oct, 2018 2 commits
  13. 16 Oct, 2018 5 commits
    • Bernd Kuhls's avatar
      cmake: fix ucontext detection · 2a576f71
      Bernd Kuhls authored
      On some archs uclibc does not provide the ucontext structure despite
      providing ucontext.h, for details see
      https://git.buildroot.net/buildroot/commit/?id=f1cbfeea95e6287c7a666aafc182ffa318eff262
      
      This patch improves the detection of ucontext by making sure that
      HAVE_UCONTEXT_H is only set when makecontext() was found.
      Signed-off-by: default avatarBernd Kuhls <bernd.kuhls@t-online.de>
      2a576f71
    • Eugene Kosov's avatar
      MDEV-17358 my_reverse_bits() is incorrect due to UB · 853dee85
      Eugene Kosov authored
      my_reverse_bits(): add a cast to fix a bit shift
      853dee85
    • Andrei Elkin's avatar
      MDEV-14431 binlog.binlog_flush_binlogs_delete_domain failed in buildbot · d8974ebd
      Andrei Elkin authored
      The test and also rpl_gtid_delete_domain failed on PPC64 platform
      due to an incorrectly specified actual key for searching
      in a gtid domain system hash. While the correct size is 32 bits
      the supplied value was 8 bytes of long int size on the platform.
      The problem became evident thanks to the big endiness which
      cut off the *least* significant part of the value field.
      
      Fixed with correcting a dynamic array initialization to hold
      now uint32 values as well as the values extraction for
      searching in the gtid domain system hash.
      A new added test ensures no overflowed values are accepted
      for deletion which prevents inadvertent action. Notice though
      
      MariaDB [test]> set @@session.gtid_domain_id=(1 << 32) + 1;
      MariaDB [test]> show warnings;
      +---------+------+--------------------------------------------------------+
      | Level   | Code | Message                                                |
      +---------+------+--------------------------------------------------------+
      | Warning | 1292 | Truncated incorrect gtid_domain_id value: '4294967297' |
      +---------+------+--------------------------------------------------------+
      MariaDB [test]> select @@session.gtid_domain_id;
      +--------------------------+
      | @@session.gtid_domain_id |
      +--------------------------+
      |               4294967295 |
      +--------------------------+
      d8974ebd
    • Sergey Vojtovich's avatar
      MDEV-11071 - Assertion `thd->transaction.stmt.is_empty()' failed in · bebe24b0
      Sergey Vojtovich authored
                   Locked_tables_list::unlock_locked_tables
      
      Similarly to regular DROP TABLE, don't leave locked tables mode if CREATE OR
      REPLACE dropped temporary table but failed to cerate new one.
      
      The problem is that there's no track of which temporary table was "locked" by
      LOCK TABLES.
      bebe24b0
    • Vladislav Vaintroub's avatar