1. 24 Sep, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-26445 innodb_undo_log_truncate is unnecessarily slow · f5794e1d
      Marko Mäkelä authored
      trx_purge_truncate_history(): Do not force a write of the undo tablespace
      that is being truncated. Instead, prevent page writes by acquiring
      an exclusive latch on all dirty pages of the tablespace.
      
      fseg_create(): Relax an assertion that could fail if a dirty undo page
      is being initialized during undo tablespace truncation (and
      trx_purge_truncate_history() already acquired an exclusive latch on it).
      
      fsp_page_create(): If we are truncating a tablespace, try to reuse
      a page that we may have already latched exclusively (because it was
      in buf_pool.flush_list). To some extent, this helps the test
      innodb.undo_truncate,16k to avoid running out of buffer pool.
      
      mtr_t::commit_shrink(): Mark as clean all pages that are outside the
      new bounds of the tablespace, and only add the newly reinitialized pages
      to the buf_pool.flush_list.
      
      buf_page_create(): Do not unnecessarily invoke change buffer merge on
      undo tablespaces.
      
      buf_page_t::clear_oldest_modification(bool temporary): Move some
      assertions to the caller buf_page_write_complete().
      
      innodb.undo_truncate: Use a bigger innodb_buffer_pool_size=24M.
      On my system, it would otherwise hang 1 out of 1547 attempts
      (on the 40th repeat of innodb.undo_truncate,16k).
      Other page sizes were not affected.
      f5794e1d
    • Marko Mäkelä's avatar
      MDEV-26450: Corruption due to innodb_undo_log_truncate · f5fddae3
      Marko Mäkelä authored
      At least since commit 055a3334
      (MDEV-13564) the undo log truncation in InnoDB did not work correctly.
      
      The main issue is that during the execution of
      trx_purge_truncate_history() some pages of the newly truncated
      undo tablespace could be discarded.
      
      This is improved from commit 1cb218c3
      which was applied to earlier-version branches.
      
      fsp_try_extend_data_file(): Apply the peculiar rounding of
      fil_space_t::size_in_header only to the system tablespace,
      whose size can be expressed in megabytes in a configuration parameter.
      Other files may freely grow by a number of pages.
      
      fseg_alloc_free_page_low(): Do allow the extension of undo tablespaces,
      and mention the file name in the error message.
      
      mtr_t::commit_shrink(): Implement crash-safe shrinking of a tablespace:
      (1) durably write the log
      (2) release the page latches of the rebuilt tablespace
      (3) release the mutexes
      (4) truncate the file
      (5) release the tablespace latch
      This is refactored from trx_purge_truncate_history().
      
      log_write_and_flush_prepare(), log_write_and_flush(): New functions
      to durably write log during mtr_t::commit_shrink().
      f5fddae3
    • Marko Mäkelä's avatar
      MDEV-26626 fixup: Do not advance checkpoint during startup · 15efb7ed
      Marko Mäkelä authored
      While the redo log is being resized in srv_start(),
      we must not write checkpoint information to the old log.
      
      Thanks to Matthias Leich for noticing this.
      15efb7ed
  2. 21 Sep, 2021 1 commit
  3. 22 Sep, 2021 2 commits
  4. 21 Sep, 2021 1 commit
  5. 17 Sep, 2021 4 commits
  6. 16 Sep, 2021 3 commits
    • Marko Mäkelä's avatar
      MDEV-26626 InnoDB fails to advance the log checkpoint · c430aa72
      Marko Mäkelä authored
      buf_flush_page_cleaner(): Always try to advance the log checkpoint,
      even when no pages were flushed during the latest batch.
      Maybe, since the previous batch, there was an LRU flush that
      removed the last dirty pages.
      
      Failure to advance the log checkpoint will cause unnecessary work
      in Mariabackup and on crash recovery.
      c430aa72
    • Monty's avatar
      Updated rocksdb test result · 65cce297
      Monty authored
      This was required as I added a new error code to my_base.h and rocksdb
      is adding it's own errors after the last official one
      
      Updated result file also for index_merge_rocksdb2. This is a big test
      and we have probably not before noticed that some optimizer changes
      caused a difference.
      65cce297
    • Eugene Kosov's avatar
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in... · 5b0a7607
      Eugene Kosov authored
      MDEV-26621 assertion failue "index->table->persistent_autoinc" in /storage/innobase/btr/btr0btr.cc during IMPORT
      
      dict_index_t::clear_instant_alter(): when searhing for an AUTO_INCREMENT column
      don't skip the beginning of the list because the field can be at the beginning of the list
      5b0a7607
  7. 15 Sep, 2021 4 commits
    • Monty's avatar
      Fixed bug in aria_chk that overwrote sort_buffer_length · 0d47945b
      Monty authored
      This bug happens when one runs aria_chk on multiple tables. It does not
      affect REPAIR TABLE.
      aria_chk tries to optimize the sort buffer size to minimize memory usage
      when used with small tables. The bug was that the adjusted value was
      used as a base for the next table, which could cause problems.
      0d47945b
    • Monty's avatar
      Merge branch '10.4' into 10.5 · b4f24c74
      Monty authored
      Fixed also an error in suite/perfschema/t/transaction_nested_events-master.opt
      b4f24c74
    • Monty's avatar
      Improve error messages from Aria · f03fee06
      Monty authored
      - Error on commit now returns HA_ERR_COMMIT_ERROR instead of
        HA_ERR_INTERNAL_ERROR
      - If checkpoint fails, it will now print out where it failed.
      f03fee06
    • Monty's avatar
      Fixed compiler warnings in CONNECT · 6be0ddae
      Monty authored
      6be0ddae
  8. 14 Sep, 2021 4 commits
    • Monty's avatar
      MDEV-23519 Protocol packet - "Original Name" info is showing alias name, · 689b8d06
      Monty authored
      instead of original name of the column
      
      When doing refactoring of temporary table field creation a mistake was
      done when copying the column name when creating internal temporary tables.
      For internal temporary tables we should use the original field name, not
      the item name (= alias).
      689b8d06
    • Daniel Black's avatar
      MDEV-26601: mysys - O_TMPFILE ^ O_CREAT · adaf0dde
      Daniel Black authored
      Thanks to Fabian Vogt for noticing the mutual exclusions
      of these open flags on tmpfs caused by mariadb opening it
      incorrectly.
      
      As such we clear the O_CREAT flag while opening it as O_TMPFILE.
      adaf0dde
    • Daniele Sciascia's avatar
      MDEV-21613 Failed to open table mysql.wsrep_streaming_log for writing · 5527fc58
      Daniele Sciascia authored
      Fix sporadic failure for MTR test galera_sr.GCF-1018B. The test
      sometimes fails due to an error that is logged to the error log
      unnecessarily.
      A deterministic test case (included in this patch) shows that the
      error is loggen when a transaction is BF aborted right before  it
      opens the streaming log table to perform fragment removal. When that
      happens, the attempt to open the table fails and consequently an error
      is logged. There is no need to log this error, as an ER_LOCK_DEADLOCK
      error is returned to the client.
      Reviewed-by: default avatarJan Lindström <jan.lindstrom@mariadb.com>
      5527fc58
    • Otto Kekäläinen's avatar
      Deb: Fix Gitlab-CI/Salsa-CI builds failures · 07abcb50
      Otto Kekäläinen authored
      The debian/salsa-ci.yml used to work also on upstream MariaDB.org branches,
      but has recently regressed and several jobs stopped working. These fixes
      are necessary to get it working again.
      
      * Partially revert 8642f592 that never worked, as MariaDB 10.2 does not
        have a mysql.global table nor a mariadb.sys user. Those features weren't
        introduced until MariaDB 10.4.
      
      * Partially revert 0268b871 as we don't want ColumnStore as part of the
        native Debian build. It should build only when the build is triggered
        via autobake-deb.sh (MariaDB.org builds).
      
      * Adjust salsa-ci.yml to cope with various Stretch to Sid upgrade issues
        and remove the legacy mariadb-connector-c job completely as that package
        hasn't been around for years anymore.
      
      * Extend Lintian overrides to be otherwise Lintian clean
      07abcb50
  9. 12 Sep, 2021 1 commit
    • Sergei Golubchik's avatar
      perfschema: use correct type for left shifts · 1a6c130c
      Sergei Golubchik authored
      set_item() uses 1UL << bit, so is_set_item() must do the same.
      
      This fixes sporadic perfschema.show_aggregate failures
      (sporadic, because `bit` is the thread id, so depending on how many
      tests were run before perfschema.show_aggregate it can be above or
      below 32).
      1a6c130c
  10. 11 Sep, 2021 17 commits