1. 03 Jul, 2007 4 commits
    • unknown's avatar
      Merge gshchepa@bk-internal.mysql.com:/home/bk/mysql-4.1-opt · f57e4b99
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/4.1-opt
      
      
      f57e4b99
    • unknown's avatar
      loaddata.result, loaddata.test: · bc3e0086
      unknown authored
        Test case update for bug #29294.
      
      
      mysql-test/t/loaddata.test:
        Test case update for bug #29294.
      mysql-test/r/loaddata.result:
        Test case update for bug #29294.
      bc3e0086
    • unknown's avatar
      sql_class.cc: · 19a5d20c
      unknown authored
        Windows compilation error fix.
      
      
      sql/sql_class.cc:
        Windows compilation error fix.
      19a5d20c
    • unknown's avatar
      Fixed bug #29294. · 166d3c91
      unknown authored
      The `SELECT 'r' INTO OUTFILE ... FIELDS ENCLOSED BY 'r' ' statement
      encoded the 'r' string to a 4 byte string of value x'725c7272'
      (sequence of 4 characters: r\rr).
      The LOAD DATA statement decoded this string to a 1 byte string of
      value x'0d' (ASCII Carriage Return character) instead of the original
      'r' character.
      The same error also happened with the FIELDS ENCLOSED BY clause
      followed by special characters: 'n', 't', 'r', 'b', '0', 'Z' and 'N'.
      
      NOTE 1: This is a result of the undocumented feature: the LOAD DATA INFILE
      recognises 2-byte input sequences like \n, \t, \r and \Z in addition
      to documented 2-byte sequences: \0 and \N. This feature should be
      documented (here backspace character is a default ESCAPED BY character,
      in the real-life example it may be any ESCAPED BY character).
      
      NOTE 2, changed behaviour:
      Now the `SELECT INTO OUTFILE' statement with the `FIELDS ENCLOSED BY'
      clause followed by one of: 'n', 't', 'r', 'b', '0', 'Z' or 'N' characters
      encodes this special character itself by doubling it ('r' --> 'rr'),
      not by prepending it with an escape character.
      
      
      sql/sql_class.h:
        Fixed bug #29294.
        The ESCAPE_CHARS macro constant is defined to enumerate
        symbolic names of espace-sequences like  '\n', '\t' etc.
        The select_export::is_ambiguous_field_sep field has been added
        to distinguish special values of the field_sep field from
        another values (see ESCAPE_CHARS).
      sql/sql_class.cc:
        Fixed bug #29294.
        The select_export::send_data method has been modified to
        encode special values of the field_sep field by
        doubling of those values instead of prepending them with a
        value of the escape_char field.
        Example: The SELECT 'r' INTO OUTFILE FIELDS ENCLOSED BY 'r'
        now produces the 'rr' output string instead of x'5c72'
        (i.e. instead of sequence of 2 bytes: \ and r).
      sql/sql_load.cc:
        Fixed bug #29294.
        Added commentary for the READ_INFO::unescape method.
      mysql-test/t/loaddata.test:
        Updated test case for bug #29294.
      mysql-test/r/loaddata.result:
        Updated test case for bug #29294.
      166d3c91
  2. 26 Jun, 2007 1 commit
    • unknown's avatar
      Fixed bug #29251. · 7fbf6303
      unknown authored
      Sometimes special 0 ENUM values was ALTERed to normal
      empty string ENUM values.
      
      Special 0 ENUM value has the same string representation
      as normal ENUM value defined as '' (empty string).
      The do_field_string function was used to convert
      ENUM data at an ALTER TABLE request, but this
      function doesn't care about numerical "indices" of
      ENUM values, i.e. do_field_string doesn't distinguish
      a special 0 value from an empty string value.
      
      A new copy function called do_field_enum has been added to
      copy special 0 ENUM values without conversion to an empty
      string.
      
      
      sql/field_conv.cc:
        Fixed bug #29251.
        The Copy_field::get_copy_func method has been modified to
        return a pointer to the do_field_enum function if a conversion
        between two columns of incompatible enum types is required.
        The do_field_enum function has been added for the correct
        conversion of special 0 enum values.
      mysql-test/t/type_enum.test:
        Updated test case for bug #29251.
      mysql-test/r/type_enum.result:
        Updated test case for bug #29251.
      7fbf6303
  3. 25 Jun, 2007 1 commit
  4. 20 Jun, 2007 1 commit
  5. 19 Jun, 2007 2 commits
    • unknown's avatar
      Bug #29116: Test "rpl_change_master" returns different · f0d59bf4
      unknown authored
       counters from relay
      
      Updated the test to return columns vertically.
      
      
      mysql-test/r/rpl_change_master.result:
        Bug #29116: test updated
      mysql-test/t/rpl_change_master.test:
        Bug #29116: test updated
      f0d59bf4
    • unknown's avatar
      Bug #29117 (init_file test crashes with embedded server) · c1cf6e61
      unknown authored
      we use net->vio in my_net_local_init, but in the my_net_init
      implementation we set it after the call, so work with unspecified
      net->vio value
      
      
      sql/net_serv.cc:
        Bug #29117 (init_file test crashes with embedded server)
        
        as we started using net->vio in my_net_local_init, we should set
        it before the call
      c1cf6e61
  6. 18 Jun, 2007 5 commits
  7. 15 Jun, 2007 1 commit
  8. 14 Jun, 2007 2 commits
  9. 13 Jun, 2007 7 commits
  10. 12 Jun, 2007 1 commit
    • unknown's avatar
      VC++Files/sql/mysqld.vcproj · fd4f52a3
      unknown authored
          Ensure ".pdb" and ".map" files are created for the MySQL server, in all configurations.
      
      
      VC++Files/sql/mysqld.vcproj:
        Ensure ".pdb" and ".map" files are created for the MySQL server, in all configurations.
      fd4f52a3
  11. 11 Jun, 2007 2 commits
  12. 10 Jun, 2007 1 commit
    • unknown's avatar
      mysqldemb.vcproj: · fd2531c6
      unknown authored
        Added lots of missing files to make "mysqlserver.lib" complete (bug#29007)
      mysql.sln:
        Let 'mysqlserver' project also depend on 'vio', else "vio.lib" will
        not be linked into the "mysqlserver.lib" static embedded lib (bug#29007)
      
      
      VC++Files/mysql.sln:
        Let 'mysqlserver' project also depend on 'vio', else "vio.lib" will
        not be linked into the "mysqlserver.lib" static embedded lib (bug#29007)
      VC++Files/mysqldemb/mysqldemb.vcproj:
        Added lots of missing files to make "mysqlserver.lib" complete (bug#29007)
      fd2531c6
  13. 08 Jun, 2007 3 commits
    • unknown's avatar
      Merge zippy.cornsilk.net:/home/cmiller/work/mysql/41gca · 5fbb42ec
      unknown authored
      into  zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-4.1-release
      
      
      5fbb42ec
    • unknown's avatar
      Bug #28984: crasher on connect with out of range password length in \ · c1585aea
      unknown authored
      	protocol
      
      One could send a malformed packet that caused the server to SEGV.  In 
      recent versions of the password protocol, the client tells the server 
      what length the ciphertext is (almost always 20).  If that length was
      large enough to overflow a signed char, then the number would jump to 
      very large after being casted to unsigned int.
      
      Instead, cast the *passwd char to uchar. 
      
      
      
      sql/sql_parse.cc:
        Cast *passwd to get rid of the sign, so that sign extension doesn't
        cause the sequence 125, 126, 127, 4294967169, 4294967170.
      c1585aea
    • unknown's avatar
      Add a cast, needed by some platforms. · 37abc7a0
      unknown authored
      Still part of the fix for bug#27078.
      
      
      libmysqld/lib_sql.cc:
        Some platforms need a cast.
        Still part of the fix for bug#27078.
      37abc7a0
  14. 07 Jun, 2007 3 commits
    • unknown's avatar
      Do not use the "thd" pointer to identify a thread in the embedded lib, · db5aab1d
      unknown authored
      but rather use the "thread_id" counter.
      
      Fixes bug#27078:
      Compile error: lib_sql.cc cast from 'THD*' to 'pthread_t' loses precision
      
      
      libmysqld/lib_sql.cc:
        Avoid casting a pointer to a (possibly) int, which will not compile on some platforms:
        Do not use the "thd" pointer to identify a thread in the embedded lib,
        but rather use the "thread_id" counter.
        
        Patch is proposed by Monty.  Fixes bug#27078.
      db5aab1d
    • unknown's avatar
      Merge trift2.:/MySQL/M41/bug23504-4.1 · 35a948f7
      unknown authored
      into  trift2.:/MySQL/M41/push-4.1
      
      
      35a948f7
    • unknown's avatar
      netware/*.def : Allocate 128K stack for all executables (bug#23504) · bc671e2f
      unknown authored
      
      netware/comp_err.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/isamchk.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/isamlog.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/libmysql.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/my_print_defaults.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisam_ftdump.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisamchk.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisamlog.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/myisampack.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql_install_db.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql_test_run.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysql_waitpid.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqladmin.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlbinlog.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlcheck.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqld.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqld_safe.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqldump.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlimport.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqlshow.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/mysqltest.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/pack_isam.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/perror.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/replace.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/resolve_stack_dump.def:
        Allocate 128K stack for all executables (bug#23504)
      netware/resolveip.def:
        Allocate 128K stack for all executables (bug#23504)
      bc671e2f
  15. 06 Jun, 2007 6 commits