1. 10 Nov, 2009 1 commit
    • Davi Arnaut's avatar
      Backport of Bug#41971 to mysql-next-mr · f924523f
      Davi Arnaut authored
      ------------------------------------------------------------
      revno: 2617.31.21
      revision-id: davi.arnaut@sun.com-20090402193933-2zbhg15kd0z3xh8r
      parent: alik@sun.com-20090402081500-78l1hpkx03twe4bf
      committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
      branch nick: 41971-6.0
      timestamp: Thu 2009-04-02 16:39:33 -0300
      message:
        Bug#41971: Thread state on embedded server is always "Writing to net"
       
        The problem is that the state of a thread on a embedded server is
        always displayed as "Writing to net", which is wrong as there is
        no "network" in the embedded server.
      
        The solution is only exclude, on a embedded server, the thread
        state conditions that are related to network operations. Other
        thread states related to waiting on conditions or other operations
        are preserved.
      f924523f
  2. 05 Nov, 2009 1 commit
  3. 04 Nov, 2009 6 commits
    • Magne Mahre's avatar
      BUG #8368 "mysqldump needs --slave-data option" · 6eb797f9
      Magne Mahre authored
        
      Added this option, named as "--dump-slave". The purpose of this option is to be
      able to produce a dump from a slave used for making backups of the master. Originally,
      dumping from the main master was fine, but as more data accumulated, the dump process
      would take over 30 minutes, locking up the master database hence website for 30 minutes.
      A slave dedicated to producing backups was the answer, but I needed a dump that could be
      
      used to restore a slave instantly and in order to do that, it has to have three things 
      contained in the dump:
        
        1. "STOP SLAVE;" at the beginning
        2. "CHANGE MASTER TO ...<the master - info from 'show slave status'>"
        3. "START SLAVE;" at the end
        
      These options in this changeset contain this.
        
        --stop-slave adds "STOP SLAVE" to the beginning of the dump and "STOP SLAVE" 
        to the end of the dump.
        
        --include-host gives the user the option to have the host explicitely added
        to the "CHANGE MASTER TO ..." line.
        
        --dump-slave adds the "CHANGE MASTER ..." to the dump representing not the slave's
        master binlog info, but the slave's master's info from "SHOW SLAVE STATUS" 
      6eb797f9
    • Magne Mahre's avatar
      Bug#26780: automatic vertical output for wide results · e30e0b7c
      Magne Mahre authored
        
      Feature from Eric Bergen, CLA signed 2007-06-27.
        
      Adds new mysql client option "--auto-vertical-output", which causes
      the client to test whether a result table is too wide for the current
      window (where available) and emit vertical results in that case.
      Otherwise, it sends normal tabular results.
      e30e0b7c
    • Jon Olav Hauglid's avatar
      Bug #43867 ALTER TABLE on a partitioned table causes unnecessary · df6d4bf1
      Jon Olav Hauglid authored
                 deadlocks
      
      Backport of revno: 2617.68.35
      
      The problem was that if one connection is running a multi-statement 
      transaction which involves a single partitioned table, and another 
      connection attempts to alter the table to drop a non-existing partition,
      (which of course will fail), the first connection still gets 
      ER_LOCK_DEADLOCK and cannot proceed anymore.
      
      This bug is no longer reproducable. This has also been tested with the
      patch for Bug#46654 "False deadlock on concurrent DML/DDL with partitions, 
      inconsistent behavior" which concerned a similar problem but where the 
      ALTER TABLE is semantically correct.
      
      Test case added in partition_sync.test.
      df6d4bf1
    • Magne Mahre's avatar
      Bug#42664: Sign ignored for TIME types when not comparing as longlong · 948bb3e6
      Magne Mahre authored
            
      Another code-path dropped sign of TIME, presuming all time is positive.
            
      Minds sign now. Patch depends on ChangeSet for 42661.
      948bb3e6
    • Magne Mahre's avatar
      Backport to 5.6.0 · 491b8fc7
      Magne Mahre authored
      491b8fc7
    • Magne Mahre's avatar
      Bug#42661: sec_to_time() and signedness · b1006c87
      Magne Mahre authored
      Bug#42662: maketime() and signedness
            
      Item_time_typecast::val_int() dropped sign from
      MYSQL_TIME gotten using from get_time().
            
      Propagates sign now.
      
      
      Backported to 5.5.0  (6.0-codebase revid: 1810.3897.1)
      b1006c87
  4. 03 Nov, 2009 2 commits
    • Magne Mahre's avatar
      Bug #36466: Adding days to day_microsecond changes interpretation of microseco · b79b3c65
      Magne Mahre authored
            
      When less than six places are given for microseconds, we zerofill from
      the right (leftmost place is always 1/10s). We only did this when all
      announced date/time fields were given; now we also format fractional
      seconds when more significant fields are left out.
      b79b3c65
    • Magne Mahre's avatar
      Bug#35224: mysqldump --help is very confusing · 6e916e03
      Magne Mahre authored
        
      The presence of "--skip" parameters is obscure, when it should be
      obvious from the text.
        
      Now, for boolean options, when they're default to ON and the --skip
      is more useful parameter, then tell the user of its existence.
      
      Backported from 6.0-codebase, revid  2572.14.1
      6e916e03
  5. 02 Nov, 2009 2 commits
    • Alexander Nozdrin's avatar
      Backport a patch from 6.0: · ee15f23c
      Alexander Nozdrin authored
      ```---------------------------------------------------------
      revno: 2599.178.12
      revision-id: alik@mysql.com-20080812161845-we7cx9f22yrghob1
      committer: Alexander Nozdrin <alik@mysql.com>
      branch nick: 6.0-rt-build
      timestamp: Tue 2008-08-12 20:18:45 +0400
      message:
        Fix memory leak.
      ```
      
      ---------------------------------------------------------
      ee15f23c
    • Alexander Nozdrin's avatar
      Manual merge from mysql-next-mr. · 8c95f3c5
      Alexander Nozdrin authored
      8c95f3c5
  6. 31 Oct, 2009 2 commits
  7. 29 Oct, 2009 8 commits
  8. 28 Oct, 2009 6 commits
  9. 27 Oct, 2009 10 commits
  10. 26 Oct, 2009 2 commits
    • Dmitry Lenev's avatar
      Fix for bug #45143 "All connections hang on concurrent ALTER TABLE". · dfa2acb1
      Dmitry Lenev authored
      Concurrent execution of statements which require non-table-level
      write locks on several instances of the same table (such as
      SELECT ... FOR UPDATE which uses same InnoDB table twice or a DML
      statement which invokes trigger which tries to update same InnoDB
      table directly and through stored function) and statements which
      required table-level locks on this table (e.g. LOCK TABLE ... WRITE,
      ALTER TABLE, ...) might have resulted in a deadlock.
      
      The problem occured when a thread tried to acquire write lock
      (TL_WRITE_ALLOW_WRITE) on the table but had to wait since there was
      a pending write lock (TL_WRITE, TL_WRITE_ALLOW_READ) on this table
      and we failed to detect that this thread already had another instance
      of write lock on it (so in fact we were trying to acquire recursive
      lock) because there was also another thread holding write lock on the
      table (also TL_WRITE_ALLOW_WRITE). When the latter thread released
      its lock neither the first thread nor the thread trying to acquire
      TL_WRITE/TL_WRITE_ALLOW_READ were woken up (as table was still write
      locked by the first thread) so we ended up with a deadlock.
      
      This patch solves this problem by ensuring that thread which
      already has write lock on the table won't wait when it tries
      to acquire second write lock on the same table.
      dfa2acb1
    • Vladislav Vaintroub's avatar
      Bug #48317 cannot build innodb as static library. · b1c355b3
      Vladislav Vaintroub authored
      The problem here is that the latest innodb push contains
      both MYSQL_STORAGE_ENGINE(INNOBASE) and MYSQL_STORAGE_ENGINE(INNOBASE)
      in the same CMakeLists.txt, to make the resulting library
      ha_innodb.dll, instead of ha_innobase.dll.
      
      Using multiple MYSQL_STORAGE_ENGINE within the same  CMakeLists.txt
      conflicts with the fix for the bug Bug #47795 "CMake, storage engine
      name different from directory name". Top-level CMakeLists.txt now 
      parses storage engine's  CMakeLists.txt to extract engines name from 
      MYSQL_STORAGE_ENGINE().
      
      For innodb, it concludes that there is not storage engine named
      INNOBASE, hence WITH_INNOBASE_STORAGE_ENGINE has no effect.
      
      The fix is to use SET_TARGET_PROPERTIES(... PROPERTIES OUTPUT_NAME ...),
      instead of renaming the engine to have plugins named ha_innodb.dll.
      b1c355b3