1. 30 Jun, 2016 26 commits
  2. 29 Jun, 2016 1 commit
    • Alexander Barkov's avatar
      Preparing the CAST(..AS [UN]SIGNED) related code to fix a number · afbd28ae
      Alexander Barkov authored
      of bugs easier (MDEV-8919, MDEV-10304, MDEV-10305, MDEV-10307)
      
      - Adding Item::push_note_converted_to_negative_complement() and
        Item::push_note_converted_to_positive_complement()
      - Adding virtual methods Item::val_int_signed_typecast() and
        Item::val_int_unsigned_typecast()
      - Moving COLUMN_GET() related code from
        Item_func_signed::val_int() and Item_func_unsigned::val_int() to
        Item_dyncol_get::val_int_signed_typecast() and
        Item_dyncol_get::val_int_unsigned_typecast()
      - Moving Item_func_signed::val_int_from_str() to Item::val_int_from_str()
        and changing it to get the value from "this" instead of args[0].
      
      The patch does not change behaviour. It's only to simplify fixing of the
      mentioned bugs. It will also simplify switching the CAST related code to
      use the type handler infrastructure easier (soon).
      afbd28ae
  3. 26 Jun, 2016 1 commit
  4. 23 Jun, 2016 1 commit
  5. 22 Jun, 2016 4 commits
    • Monty's avatar
      MDEV-10219 rpl.rpl_parallel_temptable failed in buildbot: Assertion `!table ||... · ec38c7e6
      Monty authored
      MDEV-10219 rpl.rpl_parallel_temptable failed in buildbot: Assertion `!table || !table->in_use || table->in_use == _current_thd()' failed
      
      Problem was that table->in_use was not properly set when dropping a temporary for the slave.
      ec38c7e6
    • Monty's avatar
      838205f0
    • Monty's avatar
      MDEV-10138 Support for decimals up to 38 digits · 34eb10e4
      Monty authored
      Decimals with float, double and decimal now works the following way:
      
      - DECIMAL_NOT_SPECIFIED is used when declaring DECIMALS without a firm number
        of decimals.  It's only used in asserts and my_decimal_int_part.
      - FLOATING_POINT_DECIMALS (31) is used to mark that a FLOAT or DOUBLE
        was defined without decimals. This is regarded as a floating point value.
      - Max decimals allowed for FLOAT and DOUBLE is FLOATING_POINT_DECIMALS-1
      - Clients assumes that float and double with decimals >= NOT_FIXED_DEC are
        floating point values (no decimals)
      - In the .frm decimals=FLOATING_POINT_DECIMALS are used to define
        floating point for float and double (31, like before)
      
      To ensure compatibility with old clients we do:
      
      - When storing float and double, we change NOT_FIXED_DEC to
        FLOATING_POINT_DECIMALS.
      - When creating fields from .frm we change for float and double
        FLOATING_POINT_DEC to NOT_FIXED_DEC
      - When sending definition for a float/decimal field without decimals
        to the client as part of a result set we convert NOT_FIXED_DEC to
        FLOATING_POINT_DECIMALS.
      - variance() and std() has changed to limit the decimals to
        FLOATING_POINT_DECIMALS -1 to not get the double converted floating point.
        (This was to preserve compatiblity)
      - FLOAT and DOUBLE still have 30 as max number of decimals.
      
      Bugs fixed:
      
      variance() printed more decimals than we support for double values.
      
      New behaviour:
      - Strings now have 38 decimals instead of 30 when converted to decimal
      - CREATE ... SELECT with a decimal with > 30 decimals will create a column
        with a smaller range than before as we are trying to preserve the number of
        decimals.
      
      
      Other changes
      - We are now using the obsolete bit FIELDFLAG_LEFT_FULLSCREEN to specify
        decimals > 31
      - NOT_FIXED_DEC is now declared in one place
      - For clients, NOT_FIXED_DEC is always 31 (to ensure compatibility).
        On the server NOT_FIXED_DEC is DECIMAL_NOT_SPECIFIED (39)
      - AUTO_SEC_PART_DIGITS is taken from DECIMAL_NOT_SPECIFIED
      - DOUBLE conversion functions are now using DECIMAL_NOT_SPECIFIED instead of
        NOT_FIXED_DEC
      34eb10e4
    • Monty's avatar
      Fixed compiler warnings · e4062d4d
      Monty authored
      Added my_global.h to PerconeFT to avoid "error <my_config.h> MUST be included first"
      e4062d4d
  6. 19 Jun, 2016 1 commit
  7. 14 Jun, 2016 1 commit
  8. 13 Jun, 2016 2 commits
    • Sergei Golubchik's avatar
      MDEV-10098 main.create_delayed fails with ps-protocol: assertion... · 9f9eb682
      Sergei Golubchik authored
      MDEV-10098 main.create_delayed fails with ps-protocol: assertion `global_status_var.global_memory_used >= 0' failed
      
      Remove the assert. We cannot verify that
      global_memory_used value is valid (>=0)
      because some of updates are cached in individual THD's
      (e.g. THD1 can have +300 cached, while the other THD2
      can have -300 cached. If the second THD exists before
      the first one, global_memory_used will be -300
      temporarily).
      
      Instead add the assert just before the exit, when all
      THDs been already destroyed.
      9f9eb682
    • Sergei Golubchik's avatar
      cleanup · e65703c6
      Sergei Golubchik authored
      always update global_status_var.global_memory_used
      through update_global_memory_status()
      e65703c6
  9. 10 Jun, 2016 3 commits
    • Nirbhay Choubey's avatar
      MDEV-5535: Cannot reopen temporary table · b2ae32aa
      Nirbhay Choubey authored
      Since a query can now refer to the same temporary table
      multiple times, find_dup_table()/find_table_in_list()
      have been updated to also consider this new possibility.
      b2ae32aa
    • Nirbhay Choubey's avatar
      MDEV-5535: Cannot reopen temporary table · e2087c6e
      Nirbhay Choubey authored
      Temporary table being created by outer statement
      should not be visible to inner statement. And if
      inner statement creates a table with same name.
      The whole statement should fail with
      ER_TABLE_EXISTS_ERROR.
      
      Implemented by temporarily de-linking the TABLE_SHARE
      being created by outer statement so that it remains
      hidden to the inner statement.
      e2087c6e
    • Nirbhay Choubey's avatar
      MDEV-5535: Cannot reopen temporary table · 7305be2f
      Nirbhay Choubey authored
      mysqld maintains a list of TABLE objects for all temporary
      tables created within a session in THD. Here each table is
      represented by a TABLE object.
      
      A query referencing a particular temporary table for more
      than once, however, failed with ER_CANT_REOPEN_TABLE error
      because a TABLE_SHARE was allocate together with the TABLE,
      so temporary tables always had only one TABLE per TABLE_SHARE.
      
      This patch lift this restriction by separating TABLE and
      TABLE_SHARE objects and storing TABLE_SHAREs for temporary
      tables in a list in THD, and TABLEs in a list within their
      respective TABLE_SHAREs.
      7305be2f