1. 23 Jul, 2008 2 commits
    • Sven Sandberg's avatar
      BUG#38068: binlog_stm_binlog fails sporadically in pushbuild · fc0f2481
      Sven Sandberg authored
      Problem: binlog_stm_binlog runs INSERT DELAYED queries, and
      then prints the contents of the binlog. Before checking the
      contents of the binlog, the test waits until the rows have
      appeared in the table. However, this is not enough, since
      INSERT DELAYED does not write rows to the binlog at the same
      time as it writes them to the table. So there is a race.
      Fix: Add a FLUSH TABLES before SHOW BINLOG EVENTS. That
      waits until the insert_delayed thread is done.
      fc0f2481
    • Sven Sandberg's avatar
      BUG#37493: rpl_trunc_temp.test nondeterministic · bb945f70
      Sven Sandberg authored
      Problem: the test waits for a 'DROP TEMPORARY TABLE' event to
      appear in the master's binlog, then checks on the slave whether
      the number of temporary tables has decreased. The slave does
      not sync, causing a race.
      Fix: check for the 'DROP TEMPORARY TABLE' event on slave
      instead of on master.
      bb945f70
  2. 18 Jul, 2008 2 commits
    • Sven Sandberg's avatar
      BUG#38077: rpl_incident At line 22: query 'SELECT * ...' Table 'test.t1' doesn't exist · 38376746
      Sven Sandberg authored
      This is not a fix to the bug. It only adds debug info, so
      that we can analyze the bug better next time it happens.
      Please revert the patch after the bug is fixed.
      38376746
    • Sven Sandberg's avatar
      BUG#38178: rpl_loaddata_map fails sporadically in pushbuild · e5d1324d
      Sven Sandberg authored
      Problem: master binlog has 'create table t1'. Master binlog
      was removed before slave could replicate it. In test's cleanup
      code, master did 'drop table t1', which caused slave sql
      thread to stop with an error since slave sql thread did not
      know about t1.
      Fix: t1 is just an auxiliary construction, only needed on
      master. Hence, we turn off binlogging before t1 is created,
      drop t1 as soon as we don't need it anymore, and then turn
      on binlogging again.
      e5d1324d
  3. 17 Jul, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#38170: rpl_variables failed on pushbuild: could not sync with master · e77957ee
      Sven Sandberg authored
      Problem: the test set @@global.init_slave to garbage at a time
      which was not guaranteed to be after the time when the slave's
      SQL thread used it. That would cause the slave's SQL thread to
      stop in rare cases.
      Fix: The test does not care about the value of
      @@global.init_slave, except that it should be different on
      master and slave. Hence, we set @@global.init_slave to
      something that is valid SQL.
      e77957ee
  4. 11 Jul, 2008 1 commit
  5. 10 Jul, 2008 9 commits
  6. 09 Jul, 2008 8 commits
  7. 08 Jul, 2008 6 commits
  8. 07 Jul, 2008 8 commits
    • Mattias Jonsson's avatar
    • Marc Alff's avatar
      Manual merge of bug#26030 in mysql-5.1-bugteam · 8454773a
      Marc Alff authored
      8454773a
    • Mattias Jonsson's avatar
      merge · 6cc1fcc9
      Mattias Jonsson authored
      6cc1fcc9
    • Mattias Jonsson's avatar
      Bug#35745: SELECT COUNT(*) is not correct for some partitioned tables. · c499df92
      Mattias Jonsson authored
      problem was that ha_partition::records was not implemented, thus
      using the default handler::records, which is not correct if the engine
      does not support HA_STATS_RECORDS_IS_EXACT.
      Solution was to implement ha_partition::records as a wrapper around
      the underlying partitions records.
      
      The rows column in explain partitions will now include the total
      number of records in the partitioned table.
      
      (recommit after removing out-commented code)
      c499df92
    • Marc Alff's avatar
      Merge · 68925ec2
      Marc Alff authored
      68925ec2
    • Marc Alff's avatar
      Bug#26030 (Parsing fails for stored routine w/multi-statement execution · f3ff1aeb
      Marc Alff authored
      enabled)
      
      Before this fix, the lexer and parser would treat the ';' character as a
      different token (either ';' or END_OF_INPUT), based on convoluted logic,
      which failed in simple cases where a stored procedure is implemented as a
      single statement, and used in a multi query.
      
      With this fix:
      - the character ';' is always parsed as a ';' token in the lexer,
      - parsing multi queries is implemented in the parser, in the 'query:' rules,
      - the value of thd->client_capabilities, which is the capabilities
        negotiated between the client and the server during bootstrap,
        is immutable and not arbitrarily modified during parsing (which was the
        root cause of the bug)
      f3ff1aeb
    • Georgi Kodinov's avatar
      Bug#37627: addendum : · 0a638f6b
      Georgi Kodinov authored
       - moved the test into a separate file to check for presence of the test variable
      0a638f6b
    • Mats Kindahl's avatar
      Bug #37150 Risk for crash in User_var_log_event::exec_event() · b9d6d4c0
      Mats Kindahl authored
      On certain kinds of errors (e.g., out of stack), a call to Item_func_
      set_user_var::fix_fields() might fail.  Since the return value of this
      call was not checked inside User_var_log_event::exec_event(), continuing
      execution after this will cause a crash inside Item_func_set_user_var::
      update_hash().
      
      The bug is fixed by aborting execution of the event with an error if
      fix_fields() fails, since it is not possible to continue execution anyway.
      b9d6d4c0
  9. 04 Jul, 2008 3 commits